dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
45,136 Commits 2 Branches 0 Tags
e463d00d96d6fd4a89e9bc2f400a839579bb5ad0
Commit Graph

1811 Commits

Author SHA1 Message Date
Konstantin Shcheglov 24d5466a72 Send error notifications only for files in analysis roots (and not excluded). 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2734673002 .
 2017-03-05 15:01:27 -08:00
pq cc0036d5ad Calculate text ranges for default args. 
Continued work on generating sensible default contents for args in completions.

Calculated text ranges allow us to produce linked edits in the IDE.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2727343002 .
 2017-03-02 13:14:49 -08:00
pq d826b1f931 Default arg support continued (flutter-intellij#553). 
Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=
R=brianwilkerson@google.com, scheglov@google.com

See: https://github.com/flutter/flutter-intellij/issues/553
Review-Url: https://codereview.chromium.org/2728653004 .
 2017-03-01 15:00:47 -08:00
pq d1bfe8bccb Calculate default args for local reference completions. 
First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2722253002 .
 2017-03-01 11:45:01 -08:00
Steve Messick b3ed30b822 Add assists to move Flutter widgets up and down one level. 
Fixes:
https://github.com/flutter/flutter-intellij/issues/461

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2724473002 .
 2017-02-27 15:03:51 -10:00
Konstantin Shcheglov 2816c93faf Ask Dart analysis results only for Dart files. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28905

Review-Url: https://codereview.chromium.org/2720023002 .
 2017-02-27 11:50:42 -08:00
Konstantin Shcheglov 5c0bf9539c Await in DefaultFixContributor.internalComputeFixes() to catch exceptions. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2720013002 .
 2017-02-27 10:40:24 -08:00
Devon Carew 25dfd0fa80 Deprecate execution.setSubscriptions. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2713513007 .
 2017-02-24 11:01:00 -08:00
Devon Carew 0f7fc43df5 Remove the --no-error-notification flag. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713053002 .
 2017-02-23 16:55:46 -08:00
Brian Wilkerson 37c585e842 Make it safe to initialize the notificationManager in server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2708353008 .
 2017-02-23 12:31:15 -08:00
Devon Carew 9dd2a6d452 Revert "Tweaks to the analyzer_cli." 
This reverts commit a7ac08d0e7.

BUG=

Review-Url: https://codereview.chromium.org/2709163005 .
 2017-02-23 09:39:25 -08:00
Devon Carew a7ac08d0e7 Tweaks to the analyzer_cli. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2709013005 .
 2017-02-23 09:02:49 -08:00
Brian Wilkerson 5d6b742904 Initial integration of NotificationManager into server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2713533003 .
 2017-02-22 10:41:13 -08:00
pq 56dbd3b1b4 Error state doc fix. 
Follow-up from: https://codereview.chromium.org/2707223003/

BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2710983002 .
 2017-02-22 08:57:48 -08:00
pq 174a50bb89 Missing @required arg quick fix improvements. 
* fixes missing `HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS` case
* improve quick fix message (add name)
* update codegen

BUG=
R=scheglov@google.com

Fixes: #28830
Review-Url: https://codereview.chromium.org/2707223003 .
 2017-02-22 06:43:43 -08:00
Brian Wilkerson 5bb9fb5f96 Guard against NPE caused by invalid code (issue 28829) 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2704933002 .
 2017-02-20 09:29:14 -08:00
Devon Carew 7f83d9d173 Add a diagnostic.getServerPort analysis server request. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2703033002 .
 2017-02-19 15:19:40 -08:00
Devon Carew 6d0be707d0 Some re-organization to the analysis server diagnostics pages. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2699363002 .
 2017-02-18 14:18:55 -08:00
Steve Messick 2da528aeac Add assist to reparent a list of Flutter widgets 
Apparently I forgot to sort the test file, so there's a bit of code rearrangement there.

I added the optimization to the filter from the previous CL here, too.

R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701023002 .
 2017-02-17 13:11:30 -08:00
Konstantin Shcheglov 6d79ee2602 Issue 27214. Get any AnalysisDriver for getNavigation(). 
This means that we will able to analyze any file, even outside all
analysis roots.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27214

Review-Url: https://codereview.chromium.org/2689213016 .
 2017-02-17 09:13:59 -08:00
Steve Messick 7945b65449 Add assist to reparent Flutter widget 
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2701563003 .
 2017-02-17 08:35:47 -08:00
Konstantin Shcheglov ab8aea145e Remove PubSummaryManager. 
The new AnalysisDriver is more general approach

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2698133002 .
 2017-02-16 06:58:07 -08:00
Konstantin Shcheglov 4d9968b95d Use CompilationUnitElement.lineInfo instead of AnalysisContext. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2692383003 .
 2017-02-15 10:06:28 -08:00
pq e2808dff23 Add fix for missing @required params. 
Groundwork for: https://github.com/flutter/flutter-intellij/issues/553

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2692983003 .
 2017-02-15 09:02:44 -08:00
Konstantin Shcheglov 72463adf20 If the state location is not accessible, use MemoryByteStore. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2697653004 .
 2017-02-15 08:37:22 -08:00
Brian Wilkerson 2e64ccbf84 Add the notification manager 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2692373002 .
 2017-02-15 08:04:31 -08:00
Brian Wilkerson 7993dac4f1 Check the type of a map entry before using it (issue 28756) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2697603005 .
 2017-02-14 12:58:43 -08:00
Brian Wilkerson a56cee72e5 Extract object creation methods for use by a future test class 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2696853002 .
 2017-02-14 12:37:09 -08:00
Paul Berry 02ff6326d7 Remove unused TokenType.IS. 
TokenType is used for symbols, not keywords.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2691043003 .
 2017-02-13 11:17:02 -08:00
Brian Wilkerson 92550811ac Add conversion routines from the plugin API to the server API 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2689903002 .
 2017-02-12 08:19:13 -08:00
Konstantin Shcheglov ad8e38881b Fix for 'Rename Local' refactoring without tasks. 
R=devoncarew@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2685783012 .
 2017-02-10 16:15:31 -08:00
Konstantin Shcheglov 663b7f665e Analysis.getHover should return the field's documentation for field formal parameters. 
Also return the parameter's element with completion suggestion.

R=brianwilkerson@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2681233005 .
 2017-02-10 08:49:40 -08:00
Konstantin Shcheglov 46eff8e389 Implement also 'execution.mapUri' for file to URI. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681393004 .
 2017-02-10 08:48:02 -08:00
Konstantin Shcheglov 0a09ff53c3 Include the field documentation for named field formal parameter completion suggestions. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2683233002 .
 2017-02-09 13:24:25 -08:00
Brian Wilkerson a191011c03 Update ChangeBuilder to the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688513003 .
 2017-02-09 07:51:42 -08:00
Brian Wilkerson 5d0fa7dc21 Finish file rename operation (TBR) 
Review-Url: https://codereview.chromium.org/2685783005 .
 2017-02-08 13:56:56 -08:00
Konstantin Shcheglov 2f741af001 Fix for 'execution.mapUri' with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682983002 .
 2017-02-08 08:40:59 -08:00
Brian Wilkerson 407985cbce Support merging with priority information 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683673003 .
 2017-02-07 10:05:20 -08:00
Brian Wilkerson 37720f012f Use toList to copy lists and clean up errors and warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2685613002 .
 2017-02-07 09:00:09 -08:00
Brian Wilkerson ccdf574d49 Add support for merging results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2678673002 .
 2017-02-07 08:06:59 -08:00
Konstantin Shcheglov 0c19c418c2 Add EvictingFileByteStore and make FileByteStore non-evicting. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2676363003 .
 2017-02-06 10:10:41 -08:00
danrubel 1680c434f2 suggest method references in named expressions 
Fix https://github.com/dart-lang/sdk/issues/25386

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2679503002 .
 2017-02-06 12:59:05 -05:00
danrubel 02adcc9614 suggest catch and finally keywords 
After a try block that does not have a "catch" block,
suggest the "catch" keyword and nothing else.
After a "catch" block, suggest the "finally" keyword.

Fix https://github.com/dart-lang/sdk/issues/27560

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662973007 .
 2017-02-06 12:57:57 -05:00
Konstantin Shcheglov 6e422fd0a7 Don't search for 'declaration' of elements, just name is usually enough. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2677833002 .
 2017-02-05 12:21:17 -08:00
Brian Wilkerson 9c9de9e48c Add code to locate a plugin within a package 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2671773007 .
 2017-02-05 11:58:05 -08:00
Brian Wilkerson a8f65e61a9 Initial support for managing partial results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2676593006 .
 2017-02-04 09:46:08 -08:00
Konstantin Shcheglov 7d2447d795 Replace computeNode() with AstProvider in search. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2672973002 .
 2017-02-03 10:40:44 -08:00
Konstantin Shcheglov f600f5f9de Stop using Element.computeNode() in refactorings and fixes. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2669353002 .
 2017-02-02 17:24:31 -08:00
Konstantin Shcheglov 69f9f781cc Implement Search.classMembers() using getFilesDefiningClassMemberName(). 
This fixes the performance problem you saw on class renames.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2674493004 .
 2017-02-02 10:48:19 -08:00
Dan Rubel f33c3c1676 complete named params in constructors 
This add completion suggestions for named parameters
in constructors and factories, and prevents other suggestions
such as type names, identifiers, etc when they are not appropriate.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2671533002 .
 2017-02-01 14:36:41 -05:00