Sigmund Cherem
c91b73eaf7
[3.0 alpha] Remove dart:html's deprecated document.registerElement & registerElement2 APIs
...
Change-Id: I07fc124c55d1aeb678f39a4d72d3b4f581025a10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273541
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-12-09 16:02:02 +00:00
Sigmund Cherem
b62e612dc8
[dart:html] Deprecate custom element registration APIs.
...
The `registerElement` APIs in `dart:html` are legacy APIs based on a
deprecated Web Components v0.5 specification. These methods don't work
on modern browsers and can only be used with a polyfill.
The latest Web Components specification is supported indirectly via
JSInterop and doesn't have an explicit API in the `dart:html` library.
This change marks these APIs as deprecated. We intend to remove them in
the future (see https://github.com/dart-lang/sdk/issues/49536 )
Fixes https://github.com/dart-lang/sdk/issues/48973
Change-Id: I2e96d36e95c9971b59cde80bc4da49b63d12b17c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252840
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2022-07-28 16:07:30 +00:00
Srujan Gaddam
63a57a76ce
[dart:html] Revert "[dart:html] Revert commits using MDN compatibility info"
...
This reverts commit f8ff12008e .
This CL is a revert of the initial revert and should be landed once
Flutter changes have been merged to handle the changes here.
Change-Id: I300a5efd776bf2a596743971f4e15ad62da77f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-14 23:18:43 +00:00
Srujan Gaddam
f8ff12008e
[dart:html] Revert commits using MDN compatibility info
...
This reverts commits aff77e7e..e24f205d.
Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.
Breakage: https://github.com/flutter/engine/runs/828631927
Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2020-07-02 01:33:18 +00:00
Srujan Gaddam
7349385185
[dart:html] Changes to template/src to handle compat data
...
Mostly null-assertions to make code compatible with compat
data changes.
Change-Id: I8f7c6c2421d6427851a44588978910deae8440bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152047
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-01 22:06:34 +00:00
Srujan Gaddam
9f79dfc37d
Address analyzer errors in golden files in dart:html
...
New analyzer errors are reported for dart:html around nullability.
Non-nullable fields are translated to native getters and setters if part
of a concrete class and normal getters and setters if abstract.
Change-Id: I2fd87803a08872b2a7eae4de0af704f184997c7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137481
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
e2ff83724b
Fix nullability for some templates
...
Addresses discrepancies between IDL and template files for some
operations. There's probably more I'm missing since this was
from a cursory check through all the templates.
Change-Id: Id79710b343f4a5fe0b5529f64c341d4f63d69b9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135222
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-02-11 20:28:54 +00:00
Srujan Gaddam
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
Sam Rawlins
f7dab643ff
Remove discontinued webproject.org links. Fixes #21482
...
Bug: https://github.com/dart-lang/sdk/issues/21482
Change-Id: Ie3becfa7eb9f233186629cf97bfcabe51efc8794
Reviewed-on: https://dart-review.googlesource.com/c/82790
Reviewed-by: Terry Lucas <terry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2018-11-06 22:20:51 +00:00
Terry Lucas
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-18 18:48:03 +00:00
Terry Lucas
bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-03-27 20:45:33 +00:00
Terry Lucas
ef6273cba0
Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
...
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.
Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#
Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2018-03-18 09:41:04 +00:00
Terry Lucas
621b12f324
Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Terry Lucas
8f7b8a9d87
Update to new Webkit additions for custom elements
...
TBR=jacobr@google.com ,alanknight@google.com
Review URL: https://codereview.chromium.org/1914643002 .
2016-04-22 12:53:36 -07:00
Jacob Richman
864b64fd5e
Strong html
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Alan Knight
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383 .
BUG=
Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Terry Lucas
c95b9875ef
Fix registerElement for HTMLElement prototype should not change it's m_type
...
TBR=jacobr@google.com
Review URL: https://codereview.chromium.org/1857343002 .
2016-04-05 11:59:28 -07:00
Jacob Richman
c65854d2e4
Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
...
BUG=
Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Alan Knight
a5ba7a7db6
Add an Unstable comment/annotation on caretRangeFromPoint
...
BUG=
Review URL: https://codereview.chromium.org/1578103003 .
2016-01-12 11:12:47 -08:00
Alan Knight
168e9ee882
Remove ugly check for super.created call in constructor
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org/1537563006 .
2015-12-18 09:41:45 -08:00
Sam Rawlins
931ceef9b2
Fixing dart:html links _not_ found in docs.json
...
BUG= https://github.com/dart-lang/sdk/issues/23601
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1448963002 .
2015-11-16 10:18:23 -08:00
Terry L. Lucas
d796048fcc
Fixed improper construction of custom elements.
...
Was a too aggressive on upgrading a custom element. If a JS object is a custom element never construct using the actual custom class in wrap_jso only allocate the TemplateElement or HtmlElement and let the upgrader or createdCallback do the upgrading. This was causing timing issues with nested custom elements that were data bound.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1417363003 .
2015-10-22 16:35:46 -07:00
Alan Knight
a9362610ee
Hide internal methods like wrap_jso from the dart:html public interface
...
Issue https://github.com/dart-lang/sdk/issues/24602
R=terry@google.com
Review URL: https://codereview.chromium.org/1409743003 .
2015-10-19 11:28:53 -07:00
Terry L. Lucas
4653701a76
Fixed native element extension, custom events, _VMUpgrader, and data binding.
...
Enabled tests that exercise this areas.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1391143006 .
2015-10-14 10:03:56 -07:00
Alan Knight
88b456d529
Make the check for calling super.created not sensitive to line delimiters
...
BUG=
Review URL: https://codereview.chromium.org/1399133003 .
2015-10-12 14:40:30 -07:00
Terry L. Lucas
5e8a506677
Extension support
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1401063003 .
2015-10-12 10:09:42 -07:00
Terry L. Lucas
5c04f8a13c
Disable bad test and don't allow registerElement of direct class in dart:html or dart:svg
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1397323002 .
2015-10-12 03:17:21 -07:00
Terry L. Lucas
6227b207e6
Fixed to allow only HtmlElement in registerElement
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1403683002 .
2015-10-11 20:53:50 -07:00
Terry L. Lucas
b6503c7f74
Added for registerElement checking
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1401703002 .
2015-10-11 18:57:59 -07:00
Terry L. Lucas
4f9771f4e1
Fixed JS custom elements and temporarily mark polymer test as failing
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1402693002 .
2015-10-10 16:50:10 -07:00
Terry L. Lucas
888d458e90
Fixed upgrading and data binding
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1403623002 .
2015-10-09 17:03:53 -07:00
Terry L. Lucas
78658b3a88
Hide the accessors for bad custom element upgrade
...
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1397793002 .
2015-10-08 10:27:51 -07:00
Terry L. Lucas
c9b553aad1
Fixed upgrade failures to only throw once not on each wrap_jso
...
R=alanknight@google.com
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1395723002 .
2015-10-07 14:37:24 -07:00
Jacob Richman
1f9516ba0b
Fix some build breaks.
...
Fix test breaks
Roll dep forward to fix windows build.
Dartium typed js interop work dart repo side of the change. Also tries to get
BUG=
Review URL: https://codereview.chromium.org/1390113003 .
2015-10-07 13:47:12 -07:00
Jacob Richman
8d793ca758
Dartium typed js interop work dart repo side of the change. Also tries to get
...
BUG=
Review URL: https://codereview.chromium.org/1391353002 .
2015-10-07 11:44:50 -07:00
Terry L. Lucas
f867fb0218
Fixed element upgrading for polymer
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1382383003 .
2015-10-06 13:11:23 -07:00
Terry L. Lucas
138888e566
Need to handle skipping mixins in a CustomElement
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1368383002 .
2015-09-28 07:29:14 -07:00
Terry L. Lucas
40fed74848
Fixed checking for more complex inheritance
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1374543002 .
2015-09-27 21:09:34 -07:00
Terry L. Lucas
3ce007e910
Fixed a bunch of failure cases for custom elements
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1373563004 .
2015-09-25 15:12:08 -07:00
Terry L. Lucas
54282ccd72
Update to handle expections in custom element's created constructor
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1370513003 .
2015-09-24 13:17:35 -07:00
Terry L. Lucas
7b322c246c
Dartium JS Enabled take 2
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas
09c804aa78
Revert "Dartium JS Interop enabled."
...
This reverts commit 403bd1698d .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas
403bd1698d
Dartium JS Interop enabled.
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas
9b0d2582fc
Revert "Dartium w/ JsInterop enabled"
...
This reverts commit 346af54711 .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas
346af54711
Dartium w/ JsInterop enabled
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas
012c998f64
Revert "Patched in Dartium JsInterop"
...
This reverts commit 4bb2e617db .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas
4bb2e617db
Patched in Dartium JsInterop
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
vsm@google.com
94095d64a2
Merge 38 changes to bleeding edge
...
TBR=terry@google.com ,leafp@google.com
BUG=
Review URL: https://codereview.chromium.org//605083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00