Robert Nystrom
ba40d9bece
Format tests/web/ using the 3.8 formatting style.
...
Change-Id: I73edeeaf4934899b71d6335dcb4b4b54dce46bae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426340
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Nate Biggs <natebiggs@google.com >
2025-05-02 20:17:11 -07:00
Robert Nystrom
d7ed15658a
Opt multitests out of formatting in web/.
...
The new formatter supports opting a region of code out from being
formatted. I'm applying this marker to all of the multitests since
those tests are often very sensitive to formatting and easily broken.
This way, anyone touching a multitest (including me when I reformat
the tests) doesn't have to remember to not run the formatter on it.
Change-Id: I3d6346d31581772dc8e1701594bf9d919f28db7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396104
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2024-11-19 00:59:10 +00:00
Lasse R.H. Nielsen
f8086c81ae
Collect all test-related files in package:expect.
...
Collects files from `package:async_helper` and `tests/language`
that are generally useful, so that all test-related helpers are
in `package:expect`.
Moves the two libraries from `package:async_helper` into `package:expect`,
and the `tests/language/static_type_helper.dart` file too.
Deprecates `async_minitest.dart`, to follow `minitest.dart`,
expecting the Flutter use of it to have been fixed to not break
on deprecation (I believe Flutter no longer breaks builds on deprecations at all).
Patch 1 is the actual change.
Patch 2+4+8 is changing all existing references to the files.
Patch 6 ignores deprecation in files still using `async_minitest.dart`.
3+5+7+9 are updating this text to make the numbers match.
Then it's just test-expectations and small tweaks from there.
Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2024-10-11 16:53:52 +00:00
Josh Soref
1ab011a2a7
Spelling tests web
...
Closes https://github.com/dart-lang/sdk/pull/50879
TEST=only changes to spelling to comments and internal string messages
GitOrigin-RevId: 3fa4104fa17054ea2247118a1b6213c62f2749e0
Change-Id: I776120bb2492c662dd32612dd2f6a670b5891e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278060
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2023-01-05 01:26:52 +00:00
Josh Soref
df97aca1fa
Spelling tests
...
Closes https://github.com/dart-lang/sdk/pull/50764
GitOrigin-RevId: ee2fe9a75d50e877f4ad2fe3743acdbc04f186ef
Change-Id: Ia73cd22da4e6ec95e84772aa4e1345ce2dbde215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276360
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2022-12-19 12:56:47 +00:00
Lasse R.H. Nielsen
5642199dd0
Remove uses of : as default value separator in some tests/ directories.
...
Change-Id: I35bb926e53e92fd02e264fb5b14feadf063fb8db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257961
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2022-09-07 14:49:17 +00:00
Stephen Adams
bc1d9b0a2f
[dart2js] Test for trusted script URLs
...
Change-Id: Ib4726fc522756f9a7cc860aaa09c6b0037a85c70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237638
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2022-03-18 01:09:47 +00:00
Joshua Litt
2ad8d3d23e
[dart2js] Add test for empty holders in an output unit.
...
Change-Id: I364366c2a5e9ce5895dbc4096d17ad04374b69d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202310
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2021-06-04 17:55:17 +00:00
Joshua Litt
28aa79ddd7
Reland "[dart2js] Add support for bundling fragments."
...
This is a reland of d0f55d0e42
Original change's description:
> [dart2js] Add support for bundling fragments.
>
> Also changes the default to bundling rather than interleaving fragments.
>
> Change-Id: Id79d03a8a8b5be7465b8535f6c9c47dfad120c9c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191484
> Commit-Queue: Joshua Litt <joshualitt@google.com >
> Reviewed-by: Stephen Adams <sra@google.com >
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
Change-Id: I0347ddb6dd93eb57f0abc259fc477ec3a9d7231b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194323
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2021-04-08 17:46:50 +00:00
Joshua Litt
05a0e79a76
Revert "[dart2js] Add support for bundling fragments."
...
This reverts commit d0f55d0e42 .
Reason for revert: Investigating 5% spike in memory usage
Original change's description:
> [dart2js] Add support for bundling fragments.
>
> Also changes the default to bundling rather than interleaving fragments.
>
> Change-Id: Id79d03a8a8b5be7465b8535f6c9c47dfad120c9c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191484
> Commit-Queue: Joshua Litt <joshualitt@google.com >
> Reviewed-by: Stephen Adams <sra@google.com >
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
TBR=sra@google.com ,sigmund@google.com ,joshualitt@google.com
Change-Id: I3d61f14981d9314163974c6a38d5a5e0d76b5a98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194322
Reviewed-by: Joshua Litt <joshualitt@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2021-04-07 23:53:20 +00:00
Joshua Litt
d0f55d0e42
[dart2js] Add support for bundling fragments.
...
Also changes the default to bundling rather than interleaving fragments.
Change-Id: Id79d03a8a8b5be7465b8535f6c9c47dfad120c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191484
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2021-04-07 18:30:47 +00:00
Joshua Litt
5ca3b45541
[dart2js] Remove unused 'classesOnlyNeededForRti' field.
...
Change-Id: I424fd9fcf6c7f8a9d0f724b5599fc96242bb9042
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192943
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2021-03-31 17:30:29 +00:00
Sigmund Cherem
912005267d
[web] rename suite dart2js -> web.
...
Change-Id: I46be49b2effec3e38a3dc44cd45cfe736f77fa78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182680
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2021-02-04 23:11:32 +00:00