Commit Graph

15 Commits

Author SHA1 Message Date
Robert Nystrom 8717ff636a Format tests/lib/math/ using 3.8 style.
Change-Id: Ib34bac4962df8927cf2952a4cc5e388c84dcea79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425984
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2025-05-05 02:23:50 -07:00
Lasse R.H. Nielsen 19252d5786 Fix behavior for -infinity width/height of rectangles.
Fixes #30186
BUG= dartbug.com/30186

Change-Id: I2994d180a4dc4d4e4bba7edec67bc2bcc2e8fc0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201568
Auto-Submit: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2021-06-21 13:29:39 +00:00
Riley Porter 17f5dcb336 [tests] Fix CompileTimeErrors in migrated tests.
Fixes:
lib/math/rectangle_test
lib/convert/utf8_test
lib/convert/utf8_encode_test
lib/convert/streamed_conversion_utf8_encode_test
lib/convert/streamed_conversion_utf8_decode_test
lib/convert/streamed_conversion_json_utf8_encode_test
lib/convert/streamed_conversion_json_utf8_decode_test
lib/convert/json_lib_test
lib/convert/encoding_test
lib/convert/chunked_conversion_utf8_test
lib/convert/chunked_conversion_utf85_test
lib/convert/chunked_conversion_utf84_test
lib/convert/base64_test/none
Change-Id: I9d540e2bc908ac2ac74e42fc1b2eb4c729371c96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143183
Commit-Queue: Riley Porter <rileyporter@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-04-13 22:42:51 +00:00
Robert Nystrom 582cec84f4 Set up new test suites for migrating the tests to NNBD.
- Copies corelib_2/a*    -> corelib/
- Copies language_2/ab*  -> language/
- Copies lib_2/math/     -> lib/math/
- Copies standalone_2/a* -> standalone/

And also copies over and renames all of the status files in those
directories.

Then it migrates those tests to be static error free in NNBD.

Finally, adds support to the test_runner for the new suites.

Note that this review is split into multiple patchsets. The first
patchset is a straight copy of the existing files. Then the later
patchsets have the interesting changes.

Change-Id: Icec2ff850a3aee30b653066ac184495d1e3814d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125467
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2019-11-19 00:18:43 +00:00
Ben Konyi adfc7a6b72 Migrated test lock 217 to Dart 2.0.
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.

BUG=

Review-Url: https://codereview.chromium.org/2997283003 .
2017-08-31 07:47:36 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests"
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
2017-01-25 11:06:58 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
2017-01-25 08:50:02 -08:00
lrn@google.com 1ffd31fcde Fix assert in dart:math/Rectangle.
Didn't pass NaN down the correct path, and failed an assertion.
Added tests.

BUG= http://dartbug.com/17734
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//228533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34822 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:12:21 +00:00
lrn@google.com e314fc2671 Make Rectangle and MutableRectangle constructors handle negative lengths.
Now handles negative width/height so that it's equivalent to
   new Rectangle.fromPoints(new Point(left, top),
                            new Point(left + width, top + height))

BUG= http://dartbug.com/16167
R=efortuna@google.com

Review URL: https://codereview.chromium.org//135273009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32736 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 10:12:23 +00:00
lrn@google.com 1c27022d7c Change Rectangle.operator== to compare right/bottom instead of width/height.
BUG= http://dartbug.com/16245
R=efortuna@google.com

Review URL: https://codereview.chromium.org//145973005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32155 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 09:54:44 +00:00
efortuna@google.com 4a8d13f0f6 Fix Rectangle test with method name.
BUG=

Review URL: https://codereview.chromium.org//41073004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29205 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 20:48:44 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
efortuna@google.com 0b53b15b7d "Reverting 28184"
TBR=blois

BUG=

Review URL: https://codereview.chromium.org//25785003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28186 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 22:13:16 +00:00
efortuna@google.com 837c6b6ee3 Move Point and Rect over to dart:math, to be re-exported by dart:html.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28184 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:54:02 +00:00