Commit Graph

19 Commits

Author SHA1 Message Date
Robert Nystrom d3904f5a54 Reformat tests/lib/async/** using 3.8 style.
Change-Id: I6ccbe1494165c2bda142ece13584c4738e3b43e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425347
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2025-05-02 04:08:54 -07:00
Lasse R.H. Nielsen f8086c81ae Collect all test-related files in package:expect.
Collects files from `package:async_helper` and `tests/language`
that are generally useful, so that all test-related helpers are
in `package:expect`.

Moves the two libraries from `package:async_helper` into `package:expect`,
and the `tests/language/static_type_helper.dart` file too.

Deprecates `async_minitest.dart`, to follow `minitest.dart`,
expecting the Flutter use of it to have been fixed to not break
on deprecation (I believe Flutter no longer breaks builds on deprecations at all).

Patch 1 is the actual change.
Patch 2+4+8 is changing all existing references to the files.
Patch 6 ignores deprecation in files still using `async_minitest.dart`.

3+5+7+9 are updating this text to make the numbers match.
Then it's just test-expectations and small tweaks from there.

Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
2024-10-11 16:53:52 +00:00
Robert Nystrom a2b556b937 Migrate lib_2/async to NNBD.
Change-Id: Ia5c41dda6503e1fbb8cc6099835d07588425e2ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128310
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2020-01-09 22:04:37 +00:00
Ben Konyi 0ea752b5bf Relanding test block 170 migration.
"Migrated test block 170 to Dart 2.0.""

This reverts commit 201df65b50201f023a1db5bb26bea7b8976c3b32.

Review-Url: https://codereview.chromium.org/3005813002 .
2017-08-29 16:22:07 -07:00
Ben Konyi e8b337f08f Revert "Migrated test block 170 to Dart 2.0."
This reverts commit 6e6b0cadea9adbb48556384fac52b17c2ac15443.
2017-08-29 15:37:15 -07:00
Ben Konyi a7b19c1b47 Migrated test block 170 to Dart 2.0.
Updated status file to account for strange failure in package:test when
running multiple_timer_test on dartdevc.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995013002 .
2017-08-29 15:25:42 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests"
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
2017-01-25 11:06:58 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
2017-01-25 08:50:02 -08:00
kevmoo@google.com 0726458e52 tests: import unittest via package: url
R=ricow@google.com

Review URL: https://codereview.chromium.org//218283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34602 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 16:12:39 +00:00
kevmoo@google.com 5952d7a067 Upgrading tests with unittest deprecations
R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//218273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34569 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:33:18 +00:00
lrn@google.com 70f6617532 Revert "Fix VM timer firing too early."
Committed: https://code.google.com/p/dart/source/detail?r=30987

R=floitsch@google.com

Review URL: https://codereview.chromium.org//101293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31009 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 08:40:56 +00:00
lrn@google.com dd6ee012d1 Revert "Fix VM timer firing too early."
Review URL: https://codereview.chromium.org//101293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30987 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 13:43:52 +00:00
lrn@google.com 2aa9f026f2 Change Future.timeout callback to a named parameter.
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30790

Review URL: https://codereview.chromium.org//96643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30985 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 12:06:12 +00:00
antonm@google.com ae1393fcdc Revert "Try out 15 ms safety margin."
TBR=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//16310006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23732 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 08:38:09 +00:00
antonm@google.com 5d90793a87 Try out 15 ms safety margin.
If tests start to pass on Windows, it might be a notable clue
that Stopwatch implementation on this platform is not precise
enough.

R=floitsch@google.com
BUG=10982

Review URL: https://codereview.chromium.org//16568002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23696 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 16:43:16 +00:00
floitsch@google.com 789a144672 Add margin to browser tests and not VM...
Review URL: https://codereview.chromium.org//12516012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20212 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 15:57:27 +00:00
floitsch@google.com 88dc9f5d8c Add safetymargin for timer tests in browsers.
Review URL: https://codereview.chromium.org//12855003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20209 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 15:13:30 +00:00
floitsch@google.com 61b307fb6a Move timer tests to async tests.
Review URL: https://codereview.chromium.org//12812014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20203 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 13:20:35 +00:00