361cf93984
Reformat tests/language/a-e using 3.8 style.
...
Change-Id: I5cfab9212bb78809967de323b60ebb06913b84d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425149
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2025-04-29 07:38:43 -07:00
d3bbacfa9d
[analyzer] Faster export scope calculation in bad cases
...
With the `big_chain_benchmark` for ImportExportCycle and
ImportCycleExportChain it scales a lot better. The other ones
(ImportCycle, ImportChain, ImportExportChain) doesn't change.
For ImportExportCycle, in AOT mode, before we got:
```
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.46673 | 0.169486 | 0.406448 |
| 32 | 0.875871 | 0.242876 | 0.85543 |
| 64 | 1.583077 | 0.465915 | 1.506953 |
| 128 | 3.198071 | 0.903894 | 3.09165 |
| 256 | 6.786677 | 2.149489 | 6.779569 |
| 512 | 17.346131 | 8.92149 | 17.971033 |
| 1024 | 63.358453 | 46.152089 | 65.401559 |
+------+-----------+------------+------------+
```
now instead we get:
```
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.474942 | 0.166857 | 0.411457 |
| 32 | 0.834925 | 0.243397 | 0.76843 |
| 64 | 1.608813 | 0.439885 | 1.53438 |
| 128 | 3.198453 | 0.805756 | 3.302559 |
| 256 | 6.347211 | 1.712426 | 6.165624 |
| 512 | 12.874747 | 3.551489 | 13.1461 |
| 1024 | 27.14403 | 7.844261 | 27.32785 |
+------+-----------+------------+------------+
```
An almost 6x improvement for completion and 2x+ improvement for both
initial analysis and analysing after the change.
For ImportCycleExportChain, in AOT mode, before we got:
```
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.454349 | 0.152505 | 0.400889 |
| 32 | 0.892146 | 0.302407 | 0.81263 |
| 64 | 1.67604 | 0.439954 | 1.517379 |
| 128 | 3.335087 | 0.907002 | 3.262481 |
| 256 | 6.378526 | 1.943725 | 6.292922 |
| 512 | 15.477861 | 6.461358 | 15.560008 |
| 1024 | 50.671197 | 33.14349 | 51.689455 |
+------+-----------+------------+------------+
```
now instead we get:
```
+------+-----------+------------+------------+
| Size | Initial | Completion | Fully done |
+------+-----------+------------+------------+
| 16 | 0.548357 | 0.166257 | 0.415632 |
| 32 | 0.906483 | 0.296618 | 0.910544 |
| 64 | 1.623723 | 0.464061 | 1.527888 |
| 128 | 3.067769 | 0.801507 | 2.927981 |
| 256 | 6.224551 | 1.596711 | 6.098531 |
| 512 | 12.941757 | 3.277487 | 12.345753 |
| 1024 | 25.870713 | 7.020787 | 25.760605 |
+------+-----------+------------+------------+
```
A ~4.7x improvement on completion and ~2x improvement for both initial
analysis and analysing after the change.
Change-Id: I052879c1695ad5f0aa63c2d96013a1e3eae96428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413421
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2025-03-19 02:11:16 -07:00
aab7621900
Remove some multitest runtime-tests.
...
Change-Id: I8fb69fecbe67236a4cbad9c1eb899a31a26a1ba3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410002
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2025-02-19 04:21:42 -08:00
3166d7188f
Format tests/language/e*.
...
Since I regenerated the test expectations, this also fills in a few
unspecified errors with more precise information.
Change-Id: I4a2450de030a7d38b08f30f46d9d9feca99404f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407082
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2025-02-03 03:29:35 -08:00
5bb9e922db
Opt multitests out of formatting in language/.
...
The new formatter supports opting a region of code out from being
formatted. I'm applying this marker to all of the multitests since
those tests are often very sensitive to formatting and easily broken.
This way, anyone touching a multitest (including me when I reformat
the tests) doesn't have to remember to not run the formatter on it.
Unfortunately, this doesn't opt out 100# of the multitests. There are a
handful of multitests that also contain "@dart=" comments and are thus
formatted using the old style where the "// dart format off" marker has
no effect. For those, we'll have to still be careful to not accidentally
format them.
Change-Id: I257d0ee1eb44eee57047be06b8520f0ccc7b56d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396162
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2024-11-21 10:49:44 +00:00
9789e9d7a0
Migrate "e" and "f" directory language tests off @compile-error.
...
The "@compile-error" comment is an old not-great way of defining static
error tests.
See: https://github.com/dart-lang/sdk/issues/45634
Change-Id: Idf9012cb8c213b523d1c8bb827e530e0d2cf6609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296407
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2023-04-20 20:49:17 +00:00
7e183b64a9
[test] Fix bug in export/duplicate_import_libd
...
`git show fc1b1ecc712d` shows - among lots of other changes - this:
```
diff --git a/tests/language_2/duplicate_import_liba.dart b/tests/language_2/export/duplicate_import_liba.dart
similarity index 100%
rename from tests/language_2/duplicate_import_liba.dart
rename to tests/language_2/export/duplicate_import_liba.dart
```
and
```
diff --git a/tests/language_2/duplicate_import_libd.dart b/tests/language_2/export/duplicate_import_libd.dart
similarity index 91%
rename from tests/language_2/duplicate_import_libd.dart
rename to tests/language_2/export/duplicate_import_libd.dart
index ccec81e0ff6..14f1ff413fb 100644
--- a/tests/language_2/duplicate_import_libd.dart
+++ b/tests/language_2/export/duplicate_import_libd.dart
@@ -8,6 +8,6 @@ import 'duplicate_import_liba.dart';
import 'duplicate_import_libb.dart';
import 'duplicate_import_libc.dart';
-export 'duplicate_import_liba.dart';
+export '../duplicate_import_liba.dart';
export 'duplicate_import_libb.dart';
export 'duplicate_import_libc.dart';
```
Change-Id: I806ba94ae251d574981e06ea88e6189063719785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205264
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2021-06-30 07:44:52 +00:00
9ea431c158
Simplifying and recategorizing cyclic imports test
...
This bug doesn't depend on exports and instead of the constructed class hierarchy.
See: https://dart-review.googlesource.com/c/sdk/+/162383/comment/9196db98_412d446d/
Change-Id: Ib107d3fa3ab7782bee5db59754583b20976832a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162785
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-09-14 20:20:49 +00:00
53895b2270
[dartdevc] Fixing issue related to dual exports of multiple entrypoints in a cyclic import loop.
...
See: https://github.com/flutter/flutter/issues/64011
Change-Id: I8a11e9d3f19428a516cf7a60ee45c3bacf26545d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162383
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-09-14 18:49:00 +00:00
22b8caff1f
Migrate language_2/export to NNBD.
...
Change-Id: Ib33ec31e1d200d602fd05439101847afbb629f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142709
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-04-07 23:30:56 +00:00
Robert Nystrom