I removed one clearly dead multitest piece, but otherwise didn't try
to clean things up. There's definitely something weird about the dynamic
field tests, but I don't even know what they should be doing, so left
them alone.
Change-Id: Ic80c2b26d640da0aafeededaa981ed8c2fecc93a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406920
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
The new formatter supports opting a region of code out from being
formatted. I'm applying this marker to all of the multitests since
those tests are often very sensitive to formatting and easily broken.
This way, anyone touching a multitest (including me when I reformat
the tests) doesn't have to remember to not run the formatter on it.
Unfortunately, this doesn't opt out 100# of the multitests. There are a
handful of multitests that also contain "@dart=" comments and are thus
formatted using the old style where the "// dart format off" marker has
no effect. For those, we'll have to still be careful to not accidentally
format them.
Change-Id: I257d0ee1eb44eee57047be06b8520f0ccc7b56d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396162
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Invocation forwarders currently cannot distinguish a named parameter not
passed from passed as `null`.
Refactor `getNamedParameter` to return nullable index. When the index is
not null it means that the named parameter is present, and its value may
be `null`.
This doesn't fix any of the existing tests so I added a regression test.
(Bug originally discovered and fixed in
https://dart-review.googlesource.com/c/sdk/+/278505)
Change-Id: I960c674073b3d25c37e79f9836647882acaff08b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278745
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
Various cleanups to the TypeBuilder classes:
TypeBuilder:
* Remove `origin` parameter from TypeBuilder.build and instead make
FunctionType.typedefType mutable and set if after creation.
* Remove `charOffset` and `fileUri` parameters from
TypeBuilder.buildSupertype/buildMixedInType
* Remove `bind`, `resolveIn`, and `check` from TypeBuilder so that
these are only present on NamedTypeBuilder
* Remove TypeBuilder.buildTypeLiteralType and instead pass an
argument to NamedTypeBuilder that determines what type to create
on `build`.
NamedTypeBuilder:
* Make NamedTypeBuilder.instanceTypeVariableAccess private
* Add NamedTypeBuilder.forDartType for prebuilt types
* Add NamedTypeBuilder.forInvalidType for types created for errors
* Make NamedTypeBuilder.declaration private and corresponding getter
* Check most type use errors on NamedTypeBuilder.bind
* Make NamedTypeBuilder helper methods private
* Add `TypeVariableBuilder.isClassParameter` to support checking for
valid type variable use through the `NamedTypeBuilder.bind` method.
* Remove checking of type variable in static context from BodyBuilder
since it is now checking on `NamedTypeBuilder.bind`.
FunctionTypeBuilder:
* Cache result of FunctionTypeBuilder.build
TypeBuilderComputer:
* Cache "constant" type declarations in TypeBuilderComputer
Change-Id: Ibaedcb255487eecc5efe70b84e5cbd5a118c1e0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239023
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Lasse R.H. Nielsen