617d0a8e96
[model] Remove more nullability-related assignability error messages
...
This is a preparation for removing the subtype checking procedure that
ignores the nullability in the input types.
Change-Id: I3c1db55abde0433e9059d949f1c98aaeb61e210c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428980
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2025-05-19 00:18:57 -07:00
361cf93984
Reformat tests/language/a-e using 3.8 style.
...
Change-Id: I5cfab9212bb78809967de323b60ebb06913b84d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425149
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2025-04-29 07:38:43 -07:00
0dde212150
[cfe] Add LookupResult
...
This replaces the individual lookups of getables and setables in LookupScope and NameSpace with single lookup that returns a LookupResult holding both the getable and the setable. This prepares for having getter/setter pairs in the same SourcePropertyBuilder and avoids the need for AccessErrorBuilder for handling lookups of getters where only setters exist and vice versa.
Change-Id: I2b1e2477ed43506d9f94c48acd4b44277b490540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420080
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2025-04-08 03:49:31 -07:00
aab7621900
Remove some multitest runtime-tests.
...
Change-Id: I8fb69fecbe67236a4cbad9c1eb899a31a26a1ba3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410002
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2025-02-19 04:21:42 -08:00
6cc9efe290
Reformat tests/language/c*.
...
Change-Id: I94dfcea40566190c6bf153c108b0d0d5dbf27a4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400148
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2024-12-12 15:50:08 -08:00
5430e68680
Remove unnecessary leftover @dart=2.19 from tests.
...
Change-Id: I6d5e15ff2d432202618fbc490969a65a9181816d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396281
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2024-11-28 09:10:30 +00:00
5bb9e922db
Opt multitests out of formatting in language/.
...
The new formatter supports opting a region of code out from being
formatted. I'm applying this marker to all of the multitests since
those tests are often very sensitive to formatting and easily broken.
This way, anyone touching a multitest (including me when I reformat
the tests) doesn't have to remember to not run the formatter on it.
Unfortunately, this doesn't opt out 100# of the multitests. There are a
handful of multitests that also contain "@dart=" comments and are thus
formatted using the old style where the "// dart format off" marker has
no effect. For those, we'll have to still be careful to not accidentally
format them.
Change-Id: I257d0ee1eb44eee57047be06b8520f0ccc7b56d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396162
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2024-11-21 10:49:44 +00:00
bdc1b37d42
[cfe] Adjust error message for absent super constructor parameter
...
Closes https://github.com/dart-lang/sdk/issues/56406
Change-Id: I8d1eee0f515a2df912b979c2df0663b3ed23eda8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379604
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-08-19 11:45:02 +00:00
c10ecb8fe5
[test] Convert most lib/mirrors multitests to static error tests
...
Change-Id: I4f3b728a94291bf0a31a5f38af9d8b877a9900af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363702
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2024-04-23 23:33:48 +00:00
a862d9d745
analyzer: Correct message about const addition operator
...
Fixes https://github.com/dart-lang/sdk/issues/54578
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Fixed: 54578
Change-Id: Iebc9e04539a172e58024758e33ffd93e48cb1a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-04-18 17:21:29 +00:00
1c67426891
[analyzer] Report cycles in constant constructors.
...
Cycles were not previously reported because constructors don't have an
evaluation result (since it depends on the invocation arguments).
This CL uses the ConstantVerifier to check every constant constructor.
Fixes https://github.com/dart-lang/sdk/issues/46735
Bug: https://github.com/dart-lang/sdk/issues/46735
Change-Id: Ie8419787b621abb303ecc738aa36f2e7abf96a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317841
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-08-29 19:02:38 +00:00
8c2f088481
[analyzer] Separate exception and evaluation errors in the const evaluator.
...
Some errors like type checking of fields should be reported directly, so this CL separates these errors from evaluation exception errors. This reverts some changes we have before.
Additionally, we move error reporting for the constructors to an outer-most method to avoid reporting multiple times.
Change-Id: Ie2fde0ea7d389a633051cb106012a0738354f821
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319911
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-08-22 18:21:10 +00:00
1f88336597
[analyzer] Move all constructor error reporting to _InstanceCreationEvaluator.evaluate
...
Pull the error handling outwards to _InstanceCreationEvaluator.evaluate. All errors in const constructors should point to the location of the actual exception and provide more context.
Change-Id: Iafcf46182fab698f5546c63780de6dd9a605a51b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-08-08 21:55:34 +00:00
c86af3c39b
[analyzer] Refactor visitMethodInvocation in the const evaluator.
...
Change-Id: I9ae6c17967c98770ed06dead200c8bd87ae7f2a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309829
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-06-30 18:32:27 +00:00
82b78916fd
[tests] Remove obsolete Dart 3.0 experiments from language tests
...
Change-Id: If31c487e3ebe2c1ae847aff7c8994580b8b6f2f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309660
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2023-06-15 08:26:27 +00:00
345d0f3a47
[analyzer] Issue 37238: Multiple errors for type mismatch assignments.
...
Avoid reporting an error if the static types are mismatched because
CompileTimeErrorCode.INVALID_ASSIGNMENT would have already been
reported by the ErrorVerifier.
Closes #37238
Bug: https://github.com/dart-lang/sdk/issues/37238
Change-Id: I2248d054ed6bf6a546e998afb9b731a36e197780
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2023-05-19 16:27:58 +00:00
d244eeb84c
Migrate "c" directory language tests off @compile-error.
...
The "@compile-error" comment is an old not-great way of defining static
error tests.
See: https://github.com/dart-lang/sdk/issues/45634
Change-Id: I3e10209e78e48893d2f2df7f8af7963d319efd9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296405
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2023-04-20 19:10:58 +00:00
94c165d189
[cfe] Implement primitive equality
...
Closes #51045
Closes #51565
Closes #51566
Closes #51688
Closes #51800
Change-Id: I4a679ef9cf496a22f4fdc2047a2dc4753e796e2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290320
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
2023-03-22 12:25:41 +00:00
3b06df241f
Clean up a number of 2.19 opt outs in language tests.
...
This is less than half of them, will send some other chunks later.
Bug:51557
Change-Id: I4e80812a689fde99e23c34b6405aaf57cd431ce8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289261
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-03-17 16:17:50 +00:00
7ca5ad46ce
Set tests that have mixin errors as 2.19.
...
Mark tests that contain errors about using a class as a mixin to use
language version 2.19 where that's not an error.
This may not fix all of the tests because it's the language version of
the library where the class is declared that matters, not where the
class is used as a mixin. But most tests have all of their declarations
in the same library, so this should fix most.
Change-Id: I910439ebd2f10f731418dc588b7e4619a0841c16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285923
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-03-01 15:03:39 +00:00
41bc0b4d07
opt assignable_expression_test into 2.19
...
opt switch related tests back to 2.19
opt map/set hashCode override tests back to 2.19
Change-Id: Ib5c44fc17de43eaf9bcad71d7a326c5fcbff02bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285800
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-02-27 22:48:51 +00:00
3f288db57e
Issue 51046. Implement primitive equality.
...
Bug: https://github.com/dart-lang/sdk/issues/51046
Change-Id: I2190b9e36753cc5f4708597ae0b515430d2f7bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-02-18 06:22:04 +00:00
4f8af109af
Correct primitive equality error test
...
Implicitly induced noSuchMethod forwarders cannot eliminate primitive
equality: They are not generated at all if they would override an
explicit member declaration (here: `Object.hashCode` and `Object.[]`).
Hence, the classes `Secret...` that we used to have (which were intended
to do just that) were simply compile-time errors, and hence those
classes and the locations where they were used are being removed in
this CL.
Change-Id: Id1a1f9bc1a2f7ce1886388d6938d0d0a4da45d84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279394
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2023-01-23 22:24:35 +00:00
af51dc4249
Add tests about primitive equality
...
Change-Id: Ife971f04010e801f58be48c578d6df11103fb29d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279165
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
2023-01-18 18:34:30 +00:00
17ccbecc61
Spelling tests language
...
Closes https://github.com/dart-lang/sdk/pull/50763
GitOrigin-RevId: ee6187bc11c8211402b6aa722eb2c0826cba3d5b
Change-Id: I598004024a89e25710b9f16749ffb7c6fd6753c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276340
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2022-12-19 16:30:06 +00:00
3d7aacda12
[tests] Migrate away from native
...
Aggregated test results:
Pass -> CompileTimeError (expected CompileTimeError)
bug: https://github.com/dart-lang/sdk/issues/28791
Change-Id: I4de6dc405be0fe4f2acf1a073fa9ab5210e49c68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266022
Reviewed-by: Tess Strickland <sstrickl@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2022-10-28 09:16:40 +00:00
5642199dd0
Remove uses of : as default value separator in some tests/ directories.
...
Change-Id: I35bb926e53e92fd02e264fb5b14feadf063fb8db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257961
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2022-09-07 14:49:17 +00:00
40e18905f2
Fixed various typos in a lot of files
...
Closes https://github.com/dart-lang/sdk/pull/49478
TEST=Manual
GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2022-07-25 12:21:59 +00:00
de3cec3a47
Make hashcode override test throw instead of looping indefinitely.
...
This achieves the same thing (test that `hashCode` is not called), but
avoids a costly timeout on failure. This drastically cuts down the total
testing time for the language and corelib suites for dart2wasm (which
intends not to implement a special case here, since it is going to be
illegal in the future anyway).
Change-Id: I040925ebd8271a5816c81bc16484c0a96626857d
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244061
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
2022-05-11 11:48:26 +00:00
35e66b5081
Enable by default the experiment flags for the 2.17 language features
...
TEST=Existing language tests
Change-Id: I6c2ecd73a1c7add1451d72adff94df6fdcfca9fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234704
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
2022-03-04 01:08:01 +00:00
e1428ba911
Remove references to constructor-tearoff experiment.
...
TEST=Modifying existing tests.
Change-Id: I22fa11a5f2efc4bd6d1d54a656106f40bbfeafb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220002
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2021-11-11 14:04:43 +00:00
a6fe06af36
Fix language/const/constant_type_variable_error_test
...
Change-Id: I8f2c65485d694db1a831f6778e3b6a03c280c638
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216288
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-10-12 16:06:09 +00:00
93d2f90383
Add test about type parameter as constant
...
Change-Id: If9ecc60b835944897366e716ed90896dbecc3f87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213769
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2021-09-23 07:46:24 +00:00
60d878137d
Add tests dealing with instantiated function constants
...
Change-Id: Ie8cb03a7f7bb14eebc7c2e14bb1c38c04e2e7995
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213047
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2021-09-14 18:36:11 +00:00
054ae83903
Add test for constant factory constructor feature, cf. #46984
...
Change-Id: I750345600d3b47de44c060511be35aea8744eca3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211140
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2021-08-26 09:27:31 +00:00
ae4543fcb9
[cfe] Report all compile-time errors found during constant evaluation
...
Closes #46925
Change-Id: I81e97cae05c39c24b24dae82a222f857d4730ac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210465
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-08-24 11:42:53 +00:00
a5d4e010af
[test] const types and null in const maps and sets
...
We were lacking tests for doing a `null` lookup in const maps and sets.
Also, we were lacking tests for having type literals with user-defined
classes in const maps and sets.
Bug: https://github.com/dart-lang/sdk/issues/45908
Change-Id: I1665420ddcc71df7b47a87ee9e16d7ebbe9e13f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208080
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-07-26 12:42:20 +00:00
ea5333a23f
Do not report const ctor with a mixed in abstract final field
...
Additionally, reduce duplicated errors regarding invalid const constructors.
Fixes https://github.com/dart-lang/sdk/issues/46641
Change-Id: Ica397ad6e28a05bc5340d5ceca236fbedf1e95f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207621
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-07-21 17:56:08 +00:00
d5a97be466
[test] Fix getValueNonOptimized in tests
...
Addressing https://dart-review.googlesource.com/c/sdk/+/206202/4/tests/language/const/set_hashcode_override2_test.dart#12
Change-Id: I08948507b702dd0885b98ae31b1a7d22536e9ce1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206224
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2021-07-12 10:23:14 +00:00
2a68e31ffb
[test] Non terminating hashCode override in const
...
The language spec only mandates operator== to not be overridden for
instances used in const maps as keys or const sets. However, hashCode
_can_ be overridden.
This adds a test that exercises this behavior.
Bug: https://github.com/dart-lang/sdk/issues/45908
Change-Id: Id64c0722872bb916963b71057a06309bf3b8b559
Cq-Include-Trybots: luci.dart.try:dart2js-csp-minified-linux-x64-chrome-try,dart2js-minified-strong-linux-x64-d8-try,dart2js-nnbd-linux-x64-chrome-try,dart2js-strong-hostasserts-linux-ia32-d8-try,dart2js-strong-linux-x64-chrome-try,dart2js-strong-linux-x64-firefox-try,dart2js-strong-mac-x64-chrome-try,dart2js-strong-mac-x64-safari-try,dart2js-strong-win-x64-chrome-try,dart2js-unit-linux-x64-release-try,ddc-linux-release-chrome-try,ddc-mac-release-chrome-try,ddc-nnbd-linux-release-chrome-try,ddc-win-release-chrome-try,vm-kernel-precomp-nnbd-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206085
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-07-08 12:18:48 +00:00
c8c41f72a0
[test] const instances in non-const sets
...
The language spec only mandates operator== to not be overridden for
instances used in const maps as keys or const sets. However, hashCode
_can_ be overridden.
This CL adds tests that uses these const instances in non-const maps.
(As follow up of https://dart-review.googlesource.com/c/sdk/+/206085 )
Bug: https://github.com/dart-lang/sdk/issues/45908
Change-Id: I3caf5afd45aaec24b3e89e4645b00841a2075ca3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206202
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2021-07-08 11:30:53 +00:00
fed3cef63a
[vm/tests] const maps are immutable
...
Bug: https://github.com/dart-lang/sdk/issues/45908
Change-Id: I15011ab63fb119a601ba5f147481f9e9aefafdd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203683
Reviewed-by: Clement Skau <cskau@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2021-06-15 14:08:52 +00:00
a5e18113f3
Remove references to triple-shift and generic-metadata experiments.
...
TEST= removed flags from test. No behavior should change.
Change-Id: I401bfb68c082d1bd405a118d5eca6a47a807945f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199241
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2021-05-12 13:35:00 +00:00
cd2258572d
Test for avoiding exponential tree traversal of DAG constants
...
Change-Id: Ib62db28a7a6d21fe859f32f092e1096c0c166752
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109160
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-01-06 03:54:30 +00:00
38d7c7661d
[cfe] Special case Null in assignability errors.
...
In error reporting on assignability where the expression has type
`Null` we use a special messages that doesn't state that
"'Null' is nullable". Cases where `Null` is part of the type or where
the expression of type `Null` is derived from a collection are not
special cased.
Closes #43998
Closes #44093
Change-Id: Ic0c79e6362f2365eb3fe8222ccd2ef8fac4f188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170433
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-11-09 11:07:44 +00:00
13704520a0
[cfe] Indicate nullability as assignability issue when appropriate
...
Closes #43592 .
Bug: https://github.com/dart-lang/sdk/issues/43592
Change-Id: Ib57a70526a39a7125238546f08e1a2e97c279f0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168860
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-10-29 16:10:03 +00:00
4948c31b7a
[test_runner] Support detection of CFE warnings
...
+ some test expectation fixes
Change-Id: Ibf0259914960ea25978f2b8e29aa89336e209f2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162321
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-09-15 07:57:31 +00:00
0c90775fd6
[CFE] Better error messages for class initialization errors
...
Change-Id: Ic7c489b0bfffd05cdd71dc254db042956fd25c3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161944
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-09-09 11:37:47 +00:00
b8ce4baf7e
Remove 'checked mode' from checked_mode_compile_time_errors
...
Change-Id: I6576eb186149d540ce2dbc0e0aab7177ff4727be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-07-31 19:20:58 +00:00
f23f450e11
Analyzer: Move CONST_CONSTRUCTOR_PARAM_TYPE_MISMATCH to compile-time
...
Many of the tests were highly redundant. Subtyping has been
consolidated, so the tests don't need to cover a dozen different ways
to subtype a class.
Change-Id: I04448790d3a74690d0edb57f15146a6c3b8f2173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156400
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-07-30 00:34:29 +00:00
Chloe Stefantsova