929657adc6
[co19] Roll co19 to 4ebc13c27af77129889a11fd1f95cff04dccd8f9
...
2025-04-10 sgrekhov22@gmail.com dart-lang/co19#3057 . Add more flow analysis tests for while loop (dart-lang/co19#3141 )
2025-04-10 sgrekhov22@gmail.com dart-lang/co19#2119 . Rename unary_minus.dart to be visible for the test runner (dart-lang/co19#3140 )
2025-04-09 sgrekhov22@gmail.com dart-lang/co19#3057 . Add flow analysis try-finally tests (dart-lang/co19#3139 )
2025-04-08 sgrekhov22@gmail.com Fixes dart-lang/co19#3136 . Update expected errors location in initializer_not_a_constant_t03.dart (dart-lang/co19#3138 )
2025-04-08 sgrekhov22@gmail.com dart-lang/co19#3057 . Add flow analysis try-catch tests (dart-lang/co19#3137 )
2025-04-08 sgrekhov22@gmail.com dart-lang/co19#3057 . Add switch-expression tests (dart-lang/co19#3135 )
2025-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#3133 . Fix language version format. (dart-lang/co19#3134 )
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibef7bb6dbc070122711ade17173946466f468a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422060
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com >
2025-04-11 03:38:56 -07:00
cc0527decb
Remove babel from DEPS and (dart2js) IE support from test infra.
...
Tested: N/A
Change-Id: Ib1804b49c40cac9be52e732090e8160444ebb48d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417948
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2025-03-28 11:26:47 -07:00
6f70ffa4ff
[dart:html] Disallow extending html elements.
...
This change removes the `.created` constructor in the html
class hierarchy. These classes now only offer public factory
constructors. As a result, developers will no longer be able
to extend these classes in their libraries.
This is a breaking change, however we don't expect there to
be as much use of this feature (extending html element
classes). In particular, the ability to extend html elements
was intended for web components. Dart only ever supported
the 0.5 spec of web components, which is old and long
deprecated. Previously, in Dart 3.0, we removed APIs used
to register custom elements from `dart:html`, so the ability
to extend html elements has not been useful since then.
For more details see https://github.com/dart-lang/sdk/issues/53264
CoreLibraryReviewExempt: ddc/dart2js-specific library.
Change-Id: I43d8c9ae99dc83545e70e1f3b9dfc9f1b274a5c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321741
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2025-03-11 13:25:58 -07:00
61336f32ab
[dart2wasm] Mark timing out test as SkipSlow on all browsers, not just Chrome
...
The root cause is that an `asyncEnd()` doesn't get executed which
will make the test not print `unittest-suite-success` which will
make the test controller keep waiting indefinitly until the test
times out.
=> This is true on all browsers, not just Chrome
Though commandline JS engines don't have this problem as they will
simply exit once there's no longer work and event loop is empty.
=> Here the test runner will recognize the missing
`unittest-suite-success` and report the tests as failing.
Issue https://github.com/dart-lang/sdk/issues/55182
Change-Id: Id217e9bd715d99f9927e7e18b03385aa2880b27f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404107
Reviewed-by: Ömer Ağacan <omersa@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2025-01-14 05:20:33 -08:00
5c1796f4e0
[vm,ffi] Avoid linking test DLLs to dart.exe
...
The `ffi_test_functions` shared library needs to access functions from
`dart_api.h` and `dart_native_api.h`, which are only available in
the Dart executable.
UNIX shared libraries can have undefined symbols, which are resolved at
runtime and can be found in the loading executable. Windows DLLs cannot
have undefined symbols, but they can be dynamically linked to an
executable (in this case `dart.exe`). This requires the DLL to be able
to find the executable at runtime.
A better solution is to include implementations for the Dart APIs in the
DLL itself, that use `GetModuleHandle(NULL)` to get a handle to the
executable and `GetProcAddress` to get the address of the function.
This is what `dart_api_win.c` does.
Fixes https://github.com/dart-lang/sdk/issues/40579
Fixes https://github.com/dart-lang/sdk/issues/59677
TEST=ci
Cq-Include-Trybots: luci.dart.try:vm-win-release-ia32-try,vm-win-debug-x64c-try,vm-win-debug-x64-try,vm-win-debug-arm64-try,vm-msvc-windows-try,vm-aot-win-debug-x64c-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-product-x64-try,vm-aot-win-release-x64-try,vm-aot-win-release-arm64-try,pkg-win-release-try,pkg-win-release-arm64-try,dart-sdk-win-try,dart-sdk-win-arm64-try
Change-Id: I7f971a8ce21e03d18ed2967e74998f925c9236b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400582
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2025-01-07 08:15:39 -08:00
0dd03ac92b
[co19] Roll co19 to 991e2f1664c64d455e0b22f0d5de45e384d5a90f
...
2024-11-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2994 . Fix a typo in type_void_A06_t11.dart (dart-lang/co19#2995 )
2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2559 . Fix wrong assertion text in augmenting_constructors_A18_*.dart (dart-lang/co19#2993 )
2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2976 . Add grammar tests (dart-lang/co19#2990 )
2024-11-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2991 . Fix typos and separate tests with `external` (dart-lang/co19#2992 )
2024-11-25 sgrekhov22@gmail.com dart-lang/co19#2559 . Update assertions for some Augmenting libraries tests (dart-lang/co19#2989 )
2024-11-21 sgrekhov22@gmail.com dart-lang/co19#2119 . Update assertion texts in Wildcards tests (dart-lang/co19#2981 )
2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2956 . Add more type `void` and `dynamic` tests (dart-lang/co19#2987 )
2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2979 . Update existing and add new tests checking nnbd static errors (dart-lang/co19#2984 )
2024-11-20 sgrekhov22@gmail.com dart-lang/co19#2979 . Fix CFE failures in nnbd weak-mode tests (dart-lang/co19#2988 )
2024-11-19 sgrekhov22@gmail.com dart-lang/co19#2956 . Update and rename existing tests for type `void` (dart-lang/co19#2978 )
2024-11-19 sgrekhov22@gmail.com dart-lang/co19#2559 . Update assertions in some Augmenting libraries tests (dart-lang/co19#2986 )
2024-11-19 sgrekhov22@gmail.com Fixes dart-lang/co19#2983 . Change expected error in generic_parameter_inference_A01_t05.dart (dart-lang/co19#2985 )
2024-11-18 sgrekhov22@gmail.com dart-lang/co19#2979 . Update NNBD static errors tests. Part 2 (dart-lang/co19#2982 )
2024-11-15 sgrekhov22@gmail.com dart-lang/co19#2979 . Update NNBD static errors tests (dart-lang/co19#2980 )
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ib1dcad2edfa7c6fdd996c6db94173bec91e68368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397340
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2024-11-27 07:48:30 +00:00
36425db14a
[co19] Add analyzer-linux-release-try tryjbbot to update.sh
...
Change-Id: I88099ba8f6835cf157428137021a3fce2d5bc577
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384021
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2024-09-09 07:40:34 +00:00
98849d5ae3
[dart2js][ddc] Fix firefox -> ff in .status files
...
The runtime name is actually expected to be "ff".
Issue: https://github.com/dart-lang/sdk/issues/51666
Issue: https://github.com/dart-lang/sdk/issues/51665
Issue: https://github.com/dart-lang/sdk/issues/51524
Change-Id: Idd0d071343c3908ad8504c55739e767e7ae368c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383704
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-09-05 16:32:47 +00:00
3037c3aa4a
[dart2js,ddc] Skip tests on Firefox and Safari
...
All of these tests call the TouchEvent constructor which is not exposed
in FireFox or Safari like it is in Chrome.
https://developer.mozilla.org/en-US/docs/Web/API/TouchEvent#browser_compatibility
Issue: https://github.com/dart-lang/sdk/issues/51666
Issue: https://github.com/dart-lang/sdk/issues/51665
Issue: https://github.com/dart-lang/sdk/issues/51524
Change-Id: I6404163f085795d86278831d3cdf62b5f5501a05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383450
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-09-04 15:39:29 +00:00
570ed43611
[ddc] Turning down unsound testing on canary (6)
...
Stop running co19 suite on the ddc-canary-linux-chrome bot.
Cleanup temporary skips from status file.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: I378954fc0cbb47c0f54edf158b3b7c38744bf0b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379525
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-08-14 21:31:30 +00:00
213150c745
[ddc] Turning down unsound testing on canary (5)
...
Stop running co19/LibTest suite on the ddc-canary-linux-chrome bot.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: Id696dd4e7b655ac797fd52409fc07d12c76ec2bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379524
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2024-08-13 18:01:41 +00:00
a33eb99f67
[ddc] Turning down unsound testing on canary (4)
...
Stop running co19/LanguageFeatures suite on the
ddc-canary-linux-chrome bot.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: I601867307f7ef9e4653627c8cf5c7766e2d80beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379523
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2024-08-12 16:41:39 +00:00
849cab7be8
[ddc] Turning down unsound testing on canary (3)
...
Stop running co19/Language suite on the ddc-canary-linux-chrome bot.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: Iba6d762f97803b609e91116c084430f0a1c3565d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379522
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2024-08-09 18:43:14 +00:00
8a2e2b8186
[tests] skip touch event test in FF and Safari.
...
This test uses the TouchEvent constructor, which is only available in Chrome.
Until we add the ability to specify browsers in the `// Requirement=` comment,
we use the status file to skip the test instead.
Change-Id: Ie89459f5f939b74a7ae0f42ef20cd894fdfc26db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379141
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2024-08-06 20:56:15 +00:00
4ff851e5b2
[co19] Roll co19 to 0a9f7daccd0e682ab791f04ecc23f1dbcee04977
...
2024-05-30 sgrekhov22@gmail.com dart-lang/co19#2641 . Add super parameters tests (dart-lang/co19#2687 )
2024-05-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2678 . Add more extension types static vs instance conflict tests (dart-lang/co19#2692 )
2024-05-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2668 . Reorder switch expressions to avoid flow analysis secondary issues (dart-lang/co19#2693 )
2024-05-28 sgrekhov22@gmail.com dart-lang/co19#2641 . Add external functions and covariant parameters tests (dart-lang/co19#2691 )
2024-05-28 sgrekhov22@gmail.com Fixes dart-lang/co19#2689 . Add more extension methods tests (dart-lang/co19#2690 )
2024-05-27 sgrekhov22@gmail.com dart-lang/co19#2641 . Add extension types tests (dart-lang/co19#2688 )
R=brianwilkerson@google.com
Change-Id: Ie5c551e3198e748b55d45ec5039d1ff836444ee2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369000
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-06-03 09:12:56 +00:00
1ff4f72ebc
Mark file system event tests as slow.
...
Restore timeout for windows-arm64, which did not get faster.
Change-Id: I9f032c25fc69454929348f0589d35200a4728142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364625
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2024-04-26 23:46:17 +00:00
f02007839d
[test_runner] Reduce timeouts.
...
We've roughly doubled bot speeds; half timeouts to provide pressure against this simply getting filled with slower tests.
Change-Id: I812da7adc6c08e6d484732c2558e0d3f63b2694a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364385
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-04-26 21:39:34 +00:00
5532568778
[ddc] Add configuration to compile with asserts
...
- Assertions are enabled in the compiler itself. DDC already enables
assertions in the test code by default.
- Runs tests in d8.
Change-Id: Ibdf285d9ab182c3859f4724b4c0740579d6d2377
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349361
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2024-04-04 14:40:30 +00:00
a2b833ede4
[dart2wasm] New async* desugaring
...
See `_lowerAsyncStar` for the desugaring plan.
Fixes tests:
co19/Language/Expressions/Function_Invocation/async_generator_invokation_t04
co19/Language/Expressions/Function_Invocation/async_generator_invokation_t08
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t07
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t04
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t05
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t03
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t07
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t08
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t09
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t11
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t12
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t14
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t15
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t16
language/async_star/async_star_await_for_test
language/async_star/async_star_cancel_test
language/async_star/async_star_test
language/async_star/throw_in_catch_test
language/async_star/yield_test
language/async_star/yieldstar_test
lib/async/async_await_zones_test
Fixes #55025 .
Fixes #55018 .
Fixes #52464 .
Change-Id: I9d51564698710993cb7d2cc64b3bb8c26d6d4c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355360
Commit-Queue: Ömer Ağacan <omersa@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2024-03-05 11:56:00 +00:00
83ba5916b7
[vm] Skip a slow test in aot debug mode ( #21708 )
...
The test LibTest/collection/ListBase/ListBase_class_A01_t02 takes
more than 10 minutes to be precompiled in debug mode, due to
a known issue.
Skipping this test on the CI and CQ because it causes deflaking problems
when timing out. The problem is being tracked already in an issue.
Bug: https://github.com/dart-lang/sdk/issues/54974
Bug: https://github.com/dart-lang/sdk/issues/21708
Change-Id: Ib05e0f18baac684cf3317dbc2171a5a585e04f98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354844
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2024-02-28 15:28:39 +00:00
3c218ecc53
[dart2wasm] Work around V8/Chrome bug that swallows exceptions from rethrows
...
Issue https://g-issues.chromium.org/issues/327155548
Change-Id: I7babc0bcfad3e4351af08ce3accb61db6260d86b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354227
Reviewed-by: Ömer Ağacan <omersa@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2024-02-27 14:00:32 +00:00
511a41a3b9
[dart2wasm] Skip timing out tests that hang test runner
...
Those timing out tests cause CI infra issues (purple bots)
on deflaking.
Issue https://github.com/dart-lang/sdk/issues/55025
Change-Id: Ibdc3766e0e482f180c03acc987c3323a3574647c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354621
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Auto-Submit: Martin Kustermann <kustermann@google.com >
2024-02-27 11:22:51 +00:00
fe4ae77b22
[co19] In AOT mode turn-off tests that uses mirrors
...
`dart:mirrors` is not supported in AOT mode.
Bug: https://github.com/dart-lang/co19/issues/2546
Change-Id: I2b0d42df911c6f185e72239f4786a87c535de535
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353522
Reviewed-by: Siva Annamalai <asiva@google.com >
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-02-23 08:01:59 +00:00
5e83b53f97
[co19] Roll co19 to 867d139b3169fc131488e893ec1133dc98cc3aa0
...
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2496 . Add missing part file (dart-lang/co19#2552 )
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549 . Update built-in identifier tests. Add missing ones. Part 2 (dart-lang/co19#2551 )
2024-02-20 sgrekhov22@gmail.com dart-lang/co19#2549 . Update built-in identifier tests. Add missing ones. Part 1 (dart-lang/co19#2550 )
2024-02-19 sgrekhov22@gmail.com Fix dart-lang/co19#2546 . Add constant context tests (dart-lang/co19#2547 )
2024-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2496 . Fix co19 tests that became failing after test runner update (dart-lang/co19#2497 )
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400 . Add cascade operator test and more constants tests (dart-lang/co19#2545 )
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#2350 . Add more factory constructor tests (dart-lang/co19#2543 )
2024-02-14 sgrekhov22@gmail.com dart-lang/co19#1400 . Add representation variable initialization test (dart-lang/co19#2544 )
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119 . Remove unsupported element from Stream.first/lastWhere tests description (dart-lang/co19#2540 )
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2119 . Remove unsupported element from ReceivePort.first/lastWhere tests description (dart-lang/co19#2541 )
2024-02-13 sgrekhov22@gmail.com dart-lang/co19#2339 . Add more tests for the extension method with the name `type` (dart-lang/co19#2542 )
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2535 . Add patterns constants tests for extension types (dart-lang/co19#2539 )
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2485 . Update`as` and `is` expressions tests with a function type (dart-lang/co19#2538 )
2024-02-12 sgrekhov22@gmail.com Fix dart-lang/co19#2536 . Fix use of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#2537 )
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2119 . Remove unused code, add issues numbers (dart-lang/co19#2534 )
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529 . Fix failing API core tests (dart-lang/co19#2533 )
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529 . Delete API tests with compile-time errors (dart-lang/co19#2531 )
2024-02-09 sgrekhov22@gmail.com dart-lang/co19#2529 . Fix and enable Iterable/forEach_A03_t01 (dart-lang/co19#2532 )
Change-Id: I03e721d3871d5bf2b9773fbf7ebadb2a1804a111
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353260
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-02-21 15:56:27 +00:00
3b52517bca
[test] Add support of dart2wasm.status in co19 tests
...
Fixes : #54971
Change-Id: I033c8ba78e6cdcf26dce9cae8998308a595a37e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353262
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-02-21 14:03:23 +00:00
0dbeb2135e
[test_runner] Rename host-checked to host-asserts
...
Cleanup this old naming scheme before adding new configs for DDC
that run with assertions enabled in the host compiler.
Change-Id: Icbdee694fac46b3a1d5bab7ee7411c8e9be8c4a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335385
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2024-02-08 22:01:09 +00:00
f02b05630a
[co19] Roll co19 to b5126f0bd51ea0819df8d5c362574f951a564940
...
2024-01-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2480 . Fix typos, add issue numbers (dart-lang/co19#2481 )
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2477 . Rename and reorder existing constants tests for match operators before adding new ones (dart-lang/co19#2478 )
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2420 . Add null-check-pattern tests for extension types (dart-lang/co19#2475 )
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119 . Add missing experimental flags (dart-lang/co19#2474 )
2024-01-10 sgrekhov22@gmail.com dart-lang/co19#2119 . Fix typo and improve error messages in Timer tests (dart-lang/co19#2473 )
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2471 . Fix timer constructor tests. Add check for microtasks (dart-lang/co19#2472 )
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2428 . Add `call` member tests for extension types (dart-lang/co19#2438 )
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2449 . Update positions of analyzer expected errors (dart-lang/co19#2450 )
2024-01-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2440 . Add asyncStart/End() to Stream interface tests (dart-lang/co19#2457 )
2024-01-09 sgrekhov22@gmail.com dart-lang/co19#2420 . Add another variable pattern exhaustiveness test (dart-lang/co19#2469 )
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420 . Add constant pattern exhaustiveness tests (dart-lang/co19#2467 )
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2436 . Add expected constant evaluation error for CFE (dart-lang/co19#2470 )
2024-01-08 sgrekhov22@gmail.com dart-lang/co19#2420 . Add null-assert pattern exhaustiveness tests (dart-lang/co19#2468 )
2024-01-05 sgrekhov22@gmail.com dart-lang/co19#2420 . Add parenthesized pattern exhaustiveness tests (dart-lang/co19#2464 )
Change-Id: I86862732cca7c042120bf312403279c2cc10c135
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345960
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2024-01-12 11:23:39 +00:00
8763ece3be
[co19] Roll co19 to ea5e476b3af94f74f6996e4b4319bf03f9248c1c
...
2023-12-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2413 . Add missing expected compile-time errors for CFE (dart-lang/co19#2418 )
2023-12-07 sgrekhov22@gmail.com dart-lang/co19#2119 . Run dart formatter on LibTest/async tests (dart-lang/co19#2417 )
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2398 . Make asyncStart/End() safe in LibTest/async (dart-lang/co19#2416 )
2023-12-06 sgrekhov22@gmail.com Fixes dart-lang/co19#2355 . Add more typed_date.setRange() tests (dart-lang/co19#2412 )
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2404 . Small code-style improvements and description update (dart-lang/co19#2414 )
2023-12-04 sgrekhov22@gmail.com dart-lang/co19#2004 . Add deferred libraries tests according to the changed spec (dart-lang/co19#2411 )
2023-12-04 sgrekhov22@gmail.com Fixes dart-lang/co19#2383 . Add more constant evaluation tests (dart-lang/co19#2396 )
Change-Id: I15e0d681538fa0f2a311f74d1930fad7270b81a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340561
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-12-11 09:55:05 +00:00
096bde2a4d
[cleanup] Remove co19_2 and other references to _2 suites
...
Bug: b/310114753
Cq-Include-Trybots: luci.dart.try:dart2js-hostasserts-linux-unsound-try,ddc-linux-chrome-unsound-try,vm-kernel-linux-debug-x64-try,vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,front-end-linux-release-x64-try
Change-Id: I45ebfda5d746f12ca0fa3c0003c299720f1c7179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337180
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2023-11-22 11:15:57 +00:00
1cba9f344c
[tests] Skip multiple html and co19/html tests.
...
All tests skipped here are flaking or timing out. Most of them fail for
a common reason tracked in
https://github.com/dart-lang/sdk/issues/53985 : Chrome inactive tabs do
not run behave the same as active tabs. This means that interactions like
css transitions, requestAnimationFrame, and video play don't work as
expected.
This CL skips the tests only on Chrome, but continues to run them in
other browsers where the expectation is met. If we can in the future
ensure tests are run on an active tab, we can consider reneabling these
tests. That said, the value of this tests was higher when we mantained
Dartium, but these days we may consider deleting them instead.
Change-Id: I9c0ea230fecca16fa008b64c2cf316ccdd0f53e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335030
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2023-11-10 01:20:39 +00:00
6ef117d65a
[co19] Roll co19 to 6ec024498b3546c775b65cd2d964eb3c6ff0fb2f
...
2023-09-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2289 . Fix roll failures, add issue numbers (dart-lang/co19#2290 )
2023-09-28 sgrekhov22@gmail.com dart-lang/co19#2275 . More `noSuchMethod` tests added. Part 2 (dart-lang/co19#2288 )
2023-09-27 sgrekhov22@gmail.com dart-lang/co19#2275 . Add more noSuchMethod tests. Part 1 (dart-lang/co19#2287 )
2023-09-27 sgrekhov22@gmail.com Fixes dart-lang/co19#2284 . Update `rename()` tests according to the changed documentation (dart-lang/co19#2285 )
2023-09-22 sgrekhov22@gmail.com dart-lang/co19#1400 . Corner cases tests for extension types (dart-lang/co19#2286 )
2023-09-20 sgrekhov22@gmail.com Fixes dart-lang/co19#2253 . Add mixin `on` exhaustiveness tests (dart-lang/co19#2283 )
Change-Id: Id702b84e31869f7770b0edc5c1f2b6309fac0e19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328820
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com >
2023-09-29 13:59:53 +00:00
685af7552d
[ddc] Unskip tests on canary configs
...
Now that the canary configurations are more reliable we can start
running these tests again. They were originally skipped when the
async implementation in the new type system was not working correctly.
The `web/async_stacktrace_test` has actually been timing out in the
stable configs as well. The timeout is consistent and reproducible
locally so I'm filing a new issue and skipping it on all DDC configs
for now.
Fixes: https://github.com/dart-lang/sdk/issues/50666
Issue: https://github.com/dart-lang/sdk/issues/53555
Change-Id: I7306ba66afe595fb213f06c0ad884d376240addc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326721
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2023-09-19 20:59:33 +00:00
95dea183d3
[co19] Roll co19 to 00292501dd4d8b0e246130d55a024727e31d62eb
...
2023-09-15 sgrekhov22@gmail.com dart-lang/co19#1400 . Update error expectations for CFE (dart-lang/co19#2282 )
2023-09-15 sgrekhov22@gmail.com Fixes dart-lang/co19#2147 . Add access to this tests (dart-lang/co19#2280 )
2023-09-15 sgrekhov22@gmail.com dart-lang/co19#2258 . Add missing experimental flag (dart-lang/co19#2281 )
2023-09-14 sgrekhov22@gmail.com dart-lang/co19#2258 . Only private field of an extension type is promotable (dart-lang/co19#2279 )
2023-09-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2261 . Remove obsolete inference-update-2 experimental flag (dart-lang/co19#2278 )
2023-09-14 sgrekhov22@gmail.com dart-lang/co19#2258 . No error ib case of the `noSuchMethod` forwarder of a method (dart-lang/co19#2277 )
2023-09-13 sgrekhov22@gmail.com dart-lang/co19#2258 . Add more private fields promotion tests (dart-lang/co19#2276 )
2023-09-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2265 . Extension types. Add more member conflict tests (dart-lang/co19#2270 )
2023-09-12 sgrekhov22@gmail.com dart-lang/co19#1400 . Add type aliases test (dart-lang/co19#2274 )
2023-09-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2271 . Fix typo in promotion_A01_t01.dart (dart-lang/co19#2272 )
Change-Id: Icc18b7b8e8c7aea103fc255e0da01a5f15601dac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326303
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2023-09-18 08:06:46 +00:00
7e218c4e94
[co19] Roll co19 to 910330408dd6af6b8f58c5d26464dbe0ce76e476
...
2023-08-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2236 . Expect a secondary error for CFE in syntax_A08_t03.dart (dart-lang/co19#2237 )
2023-08-24 sgrekhov22@gmail.com dart-lang/co19#2232 . Fix secondary errors in not_a_constant_in_superclass_t02.dart (dart-lang/co19#2233 )
2023-08-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2230 . Fix roll failures (dart-lang/co19#2231 )
2023-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2228 . Fix syntax error in static_analysis_extension_types_A10_t08.dart (dart-lang/co19#2229 )
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#1400 . Extension types subtyping tests. Resolve name conflict, add missing tests (dart-lang/co19#2227 )
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#1400 . Add tests for external members, covariant parameters, nullable supertypes (dart-lang/co19#2225 )
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#2217 . Add tests for calculating of the least upper bound for extension types (dart-lang/co19#2223 )
2023-08-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2224 . Remove excessive error expectation for CFE (dart-lang/co19#2226 )
2023-08-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2221 . Replace inline classes by extension types (dart-lang/co19#2222 )
2023-08-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2219 . Replace `inline class` by `extension type` in test description (dart-lang/co19#2220 )
2023-08-18 sgrekhov22@gmail.com dart-lang/co19#2142 . Add Subtyping tests for extension types (dart-lang/co19#2215 )
2023-08-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2216 . Add test for extension type abstract members (dart-lang/co19#2218 )
2023-08-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2213 . Fix stack trace comparison (dart-lang/co19#2214 )
Change-Id: I009f43878130f934fc6c2eea3368f9763c94e7a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322660
Reviewed-by: Alexander Thomas <athom@google.com >
2023-08-25 08:55:34 +00:00
3024bfdde2
[test] Skip two dartdevc tests that are timing out
...
Issue is currently open to fix these tests.
Bug: https://github.com/dart-lang/sdk/issues/49622
Change-Id: I22c21437461f7b9bf757e6ed5935b4eeba4f52d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317761
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2023-08-03 11:31:35 +00:00
7f42498d66
[co19] Roll co19 to 7e4ba229fecce1affe8284b166744329182feb3e
...
2023-07-14 sgrekhov22@gmail.com Fixes dart-lang/co19#2132 . Fix roll failures, add issue numbers (dart-lang/co19#2134 )
2023-07-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2130 . Fix roll failures, add issues numbers (dart-lang/co19#2131 )
2023-07-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2125 . Add more external functions tests (dart-lang/co19#2128 )
2023-07-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2087 . Reorder covariance tests to make maintenance easier (dart-lang/co19#2129 )
2023-07-12 sgrekhov22@gmail.com dart-lang/co19#2087 . Add tests for parameters covariant-by-declaration (dart-lang/co19#2121 )
2023-07-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2117 . Update assertions, add tests for external members (dart-lang/co19#2126 )
2023-07-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2123 . Update Superclasses tests. (dart-lang/co19#2124 )
2023-07-11 sgrekhov22@gmail.com dart-lang/co19#2117 . Update accessible_instance_member_t* tests (dart-lang/co19#2122 )
2023-07-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2099 . Add subtyping tests for function type with required named arguments (dart-lang/co19#2100 )
2023-07-10 sgrekhov22@gmail.com dart-lang/co19#2112 . Add missing tests for mixins. Part 2 (dart-lang/co19#2118 )
2023-07-07 sgrekhov22@gmail.com dart-lang/co19#2119 . Minor wording changes (dart-lang/co19#2120 )
Change-Id: I310f2e0a660ac55a242bb9b2ed9a2f1917555d0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313562
Reviewed-by: Alexander Thomas <athom@google.com >
2023-07-14 09:29:50 +00:00
a721944709
[gardening] Add LibTest/core/List/List_all_t02 to skipped slow tests.
...
It's been skirting the Pass/Timeout border for a while now, but has
finally become consistently Timeout.
Issue: https://github.com/dart-lang/sdk/issues/50421
Change-Id: I922fbb55b5a48f57f8071597e8082a12a0883331
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311640
Commit-Queue: Tess Strickland <sstrickl@google.com >
Auto-Submit: Tess Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2023-06-27 14:16:40 +00:00
f469856233
[ddc] Temporarily skip tests that timeout
...
These tests are flaky or timing out on the stable DDC configurations.
This change adds skips for the canary configurations to avoid crashing
the infra when too many tests that timeout are attempted to be
deflaked.
When the canary mode stabilizes we should manually mark all these
tests as flaky if they are still not passing on the stable DDC
configurations.
Issue: https://github.com/dart-lang/sdk/issues/50666
Change-Id: I9b1cb8fe466624480767fea05610331bf0f4ed87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302843
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2023-05-11 23:03:38 +00:00
3d8424e9fc
[test] Introduce status variable $simulator, and fix some cases missing simarm_x64.
...
TEST=ci
Change-Id: Ie2a8ac015b2d316527d648956c86d4c7cb319d26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292962
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2023-04-04 03:10:26 +00:00
de44a23dd1
[test_runner] Cleanup unused compiler names
...
"dartdevc" and "dartdevk" have been replaced with "ddc".
Change-Id: I823bc029a0bbe1295fd731efcc32961e61c6c175
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282485
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-03-07 02:09:16 +00:00
2d3c9f4346
[dart2js, ddc] Skip flaky tests
...
These tests are flipping between Fail, Pass, Flaky at a rate that
is avoiding flake detection. Skipping until we can address the
issues.
Issue: https://github.com/dart-lang/sdk/issues/51086
Issue: https://github.com/dart-lang/sdk/issues/50718
Change-Id: I9a6aa25bdc1573fe1af8783c7ddb389282695540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282810
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2023-02-13 23:44:59 +00:00
87d1806055
[test_runner] Add new name for ddc compiler
...
* The new compiler name "ddc" will be used for all configurations
in an upcoming change.
* Aliases "dartdevc" and "dartdevk" will be removed in the future.
Change-Id: I2fa48e0ec043b1ba7fb70f883b39e40f338b6928
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280862
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2023-02-09 18:32:58 +00:00
5aae8f9688
[dart2wasm] Skip VM-specific co19 Finalizer tests
...
Change-Id: I6ba56c089362bf6c36a7f7cd918862d72cb68991
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280089
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2023-01-31 10:28:36 +00:00
e805b776bc
[dart2wasm] Use status files for defining which tests to run
...
This makes it easier to run tests locally, just specifying the suites
`co19 corelib language lib web` to `test.py`.
It also make it easier to change which tests we run going forward.
Change-Id: I3a4765c18ee105055fdb9a6b59036da11b956e1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279973
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Jackson Gardner <jacksongardner@google.com >
2023-01-30 10:42:22 +00:00
f72f2e92d5
[dart2wasm] Re-enable async tests that no longer time out
...
Issue: https://github.com/dart-lang/sdk/issues/50122
Change-Id: I311c7a709e74381c84cb9c42cceb3d5c9cde4d61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267960
Reviewed-by: Ömer Ağacan <omersa@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2022-12-08 13:43:41 +00:00
f34be9eda4
[gardening] Consolidate skipped Windows tests between co19 and co19_2
...
Issue: https://github.com/dart-lang/sdk/issues/32138
Also updated the issue in the status files.
Change-Id: Icd80055a0dbc1341614bb9f5ce197796e0edf30f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268301
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2022-11-22 09:37:48 +00:00
e4a8525d86
[co19] RawDatargamSocket tests enabled
...
Change-Id: I3ea1e20eaa14f546da333a8841bfa2ef75891bda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263301
Reviewed-by: Alexander Thomas <athom@google.com >
2022-10-11 02:42:00 +00:00
5b119191a5
[test] Add missing architectures when skipping tests using FFI on simulators.
...
Bug: https://github.com/dart-lang/sdk/issues/37299
Change-Id: If4553d20ca13bdc3191cad19a987c875c1c88d73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262849
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2022-10-06 19:24:08 +00:00
88539e58ea
[dart2wasm] Update tracking issue for skipped async tests
...
Change-Id: I163c2125fb69438ff1339e1aa26eb590b8710e83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262426
Commit-Queue: Ömer Ağacan <omersa@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2022-10-04 10:39:49 +00:00
d0d509d4fc
[dart2wasm] Add relevant co19 and lib tests
...
A few co19 tests are marked as skipped for now, as they are hanging
due to https://github.com/dart-lang/sdk/issues/50026
Increase the number of shards to match the increased number of tests.
Change-Id: Ib91127986d13140164c357a22f2d1d9b7b2b7636
Cq-Include-Trybots: luci.dart.try:dart2wasm-linux-x64-d8-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260361
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2022-09-21 16:11:22 +00:00
Sergey G. Grekhov