dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
107,612 Commits 2 Branches 0 Tags
e3e82c95cb3782515e5775bd8da170fd6771a723
Commit Graph

111 Commits

Author SHA1 Message Date
Derek Xu 3dc9d8dcf9 [VM/Service] Add getQueuedMicrotasks RPC 
TEST=pkg/vm_service/test/get_queued_microtasks_rpc_test

CoreLibraryReviewExempt: This CL does not include any core library API
changes, only VM Service implementation changes within
sdk/lib/vmservice/.
Change-Id: Ie5488f498e4d0f3d201e3f31423fd5029b74a726
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425160
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2025-05-13 14:29:37 -07:00
Alexander Thomas 5b1e226fc6 [api.dart.dev] Update incorrect URLs in the Dart SDK sources 
The old site supported api.dart.dev/stable/<page in the latest version>
links. These currently don't work, but the correct link omits the
`/stable/` path component.

Even if we add redirects to make the old URLs work, we still want to
update sources with the canonical URLs.

CoreLibraryReviewExempt: Documentation change only.
Fixes: https://github.com/dart-lang/sdk/issues/57110
Change-Id: I0b20bfa875db5ce62362a02e884d7d43b0efc73e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395961
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
 2024-11-20 09:36:12 +00:00
Ben Konyi 98ddead31c [ package:vm_service ] Don't try to send service extension response after service connection disposal 
Also prepares for 14.3.1 release.

Fixes https://github.com/flutter/flutter/issues/157296

Change-Id: I623102a54ad7ca4481dd5957a7da65dbc5a2e9b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391500
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2024-10-22 17:02:02 +00:00
Danny Tuppeny e099a00ee2 [dds] [vm_service] Add a new RPC error code for "Service Disposed" errors 
This is not currently used for errors but just adds constants to allow clients to write code to handle these kinds of errors so we can use them in future (instead of generic error codes with string messages).

DAP is also updated ready to handle this error code.

See https://github.com/flutter/flutter/issues/153471

Change-Id: I6ad030d0317e9a70d9e28578787edec75554daad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381501
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2024-09-03 14:54:18 +00:00
Derek Xu 354084c62c [package:vm_service] Include stack traces with 'Service connection disposed' RPCErrors 
TEST=pkg/vm_service/test/regress_55559_test.dart

Issue: https://github.com/dart-lang/sdk/issues/56491
Change-Id: I584cbc0827a1a074d28840819cc572beba5f2854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381060
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2024-08-16 16:27:32 +00:00
Parker Lougheed 6c92babf4d [vm_service] Use collection language features in generated code 
This removes the necessity of the `_setIfNotNull` function.

TEST: CI - No behavior change.
Change-Id: I80725bba21a1bda60d35d166723e4bbd55b6e73b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374240
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2024-08-08 20:07:15 +00:00
Ben Konyi bcaf745a9b [ package:vm_service ] Add missing code to code generator 
Was added originally in https://dart-review.googlesource.com/c/sdk/+/367821

Change-Id: I7873e960319c10e995e24b1bb2514ede0c3299d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371360
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2024-06-13 15:03:49 +00:00
Ömer Sinan Ağacan 633e7c4b15 [vm_service] Decode incoming JSON in one step instead of two 
Currently we decode incoming data as a string, then parse the string as
JSON.

We can do it in one step by fusing a `Utf8Decoder` with a `JsonDecoder`,
which will be faster.

A difference between `jsonDecode` and the fused version is that
`jsonDecode` returns `dynamic`, the fused version returns `Object?`.

To keep changes as small as possible we cast the return value of the
fused verison to `dynamic` in this CL.

However using `dynamic` values is often slower than type casting it to
the right type and then using it. So it might make sense to cast it to
something like `Map<String, dynamic>` in a separate CL.

Change-Id: I76de535a72ae5532db5a27e543929519c48c701c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371080
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2024-06-13 11:53:40 +00:00
Ben Konyi a7d8707a59 [ package:vm_service ] Automatically invoke VmService.dispose() when the service connection closes 
Fixes https://github.com/dart-lang/sdk/issues/55559

Change-Id: I213ae3960c15bf2a68b4113a26f333090266b9c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365060
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2024-05-02 16:01:49 +00:00
Ben Konyi 3a62af40b3 [ package:vm_service* ] Prepare for release of package:vm_service 14.2.0 and package:vm_service_interface 1.1.0 
Adds support for 4.15 of the VM service protocol to both packages. Also
adds `yieldControlToDDS` to the `VmServiceInterface` so implementers of
the service protocol can correctly handle DDS connections.

Change-Id: I9253a647c1781f4d52758ecce4984082dfbf4fa0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357720
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Elliott Brooks <elliottbrooks@google.com>
 2024-03-20 13:34:07 +00:00
Daco Harkes f944ef16ab [vm] Fix g3 build 
The file doesn't seem to have field promotion enabled in g3.

Change-Id: I1eafd191064fa24e62f60b7d29bb7468f55cfceb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346460
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2024-01-16 09:48:40 +00:00
Daco Harkes 7ba473f32b [vm] Support Finalizers in the debugger 
TEST=pkg/vm_service/test/get_object_rpc_test.dart

Closes: https://github.com/dart-lang/sdk/issues/54615
Change-Id: I5262d756af63eb5d1677894f6a2e151cd0d65fc1
Cq-Include-Trybots: luci.dart.try:vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-mac-debug-arm64-try,vm-win-debug-x64-try,vm-win-release-ia32-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346403
Reviewed-by: Ben Konyi <bkonyi@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2024-01-15 23:14:56 +00:00
Jonas Termansen ffdb0a2e19 [vm_service] Bump vm_service language version to 3.2. 
Remove older version tags in vm_service and clean up old experiments.

Bug: b/318347018
Change-Id: I6bf87e46878d57d05d7f9d64674ce0c573364d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345302
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2024-01-10 12:06:57 +00:00
Parker Lougheed ba78c6604c [vm_service] Update generator to unignore use_super_parameters lint 
Fixes https://github.com/dart-lang/sdk/issues/53601

Bug: 53601
Change-Id: Iae5b2c0e0cf24ab58866ec5169e10282402a61da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340161
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
 2023-12-07 20:31:11 +00:00
Ömer Sinan Ağacan 8058ad681b [VM/Service] Avoid copying incoming byte arrays 
In devtools, `VmService` is passed a stream from the
`web_socket_channel` library, which writes `Uint8List` values to the
stream. In these cases we don't need to copy the messages.

Change-Id: Iade3897370fb11b31e8f2894d64554b8b7e7d141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339123
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-11-30 19:27:48 +00:00
Ben Konyi aa2637ebd9 [ package:vm_service ] Migrate Observatory service tests (o* - r*) 
Also:
 - added some missing RPC error kinds to `RPCErrorKind`
 - started making use of `update_line_numbers.dart` to automatically fix
   line numbers in service tests. Will go back through the existing
   tests to update them to use this script in a future CL.
Change-Id: I99a443ca59429eec829e5f289c0f396562cde89b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333980
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-11-08 16:42:44 +00:00
Ben Konyi fa6253ec11 [ package:vm_service ] Cleanup for 13.0.0 release 
This change includes:
 - Removal of deprecated methods and constants
 - Removal of dependency on package:expect for testing, instead copying
   over the minimal amount of functionality needed for testing from
   package:expect into pkg/vm_service/test/common/expect.dart
 - Removal of classes and interfaces that are now found in
   package:vm_service_interface
Change-Id: I21c2d228e615f97e64dd98b6512bf2e533916454
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331760
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-25 14:02:42 +00:00
Ben Konyi 08b4f49249 Split package:vm_service into package:vm_service and package:vm_service_interface 
To reduce the headache associated with adding parameters to VM service
APIs, VmServiceInterface has been removed from package:vm_service and
pulled into its own dedicated package:vm_service_interface. This will
help reduce the need for major version bumps of package:vm_service,
which requires manual version bumps through >8 packages in order to make
the latest version available to flutter_tools and DevTools.

This separation of the VmService client from the interface will reduce
the frequency of major version bumps to `package:vm_service` as adding
optional parameters to existing APIs would cause implementers of the
interface to break.

package:vm_service continues to expose a copy of the contents of package:vm_service_interface to avoid breaking google3 rolls until package:dwds can migrate to package:vm_service_interface. package:vm_service will not be published until this copy is removed.

This change also includes:
 - some code cleanup and modernization to both the code generator and
   generated code
 - >=3.0.0 SDK version requirement to allow for new language features

Change-Id: Ib1859c1b4e153fef7ee1f91e67e881bbf42652c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330500
Reviewed-by: Derek Xu <derekx@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-23 17:00:10 +00:00
Ben Konyi b68f533639 [ package:vm_service ] Additional Observatory test migrations 
Also bumped minimum SDK requirement to 3.0.0 to make use of new language
features.

Work towards https://github.com/dart-lang/sdk/issues/45037

Change-Id: I3543dd902a69f9490087f1f263aeb2dabb488fa0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/326841
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-10-16 15:23:47 +00:00
Kenzie Schmoll a489f8a621 Add wrapFuture VmService endpoint that can be overridden to add additional logic to each VM service RPC call, like logging or tracking values. 
This CL also adds:
1. a method `vmServiceConnectUriWithCreator` helper alongside the existing `vmServiceConnectUri` helper. This method can create a generic `VmService` instance with the same logic as the existing `vmServiceConnectUri` helper. This was implemented this way so that it is not a breaking change to the existing helper.
2. a typedef `VmServiceCreator` for use in the `vmServiceConnectUriWithCreator` method and for shared use in packages that depend on `package:vm_service` (e.g. the DevTools packages)
3. a static method `VmService.defaultCreator` that provides a `VmServiceCreator` method for the `VmService` class.

The DevTools changes that are paired with this change are here: https://github.com/flutter/devtools/pull/6508.

Change-Id: I72d22e7d93d5aeba628bef630ae168eb7477ca6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329820
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2023-10-12 18:36:52 +00:00
Devon Carew e2fe203adc [deps] roll package:lints to the latest 
Change-Id: I582f956cd4b712203c2f6dd630b4e1384040446d
Tested: analysis clean (this is a lint only related change)
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329400
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2023-10-05 03:36:59 +00:00
Devon Carew 3b0b1bd863 Bump package:lints to the latest; address instances of new lints. 
Changes:
```
> git log --format="%C(auto) %h %s" 8d5f750..b044aca
 https://dart.googlesource.com/lints.git/+/b044aca add several rules to core and recommended (150)
 https://dart.googlesource.com/lints.git/+/81100a2 fix a dangling table link (146)
```

Diff: https://dart.googlesource.com/lints.git/+/8d5f7500024320654adb1e799e49fc10c5304ae7..b044acab9f6669b3d8e781923a8ff86877801177/
Change-Id: I031333ade99af700a7009b14a36d3aadba12fc94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327321
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2023-09-25 21:15:15 +00:00
Ben Konyi 0f39236144 [ package:vm_service ] Add wsUri property to VmService 
The `wsUri` property can be used to identify the target VM service that
a `VmService` instance is connected to.

Change-Id: Ic2ba4674e7b247f808d399aeb64d246a5c791a93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322540
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-08-24 20:23:14 +00:00
Derek Xu 17d59bf657 [package:vm_service] Update generator to always include required parent class fields in constructors 
Change-Id: I3c37668788721735fac58c28e3b9ad15ef364fbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317980
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-08-03 15:54:36 +00:00
Derek Xu ce5210bac9 [package:vm_service] Make generator generate abstract classes for enums in service.md 
Change-Id: Idd7542daadcecdd8f71eebafdae3a8e7eecb7e9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313641
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-07-17 15:01:21 +00:00
Elliott Brooks 70af4a9db0 Add constructor to RPCErrorKind enum 
Follow up to https://dart-review.googlesource.com/c/sdk/+/307970

Learned from Kenzie this was possible :) https://github.com/flutter/devtools/pull/5917#discussion_r1231368050

Bug: https://github.com/dart-lang/sdk/issues/52636
Change-Id: Ic244765a6258c000c4171ece35273609c7ee5929
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309831
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-06-20 18:33:50 +00:00
Elliott Brooks 66ded0cdd9 Copy rpc error codes from dds to vm_service 
Bug: https://github.com/dart-lang/sdk/issues/52636
Change-Id: Icdf66a3499562a2aba50e7f27879497a7b34ab98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307970
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
 2023-06-09 18:13:18 +00:00
Derek Xu 1a519f6c8c Revert "[ package:vm_service ] Add type check to VmServiceConnection to make runtime failures debuggable" 
This reverts commit 23661e431f.

Reason for revert: broke google3

Original change's description:
> [ package:vm_service ] Add type check to VmServiceConnection to make runtime failures debuggable
>
> Fixes https://github.com/dart-lang/sdk/issues/49590
>
> Change-Id: I09c83ce34db06326459f18a51ae05a38c6459250
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293480
> Reviewed-by: Derek Xu <derekx@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

Change-Id: I2a4e0ff84f67dfb4cbb8983c75129752db4c36d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293760
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-04-05 16:51:17 +00:00
Ben Konyi 23661e431f [ package:vm_service ] Add type check to VmServiceConnection to make runtime failures debuggable 
Fixes https://github.com/dart-lang/sdk/issues/49590

Change-Id: I09c83ce34db06326459f18a51ae05a38c6459250
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293480
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2023-04-05 15:56:11 +00:00
Derek Xu d7a26dc078 [VM/Service] Prevent VmServerConnection from converting SentinelExceptions into RPCErrors 
TEST=CI, ran `flutter run -d chrome --debug` with the changes in this CL
applied to the vm_service directory in the pub cache and ensured that
this if-statement was entered
https://github.com/flutter/flutter/blob/8679aeb2353933c329463808aefcf086157fce6c/packages/flutter_tools/lib/src/vmservice.dart#L1020-L1024

Fixes: https://github.com/dart-lang/sdk/issues/51752
Change-Id: I2cec21bbb065b697fa34bd37c80b38f5eb9f493f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-03-20 20:03:48 +00:00
Derek Xu 9a6c8ed50b [VM/Service] Fix accessors of fields of simple types in generated Java classes 
TEST=Modified VmServiceTest.java locally to make it exercise
BoundField.getName()

Fixes https://github.com/dart-lang/sdk/issues/51514
Change-Id: I232d98a2efffbaf82a0101a20405f48fe4ba03d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285700
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-02-27 16:51:26 +00:00
Derek Xu ad632cc8eb [VM/Service] Fix accessors of fields of simple types in generated Java classes 
TEST=ran `ant test` target

Fixes https://github.com/dart-lang/sdk/issues/51448
Change-Id: I7099c1662b30378c6895f1f0e8f702f678aba884
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284720
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-02-22 17:11:41 +00:00
Kevin Moore fd836d3b34 vm_service: fix a bunch of comment references 
also fix a couple of typos in service.md

TEST=re-ran generate script

Change-Id: I6fb6dbbc3780af14e5721817e20ec0e6370bfc1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284440
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-02-22 16:32:28 +00:00
Devon Carew 5a53de5b14 [pkg/vm_service] use package:lints/recommended.yaml 
Change-Id: Icf2b33ed47c5006c72bb4809fca230845cf51908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282383
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2023-02-10 17:59:33 +00:00
Derek Xu 5cc3c3b96a [VM/Service] Reduce number of generated is checks in package:vm_service 
TEST=CI, manual testing

Change-Id: I4865ab71714f1b4bc7af55ed485cccc970e11989
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281540
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2023-02-08 19:12:12 +00:00
Derek Xu c25308d003 [VM/Service] Fix generation of toJson() calls on dynamic variables 
TEST=CI, manual testing

Issue: https://github.com/dart-lang/sdk/issues/51188
Issue: https://github.com/dart-lang/sdk/issues/51100
Fixes https://github.com/dart-lang/sdk/issues/51100
Change-Id: I4b7122df2e24534ed919aa0665dcf2a777c5deed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281463
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-02-07 21:28:36 +00:00
Derek Xu f971bb30c4 [VM/Service] Fix generation of code for serializing objects with multiple simple types 
Fixes https://github.com/dart-lang/sdk/issues/51141

Change-Id: I1b9503bb76781779f29b7125082a9d9ac370a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280040
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2023-02-01 22:04:29 +00:00
Derek Xu dba1e5fd3f [VM/Service] Fix package generator 
package:markdown was updated to follow CommonMark's rules for encoding
certain special characters as HTMLEntities.
See https://github.com/chenzhiguang/fork-markdown/blob/43bafebbe8534ed3b6e732b5bbf6f427202d6828/lib/src/util.dart#L15

This CL updates the package:vm_service generators to handle these
changes.

Change-Id: I4e2e4c1c800a44ff1f3b9e7e163d60876cd6b013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272522
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
 2022-11-30 16:25:57 +00:00
Devon Carew 8e0f4f4191 [pkg/vm_service] turn on a few more lints for this package 
Change-Id: I8eef00c606e713e252db8834f730f1655cdd57a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259509
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-19 17:02:14 +00:00
Liam Appelbe fcc759b302 [ VM / Service ] Use same default value logic in toJson as _fromJson 
Bug: https://github.com/dart-lang/webdev/issues/1741
Change-Id: I86df5591c3b302e88f76a2f7031215df18bb1431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258100
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2022-09-08 16:16:43 +00:00
Anis Alibegić 40e18905f2 Fixed various typos in a lot of files 
Closes https://github.com/dart-lang/sdk/pull/49478

TEST=Manual

GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-07-25 12:21:59 +00:00
Liam Appelbe 844a9f3808 Reland "[ VM / Service ] Add abstract flag to Function" 
This reverts commit 9b02bdaa76.

With https://dart-review.googlesource.com/c/sdk/+/251443 this is a
non-breaking change.

Bug: https://github.com/dart-lang/coverage/pull/412
Change-Id: Iaa8a74ab8065380d2a7e8a8fc07fec3a4518d979
TEST=Added to get_object_rpc_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251480
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-15 18:30:20 +00:00
Liam Appelbe df2b0426df [ VM / Service ] Remove required from constructor params 
The required keyword means that adding a field to a class is a breaking
change, and needs a major version bump instead of a minor one. All the
fields are already nullable, and the constructors all use named
parameters, so removing this keyword is a minor (non-breaking) change.

Bug: https://github.com/dart-lang/coverage/pull/412
Bug: https://buganizer.corp.google.com/issues/236964692
Change-Id: I410d0f4359c003696570dfb11e3e2f7f179fb9ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251443
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-13 19:35:23 +00:00
Alexander Aprelev 9b02bdaa76 Revert "Reland "[ VM / Service ] Add abstract flag to Function"" 
This reverts commit aa2e19827f.

Reason for revert: broken g3 bot

Original change's description:
> Reland "[ VM / Service ] Add abstract flag to Function"
>
> This reverts commit 6c542eca22.
>
> Switched vm_service from a minor version bump to a major one.
> See: https://buganizer.corp.google.com/issues/236964692#comment4
>
> Bug: https://github.com/dart-lang/coverage/issues/398
> Change-Id: I85f88d4a1cdcb878cbf77da283041458381e2a2b
> TEST=Added to get_object_rpc_test.dart
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250772
> Commit-Queue: Liam Appelbe <liama@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=bkonyi@google.com,asiva@google.com,liama@google.com

Change-Id: I6fbedfb146ee2157baf49162acd0c943402b6cbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/coverage/issues/398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250787
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-07-07 02:39:11 +00:00
Liam Appelbe aa2e19827f Reland "[ VM / Service ] Add abstract flag to Function" 
This reverts commit 6c542eca22.

Switched vm_service from a minor version bump to a major one.
See: https://buganizer.corp.google.com/issues/236964692#comment4

Bug: https://github.com/dart-lang/coverage/issues/398
Change-Id: I85f88d4a1cdcb878cbf77da283041458381e2a2b
TEST=Added to get_object_rpc_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250772
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-07-06 22:32:22 +00:00
Emmanuel Pellereau 6c542eca22 Revert "[ VM / Service ] Add abstract flag to Function" 
This reverts commit 921476edf3.

Reason for revert: breaks google3 (b/236964692).

Original change's description:
> [ VM / Service ] Add abstract flag to Function
>
> Bug: https://github.com/dart-lang/coverage/issues/398
> Change-Id: I1f6e16483e28fb7a77aebae079fd62abe9d16099
> TEST=Added to get_object_rpc_test.dart
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249421
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=bkonyi@google.com,liama@google.com

Change-Id: I1733080dadd6f283766dddbdbe1390d821f91f64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/coverage/issues/398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249680
Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
 2022-06-24 07:35:29 +00:00
Liam Appelbe 921476edf3 [ VM / Service ] Add abstract flag to Function 
Bug: https://github.com/dart-lang/coverage/issues/398
Change-Id: I1f6e16483e28fb7a77aebae079fd62abe9d16099
TEST=Added to get_object_rpc_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249421
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2022-06-23 15:46:05 +00:00
Ben Konyi f22f4a3924 [ package:vm_service ] Update UriList.uris from List<dynamic> to List<String?> 
Fixes https://github.com/dart-lang/sdk/issues/48521

Change-Id: I0028d918de4ff015f5d1a28acec6d6eed9e5ba83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236281
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-09 21:23:14 +00:00
Ben Konyi 0452019d43 [ package:vm_service ] Remove unused generated vm_service_assert.dart 
Change-Id: Id9bf0c1f8919e1f2499222d2fde54eef241a4068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236280
Reviewed-by: Devon Carew <devoncarew@google.com>
 2022-03-09 17:13:56 +00:00
Helin Shiah ba50128769 Add script location to generated code message 
The previous message added to Java generated code was not helpful for finding the generating code.

TEST=N/A

Change-Id: Ie60202ac68e8790a422a47c6edfd75997cf32145
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232024
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-08 19:44:40 +00:00