This CL implements `Finalizable` by means of a CFE transform.
The transform is implemented in the existing FFI transform to avoid the
overhead of traversing the AST an extra time. The FFI transform slows
down ~15-30% on Flutter Gallery. For more info see the design doc.
TEST=`dart pkg/vm/test/transformations/ffi_test.dart`
Design doc: go/dart-vm-finalizable
Bug: https://github.com/dart-lang/sdk/issues/47777
Change-Id: I0bf9dead90a61631b7f215dc19fbaa9e40e63c8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227501
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This reverts commit c2a32fe534.
Reason for revert: Reverting because enabling these lints without doing a cleanup breaks some peoples workflow. We'll discuss which path to take forward, and enable them again later.
Original change's description:
> [cfe/vm] Enable prefer_final lints in pkg/vm
>
> As discussed by email, this adds the prefer_final_* lints to pkg/vm.
>
> Adding the lints is a practical step forward, even though we do not enforce them with a presubmit check at this time.
> Next steps including cleaning up lint violations and adding a presubmit check.
>
> Change-Id: I50c421ad06114b1ae4a5da422b375fd28d7150d6
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118542
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
TBR=johnniwinther@google.com,dacoharkes@google.com
Change-Id: I9dd908a0a594f9c23279ba3f5380382c239f5c2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118583
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
As discussed by email, this adds the prefer_final_* lints to pkg/vm.
Adding the lints is a practical step forward, even though we do not enforce them with a presubmit check at this time.
Next steps including cleaning up lint violations and adding a presubmit check.
Change-Id: I50c421ad06114b1ae4a5da422b375fd28d7150d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
* kernel-service.dart is moved to pkg/vm/bin and renamed to
kernel_service.dart
* LICENSE, pubspec.yaml and analysis_options.yaml added to pkg/vm.
* Kernel isolate name is corrected to be independent of URI passed
in --dfe VM option.
Change-Id: I5b7b860297314e240e557af80913e7ac3e6324ad
Reviewed-on: https://dart-review.googlesource.com/21260
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Devon Carew