07680e9603
Add --disable-cors flag to DevTools server.
...
Required to fix https://github.com/flutter/devtools/issues/9176 .
Change-Id: I6648a797a6ff4c22073ab49af5d584d2df52036a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429064
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
2025-05-16 14:53:13 -07:00
3dc9d8dcf9
[VM/Service] Add getQueuedMicrotasks RPC
...
TEST=pkg/vm_service/test/get_queued_microtasks_rpc_test
CoreLibraryReviewExempt: This CL does not include any core library API
changes, only VM Service implementation changes within
sdk/lib/vmservice/.
Change-Id: Ie5488f498e4d0f3d201e3f31423fd5029b74a726
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425160
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2025-05-13 14:29:37 -07:00
8360666390
Update DevTools rev to 21132242f6e12b26e3d9c0f06109361f7e519608
...
Note: `Handler` was removed from `devtools_server` in https://github.com/flutter/devtools/pull/9170
Change-Id: Ic29658a1caece780a72125ca8ed040bbdc2405e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426540
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Elliott Brooks <elliottbrooks@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
2025-05-05 12:40:22 -07:00
90a5e71787
Lint. unnecessary_this. Report for this.foo() of the same class.
...
Change-Id: I55fe9d08fd8d9985f992c7b2cda6376efb8386be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421421
Reviewed-by: Derek Xu <derekx@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-04-16 12:57:12 -07:00
049ca4100f
[DDS] Start caching events sent on the 'Timer' stream
...
TEST=pkg/dds/test/timer_event_history_test
Change-Id: Id1b867e5f582aca9d57c6d52978880bbbd889b27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411160
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2025-04-14 13:04:28 -07:00
aad32ab70b
[dds/dap] Improve display of Sets in debug views
...
- Show "Set (x items)" to match lists and maps
- Compute an evaluation name as "x.elementAt(y)" since "x[y]" isn't valid for sets
Fixes https://github.com/dart-lang/sdk/issues/60488
Change-Id: Ifb9df6e1d7cf91e2e25a421565d4c5fbb75ca0fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420704
Reviewed-by: Derek Xu <derekx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2025-04-08 08:10:59 -07:00
29c350dfe9
[dds/dap] Ensure DAP always sends resume on PausePostRequest
...
The change at https://dart-review.googlesource.com/c/sdk/+/410760 to fix a race incorrectly assumed that once we had handled startup for a thread, we would never need to send an automatic resume again. However this was not the case - after a hot reload, we need to resume the thread even though we had technically already handled startup.
This is essentially a partial revert of 84e6ed0784https://dart-review.googlesource.com/c/sdk/+/416580
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2025-03-19 07:32:19 -07:00
3c973fb292
[lints] address diagnostics related to strict_top_level_inference
...
Change-Id: I228058202855900f0adba73c1ab04d35180a6e5d
Tested: this is an analyzer diagnostic only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414900
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Nate Biggs <natebiggs@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2025-03-17 08:27:57 -07:00
ca3cea291c
Bump language version for pkg/dds_*
...
Extracted from https://dart-review.googlesource.com/c/sdk/+/397164
Which migrates the sdk to resolve as a pub workspace
Pub workspaces requires a language version of 3.5.
Change-Id: I74abaac7dec6b88bc0453ef799748c4cbc3026e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412084
Auto-Submit: Sigurd Meldgaard <sigurdm@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com >
2025-02-27 07:00:27 -08:00
1e148e651b
Fix issue that was found with the flutter rolls (unable to locate
...
the dds snapshot)
Reland "[SDK] Switch dds and dtd to use an AOT snapshot"
This reverts commit 11ab2dfe2f6450d76f1fhttps://dart-review.googlesource.com/c/sdk/+/387133
> > Reviewed-by: Ben Konyi <bkonyi@google.com >
> > Commit-Queue: Siva Annamalai <asiva@google.com >
>
> Change-Id: I9985919063cacfc8673b3e2946eaa163e90c9cc3
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411200
> Auto-Submit: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Siva Annamalai <asiva@google.com >
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Siva Annamalai <asiva@google.com >
Change-Id: I5ec8e58f905b4ad1d22d507acd8e22e676dc5532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410921
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Brian Quinlan <bquinlan@google.com >
2025-02-25 14:32:41 -08:00
11ab2dfe2f
Revert "[SDK] Switch dds and dtd to use an AOT snapshot"
...
This reverts commit 6450d76f1fhttps://dart-review.googlesource.com/c/sdk/+/387133
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Siva Annamalai <asiva@google.com >
Change-Id: I9985919063cacfc8673b3e2946eaa163e90c9cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411200
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2025-02-20 15:17:16 -08:00
7ec6bdc336
[dds/dap] Provide reason/message for unverified breakpoints
...
This adds some additional information to breakpoint response/events so that in VS Code a grey breakpoint has a tooltip that explains the reason.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5314
Change-Id: I1defdbc9b62b8536b81efbe3f01626e6faf8db50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409280
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2025-02-20 09:37:29 -08:00
84e6ed0784
[dds/dap] Fix a race in DAP startup code that caused flaky tests
...
We start isolates paused so that we can send breakpoints before any code runs. This means we need to resume after initialization is complete.
It's important we don't try to resume multiple times during initialization (regardless of the order of isolate events or whether the isolate was found when we queried for isolates during connection).. This is done with the flag `startupHandled`.
One code path was not taking this flag into account, which meant multiple resumes were still possible. This seemed to occur on Linux during test runs (I've noticed the order of events being different on Linux in the past).
This change extracts the checking of `startupHandled` before sending `readyToResume` and uses it in all places that handle this kind of startup resume.
Fixes https://github.com/dart-lang/sdk/issues/60128
Change-Id: Ie2679fc806ab3edf007259298da82dbc8b802a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410760
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2025-02-19 08:23:28 -08:00
6450d76f1f
[SDK] Switch dds and dtd to use an AOT snapshot
...
TEST=ci
Change-Id: Ib65ca1d1a05d3bc7b5f5cab25d90fc459ec8d853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387133
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2025-02-13 09:11:38 -08:00
217bfed9bd
[ DDS ] Add middleware that converts exceptions thrown by handlers into error responses
...
Handler functions may return a Future<Response> that completes with an error. If that happens, then the top level error handling in the Shelf server will try to log the error to stderr.
But this will fail because DDS closes its stderr at startup. So Shelf will not write any response to the client, and the client will time out.
This PR adds a middleware to the DDS pipeline that receives errors thrown by the pipeline's handlers and returns a failure response.
Change-Id: I31beaf6abb0cbb42137c6b03f6081809de5d7119
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405681
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2025-01-28 10:10:57 -08:00
9b7bb9df90
Fix "the the" typo
...
Closes https://github.com/dart-lang/sdk/pull/59926
GitOrigin-RevId: cb37bca473b0c177b876a0f4e75858cd1862e699
Change-Id: I6827241b22e99db455945afcdfbaee0450999ce9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404923
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2025-01-21 14:08:20 -08:00
131fe7b525
[dds/dap] Extract URIs from stack traces with regex instead of package_stack_trace
...
package:stack_trace only parses stack traces in very specific formats and this has caused us to miss some in the past. https://github.com/Dart-Code/Dart-Code/issues/5360 reports that this is also the case when there is any prefix (including `flutter:`) in the output.
Rather than trying to clean up the input to pass to package:stack_trace, this just uses a simple regex to extract the URIs (and optional line/cols) from the line instead.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5360
Change-Id: I13192fb201499f6cee6e28e7aa86d882557c0232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400380
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2025-01-06 09:19:24 -08:00
acf43c7587
[dds] Build DevTools URL using querystring, not fragment
...
DevTools now uses page URLs so we don't need to put the querystring as a fragment. The original code did work, but it complicates things for other code (such as code injecting `?wasm=true`) so should be updated.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5365
Change-Id: I80ff4d78a3df1f77740a9b8f61ef5499bd008eda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399681
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-12-19 12:54:42 -08:00
0a71249650
Add support for connecting a debug version of DevTools to the DevTools server.
...
Requires https://github.com/flutter/devtools/pull/8621 .
Bug: https://github.com/flutter/devtools/issues/6486
Change-Id: I57b6a6d1551831d89cc7d007376291e8cffd920e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366421
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
2024-12-13 09:14:55 -08:00
abb17bc59d
[dds] update dds and dtd to be forward compatible with an upcoming release of package:shelf_web_socket
...
Change-Id: I7bcbacaad44358759d8856b0bcf0b99120e79e89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398584
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-12-03 20:41:53 +00:00
a990da0992
[dds/dap] Set supportsANSIStyling=true in DAP server capabilities
...
This is the proper fix for https://github.com/Dart-Code/Dart-Code/issues/5302 , which is to advertise to clients that we may use ansi color codes in output events.
It requires increasing the DAP constraint because this field was added to the DAP package in 1.4.0 and we need to ensure anyone (like Flutter) building on top of this base debug adapter has a matching version.
Change-Id: Ie595cda91389f1c7f031a657c96e9f7480b00933
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397521
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-11-26 15:56:30 +00:00
3fe58da3cf
[ DDS ] Fix race condition in Mutex
...
The lock was being released but not reacquired when the next request
resumed, potentially leading to a race.
Change-Id: Ib00ae40ca8c1dfff6b98bbf642032c57d498fa40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394760
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Jessy Yameogo <yjessy@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2024-11-12 20:50:21 +00:00
74d84f397e
[dds/dap] Ensure 'allThreadsContinued' is always explicitly set on ContinuedEvents
...
+ same for allThreadsStopped, just in case!
Fixes https://github.com/Dart-Code/Dart-Code/issues/5252
May fix https://github.com/dart-lang/sdk/issues/56367
Change-Id: I01ad062d0723301ab59f46a6052162ec1931a8c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394301
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2024-11-12 15:56:00 +00:00
d131404ddd
[DAP] Normalize Directory.current in DAP before launching the process
...
We normalize paths to have uppercase drive letters in many places in DAP to avoid mismatches of things like breakpoint paths if the client sends mixed casing.
It's not clear why the change to not host DDS internally affected this, but it seems sensible to perform this normalization here because we're normalizing everywhere else and right now the paths are treated as case-sensitive in many places.
Fixes https://github.com/dart-lang/sdk/issues/56965
Fixes https://github.com/dart-lang/sdk/issues/57011
Change-Id: Ie63ef66058ff9d37955659a780f7bd40cdfc2dc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392442
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2024-11-11 20:19:55 +00:00
5b9d75ff20
[dds/dap] Use ID Zones for evaluation requests and invalidate them on resume
...
Fixes https://github.com/dart-lang/sdk/issues/56794
Change-Id: Ied408503d22c4abb2c4f996f6c9b7847b8ad82be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389960
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-10-30 18:41:13 +00:00
97ab888201
Remove spawning of DDS from DAP and let the spawned dart run/dart test do it
...
Fixes https://github.com/dart-lang/sdk/issues/56733
Change-Id: I23acd9ba4cd48dd7fe5e23fc388d143db8779754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386500
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2024-10-24 20:44:34 +00:00
da9d9f254b
Reland "[DDS] Make runDartDevelopmentServiceFromCLI use IPv6 to serve DDS if either the VM Service address or the bind address cannot be resolved to an IPv4 address"
...
This is a reland of commit 4391ca6643https://github.com/dart-lang/sdk/issues/56557
> Change-Id: Id06532aedf26d8d5e4d037df72dece2d6550e694
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389521
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Derek Xu <derekx@google.com >
Change-Id: Ib7536f61d49526e67d449ca0a475f379ad4bd362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390760
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-10-18 14:38:07 +00:00
cec29f1306
Revert "[DDS] Make runDartDevelopmentServiceFromCLI use IPv6 to serve DDS if either the VM Service address or the bind address cannot be resolved to an IPv4 address"
...
This reverts commit 4391ca6643https://github.com/dart-lang/sdk/issues/56557
> Change-Id: Id06532aedf26d8d5e4d037df72dece2d6550e694
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389521
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Derek Xu <derekx@google.com >
Change-Id: I02709235d32abab122b5269a5d80f12c4085988b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390542
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2024-10-16 22:15:28 +00:00
4391ca6643
[DDS] Make runDartDevelopmentServiceFromCLI use IPv6 to serve DDS if either the VM Service address or the bind address cannot be resolved to an IPv4 address
...
TEST=CI
Fixes: https://github.com/dart-lang/sdk/issues/56557
Change-Id: Id06532aedf26d8d5e4d037df72dece2d6550e694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389521
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2024-10-10 19:22:50 +00:00
bfbbe5c6b6
[VM/Service] Delete all the Service ID zones created by a client when it disconnects
...
TEST=pkg/vm_service/test/id_zone_deletion_on_client_disconnect_with_dds_test.dart,
pkg/vm_service/test/id_zone_deletion_on_client_disconnect_without_dds_test.dart,
CI
Issue: https://github.com/dart-lang/sdk/issues/55869
CoreLibraryReviewExempt: This CL does not include any core library API
changes, only VM Service implementation changes in
sdk/lib/vmservice/client.dart and
sdk/lib/vmservice/running_isolates.dart.
Change-Id: I32a72ade89b858519c61b5124adbeafb835c3d61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381520
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2024-10-02 15:46:31 +00:00
c4a77dce65
[DDS] Make runDartDevelopmentServiceFromCLI pass the specified bind address directly into startDartDevelopmentService
...
Resolving the bind addres before passing it into startDartDevelopmentService was causing some problems with debugging web applications in g3.
TEST=patched these changes into g3 and confirmed that they restore the ability to debug the hello_flutter sample
Change-Id: I2e10be1e2e73245e00d2c3936697b736029a7d47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387280
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2024-10-01 14:32:29 +00:00
2cf6ba2d55
[dds/dap] Handle VM Service shutdown exceptions when resuming
...
This will hopefully fix the flaky tests noted in https://github.com/dart-lang/sdk/issues/55313 . I believe when we resume from pause-on-exit, the VM might shut down fast enough that the response is not handled and throws "Service connection disposed" (see https://github.com/dart-lang/sdk/issues/55313#issuecomment-2376593906 ).
This change will discard any known shutdown errors while sending the request instead.
Change-Id: I7c10aa3eddd6e651114ddba948b0a17688352720
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386806
Reviewed-by: Helin Shiah <helinx@google.com >
Commit-Queue: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-09-26 15:56:42 +00:00
560adc7dc6
[dds/devtools] Switch to always using a relative base href in DevTools pages
...
This avoids the server needing to know the exact URL path being used on the client, so proxies that rewrite the path (such as code-server) can still work.
See https://github.com/flutter/devtools/issues/8067#issuecomment-2236419703
Change-Id: I5b131d84232c63f5495ccbb533da727cce514de5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376682
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-09-26 15:19:54 +00:00
6121c396ee
[VM/Service] Expose Service ID zone APIs in service.md and package:vm_service
...
TEST=pkg/vm_service/test/id_zones_test.dart, CI
Issue: https://github.com/dart-lang/sdk/issues/55869
CoreLibraryReviewExempt: This CL does not include any core library API
changes, only VM Service implementation changes in
sdk/lib/vmservice/running_isolates.dart.
Change-Id: Id63180fd08a88865064435b056fa3269835cd476
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381400
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
2024-09-25 17:28:44 +00:00
2483d300f9
Change the type of google3WorkspaceRoot to String.
...
This is a followup to https://dart-review.googlesource.com/c/sdk/+/383901
Remove the temporary backward compatibility now that users of this
function has all been migrated.
Bug: b/364942683
Change-Id: I8f951c6eb143497fb9edbf1465417d121a1cbf72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384827
Auto-Submit: Chingjun Lau <chingjun@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-09-13 14:27:11 +00:00
a5cd16c0cb
[ DDS ] Fix failing tests
...
Fixes failing tests introduced by
https://dart-review.googlesource.com/c/sdk/+/383780 .
Change-Id: I700543f4dc6481dd905ffdc44177b009612565d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384880
Auto-Submit: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2024-09-11 21:43:08 +00:00
f50975e3b5
[dds] Bump DDS to 5.0.0, use devtools_shared 11.0.0, and support a second DTD URI for web editors
...
devtools_shared 11.0.0 updates some signatures to use a new DTDInfo class to support both a local + exposed URI for DTD. A new CLI flag `--dtd-exposed-uri` for `devtools server` allows passing this second URI.
The DevTools server will use `--dtd-uri` to connect to DTD itself, but serve `--dtd-exposed-uri` to the frontend.
`--dtd-exposed-uri` is entirely optional and if not supplied, the value from `--dtd-uri` will be used in its place.
Change-Id: I5ab052ff9c4e7b2b186c1592f1ba2d63b7711113
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383400
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
2024-09-11 17:05:09 +00:00
1850fbbb3a
Change the type of google3WorkspaceRoot to Uri | String.
...
A subsequent CL will be sent to change this to String, after
flutter_tools is migrated to pass a String instead of a Uri.
BazelUriConverter treats google3WorkspaceRoot as a String. Passing a Uri
causes the debug adapter to pass `--google3-workspace-root=file:///`
when launching DDS, making it fail to resolve the uris.
Bug: b/364942683
Change-Id: I46f366bb2308a107a68e63445138e071432e45de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383901
Reviewed-by: Ben Konyi <bkonyi@google.com >
Auto-Submit: Chingjun Lau <chingjun@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2024-09-06 16:07:00 +00:00
e099a00ee2
[dds] [vm_service] Add a new RPC error code for "Service Disposed" errors
...
This is not currently used for errors but just adds constants to allow clients to write code to handle these kinds of errors so we can use them in future (instead of generic error codes with string messages).
DAP is also updated ready to handle this error code.
See https://github.com/flutter/flutter/issues/153471
Change-Id: I6ad030d0317e9a70d9e28578787edec75554daad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381501
Reviewed-by: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-09-03 14:54:18 +00:00
6b978a8339
[VM/Service] Add secret _idZoneId parameters to all Service methods
...
TEST=pkg/vm_service/test/id_zones_test.dart, CI
Issue: https://github.com/dart-lang/sdk/issues/55869
CoreLibraryReviewExempt: This CL does not include any core library API
changes, only VM Service implementation changes in
sdk/lib/vmservice/running_isolates.dart.
Change-Id: Ib8af3f073f6db9172df90a5ea221269411f72156
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379545
Reviewed-by: Ben Konyi <bkonyi@google.com >
2024-08-28 16:41:50 +00:00
13285dc8f8
[ DDS ] Prefer IPv6 addresses if the VM service is using IPv6
...
Fixes https://github.com/dart-lang/sdk/issues/56557
Change-Id: I6c18f31a49e6e0d924a467b4b8c1f9d5709d47d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382020
Commit-Queue: Derek Xu <derekx@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2024-08-23 15:33:54 +00:00
e0d140c01e
[ DAP ] Migrate DAP to launch DDS with DartDevelopmentServiceLauncher
...
Part of the process to remove uses of
DartDevelopmentService.startDartDevelopmentService in favor of launching
with `dart development-service`.
Change-Id: I857aee932c0b2fc6ae2172eb106b78c76d536295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380760
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2024-08-22 19:46:11 +00:00
ac038f7e84
[dds] Roll chrome_tag, browser_launcher_rev, and add --use-mock-keychain flag to dds
...
With this roll, Chrome now triggers a dialog on MacOS requesting
credentials. This results in timeouts for
pkg/dds/test/devtools_server/remote_control_test. To avoid user
input, we use a mock keychain instead. The same change has gone
into browser_launcher_rev, and so we include that commit here.
Bug: https://github.com/dart-lang/sdk/issues/56519
Change-Id: I0e0733b658eb09b0775178e617e5ceb42e184ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381705
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2024-08-22 18:17:51 +00:00
212e49fda6
[dds/dap] Treat "Service Connection Disposed" the same as "Client closed with pending request"
...
Should fix https://github.com/flutter/flutter/issues/153473
Change-Id: I77bcf2da01d340412c3dc709a74cc8ed2d80a43f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381181
Reviewed-by: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Helin Shiah <helinx@google.com >
2024-08-19 18:12:14 +00:00
89532d54ed
[deps] rev package:lints to capture the unnecessary_library_name addition
...
Change-Id: I6ca4b0cef189248eac4d0898e8549424f2d889bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380180
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2024-08-13 17:04:13 +00:00
37c16d095c
[ DDS ] Revert removal of --google3-workspace-root option
...
This option is still needed for Flutter in Google3, which uses DDS from
the external SDK rather than the custom Google3 DDS entrypoint.
Change-Id: I982238a63adde1a80f7226a7f2713cd5d610553f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379540
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Reviewed-by: Helin Shiah <helinx@google.com >
2024-08-08 00:09:41 +00:00
dbe6d5852a
Fix bad pattern matching in DDS exception parsing
...
Nullable types for values in map patterns require the key to be present. Since the 'uri' key is not always present in DDS exception responses, this was causing us to fall back to throwing a StateError.
Related issue: https://github.com/flutter/flutter/issues/152684
Change-Id: I929e1e880c4fc6f740ee595e6e852f23fa247b92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378600
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2024-08-01 20:03:34 +00:00
7eef09cd6e
[ package:dds ] Add DartDevelopmentServiceLauncher class
...
Provides shared logic for launching DDS using `dart
development-service`.
Change-Id: I934c777ada23206b498731ffb0611ed3bd383f1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378320
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2024-08-01 14:29:59 +00:00
8ab91cd9db
[dds/dap] Ensure formatting applies to values of type_data lists
...
When formatting numbers as hex, this should apply to values decoded from typed_data lists too.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5199
Change-Id: I02f3437fa202e5227e9fe0c8df621de846bc3edc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377423
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Helin Shiah <helinx@google.com >
2024-07-30 14:55:06 +00:00
ef0e0ee2b6
[dds/dap] Allow sending verbose logs to DAP client to be toggled during a debug session
...
Capturing debug logs that includes VM Service traffic is useful for debugging. Previously with the new DAPs, this could only be enabled at session start which meant users would have to capture very large log files.
This adds the ability to enable/disable this logging while a debug session is already running. A related change in Dart-Code will send this request when you use the "Capture Debugging Logs" command, so you can start a debug session, get to the point of reproducing an issue, and then just capture the relevant logs (VM Service traffic included).
Fixes https://github.com/Dart-Code/Dart-Code/issues/5197
Change-Id: I7e766e57bd80819eb5da164e544903fae23927ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377222
Commit-Queue: Helin Shiah <helinx@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Helin Shiah <helinx@google.com >
2024-07-24 16:51:33 +00:00
Kenzie Davisson