Commit Graph

93 Commits

Author SHA1 Message Date
Mayank Patke 08092d107c [dart2js_info] Update pubspec to 3.8 and reformat.
Change-Id: I21a79df1900038fa4dbed97c085a64bdcf4b4156
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427580
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
2025-05-08 14:28:26 -07:00
Kevin Moore d49663a96b Update proto output
Change-Id: Ib9e6c43005bb566e4e81e248377498b0b6d86f52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421888
Commit-Queue: Mayank Patke <fishythefish@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
2025-04-14 12:49:43 -07:00
Kevin Moore 9c4dc2edf8 [dart2js_info] cleanup graph impl
Remove asserts. Remove mutable _empty var.
Make a thing final.
Drop inconsistent use of `identical`

Fixes https://github.com/dart-lang/sdk/issues/60502

Change-Id: I7e1ed62fce29df9266c6b2ab309429d55bdb6970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421480
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2025-04-08 17:25:33 -07:00
Kevin Moore ff096999e1 [dart2js_info] deduplicate holdings in JSON serialization
Reduces file size and makes scanning easier

Change-Id: I50af1bcc58670c25b77af4310c7455952778198e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419781
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2025-04-03 15:50:38 -07:00
Sigurd Meldgaard 2fe05bd568 Reland "Migrate to use pub workspace"
This is a reland of commit b9b77058a9

Original change's description:
> Migrate to use pub workspace
>
> Use `pub get` to generate `.dart_tool/package_config.json` on gclient sync.
>
> All pkg/ (and a few third_party) packages that are developed inside the sdk repo are included in the workspace from the root `pubspec.yaml`.
>
> All dependencies that are pulled in via DEPS are added as path dependencies via `dependency_overrides` in the root `pubspec.yaml`.
>
> Bug: https://github.com/dart-lang/sdk/issues/56220
> Change-Id: I38c12b608c68da54c57821116cf9aa6696936746
> Tested: relies on CQ of existing tests. Should have no effect on functionality
> CoreLibraryReviewExempt: only core library change is adding a `// ignore:` comment. Should have no influence on functionality
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397164
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>

Bug: https://github.com/dart-lang/sdk/issues/56220
Change-Id: I29afabade2d2447dea05121cb87ff50bb21a4b76
Cq-Include-Trybots: luci.dart.try:flutter-linux-try,flutter-web-try
Tested: relies on CQ of existing tests. Should have no effect on functionality
CoreLibraryReviewExempt: only core library change is adding a `//
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415561
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2025-03-20 06:19:16 -07:00
Devon Carew 3c973fb292 [lints] address diagnostics related to strict_top_level_inference
Change-Id: I228058202855900f0adba73c1ab04d35180a6e5d
Tested: this is an analyzer diagnostic only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414900
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2025-03-17 08:27:57 -07:00
Sigurd Meldgaard 6c4de1ab7e Revert "Migrate to use pub workspace"
This reverts commit b9b77058a9.


Revert "Add missing sample pubspec to workspace"

This reverts commit 892ea15ac7.


These seem to break the engine.

Change-Id: Ieee26deb7928c3869a1b6265326c3ce568ffe731
Tested: this is a revert.
CoreLibraryReviewExempt: this is a revert
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2025-03-14 09:08:20 -07:00
Lasse R.H. Nielsen 7fd5108794 Remove .packages from .gitignore files.
The `.packages` file is no longer a special Dart file,
so any existing file lying around is garbage to be cleaned up.
We shouldn't be hiding it.

Change-Id: I269099bd66e392d630d5b23f4617a705a66a0800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414101
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2025-03-14 07:08:55 -07:00
Sigurd Meldgaard b9b77058a9 Migrate to use pub workspace
Use `pub get` to generate `.dart_tool/package_config.json` on gclient sync.

All pkg/ (and a few third_party) packages that are developed inside the sdk repo are included in the workspace from the root `pubspec.yaml`.

All dependencies that are pulled in via DEPS are added as path dependencies via `dependency_overrides` in the root `pubspec.yaml`.

Bug: https://github.com/dart-lang/sdk/issues/56220
Change-Id: I38c12b608c68da54c57821116cf9aa6696936746
Tested: relies on CQ of existing tests. Should have no effect on functionality
CoreLibraryReviewExempt: only core library change is adding a `// ignore:` comment. Should have no influence on functionality
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397164
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2025-03-14 05:21:40 -07:00
Sigurd Meldgaard a9ab52bcbb Language version bumps for publish_to: none pkgs
Also a separate pubspec for the tools/ folder

Extracted from https://dart-review.googlesource.com/c/sdk/+/397164

Change-Id: If49a6ede07e4864d0c0fcb210c04c18c804849df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412041
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2025-02-27 00:48:40 -08:00
Devon Carew 79b52401f2 Update various packages based on diagnostics from strict_top_level_inference.
Change-Id: I032d10fd1956b62a9e45ceee9ca2b28c9863d1ce
Tested: diagnostic updates only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401560
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2024-12-19 08:23:51 -08:00
Mayank Patke 5cacaca050 [dart2js_info] Update pubspec to 3.7 and reformat.
Change-Id: I2e3eb18c9bc515d96efa6f454d092f66a63c7090
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400720
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2024-12-13 13:13:49 -08:00
Devon Carew 1f8aea0c81 Bump lints to a97011b4b031b1df94765dbacd7d92b0b765c8b9
Changes:
```
> git log --format="%C(auto) %h %s" af68bf0..a97011b
 https://dart.googlesource.com/lints.git/+/a97011b add unintended_html_in_doc_comment; rev to 5.1.0 (211)

```

Diff: https://dart.googlesource.com/lints.git/+/af68bf0cbad88002a2ae19ee8db37b64eb120c32..a97011b4b031b1df94765dbacd7d92b0b765c8b9/
Change-Id: I998d73f5f72e94d5f2922b0751d31620a837555e
Tested: analysis only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387601
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2024-09-30 21:48:03 +00:00
Devon Carew 89532d54ed [deps] rev package:lints to capture the unnecessary_library_name addition
Change-Id: I6ca4b0cef189248eac4d0898e8549424f2d889bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380180
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2024-08-13 17:04:13 +00:00
Kevin Moore 06f7d41c34 dart2js_info: drop references to visualizer
Closes https://github.com/dart-lang/sdk/issues/49204

Change-Id: I560e24c077b218df4038879167f14b8152f38043
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375400
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2024-07-11 19:19:22 +00:00
Mayank Patke 69df740ea9 [dart2js] Assorted TODO cleanup, bump pubspecs to 3.3.0
Change-Id: I621ac252c5d6f3b157a2f194b7f0b7ad85874e4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352990
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2024-02-21 00:02:13 +00:00
Nate Biggs df5a3d8678 [dart2js] Fix dump-info tests by starting indexing at 0 instead of 1.
Also should cache on `serializedId` rather than just the `name`.

Change-Id: I16e095fea5f320d39d55374ce354b9302c3a1e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346024
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2024-01-12 21:51:51 +00:00
Nate Biggs 06adfb8d6b [dart2js] Fix resource usage of binary to json converter tool.
Improves binary -> json conversion from >900s to ~52s for a large program.

This change contains 2 major fixes:
1) Make element name deduping be O(1) rather than O(n) by using a hash map. I didn't calculate how many duplicated names there were but this change improved the runtime of the conversion process by ~10x.

2) Use chunked string writing for the json encoding/file writing process. By doing chunked conversion with buffered writes we avoid having the entire JSON blob in memory and fewer midsized write operations end up being faster. Without this the program took ~87s for the same large program.

Change-Id: I2d3cddbbb96895b68086fce2256937d567beff11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345940
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2024-01-12 17:11:51 +00:00
Ludi Zhan 24fafa3bf7 Update references of dart2js to dart compile js in dart2js info
README

R=jacobr@google.com

Change-Id: I8e8b1c35adadb77c7322b76c5a434f1cfe973451
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339344
Commit-Queue: Ludi Zhan <ludizhan@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
2023-12-02 21:58:53 +00:00
Nate Biggs 171c1334cc [dart2js] Add 'main-only' option to dump info diff tool.
Change-Id: Ibabfd4eb9de5820365772c4b75d5ed0624b148a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332640
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2023-10-30 22:49:09 +00:00
Nate Biggs 1df418af1a [dart2js_info] Add 'main-only' option to info diff.
New option will only include diffs in the "main" output unit for the provided builds. Only sub-library entities have an output unit. Libraries do not have an output unit because there is no code associated with the library itself and a single library's contents can be spread across multiple output units.

Mutually exclusive with the 'package-only' flag because that one only prints libraries and 'main-only' includes no libraries.

Change-Id: I4d5abe54daa8e09d892dd2e2fc2b840f0705ad86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332120
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
2023-10-24 21:38:42 +00:00
Devon Carew e2fe203adc [deps] roll package:lints to the latest
Change-Id: I582f956cd4b712203c2f6dd630b4e1384040446d
Tested: analysis clean (this is a lint only related change)
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329400
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-10-05 03:36:59 +00:00
Sigmund Cherem ab0b4fcbe2 [dart2js] cleanup backend usage (I)
Change-Id: Id2fcc83ef3ae68b00693a13b186ffc406886972c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318880
Reviewed-by: Stephen Adams <sra@google.com>
2023-08-10 22:45:54 +00:00
Kevin Moore 7d9dab0e7a [dart2js_info] Update tests to allow using dart test command
Makes local development a lot easier

Change-Id: I85c6911db313cc9842359b149405aedeb8243be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280407
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2023-02-03 00:29:38 +00:00
Josh Soref 77978889eb Spelling
Closes https://github.com/dart-lang/sdk/pull/51143

GitOrigin-RevId: 9e21c99a222d588e4fc95980725a2f8c9784965c
Change-Id: If0870e8936c7649935dce7e23cd783d62aa5610c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279916
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-30 18:29:59 +00:00
Ahmed Ashour 63180b95ed Remove superfluous words.
Fixes #51095

TEST=ci

CoreLibraryReviewExempt: There are no API changes, just removal of superfluous words in the comments.
Change-Id: Ib1020c62fe6baed5ca68f0074323f025cc90e9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279500
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-01-30 15:58:38 +00:00
Josh Soref 01b28894e7 Spelling pkg dev compiler
Closes https://github.com/dart-lang/sdk/pull/50861

GitOrigin-RevId: 71005e6f5bf5a151cb5c1aefb6a2a300fc40f592
Change-Id: Iadfafb5787a62e9a379437f6a3763d31f99ba7c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277743
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-26 09:12:41 +00:00
Josh Soref 84e3c8b50f Spelling tests
Closes https://github.com/dart-lang/sdk/pull/50920

GitOrigin-RevId: fa87531bd0f52b69485c9d02ff9e44a4a29c6a91
Change-Id: I0ae8574a5b77087895e004079f221201bb550cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278535
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-19 16:24:29 +00:00
Kevin Moore 67015b7175 [dart2js:dump_info] put version and program info first...
...more consistent sorting of holdings (improves diffing)

Change-Id: I2f2c418edea1f2dec6b8cc26e8058a5e3855ceb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271820
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-11-23 23:30:32 +00:00
Kevin Moore 0a7b6d10a9 [dart2js_info] Fix library size - change a name field no nullable
Otherwise tools.dart library_size crashes

Change-Id: Iba72c273eea6d550c2ecf1193f44111f55ca4c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271564
Reviewed-by: Nate Biggs <natebiggs@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2022-11-23 01:18:27 +00:00
Nate Biggs ba662eb4b4 [dart2js] Replace dart2js_dynamic_test with lint and appropriate lint ignores.
See patch 2 for failures coming from this new analysis option.

Change-Id: I6bb10c2eb12431f6c503cc817a9c9bb45ba597a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269800
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2022-11-15 21:11:59 +00:00
Devon Carew b84a08a0e1 [pkg/dart2js_info] remove older .github config files
Change-Id: I1d558855bbeec2e598f5d02efb6355cc575f30df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269362
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2022-11-11 21:13:13 +00:00
Nate Biggs 9766e53168 [dart2js] Migrate dump_info.dart to null safety.
Change-Id: I0b6232bb29866777b7048e30bed62abab10016d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267824
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2022-11-04 16:39:53 +00:00
Mark Zhou 3fd0d96e72 [dart2js] Avoid double-counting used class sizes
Change-Id: I9656f648fabc935868b9b38b074d866d431c5bc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256963
Commit-Queue: Mark Zhou <markzipan@google.com>
Auto-Submit: Mark Zhou <markzipan@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
2022-08-30 22:43:59 +00:00
Mark Zhou 18e4b40dcc [dart2js] Moving dart2js_info coverage helper classes into /lib
Also updates the logic for resolving Angular Info items

Change-Id: Idb5fe1c00db04adc6dcbcf508b01bbf3f8055c2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256603
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-08-29 21:10:00 +00:00
IslinaS 9e740799c6 [dart2js] Corrected package and library size calculation
Change-Id: I17aec52b8f39992e2c18e208da931a3465afb089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253712
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Islina Shan <islinashan@google.com>
2022-08-12 18:30:43 +00:00
IslinaS f5e4113454 [dart2js] Convert program info with main and deferred units into a treemap
Change-Id: Ie0b4d1549ff9f8dd05896012a42222a71cda8adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253561
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Islina Shan <islinashan@google.com>
2022-08-08 23:03:30 +00:00
IslinaS abd6e8eba7 [dart2js] separate main and deferred units in programInfo tree structures
Change-Id: Ia1a6ba772fa6384ef23ab5d814a0228c7d5613bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252870
Commit-Queue: Islina Shan <islinashan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-08-04 00:27:26 +00:00
Kevin Moore d50903739c dart2js_info: Enable and fix some lints
always_declare_return_types
unawaited_futures

Enabled, fixed then disabled directives_ordering due to code generation

Change-Id: Icaf7358222b1c9a939a4764be091e1956d449386
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253365
Commit-Queue: Mark Zhou <markzipan@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-08-02 01:10:34 +00:00
IslinaS 546d0f5fe2 [dart2js] Adding asserts to all makeX functions to ensure that all new programInfoNodes are unique
Change-Id: Ifc413160b3bc4cebd3d56e72d36fd19def32e303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252864
Commit-Queue: Islina Shan <islinashan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-08-01 20:10:33 +00:00
IslinaS 77637cf8d4 [dart2js] addressed null check errors due to unnamed libraries
Change-Id: I182d269854464a2b62d34200234d49351477c486
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252861
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Islina Shan <islinashan@google.com>
2022-08-01 19:12:04 +00:00
IslinaS 7c8981f627 [dart2js] Filling out visitor functions for ProgramInfoNode transformer
Change-Id: I06e43f760f37818d7c7827ac5bcd17658f6a9c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252409
Commit-Queue: Islina Shan <islinashan@google.com>
Reviewed-by: Elliott Brooks <elliottbrooks@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-07-27 23:08:29 +00:00
Mark Zhou 4f9002286f [dart2js] Adding tests for angularInfo conversion for runtime coverage
Change-Id: I143565cb2c36c551ed7e1189ffbcf64fb9b2a5de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252560
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-07-26 21:16:57 +00:00
Mark Zhou 11004430bf [dart2js] Extending coverage analysis to allow class filters
This format is emitted by AngularInfo internally (for identifying providers/components) but conforms to Dart2JS's qualified naming scheme.

Change-Id: I1a38e41105f7fb92a30d3358c08b72e892ccf3c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250344
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-07-25 20:40:10 +00:00
IslinaS d6d9924b26 [dart2js] stubbed out to-devtools-format command
Change-Id: I1e39b38c7782d993d3745b209efff47ac817e12b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252408
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Islina Shan <islinashan@google.com>
2022-07-22 21:35:57 +00:00
IslinaS 8d6c44df7d [dart2js] Adding support for packageInfo ProgramInfoNodes
Change-Id: I72d534669835df176fd6e2bfdd041f5e6a4e7bff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252405
Commit-Queue: Islina Shan <islinashan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
2022-07-22 21:34:58 +00:00
Mark Zhou 59c29c5fc9 [dart2js] Bumping dump info major version after ramUsage addition
Change-Id: If50867ff3e936c98b9e5b09202bbea4dfe269a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252004
Reviewed-by: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-07-20 18:40:05 +00:00
Mark Zhou 0ee0fba728 [dart2js] Adding supertype hierarchy to dump info
Note: this info is not added to the proto format

Change-Id: Ic7407405dea7bcd7b9d3328cfe0850609dc007a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250785
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-07-19 00:55:53 +00:00
Mark Zhou 635a3bf00f [dart2js] Adding total program RAM usage to dump info's output
See: #49160

This doesn't offer a phase-specific view of the ram usage nor aggregate ram usage across split phase compilation.

Change-Id: Ia1f781f9bd35b40048ac23fe103b8fee3b4da584
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250947
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-07-12 00:53:41 +00:00
Mark Zhou 59f9368e4b [dart2js] Cleaning up readme and removing out-of-date docs
Fixes #49285

Change-Id: I0703c9750ba2d5b2f5f3640cc5d2caea4f827236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249064
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2022-06-21 04:56:22 +00:00