This function was defined once in analyzer testing code, once in
linter testing code. In this change, all three are combined into one
function in analyzer_utilities.
Change-Id: I3c9d30c814bf47bf3436ad0acaba48b75fd2c55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423606
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This function was defined once in analyzer testing code, once in
linter testing code, and once in analysis_server testing code. In this
change, all three are combined into one function in analyzer_utilities.
Change-Id: Ib2daa7b3d14aae6ca2aa09f6f9bdeaf76bc72d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423068
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Similarly, read diagnostics from bytes if requirements are still
satisfied.
Note, not all requirements are recorded yet, so if enabled now, we might get stale diagnostics. But I believe that with time the implementation
can be worked to the point when we record all necessary requirements.
Change-Id: Ie81a1c4aa5d41cba3e181e85a30970f2beb97f58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Sam Rawlins