Commit Graph

23 Commits

Author SHA1 Message Date
pq 4f5aacfd90 [CQ] bump analyzer_cli to 3.7 and tall-style re-format
Change-Id: Ic0e1e33da71036800432aa3dae8df22dbef8a460
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404343
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2025-01-14 16:40:21 -08:00
Sam Rawlins 5f8ef7be53 Enable new linter rules in analyzer packages
Change-Id: Id0182648a347a05cbf6e1483a0afe94219268853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-11-21 23:02:38 +00:00
Mike Fairhurst f846d0e7ea [analyzer_cli] Remove unused dart:async imports
Change-Id: I58d1ca58e6d630aee928c6a7cb7fc97822a3be22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161449
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-09-02 17:38:37 +00:00
Erik Ernst 7d06e198c0 Performing the breaking change of SDK issue 40678
Change-Id: I785b0fb10abfda0dd9fc8670c5641127dd67fed7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140640
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2020-03-25 11:39:45 +00:00
Brian Wilkerson cbd67124d1 Add a test that will fail if any of the files in analyzer_cli are not sorted by MemberSorter
Change-Id: I76d5caeef2b6525e93636f150579143a5b7e2c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-03-22 21:27:00 +00:00
Brian Wilkerson b25a68ecf5 Enable omit_local_variable_types in analyzer_cli
Change-Id: Icffcc6e64c538de45b055a691a06db5cb6ca3783
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140560
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-03-22 18:38:49 +00:00
Brian Wilkerson 29c166f07d Enable 4 lints in analyzer_cli
Change-Id: I6b761743bcb8cff61912307d24fc33e3ea224574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132457
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-01-18 22:16:33 +00:00
Brian Wilkerson c1f0b359cd Remove unnecessary uses of new in analyzer_cli
Change-Id: Ib6d0123ae7c49814275b5829a1fd2676122dc540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128842
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-12-18 14:29:21 +00:00
Brian Wilkerson 18844b85ec Remove occurrences of Future<Null> from analyzer_cli
Change-Id: I008589455681dd5da80df4e466803f8cf48cd910
Reviewed-on: https://dart-review.googlesource.com/c/88435
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-01-05 19:25:47 +00:00
Brian Wilkerson 4b04ff2270 Remove dead code from analyzer_cli
Change-Id: I032a004497c0add825b24d4f989d8f5851d157d0
Reviewed-on: https://dart-review.googlesource.com/c/88164
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-01-02 14:22:39 +00:00
Brian Wilkerson 0b8aee98b8 Remove tests from analyzer-cli that do not test code in that package
Change-Id: Icfa56ba8bc29aca2c780252683e904bacffdaf6f
Reviewed-on: https://dart-review.googlesource.com/c/82801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-11-04 19:57:38 +00:00
Devon Carew a0b335ac6c Try no implicit casts in pkg/analyzer_cli.
Change-Id: Ied093d1d988e944b497121e654956e93e61ee52d
Reviewed-on: https://dart-review.googlesource.com/69002
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-08-08 22:14:12 +00:00
Brian Wilkerson 62d0376231 Run the sorter to reduce code churn
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933753002 .
2017-06-12 07:37:14 -07:00
danrubel c04f6a2ab1 fix dartanalyzer find options in bazel workspace
- add dartanalyzer test for bazel workspace
- ensure call to getAnalysisOptions passes an absolute path
- update BasicWorkspace to have an absolute normalized path similar to BazelWorkspace

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2719703005 .
2017-02-26 08:52:55 -08:00
Konstantin Shcheglov ec282eb726 Switch analyzer_cli to 'package:test'.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2395183002 .
2016-10-06 10:02:39 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
2016-09-09 09:09:59 -07:00
Brian Wilkerson fe02411930 Remove several references to JavaFile
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2323173002 .
2016-09-09 07:45:40 -07:00
Jacob MacDonald d2e2241fc1 update to use bazel_worker package
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1885073002 .
2016-04-14 07:46:33 -07:00
Jacob MacDonald 92419d092b Update worker mode to use the bazel protos directly instead of json
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1868663002 .
2016-04-06 13:49:32 -07:00
pq fd0f649327 Driver failure mode fixes (and test cleanup).
* `printAndFail(msg)` doesn't exit in testing (so we need to return null).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1530453002 .
2015-12-14 13:58:05 -08:00
pq 9ae1265ff5 analyzer_cli move to SDK.
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
2015-11-19 14:52:54 -08:00
pq 5cc9a288bb Revert "Move analyzer_cli into the SDK."
This reverts commit a573ed31f1.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1462143002 .
2015-11-19 11:28:52 -08:00
pq a573ed31f1 Move analyzer_cli into the SDK.
Build changes to follow.

Tracking bug: https://github.com/dart-lang/sdk/issues/24731

BUG=24731
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1464553003 .
2015-11-19 11:11:17 -08:00