092728e8b5
[CQ] [server] anticipate strict_top_level_inference
...
Related to https://dart-review.googlesource.com/c/sdk/+/412383
(Note: presubmit required some re-formatting 🤷 )
Change-Id: Ib18c7c1c1fceaa0007d804fbcb6397055242fa42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Phil Quitslund <pquitslund@google.com >
2025-02-26 17:55:13 -08:00
bc7feacec6
[analysis_server] Fix missing trailing comma when inserting arguments before solo child/children
...
The logic here was bad, assuming we didn't need a trailing comma when inserting an arg before a solo argument (which can happen for child/children).
Fixes https://github.com/flutter/devtools/issues/8921
Change-Id: I38f9003cdc8b499d6417cac7989c65a4760416a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-20 15:07:32 -08:00
ca2119e0a6
[anlaysis_server] Improve the error text/codes for property editor APIs
...
Change-Id: If3ad0fd11cc661e88104444afd14a5d79374cc1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-01-28 13:00:18 -08:00
8eb9bcd7f0
[analysis_server] Verify with/without documentChanges for EditArguments tests
...
The tests by default run with documentChanges (set in `setUp`), but it's possible LSP-over-Legacy clients won't support it.
Change-Id: I40c65f05127c88e15a43f16669f64675285955dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406002
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-27 12:54:48 -08:00
1165528f9f
[analysis_server] Improve the formatting of inserted arguments
...
This improves the formatting of inserted arguments by including newlines and indentation if an invocation spans multiple lines.
Change-Id: Idef4602ee9ac9f145879a4628190ec44f87a0018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405122
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
2025-01-22 15:15:31 -08:00
199d50aab1
[analysis_server] Check for applyEdit support before handling EditArguments
...
If we get an editArgument request (usually via DDS), we should verify the connected editor supports edits and return an explicit message if not.
Also adds a `setUp()` declaration to `SharedTestInterface` so shared tests can set client capabilities instead of them being duplicated in each test class (and moves the same for ApplyEdit tests to this).
Change-Id: Ie6a85620b3b53663ce92e55d93e3aefcaf4dc980
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-01-22 15:15:19 -08:00
dd9a061f4e
[analysis_server] Enable "EditArgument" request to work over the legacy protocol
...
+ move all related tests to a shared mixin so they run for both servers.
Change-Id: I853e8f24948c07fdde2a5d6a64ddc65962357b6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404841
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-01-18 10:59:08 -08:00
pq