dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
107,612 Commits 2 Branches 0 Tags
e3e82c95cb3782515e5775bd8da170fd6771a723
Commit Graph

2114 Commits

Author SHA1 Message Date
FMorschel f2776dfab1 [DAS] Fixes no parenthesis when inlining variables in literal expression 
Fixes: https://github.com/dart-lang/sdk/issues/60761
Change-Id: Ide0f446712e5cda235e82bf69030bdc24c1441fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430001
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-05-21 10:13:31 -07:00
Sam Rawlins fb03a18f63 DAS: switch ConfigurationFilesMixin to use package getters 
Change-Id: I4931f2b7598ea96313fb00963e5e154101d51c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429829
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-05-21 08:41:38 -07:00
Konstantin Shcheglov 5d175fa43c Elements. Deprecate InterfaceElement.constructors2, use constructors. 
Change-Id: I78faea1fdbc55e46cdb7fc0b187d12561736cec2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-05-20 15:11:42 -07:00
Alexander Aprelev 1159405ad4 Revert "[DAS] Trigger incompatible lint for included rules" 
This reverts commit 261f8199af 

Reason for revert: it breaks flutter customer testing on hh and on the roller.


Original change's description:
> [DAS] Trigger incompatible lint for included rules
>
> Fixes: https://github.com/dart-lang/sdk/issues/60125
> Change-Id: Icc0b8efda0e7e915d7315a1c2e70c1a7a5093057
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419982
> Auto-Submit: Felipe Morschel <git@fmorschel.dev>
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I0db90864092760efde1cb02cc792c1de14eabf2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429381
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2025-05-19 10:08:35 -07:00
FMorschel 652a419fdb [DAS] Fixes completion for collection ifs and fors 
Fixes: https://github.com/dart-lang/sdk/issues/60604
Change-Id: I55a8426ae54a92fb26fd5a04e3dc11c267c26acf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428940
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-05-19 09:19:49 -07:00
FMorschel 261f8199af [DAS] Trigger incompatible lint for included rules 
Fixes: https://github.com/dart-lang/sdk/issues/60125
Change-Id: Icc0b8efda0e7e915d7315a1c2e70c1a7a5093057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419982
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-05-16 17:31:21 -07:00
FMorschel ade4bf824a [DAS] Fixes record extension field completion 
Bug: https://github.com/dart-lang/sdk/issues/60625
Change-Id: I23e4a5a85dc15059c9b1e658fb2fc3f868fa91a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-05-16 13:43:09 -07:00
Sam Rawlins b40b806bee DAS: enforce unnecessary_async lint rule 
Change-Id: I05c6fbcc5ea7dea37bb7a01a3492e5cd842d11ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-05-16 13:37:53 -07:00
Konstantin Shcheglov 78bc6da66c Elements. Deprecate InstanceElement.xyz2, use 'xyz' instead. 
Change-Id: Ie12b7596b70c77fd2f08520a423eeaf3b6978326
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-05-16 10:24:25 -07:00
Sam Rawlins bd700772ff analyzer: move testing utilities to analyzer_testing package 
Work towards https://github.com/dart-lang/sdk/issues/55660

Change-Id: Iae062d95e5cf3b94b540496242b3627268ac2612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428844
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2025-05-15 16:28:50 -07:00
Konstantin Shcheglov 05da3e1f22 Elements. Deprecate Element.enclosingElement2, use enclosingElement. 
Change-Id: I055b1f9dd1c00605d813effcbbadb9cea874129a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-05-15 13:47:32 -07:00
FMorschel 9dd284ebf2 [DAS] Fixes comment references completion outside braces 
Fixes: https://github.com/Dart-Code/Dart-Code/issues/5507
Change-Id: Icd83264a3d31118c4ee837e2dd2303fd1e10b42a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427460
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-05-13 11:21:14 -07:00
Sam Rawlins c4c9854b9b analyzer_testing: Move ResourceProviderMixin to analyzer_testing 
Work towards https://github.com/dart-lang/sdk/issues/55660

Change-Id: I31932409e495369793dd16c017385c98b86cf44c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427480
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-05-09 16:56:29 -07:00
Sam Rawlins 3021cc4913 analyzer: Move PackageConfigFileBuilder to public API. 
Work towards https://github.com/dart-lang/sdk/issues/55660

Change-Id: I3df2cd374f6b3ef9e027f0e07c748be6ea21ebb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427586
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-05-09 10:57:55 -07:00
Sam Rawlins eb03a1673d DAS: Use Diagnostic in place of deprecated AnalysisError 
Work towards https://github.com/dart-lang/sdk/issues/60635

Change-Id: I0107a65580bc41d769c2a384319225b256df2fbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-05-05 09:35:18 -07:00
FMorschel 576668104d [DAS] Adds test for renaming parameter parameter name 
Fixes: https://github.com/dart-lang/sdk/issues/60578
Change-Id: Ie940bebc36e6d37875d7972df56d4c673747df60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-05-02 15:01:04 -07:00
FMorschel a26d653b9f [DAS] Fixes keywords suggestion for patterns 
Bug: https://github.com/dart-lang/sdk/issues/59854
Change-Id: I4e3b3ca51e08ea63e9516d6b1fca88f75895ade6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417143
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-05-02 11:56:21 -07:00
Sam Rawlins 3a9f4331dd analysis_server: Use new DiagnosticCode name 
Work towards https://github.com/dart-lang/sdk/issues/60635

Change-Id: I76c3f7b3ed890b808f3831f2b7776bd1988a223d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425407
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-30 09:29:50 -07:00
Konstantin Shcheglov 7498555a16 Completion. Fix for NPE when complete at the start of a DartDoc. 
Bug: https://buganizer.corp.google.com/issues/414299463
Change-Id: I70d38a825b5b8eb3d9e3ce0a0dbbe95ea6e5774f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-28 09:04:07 -07:00
Konstantin Shcheglov 2cf84f8053 Elements. Rename most XyzElementImpl into XyzFragmentImpl. 
Change-Id: I7902ccedd9d3e9ccde1091eb28aad98591791b6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-28 08:35:25 -07:00
FMorschel e43a6b252e [DAS] Fixes completion suggestion for setter based on inheritance 
R=scheglov@google.com

Bug: https://github.com/dart-lang/sdk/issues/60298
Change-Id: I43b89744c74bd3bbfc664a505c0fc4d05cc87f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-04-25 17:24:25 -07:00
Konstantin Shcheglov b2fdd8a345 Elements. Rename XyzElement2 into XyzElement. 
The CL was done with rename + adding typedef for each class.

Change-Id: Ia25cc581d2e42cf7d12a85a3579af952d5c232ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424687
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-25 13:27:18 -07:00
Konstantin Shcheglov 49599e06cc Elements. Deprecated element2.dart library. 
Change-Id: I2be38df49e6f242d9fe59f34164549da4a0f41b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424683
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-04-25 11:23:18 -07:00
FMorschel 47d29ca4ba [DAS] Fixes types and keyword suggestions on named parameters 
Fixes: https://github.com/dart-lang/sdk/issues/60550
Change-Id: Ie1f116387483c47f48b90cd6353481b06d93321e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-04-22 12:31:04 -07:00
Danny Tuppeny 59587b0e27 [analysis_server] Enable test newline normalization by default 
+ fix several failing tests with this enabled.

See https://github.com/dart-lang/sdk/issues/60234

Change-Id: Ie71e1655bf2ab8ac651bfcf803884741863b42c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423801
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-22 10:23:12 -07:00
Danny Tuppeny 226ec8413e [analysis_server] Pre-emptively opt some tests out of newline normalization 
Currently newline normalization is opt-in for server tests because there are many tests that fail when the newlines are normalized to the current platform. This change pre-emptively opts-out a number of tests that fail so that the default can be flipped, and then these tests could be worked through.

See https://github.com/dart-lang/sdk/issues/60234

Change-Id: I19f5121612fbc9da18ad0edbe631549e04553e6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423800
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-22 10:21:00 -07:00
Sam Rawlins 5eef8e4ebe analyzer etc: move analysisOptionsContent function to be shared 
This function was defined once in analyzer testing code, once in
linter testing code, and once in analysis_server testing code. In this
change, all three are combined into one function in analyzer_utilities.

Change-Id: Ib2daa7b3d14aae6ca2aa09f6f9bdeaf76bc72d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423068
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-04-21 13:01:36 -07:00
FMorschel 9fbed46b13 [DAS] Removes operators suggestions from . access and more considerations from extension suggestions 
Fixes: https://github.com/dart-lang/sdk/issues/60118
Change-Id: Ibd8399349a3bd82615083f46c3d506fafff20101
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417400
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-04-18 09:43:35 -07:00
FMorschel 42394e5874 [DAS] Better docs auto-complete with extensions and typedefs 
Fixes: https://github.com/dart-lang/sdk/issues/60423
Change-Id: I0907a52a0c7787adc3de21c82bb60aced8263d2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2025-04-01 16:29:10 -07:00
FMorschel 725553b5b9 [DAS] Fixes renaming error and stack in try-catch 
Fixes: https://github.com/dart-lang/sdk/issues/60345
Change-Id: I8dc4741f30ed17499b834d857043824fa1c25ad0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416440
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-03-27 13:55:38 -07:00
Brian Wilkerson 1d99b136d4 [cq] Cleanup extract_widget_test 
This also removes some unused code in the assist processor test
framework.

Change-Id: I07fce90d2cc099f11a22fbaa66d2ed9a3b589af1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417883
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-03-25 14:05:43 -07:00
FMorschel dc2b368732 [DAS] Fixes refactor rename wrong conflict error 
Fixes: https://github.com/dart-lang/sdk/issues/60315
Change-Id: I1974580be8805dd83c9d2895860fb6eed825ccca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415941
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2025-03-25 13:50:32 -07:00
Brian Wilkerson d37521aad7 [cq] Clean up one server test class 
This change converts all of the tests to use the `TestCode` approach to
marking positions and ranges, which makes them more consistent and more
readable. It also means that offset-based tests can now be run on the
Windows bot without failure (though this CL doesn't change which tests
are run there and which aren't).

In the process I combined `indexTestUnit` into `_createRefactoring`,
removing one line of code from each of the tests, reducing the visual
clutter.

Change-Id: I02f0d0f46f3965b243abea01828f61a19d276aba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417300
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-03-21 10:50:22 -07:00
Sam Rawlins d3adf41b9a DAS: reformat 
Recently a bug was fixed in the formatter, regarding how declarations
preceded by an end-of-line comment are formatted. Good to just bundle
the formatting changes into one CL.

Change-Id: Ieab8ec3263932505f8b8da77fbe637dffc61b46d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-03-20 09:18:54 -07:00
FMorschel f276d3c65b [cq] Using TestCode and normalizeSource for quick-fix tests 
This change introduces `TestCode` and `normalizeSource` into the tests for quick fixes. The goal is to add these capabilities to `AbstractSingleUnitTest`, allowing a future update to replace offsets in tests with markers.

Bug: https://github.com/dart-lang/sdk/issues/60234
Change-Id: I760e6b5fb13b37d4e35278073a78f4d755deda64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-03-19 17:35:20 -07:00
Brian Wilkerson 42bdd6071f Add support for a zero-length marker in test code 
Change-Id: I44642ecbb09d8fc2c3b86400f5d388c74d6fb3d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416521
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-03-19 12:18:40 -07:00
Konstantin Shcheglov bb676ba1f5 Elements. ElementImpl is not Element2. 
Change-Id: Ia8885018d3e23875e53dfa0d3cf470bdd28eef29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-03-17 08:46:49 -07:00
Brian Wilkerson 38d8834c07 [cq] Reduce assignments to testCode to 1 
The purpose for this change is to make it easier to use `TestCode` to
parse the code under test. This, in turn, will allow us to use the same
markdown in all of our test code, making it easier to write and read
our tests. This biggest blocker to that goal is the fact that we assign
to `testCode` in several places, and that's the problem solved by this
change.

Change-Id: Id88463925587ff0839fe75faf6a1d083a1b3320c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415700
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-03-15 07:34:29 -07:00
FMorschel fcf79e06ce [DAS] Adds working rename when shadowing global variable is assigned 
R=srawlins@google.com

Bug: https://github.com/dart-lang/sdk/issues/59954
Change-Id: I39417d9e712a40b6992fbad86180c257e782e04a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414200
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-03-14 07:38:48 -07:00
FMorschel 1ce0b0e7ec [analyzer] Adds new warning for multiple combinators 
Fixes: https://github.com/dart-lang/sdk/issues/56879
Change-Id: Ifd53878e3603090efa7905b3cd021b8a63344c26
Tested: trybots
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2025-03-10 15:43:12 -07:00
FMorschel 82c3d74505 [DAS] Renaming positional parameters to rename hierarchy equivalent 
Fixes: https://github.com/dart-lang/sdk/issues/53187
Change-Id: Ie0aaea2e24667ad04a95ce6522fd687710501230
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2025-03-07 10:29:44 -08:00
Brian Wilkerson 2aa14dbe98 [cq] Convert some uses of a comment marker to use TestCode 
There are a couple of other places where this older convention is still
being used, and I hope to clean them up as well.

Change-Id: I84d7e8d81778b6b7b69060df6eda5db2a6aaf256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414161
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-03-07 10:15:59 -08:00
FMorschel 83a16ea8a7 [DAS] Fixes renaming fields at constructor parameters 
Fixes: https://github.com/dart-lang/sdk/issues/52305
Change-Id: I39a547c391ffd3538b3ccaafeab3af65bb4088b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413340
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2025-03-07 09:27:32 -08:00
FMorschel 50ff1c349c [DAS] Fixes rename field add this to fix shadowing 
R=srawlins@google.com

Fixes: https://github.com/dart-lang/sdk/issues/59954
Change-Id: I860e48989566a09ea09092ddd1771be61f89121b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413901
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
 2025-03-06 10:15:43 -08:00
Konstantin Shcheglov 4bd9df1e2b Elements. Remove support for augmentations and methods. 
We don't support augmentations feature yet, and it turned out to be
complicated finishing migration while keeping the current implementation.

Change-Id: I035ecfa74cc107bd9d21a935f76d92987835f542
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413940
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-03-06 09:26:29 -08:00
FMorschel b8dbdda316 [DAS] Fixes instance members completion on dart docs 
R=keertip@google.com

Fixes: https://github.com/dart-lang/sdk/issues/59724
Change-Id: I1e80e62e553c5411ee69d58dbe941b61bc575a81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411361
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2025-03-05 09:49:58 -08:00
Keerti Parthasarathy b251a6f8e4 Add a completion test to verify scoping rules. 
Change-Id: I4b210b9d48007812a04053f43650ac894543b5da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2025-03-05 07:33:57 -08:00
FMorschel f7d62a5ec6 [DAS] Fixes rename FieldFormalParameter outside library 
Fixes: https://github.com/dart-lang/sdk/issues/60182
Change-Id: Ic833f07f2158bedcd196e06a7feebc761109fdef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-03-04 14:24:29 -08:00
Danny Tuppeny 48b7b37ebc [analysis_server] Add imports for test/group snippets 
Fixes https://github.com/Dart-Code/Dart-Code/issues/5421

Change-Id: I70b1bac0e86117c19324d482ba993f950b5be931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-02-27 11:36:11 -08:00
FMorschel c083f5ae06 [DAS] Fixes import and library doc comments. Adds missing enum test 
R=srawlins@google.com

Bug: https://github.com/dart-lang/sdk/issues/59724
Change-Id: I580b39acc96697990b12527aea699cdf09d788e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411360
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-02-26 07:20:29 -08:00