bd700772ff
analyzer: move testing utilities to analyzer_testing package
...
Work towards https://github.com/dart-lang/sdk/issues/55660
Change-Id: Iae062d95e5cf3b94b540496242b3627268ac2612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428844
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2025-05-15 16:28:50 -07:00
3021cc4913
analyzer: Move PackageConfigFileBuilder to public API.
...
Work towards https://github.com/dart-lang/sdk/issues/55660
Change-Id: I3df2cd374f6b3ef9e027f0e07c748be6ea21ebb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427586
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-05-09 10:57:55 -07:00
16d6594346
[analysis_server] Wire up analysis_options formatter/trailing_commas to formatter
...
+ validation + code completion
Fixes https://github.com/dart-lang/sdk/issues/60599
Change-Id: I383c888756e29e091c7abf8d4b8df66387714e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-04-24 11:59:05 -07:00
5eef8e4ebe
analyzer etc: move analysisOptionsContent function to be shared
...
This function was defined once in analyzer testing code, once in
linter testing code, and once in analysis_server testing code. In this
change, all three are combined into one function in analyzer_utilities.
Change-Id: Ib2daa7b3d14aae6ca2aa09f6f9bdeaf76bc72d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423068
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-04-21 13:01:36 -07:00
b40c30898c
DAS: Fix ElementLocator for the SimpleIdentifier under a ConstructorSelector
...
With the `nodeCovering` utility, ElementLocator is given the
SimpleIdentifier _under_ a ConstructorSelector, in code like:
```dart
enum E {
one, two.^new();
}
```
ElementLocator previously did not handle this SimpleIdentifier
correctly.
Change-Id: I32296dea2aaef6df33e56da23b77a4f83d06c9e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423063
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2025-04-18 13:34:12 -07:00
d6eca31417
[cq] Support use of TestCode in more tests and clean up refactoring_test
...
Change-Id: I2b939042654fcc8a1b97edf5644769669ffa45e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418400
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-03-27 13:30:31 -07:00
a804d0d2e5
DAS: Require assists to be registered
...
This is required so that an analyzer plugin can process producer generators that are registered in a plugin isolate.
* Change `AssistProcessor._generators` and
`AssistProcessor._multiGenerators` into private top-level variables
which are only used as "built-in" assist processor generators. They
must be explicitly registered, which we see much of in this change.
* Rename all of the lists of _generators_ and maps with lists of
_generators_, which were named "producers". The new names are
"generators." This leads to giant diffs because of alphabetizing.
Change-Id: Id4432737daaec1bb282f0b387619b23c18c0ea55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2025-03-12 12:07:40 -07:00
07ae3d6159
[cq] Remove the last uses of a comment-based cursor position
...
Change-Id: Ie5e9c81a6e35cd5da411620dacdbea5429ca454c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414460
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-03-11 14:10:58 -07:00
82c3d74505
[DAS] Renaming positional parameters to rename hierarchy equivalent
...
Fixes: https://github.com/dart-lang/sdk/issues/53187
Change-Id: Ie0aaea2e24667ad04a95ce6522fd687710501230
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2025-03-07 10:29:44 -08:00
2aa14dbe98
[cq] Convert some uses of a comment marker to use TestCode
...
There are a couple of other places where this older convention is still
being used, and I hope to clean them up as well.
Change-Id: I84d7e8d81778b6b7b69060df6eda5db2a6aaf256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414161
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-03-07 10:15:59 -08:00
83a16ea8a7
[DAS] Fixes renaming fields at constructor parameters
...
Fixes: https://github.com/dart-lang/sdk/issues/52305
Change-Id: I39a547c391ffd3538b3ccaafeab3af65bb4088b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413340
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Auto-Submit: Felipe Morschel <git@fmorschel.dev >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2025-03-07 09:27:32 -08:00
d18af76865
[migration] analysis_server.dart
...
Change-Id: I111faf848d4243f72fb5e9bf20393784d6ed1fcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410180
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2025-02-14 12:15:10 -08:00
2946ea71d5
Macro. Remove more from analyzer/ and analysis_seever/.
...
Change-Id: Id5426cce73395d3d95657cf1e0b5f9d85fe3f574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2025-01-31 11:35:10 -08:00
a5468363c6
CQ. Remove unnecessary 'async' where no 'await'.
...
Change-Id: I58f56c098c9cec753325ab56d0aad37e1fde0ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403082
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2025-01-07 10:08:11 -08:00
143bbe0a05
Elements. Use identical() to compare ElementImpl(s), other elements.
...
Change-Id: If2abddeaea0551fa4646027ad8aa1bb4fd255660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401760
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-19 13:17:19 -08:00
6494efb192
Elements. Use identical() to compare ElementImpl(s).
...
Change-Id: Idbe935bc6ae333d9940d8ea53ad44011eff237ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-18 14:25:00 -08:00
619c8511ab
[analysis_server] Add tests for formatter language version for legacy protocol
...
LSP already has equiv tests in `test/lsp/source_edits_test.dart`.
Fixes https://github.com/dart-lang/sdk/issues/56685
Change-Id: I70a836e4de9a50816f08382b81c0fc4a3f3e6fba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397540
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-12-02 19:32:41 +00:00
06caa3fa11
[DAS] Adds new import with show option
...
R= srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/32234
Fixes https://github.com/dart-lang/sdk/issues/55842
Change-Id: I3acb03cc6d9a5f8bc1ebaf590a45ac5ee10388f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396564
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-12-02 18:54:59 +00:00
9350b85b17
[analysis_server] Add a missing 'await' that may prevent handling of InconsistentAnalysisException
...
This test (without the code fix) reproduces an infinite loop in the GetFixes handler. There is error handling for `InconsistentAnalysisException` but it didn't appear to work (at least in some cases) because it's async and there was no `await`.
Change-Id: I835398062ea3da1386c2bc065bbdaf93cf10cdf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-21 16:04:47 +00:00
be7a40dd78
[analyzer] Ensure parseFileSync() flushes pending file changes
...
Fixes https://github.com/dart-lang/sdk/issues/57120
Fixes https://github.com/dart-lang/dart-pad/issues/3092
Change-Id: I803cdc19702bcd357cdafde3176ecad246495182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-18 19:05:29 +00:00
fbf331e0dd
DAS: reformat source code with tall-style
...
Change-Id: I42b4a44fd6a2197e499e8623274b3cd1a4b5556f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394003
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-06 23:04:00 +00:00
97dafd74f5
[analysis_server] Consider sort_constructors_first lint when sorting
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4934
Change-Id: Ic6c739a2aaf6f62ecf0c2488a32f90c3f19738a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-10-29 20:04:49 +00:00
75d15bbfa3
[analysis_server] Support formatter page width from analysis_options in legacy protocol
...
This adds the same support previously added to LSP to the legacy protocol.
As with LSP, the value in analysis_options overrides the explicit argument (since the expectation is that the user has not specifically chosen this value for this file, but rather as a default for the project/globally).
See https://github.com/dart-lang/sdk/issues/56864
[analyzer] Add support for "formatter" in analysis_options + use page_width in LSP
This adds support for validation + completion for `formatter/page_width` in analysis_options, and uses this value in preference to the client-supplied value in the LSP server.
It does not yet add support for the legacy protocol, and there are a few questions in https://github.com/dart-lang/sdk/issues/56864#issuecomment-2399289974 .
See https://github.com/dart-lang/sdk/issues/56864
Change-Id: Ic2be00087f78eb62c409dbc8f558d2f24b521f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-10-08 17:31:46 +00:00
a409a1c07d
[analyzer/linter] Use shared enumeration for lint names
...
This helps to avoid any accidental mispellings, enables find usages, and potentially makes future renames easier.
The primary goal is to make future work in https://github.com/dart-lang/sdk/issues/56835 easier.
Change-Id: I684630a4d6cb145031de0dabc221f247246ea00c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Parker Lougheed <parlough@gmail.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-10-03 21:36:49 +00:00
1c0c5f355f
Issue 54063: fixed formatting issues
...
Issue 54063: Adding in file quick fix support for missing semicolons and associated test
R=srawlins@google.com
Bug: https://github.com/dart-lang/sdk/issues/54063
Change-Id: Ia1a20129e3c630d977ab3d40bf8e79b0ed852936
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Ann Mossman <mossman@google.com >
Auto-Submit: Ann Mossman <mossman@google.com >
2024-07-02 17:30:49 +00:00
916272331b
[analysis_server] Remove the singleton uriConverter and pass explicitly to all toJson/fromJson methods
...
This avoids accidentally using the converter when talking to plugins, (at least for now) URIs are never expected, and file paths should always be used regardless of which mode the server is in.
This unfortunately touches a _lot_ of code, so I've pushed in many separate patch sets to Gerrit.
Fixes https://github.com/Dart-Code/Dart-Code/issues/5156
Change-Id: I312c3e2cbc35a05a078aaa0138aec7288b3c7dd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373745
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-07-02 14:15:11 +00:00
5c07c89a35
Enable 'unnecessary_final' in analysis_server/.
...
Change-Id: I71ee934b915d4aff924cf5925f87bcc9adc6c015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-04-16 20:04:15 +00:00
8dcb212010
Issue 53669: Remove duplicate await when inlining methods.
...
Fixes https://github.com/dart-lang/sdk/issues/53669
Change-Id: I64eb73d5eef4a8a8ab5184b3e67bb2303faed5e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360580
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-04-02 14:47:02 +00:00
a09fa058d2
Completion. Issue 38235. Check if isPostfixCompletionApplicable invoked inside a comment.
...
Bug: https://github.com/dart-lang/sdk/issues/38235
Change-Id: I97108bb549d220d45dba35147c0e1fe53fe6b597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-03-18 18:12:24 +00:00
8968e5500a
CQ. Enable avoid_redundant_argument_values in analysis_server/
...
Change-Id: If9c09f81bdbac890553573a8491ca27cb4f22dd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353805
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-02-26 19:51:41 +00:00
19d11a70af
Add expectations for rename test.
...
Change-Id: I95c067030bb836416844f5334982eab152624214
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353785
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-02-22 22:09:37 +00:00
167c0a1b78
Add tests for rename with macro code.
...
Change-Id: Ifa0d5245918c06fa3eda1532560523263682bd43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-02-22 19:22:57 +00:00
b204f82059
Disable fixes, assists, and refactorings in generated files
...
Change-Id: I5c9f36b0edc270cab774f355eec9183940b7e6ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352380
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-02-15 22:20:58 +00:00
581686b8fb
[analysis_server] Consolidate some more writePackageConfig() methods
...
+ tidy up some redundant package versions that are inherited from the ConfigurationFiles mixin.
Change-Id: I93329cbf65af3a68ed27284903e7becac01cf5ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-02-01 19:11:27 +00:00
3f91beb64f
analyzer: Separate FixProcessor from built-in fix producer mappings
...
In order for CorrectionProducers to be used in analyzer plugins, we
need to access DartFixContributor which needs to compute fixes via
FixProcessor. So both DartFixContributor and FixProcessor need to be
moved into analyzer_plugin (eventually). For now, to support
prototyping, I am moving FixProcessor to its own library, and
separating all of the built in mappings (from diagnostic to producer
generators).
I think this separation actually stands on its own as being tidier,
simplifying fix_internal.dart, and separating code from data, as it
were.
Work towards https://github.com/dart-lang/sdk/issues/53402
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try
Change-Id: I3b4fadc7ed94c23597d72bef7dcd832380d34e9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345561
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-01-15 23:41:29 +00:00
278f386c12
Rename AnalysisDriver.getResult() to getResolvedUnit()
...
Change-Id: I3262713dbc9736b7c4c6af9fbbc0b57d7f53d4d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-01-04 17:07:58 +00:00
e3451cb526
[analyzer] Fix some issues running tests with Windows paths on macOS
...
While tidying up some branches on my Mac I found this change I'd never uploaded. It fixes some (thought not all) failures when running with the memory resource provider set to Windows-style paths on non-Windows.
It also allows an environment variable (TEST_ANALYZER_WINDOWS_PATHS) to be used to set this behaviour to avoid modifying the code.
Change-Id: I4cb7e0c0aa6a10f28b43397c33ac8649af73a459
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331046
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2023-10-18 16:26:31 +00:00
2a758931aa
Extension type. Fixes for activating rename refactoring.
...
Change-Id: Ie275fbb94789878ca96302635677823f24242284
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2023-09-08 18:13:51 +00:00
12bd986c71
Extension type. Request based test for rename, a fix for representation field.
...
Change-Id: Ic10550089272797724a0047a31fa040f4a293001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323706
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-09-01 17:53:57 +00:00
ea2d6a7659
Issue 52177. Fix rename refactoring for type parameter of a class.
...
It does not work for function / method type parameters though.
Bug: https://github.com/dart-lang/sdk/issues/52177
Change-Id: I51ae5379425e156640ae32d0cea6fd59cdc62b15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/298960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-04-27 04:51:26 +00:00
39cb6acb88
Issue 52149. Fix to support rename refactoring for declared identifier with LSP.
...
Bug: https://github.com/dart-lang/sdk/issues/52149
Change-Id: Ia4c5c564cc44583741722c658389ea674a5643c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-04-24 22:04:39 +00:00
f4bbc427c3
Implement the legacy protocol for showing messages and URIs to users
...
There is a desire to unify the two subclasses of the analysis server,
but I didn't attempt to do that in this CL.
Change-Id: I17bbf4f6247fc547df1c82f02e74c50eabe7aadc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2023-03-24 18:10:17 +00:00
27984095de
[analysis_server] Avoid Future-of-implicit-dynamic in tests
...
* 99% of these are `Future ` --> `Future<void> `
* There are some `test_` methods which declare a return type of `Future` which
is non-idiomatic, I think, but in order to create a pragmatic consistency, I
added `<void>` to the few test methods in these libraries. Later if we
desire, we can remove all of the return types.
* Also a few `Completer ` --> `Completer<void> ` and
`Stream ` --> `Stream<Object?> `
* There are many remaining cases in `lib/`
Change-Id: I41cd51bab6886788e15ac7065dd21e95e789d09f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2023-03-07 21:12:58 +00:00
39603fd3d0
[dart fix] remove a check that a lint code was enabled when performing a bulk fix
...
Bug: https://github.com/dart-lang/sdk/issues/51427
Change-Id: I67ae94d626d16ac831996b1ce4da626afcfccd56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283462
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2023-02-17 00:58:41 +00:00
59d080301e
Index, search, rename for pattern fields.
...
Change-Id: Iaeae578d18c139850664f30fc5bbc92ad95132ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283127
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-02-15 03:54:58 +00:00
0376883986
Rename Local refactoring for pattern variables.
...
Change-Id: I283532d19d165b9c1442c026a76ef40b47a0c00f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279205
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-02-09 20:05:17 +00:00
4bf325dd90
[analysis_server] remove unneeded new
...
Fixes #49901
Change-Id: I7729e29c1e7ca73a824762156fd68d5d8a2516fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258243
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-01-05 03:05:58 +00:00
aea639bd03
Issue 50604. Fix renaming extension at its declaration.
...
Bug: https://github.com/dart-lang/sdk/issues/50604
Change-Id: I1c685ea7545ef120e5fc23fe6a507ded8c4f4cb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-12-07 22:38:19 +00:00
63b779533f
Add a flag that will allow plugin support to be disabled when necessary
...
Change-Id: Ifa80f14a58501054a72a9e82ff66aa35de37b4fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272490
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-11-30 16:02:50 +00:00
5d0cdc12b0
[analysis_server] rename to handle private named parameters
...
Fixes #49872
Change-Id: Ied484a817713a922133fed070e6703f57336ffb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257102
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-16 20:53:30 +00:00
Sam Rawlins