Commit Graph

500 Commits

Author SHA1 Message Date
lrn@google.com 4214819184 Mark list_test as failing on browsers.
Seems to be failing in UInt8List.operator[] with invalid argument.

BUG=http://dartbug.com/10174

Review URL: https://codereview.chromium.org//14178017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21945 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 12:58:01 +00:00
lrn@google.com e0e13fe852 Fix missing concurrency check in [].forEach.
Also fix a bad range check for List.setRange.

Added more tests.

BUG=http://dartbug.com/10045

Review URL: https://codereview.chromium.org//14468004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21935 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 09:34:17 +00:00
lrn@google.com 8f4f669d7c Fix build by marking test failing.
Typed arrays on IE9 fails.

Review URL: https://codereview.chromium.org//14385003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21885 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 14:36:34 +00:00
ager@google.com 4f1a6eccc4 More fixes. Thanks to Slava for reminding me of check-function-fingerprints flag.
R=asiva@google.com, floitsch@google.com, srdjan@google.com
BUG=

Review URL: https://codereview.chromium.org//14042012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21875 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 12:23:27 +00:00
lrn@google.com 554a845e4f Make List.remove return boolean.
Remove Queue implementations' remove methods, which are not in the
interface.
Added more tests for list operations.
Fixed bugs and omissions found by tests.

http://dartbug.com/10042
http://dartbug.com/10112

Review URL: https://codereview.chromium.org//14425003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21867 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 11:13:17 +00:00
ahe@google.com 2abb5be5ec Implement Symbol correctly in dart2js.
Review URL: https://codereview.chromium.org//14079003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21694 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-18 19:25:22 +00:00
ahe@google.com 6a2d20cb7d Update symbol test to have proper expectations.
Review URL: https://codereview.chromium.org//14048012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21617 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 12:19:07 +00:00
ajohnsen@google.com 4fc71f1743 'Fix' collection/iterable_test for dart2dart.
BUG=

Review URL: https://codereview.chromium.org//14264013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21494 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 18:51:28 +00:00
floitsch@google.com 1049521aaa Add setAll, insertAll, replaceRange and fillRange.
BUG=

Review URL: https://codereview.chromium.org//14175013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21471 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 16:25:21 +00:00
floitsch@google.com 759a366cea Remove insertRange.
Review URL: https://codereview.chromium.org//13956006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21464 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:20:16 +00:00
floitsch@google.com 9bfc844930 Refactor removeRange.
Review URL: https://codereview.chromium.org//13872007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21462 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:10:23 +00:00
ahe@google.com 45ad548837 Update dart:mirrors to use Symbol.
Review URL: https://codereview.chromium.org//14173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21460 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:00:45 +00:00
lrn@google.com 485c8a5999 Move Iterable implementation to collection.
Add IterableMixin and IterableBase to dart:collection.
For now, the implementation is duplicated, because mixins and const
constructors don't mix. We hope that mixins will be improved in the
future to allow using the mixin to define the base class.

Review URL: https://codereview.chromium.org//14022007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21457 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 14:32:16 +00:00
floitsch@google.com 8a0d52ed03 Add missing functions to ListMixin.
Were missing: insert, removeAt and expand.

BUG= http://dartbug.com/9869

Review URL: https://codereview.chromium.org//13877006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21454 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 14:02:43 +00:00
floitsch@google.com bebe3ac2cd Refactor List.setRange function.
Review URL: https://codereview.chromium.org//13863012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21452 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:52:29 +00:00
ahe@google.com 601686b901 Update Function.apply to use Symbol.
Review URL: https://codereview.chromium.org//14107006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21451 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:48:25 +00:00
floitsch@google.com 07b02a845c Remove String.slice. Too much overlap with String.substring.
Review URL: https://codereview.chromium.org//13874008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21442 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 12:20:07 +00:00
floitsch@google.com 65b551ea80 Add default implementation of toString for ListMixin.
Review URL: https://codereview.chromium.org//13855004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21399 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-13 00:52:24 +00:00
ajohnsen@google.com 24c200b76c Fix 'collection' tests and co19 dartc/dart2js status files.
BUG=

Review URL: https://codereview.chromium.org//14135005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21343 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-12 10:28:29 +00:00
ajohnsen@google.com 044f0d02eb Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.
BUG=

Review URL: https://codereview.chromium.org//14173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21338 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-12 09:34:52 +00:00
floitsch@google.com aecbeabcac Implement getRange (returning an Iterable).
Review URL: https://codereview.chromium.org//14065011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21281 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 14:14:29 +00:00
ahe@google.com 762334b7a9 Update test status.
Review URL: https://codereview.chromium.org//14171004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21279 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 13:27:28 +00:00
ahe@google.com bdce382768 Add Symbol class.
Review URL: https://codereview.chromium.org//14142003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21273 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 12:46:16 +00:00
ajohnsen@google.com 974a300cad Remove deprecated <, <=, >, and >= of DateTime.
BUG=

Review URL: https://codereview.chromium.org//14153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21260 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 09:27:54 +00:00
lrn@google.com f41508d33b Added new version of reduce.
Removed min/max and uses of min/max.

Review URL: https://codereview.chromium.org//14071002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21258 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 08:32:31 +00:00
lrn@google.com 77c8b06377 Make the analyzer happy about collections.
Fix some typing issues and a few real errors.

Review URL: https://codereview.chromium.org//14048002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21194 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 11:31:09 +00:00
floitsch@google.com 62358bf5e2 Make default argument to Iterable.join be "".
Review URL: https://codereview.chromium.org//13945009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21193 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 11:28:32 +00:00
floitsch@google.com 0a26d0e20b Rename DateTime constants to full names.
BUG= http://dartbug.com/9441

Review URL: https://codereview.chromium.org//13841005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21189 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 09:23:26 +00:00
kasperl@google.com 57a82e9d05 Implement JS version of LinkedHashSet and move the various HashTable implementations to the VM collection library patch.
R=erikcorry@google.com,lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//13913005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21180 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 07:12:50 +00:00
floitsch@google.com 343fa26d65 Remove deprecated Expect from the libraries.
Review URL: https://codereview.chromium.org//13724021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21079 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 16:07:34 +00:00
lrn@google.com 24e3c0bbb0 Reapply "Reduce usage of IterableMixinWorkaround"
Fix bug and recommit

Review URL: https://codereview.chromium.org//13496014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21049 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 08:07:39 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com bef8ebb5f6 Add Iterable.fold (and Stream.fold) which replace reduce.
For now this is just a copy. In a next step we will change the behavior of
`reduce`.

BUG= http://dartbug.com/9536

Review URL: https://codereview.chromium.org//13548002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20978 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 16:12:40 +00:00
erikcorry@google.com 4e0db7cede Revert 20969: Reduce usage of IterableMixinWorkaround
R=ahe@google.com
BUG=

Review URL: https://codereview.chromium.org//13598015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20972 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 15:18:13 +00:00
lrn@google.com f3608405a3 Reduce usage of IterableMixinWorkaround.
Review URL: https://codereview.chromium.org//13685004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20969 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 15:01:19 +00:00
kasperl@google.com f15b6960c0 Add a new implementation of HashMap that uses JS objects for its (multiple) hash tables.
I'll start refactoring the implementation to make it a bit more
maintainable, but I wanted to get your first impressions.

R=erikcorry@google.com,lrn@google.com,srdjan@google.com
BUG=

Review URL: https://codereview.chromium.org//12827018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-02 11:51:36 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
floitsch@google.com 76d507cb6f Add List.insert.
BUG= http://dartbug.com/5375

Review URL: https://codereview.chromium.org//12383073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20037 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 17:38:14 +00:00
floitsch@google.com a84cdc03ae Revert "Ints don't have "isEven" anymore."
This reverts commit 19935.
Dart2js has been fixed.

Review URL: https://codereview.chromium.org//12691012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20012 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 12:27:54 +00:00
floitsch@google.com 8153baac14 Revert "Fix expectation for test hitting bug in dart2js."
This reverts commit 19936.

Review URL: https://codereview.chromium.org//12577005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19938 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 15:17:01 +00:00
lrn@google.com d97d223eae Fix expectation for test hitting bug in dart2js.
Review URL: https://codereview.chromium.org//12588006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19936 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 15:05:16 +00:00
floitsch@google.com cc7dfdcd14 Ints don't have "isEven" anymore.
Review URL: https://codereview.chromium.org//12836002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19935 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 15:02:44 +00:00
lrn@google.com f9ae90a844 Add Set.union, Set.difference. Change Set methods to expect Set.
Previously the Set methods expected a Collection, which made no
sense.

Review URL: https://codereview.chromium.org//12646005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19926 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:05:48 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
lrn@google.com 03b0de60a7 Fix bug in queue_test.
Review URL: https://codereview.chromium.org//12787003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19861 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 13:37:07 +00:00
lrn@google.com 8e09592d71 Cleanups in collection.
Make SplayTreeMap throw on null key. Optimize first/last.
Make DoubleLinkedQueue have fast length.

Review URL: https://codereview.chromium.org//12611014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19853 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 12:00:59 +00:00
floitsch@google.com 7c9197fa79 Move more tests to IE-fail test-file.
Review URL: https://codereview.chromium.org//12761004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19816 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:19:06 +00:00
floitsch@google.com 00d67f738c Update status file.
Move tests into separate file to keep coverage.

Review URL: https://codereview.chromium.org//12680005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19814 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 20:09:09 +00:00
floitsch@google.com 793d492e8a Update status files.
Move bad tests into separate files so that we still have coverage.

Review URL: https://codereview.chromium.org//12667008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19812 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 19:44:23 +00:00
floitsch@google.com cead1d41f1 ceil/floor/truncate/round return integers.
This CL supercedes https://codereview.chromium.org/11748016/

Review URL: https://codereview.chromium.org//12317107

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19810 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 18:54:37 +00:00