dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
84,564 Commits 2 Branches 0 Tags
e16a4e76e6bb9fe1e01ac78c0e63a261cc580819
Commit Graph

230 Commits

Author SHA1 Message Date
Clement Skau 2236883ff2 [SDK] Removes non-exiting tests from .status 
TEST=Tested all configurations.

Change-Id: Iec00d7e6ea56221ffebcf044de22647907f598f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182500
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2021-02-04 06:46:13 +00:00
Alexander Markov e9aa232066 Remove remaining tests for bytecode mode 
Change-Id: I9690bd8a9bdcf16963424c64c1b80628e50fa28a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166922
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-10-09 22:30:19 +00:00
Alexander Markov 2639f146dd [gardening] Skip flaky lib_2/async/stream_state_nonzero_timer_test 
This test sporadically crashes and confuses
vm-dartkb-linux-release-x64-abi bot which compares results on different
versions of ABI.

Issue: https://github.com/dart-lang/sdk/issues/42073
Issue: https://github.com/dart-lang/sdk/issues/42331
Change-Id: Ib61ca37ed07f40384f78e19e40c51096dd68dc08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152591
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-06-25 22:13:32 +00:00
Ryan Macnak 7295841073 [test] Remove dart2js tests of MirrorsUsed. Remove MirrorsUsed annotations for all tests. 
Remove tests using both dart:mirrors and dart:html.

Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: Ib0fcaab497fee6c18460199ae2db18451408b015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132740
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-01-22 00:06:24 +00:00
Ryan Macnak acc9ffc327 [test] Remove unnecessary slow heap growth flag from streamed_conversion_json_utf8_decode_test. 
This test already has several GCs under the default growth policy, so the verifier runs enough with this flag omitted.

Also, re-enable the background compiler in this test.

Change-Id: I5b874984f45766be76d5ab429df84c2f64bf7e17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123330
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-10-29 19:43:06 +00:00
Samir Jindel c885bdde1d [vm] DBC is obsolete. Remove dead code. 
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-10-27 18:18:29 +00:00
Ryan Macnak 9a9c0f3374 [test] Update status for some mirrors tests under reload stress testing. 
Change-Id: Ia1b9adf1b83fe5cb5be8a853d1561fd1519f1df3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116550
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-09-10 23:07:38 +00:00
Karl Klose ed55695f6b [infra] Remove non-essential test expectations with comments from kernel status files 
Change-Id: I7f49b31abdf4786365ac2a1e6cedc5ddbfae2ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114852
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-09-02 07:04:06 +00:00
Karl Klose b625152523 [infra] Remove non-essential test expectations from kernel status files 
Change-Id: Id246d9abb338873ef5082c3c70f45f5650ad1dcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113981
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-21 10:37:45 +00:00
William Hesse 2706114f4d Revert "[infra] Remove non-essential test expectations from kernel status files" 
This reverts commit c010458732.

Reason for revert: We believed that the Crash marker had no effect in the -kernel status files, but some of these crashes were vm crashes, so they were suppressing upload of core dumps.  These uploads are failing on Windows builders.

Original change's description:
> [infra] Remove non-essential test expectations from kernel status files
> 
> Change-Id: I959b7847e93c221d77c94bd25f95e913a25e91cd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113685
> Reviewed-by: Jens Johansen <jensj@google.com>
> Commit-Queue: Karl Klose <karlklose@google.com>

TBR=karlklose@google.com,jensj@google.com

Change-Id: I57978d9253a5889c58444fce3ce6c30b79ab4040
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113691
Reviewed-by: William Hesse <whesse@google.com>
 2019-08-19 14:29:45 +00:00
William Hesse a04a567801 Restore "Crash" status to test in status file, accidentally removed. 
Change-Id: I9957d129f304f992fca4d56b92d82c6d586194b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113690
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-19 14:10:59 +00:00
Karl Klose c010458732 [infra] Remove non-essential test expectations from kernel status files 
Change-Id: I959b7847e93c221d77c94bd25f95e913a25e91cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113685
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2019-08-19 12:01:01 +00:00
Martin Kustermann a3f5dfc5ec [vm/gardening] Disable isolate/ping_pause_test 
Issue https://github.com/dart-lang/sdk/issues/37787

Change-Id: I2fb6c329ab4ba06136e2b8564440c4dcbb0045ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112348
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-08-08 15:36:43 +00:00
Ryan Macnak 9fe8865f4a [vm, bytecode] Implement ParameterMirror and enable mirror tests. 
In particular, mirrors_reader_test no longer crashes.

Change-Id: I602e7d85755dafd943fe84d20831f0f35484b387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108968
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-07-25 00:04:02 +00:00
asiva 4a69ef4a50 Skip all spawnURI tests for the simulator architectures as these tests involve invoking the front end for compilation which would mean the front end has to run in simulated mode. 
Change-Id: Idce29ff924fb88c909e0faf2dc1107506659dc6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107832
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-07-02 15:06:37 +00:00
Nate Bosch 8614f86c9b Remove remaining support for dart:isolate on web 
Closes #37153

Isolate.resolvePackageUri was the only API which had an implementation
across DDC and dart2js. The implementation in dart2js has been broken by
default since Dart 2.0.0 without a user implemented hook that is not
used on any public repo on github. Our current supported path for
invoking the compilers on projects disallows the import altogether on
the web and it is only usable with an older version of the
`build_web_compilers` package, or by invoking the compiler manually
outside of the build system. This CL does not break the ability to have
the import when invoking outside of the build system.

- Drop implementation for `Isolate.resolvePackageUri` from the dart2js
  and DDC patch files.
- Drop all references to `defaultPackagesBase` since it is not used.
- Drop all tests under `isolate/browser` since we do not expect any
  support on the web. Most of these tests would have already been
  failing. Remove status file entries that refer to the deleted tests.

Change-Id: I4a19213b0946d835c00e9c107a714f3bc5672f86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105080
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-06-07 21:13:06 +00:00
Nicholas Shahan 86c7165969 [tests] Avoid use of $strong because it is always true now 
* Remove all `&&  $strong` clauses.
* Delete all sections that include a `&& !$strong` clause.

Change-Id: Idd32cf5623793e3f98e3e998025bac079d88e2f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102223
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-05-16 17:41:27 +00:00
Alexander Markov 0b9060ec1d [vm] Fixes for flaky crashes when querying source or source location 
There were no checks for missing source or source position, which
caused flaky crashes while running test mirrors/mirrors_reader_test.

Change-Id: I73497414ebe7b030ba308851038e0ef9e133aa48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100781
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-29 22:10:38 +00:00
Sigmund Cherem 4b7d256a06 Revert "Enable constant-update-2018 by default." and "Update .expect files in pkg/front_end after e9ca6a53" 
This reverts commit e9ca6a5335 and d3e00fd35e.

Change-Id: I346d6156be19c4fceffa202a7ce9bfa931c7c14b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99560
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-04-16 20:20:12 +00:00
Aske Simon Christensen e9ca6a5335 Enable constant-update-2018 by default. 
Fixes https://github.com/dart-lang/sdk/issues/32517
Fixes https://github.com/dart-lang/sdk/issues/34189
Fixes https://github.com/dart-lang/sdk/issues/34192
Fixes https://github.com/dart-lang/sdk/issues/34205

Unskipping the skipped tests is tracked by
https://github.com/dart-lang/sdk/issues/36433 and
https://github.com/dart-lang/sdk/issues/36595.

Expectation files for front-end tests will need to be updated to make
front-end builders green. They are part of unapprovable suites.

Change-Id: I311f449af6feff5bf40740227a95aa06e0a9d84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99169
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-04-12 13:30:15 +00:00
Alexander Markov 07482eeb5e [bots] Run all tests on vm-dartkb-* bots 
Bytecode configurations should have the same test coverage as default mode.

The following tests are excluded in dartkb mode as there are too many crashes:
 - service/* (debugging capabilities are not supported);
 - lib_2/mirrors/* (mirrors are not supported);
 - vm/cc/* (bytecode modes are not wired up in run_vm_tests).

Change-Id: I11eead94b96f43ab454acd6e6f6861af943c0488
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97847
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-05 18:25:34 +00:00
Ryan Macnak 975cc65c17 [vm, interpreter] Implement interpreter stubs for IA32. 
Change-Id: I7bb7e51cb46868abcc10c7dcc7cbf1db1ccdc35c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95264
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-06 21:09:30 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context. 
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Ryan Macnak d253642f25 [standalone] Fix isolate messages for processes that a creating an AppJIT snapshot. 
The standalone embedder was sorting classes in the main isolate, but not child isolates, causing the CIDs to diverge.

Also fix a few isolate tests.

Bug: https://github.com/dart-lang/sdk/issues/33128
Bug: https://github.com/dart-lang/sdk/issues/36000
Change-Id: Ic21acb02eb623ae177ed242aa21b0e243775e369
Reviewed-on: https://dart-review.googlesource.com/c/93923
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-21 22:39:39 +00:00
Ryan Macnak 3068192450 [vm] Remove deferred canonicalization from isolate message serialization. 
This fixes sending more commonly used types at the expense of less common recursive types.

Bug: https://github.com/dart-lang/sdk/issues/35778
Change-Id: I55f1105d1a8a48b6c4c241c2ce4d2f36863d7b5a
Reviewed-on: https://dart-review.googlesource.com/c/93372
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-20 20:11:05 +00:00
Martin Kustermann 4daabe69c3 [vm/gardening] Mark convert/base64_test/01 as flaky 
Issue https://github.com/dart-lang/sdk/issues/35948

Change-Id: Ib0358706e96ceda5d49d7a3496354eb903d8a40d
Reviewed-on: https://dart-review.googlesource.com/c/93223
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-14 16:42:48 +00:00
Samir Jindel 3c97ac1978 [vm/gardening] Update status file for int32_length_overflow_test 
Change-Id: I7ea2042d0de5f5af3bb2c5fb2d2cf39e95f6bb84
Reviewed-on: https://dart-review.googlesource.com/c/90701
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-01-23 12:31:38 +00:00
Samir Jindel 89d3276703 Revert regexp_kill_test which is flaky on all platforms. 
Change-Id: I87a70e787ff205f68dd13f51d2c0005b065f379e
Reviewed-on: https://dart-review.googlesource.com/c/88830
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-01-10 08:21:29 +00:00
Alexander Markov 0213c9f9d2 [gardening] Mark test as flaky in dartkb mode 
Issue: https://github.com/dart-lang/sdk/issues/35590
Change-Id: I95721a0a62a1e6201ffd4f7833eed089f915c2e5
Reviewed-on: https://dart-review.googlesource.com/c/88660
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-01-08 01:49:49 +00:00
Alexander Aprelev 7d14785115 This relands "Load isolate from parent's kernel in Isolate.spawn calls.". 
Original PR was reverted because it broke hot-reload bots. This CL adds steps to initialize kernel_service compiler for child isolate. Compiler is needed to support hot-reload request. Child isolate's compiler is created from full kernel file produced by main isolate's compiler. Changes since original PR are pkg/vm/bin/kernel_service.dart in pkg/vm/lib/incremental_compiler.dart.

Further this CL changes kernel fingerprint calculation for interface types so it calculates the hash of the canonical names themselves, rather than indices(that might change from one compilation to another).

This reverts commit 63fd8f63e6.

Change-Id: I6fe5b2ef99f209b32cd4087dfd1c8cac229c2d8b
Reviewed-on: https://dart-review.googlesource.com/c/87265
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
 2018-12-14 23:45:57 +00:00
Alexander Aprelev fc3153a4f0 [vm] Unskip isolate tests on sim* architecture. 
Also make kernel-service verbose output friendlier(so it doesn't dump platform.dill on console).

Change-Id: Ibed494f324cd574e05b701f7d56b18c0fb1b451f
Reviewed-on: https://dart-review.googlesource.com/c/86784
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-12-13 03:07:06 +00:00
Alexander Aprelev 95eed86c34 Unskip isolate hot-reload tests. 
Change-Id: I85b557a0a8297e198f8a11e0b4b4677018da991d
Reviewed-on: https://dart-review.googlesource.com/c/86820
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-13 02:24:49 +00:00
Daco Harkes 04b2b75d8c [Gardening] Remove inherently flaky async/timer_regress22626_test 
Closes https://github.com/dart-lang/sdk/issues/28254

Change-Id: I5c1f66a3f22ee7adbb7bc294f1b5a6ffd94637c2
Reviewed-on: https://dart-review.googlesource.com/c/86025
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-12-07 12:17:55 +00:00
Sigmund Cherem 8d41ec30c0 Remove obsolete comment in status files. 
I added these when we were maintaining the .status files with a script at the
time strong-mode was being implemented in the CFE. The comments are no longer
relevant.

TBR=paulberry@google.com

Change-Id: I3d37da32cd611731e3e0d91a5aa751fa550cc179
Reviewed-on: https://dart-review.googlesource.com/c/85408
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-11-27 01:25:51 +00:00
Vyacheslav Egorov 78332742ac [gardening] Skip lib_2/async/timer_regress22626_test in reload-rollback + debug configuration 
The test is timing dependent so slow reload might cause a failure.

Change-Id: I1970d429a4c2346a1f6af514e226ffc553060e61
Reviewed-on: https://dart-review.googlesource.com/c/85343
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-26 10:14:40 +00:00
Samir Jindel e23acaaf90 [vm/aot] Fix obfuscation. 
Test Plan:

Make vm-kernel-precomp-obfuscate-linux-release-x64-try green, ensuring status file changes
reflect design gaps and not bugs.

Tested locally that obfuscated Flutter Gallery runs.

Change-Id: Ifcdc334de58f43c310e15b58dbcf6fe1597206f2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/81009
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-26 13:00:33 +00:00
Dmitry Stefantsov 8648d782ae Reland "[fasta] Report errors for bounds violations" 
The original commit:
https://github.com/dart-lang/sdk/commit/aa6fb2d3a4298e60b5635f26507d5b39f4e531cb

Change-Id: I34287ec856fde16d56e9369ef2620311ba9bb722
Reviewed-on: https://dart-review.googlesource.com/c/79200
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-11 10:20:01 +00:00
Ryan Macnak 662ff7f112 [vm] Remove TokenStream, TokenValue, CompilerStats. 
(CompilerStats timers have been replaced with the timeline events.)

Change-Id: Iddcb752c085de9762eb802371b6d2905fa608a76
Reviewed-on: https://dart-review.googlesource.com/c/79086
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-10 21:39:45 +00:00
Dmitry Stefantsov a539d2ef5f Revert "[fasta] Report errors for bounds violations" 
The CL is reverted because it didn't account for the case when a check
of a user-specified type argument against the bound depends on another
type that is only known after type inference is done.

Change-Id: I1fd140af95ed37b9191a5b161a281d4639e3453f
Reviewed-on: https://dart-review.googlesource.com/c/79048
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-10 15:31:27 +00:00
Martin Kustermann 17ac151f44 [Gardening] Increase timeout on release-hotreload configuration as well (not just debug), skip streamed_conversion_json_utf8_decode in hot-reload-simdbc64 
Change-Id: Ifde8ae03b0f4da57c9c2f7ea445c0626630bcbce
Reviewed-on: https://dart-review.googlesource.com/c/79026
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-10-10 12:14:16 +00:00
Dmitry Stefantsov aa6fb2d3a4 [fasta] Report errors for bounds violations 
Fixes #33308.

Bug: http://dartbug.com/33308
Change-Id: Iae087928468ed6883c438db95644135dc7ef0a6a
Reviewed-on: https://dart-review.googlesource.com/c/57621
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-10 12:03:36 +00:00
Ryan Macnak a8e0db1077 [gardening] Mark remaining ASAN failures. 
Bug: https://github.com/dart-lang/sdk/issues/32187
Bug: https://github.com/dart-lang/sdk/issues/34724
Change-Id: I123549194670fa5471a187bfcc5e70fd97efc2ee
Reviewed-on: https://dart-review.googlesource.com/c/78706
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2018-10-09 17:31:28 +00:00
Daco Harkes c1361963aa Update status files for tests failing due to #34724 and #34724 
Change-Id: I2b6d03bed48a1d867f95a4c5754d77c7558ae2c6
Reviewed-on: https://dart-review.googlesource.com/c/78780
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2018-10-09 16:58:27 +00:00
Aske Simon Christensen 79e8b3d57f Make importing two libraries with the same name a warning 
Bug: https://github.com/dart-lang/sdk/issues/34612
Change-Id: I2697b56fb02d6bee8ea3bc2d06329100e287ae34
Reviewed-on: https://dart-review.googlesource.com/c/78242
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-10-09 06:56:13 +00:00
Alexander Markov a97ddf8ce1 [vm/bytecode] Fix sporadic crashes when running with bytecode. 
Several tests crashed sporadically as bytecode Code object was not
properly scanned by GC.

Change-Id: I4810c46552a9f1990f1304f7c502b3408df8ed88
Reviewed-on: https://dart-review.googlesource.com/c/78141
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-04 20:01:25 +00:00
Alexander Markov 097e716694 [vm/bytecode] Update test status 
Change-Id: I99881b9136a62ffb9eff184347532c807096b488
Reviewed-on: https://dart-review.googlesource.com/c/77943
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-03 22:10:11 +00:00
Jens Johansen 570fd5a788 Error on re-export, export and import of libraries with same name. 
Fixes #12916.

Change-Id: Icef0f04f1575c8dad5f1cd23a9363f06fa2a2b35
Reviewed-on: https://dart-review.googlesource.com/74161
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-09-25 09:09:21 +00:00
Alexander Markov 62d154f6a3 [vm/bytecode] Record null-initialized fields in bytecode 
If a field is initialized with null (either explicitly or implicitly),
field store can be omitted in bytecode. In such case, bytecode should
still convey the information about this initialization to VM for
field guards to work correctly.

Change-Id: I1fd45b858c3c521b97fa5dbffe0e15b1ea75d92f
Reviewed-on: https://dart-review.googlesource.com/76060
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-09-24 17:56:35 +00:00
Daniel Hillerström 7ad1e5da99 Perform substitution on type argument/parameter bounds. 
Fixes regression #34528. Introduces a new test to mitigate future
regressions.

Closes #34528.

Change-Id: Iaf0a8f44db2a8b4a8151c391ddb8dff69910fe3a
Reviewed-on: https://dart-review.googlesource.com/75840
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-09-24 14:02:01 +00:00
Alexander Markov 654c4babc8 [vm/bytecode] Fix a couple of assertions when running with bytecode 
Also, add more tests to dartkb bots.

Change-Id: I6fbcbe73d6b9065ec03e64bf150b4ebd742e4d28
Reviewed-on: https://dart-review.googlesource.com/75981
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-09-21 22:54:39 +00:00