Commit Graph

6 Commits

Author SHA1 Message Date
Leaf Petersen b101a7d002 Add language versions to _2 test libraries
Change-Id: Ib33169c3e0ffc870915c189404074a1dea472546
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196548
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2021-04-26 17:58:57 +00:00
Erik Corry 01e5fcd315 Reactivate 90% of string_split_test on dart2js
R=sra@google.com

Change-Id: Ibc88048063899c0ff3eb5be9c3644b5e717d5594
Reviewed-on: https://dart-review.googlesource.com/35282
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Erik Corry <erikcorry@google.com>
2018-01-17 21:03:07 +00:00
Erik Corry b2f8b5481d Update two string tests in strong mode
R=vegorov@google.com

Change-Id: I07edf1dbf6d49ff8283a52f655e8bef8c2e99b4d
Reviewed-on: https://dart-review.googlesource.com/34823
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-01-17 14:50:11 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests.
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-17 23:37:15 +00:00
Jennifer Messerly d0072fa73f Fix the return type of String.split in DDC to be correct
It wasn't actually a List<String>, so it could fail a strong mode cast, and also permitted non-Strings to be added.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/3005533002 .
2017-08-25 11:24:54 -07:00
Ben Konyi 370938c4c2 Migrated test block 28 to Dart 2.0.
Relatively simple block. Split string_replace_test into
string_replace_test and string_replace_static test and updated status
file to expect MissingCompileTimeError for vm + dart2js

BUG=
R=jcollins@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2983273002 .
2017-07-24 12:10:15 -07:00