0a0bc8cd1c
Issue 1738. Check type of DartMethodDeclaration.getName().
...
http://code.google.com/p/dart/issues/detail?id=1738
R=zundel@google.com ,brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9430013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4413 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-21 23:12:09 +00:00
dedbb79fa3
Issue 1714. Report warning if assert argument is not 'bool' or '() -> bool'.
...
http://code.google.com/p/dart/issues/detail?id=1714
R=codefu@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9421002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4404 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-21 18:19:28 +00:00
bdfccd85b4
Allow declare new named parameters in method override.
...
http://code.google.com/p/dart/issues/detail?id=1575
R=karlklose@google.com ,zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9403026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4402 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-21 17:56:56 +00:00
cf869318e9
Issue 1606/1108. The 'native' keyword is supposed to only be allowed in core libraries.
...
http://code.google.com/p/dart/issues/detail?id=1606
http://code.google.com/p/dart/issues/detail?id=1108
R=codefu@google.com ,zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9421001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4361 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 18:07:07 +00:00
5fdd279826
Issue 1475. Report warning for non-unique Map literal keys.
...
http://code.google.com/p/dart/issues/detail?id=1475
R=codefu@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9355006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4360 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 17:55:29 +00:00
d6e272b8e1
Issue 1548. If URI can not be parsed, return null.
...
http://code.google.com/p/dart/issues/detail?id=1548
This is also specified in JavaDoc for this method.
R=danrubel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9420011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4341 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-16 21:26:25 +00:00
74ab781eab
Issue 1551. Report error for new-line in single-line raw string.
...
http://code.google.com/p/dart/issues/detail?id=1551
R=codefu@google.com ,zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9414015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4332 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-16 19:19:20 +00:00
1165672c79
Allow named parameters in const constructor invocations.
...
The compile time constant analyzer visited the name of the parameter as identifier, which was not resolved. This resulted in an element of kind NONE, which was classified as non-constant.
BUG=http://code.google.com/p/dart/issues/detail?id=1576
TEST=language/NamedArgumentInConstCreationTest
Review URL: https://chromiumcodereview.appspot.com//9359038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4301 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-16 08:13:49 +00:00
f5d335800f
This CL is part of a proposal to change the API of dartc's implementation of UrlSource.
...
Review URL: https://chromiumcodereview.appspot.com//9392017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4272 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-15 16:41:24 +00:00
9bf46f477d
Don't cache subtypes in elements. It causes a memory leak in the Editor.
...
Review URL: https://chromiumcodereview.appspot.com//9390011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4271 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-15 16:37:55 +00:00
f81c137b51
Multimap replacement
...
Review URL: https://chromiumcodereview.appspot.com//9373059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4217 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-14 13:19:42 +00:00
1b21501f7a
Remove DartIsolateStubGenerator.
...
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9384013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4191 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-13 16:42:24 +00:00
b994d9d930
Optimize clone operation
...
Review URL: https://chromiumcodereview.appspot.com//9370016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4143 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 20:17:11 +00:00
41f0492cf0
Remove dartc optimizing backend.
...
Review URL: https://chromiumcodereview.appspot.com//9353015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4025 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-08 10:22:07 +00:00
8fdd07b9fd
This change makes the normal way of running dartc equivalent to running it with what was the --check-only flag. Shared test status files have been updated to run 'green' for now until we can get a special static analysis testing tool in place.
...
The code generation backend is still there behind a flag, but due to be removed.
Review URL: https://chromiumcodereview.appspot.com//9346021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4008 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-07 22:00:40 +00:00
574f7dfb0b
Fix DartRunner to work properly with --check-only cmdline flag
...
Review URL: https://chromiumcodereview.appspot.com//9310096
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3944 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-06 14:15:52 +00:00
15234d56d5
Remove DartDocumentationGenerator and related flags.
...
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9317093
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3919 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-03 21:27:31 +00:00
d861694b20
Issue 561. Fix for methods named get/set/operator.
...
http://code.google.com/p/dart/issues/detail?id=561
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9301007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3866 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-02 19:18:22 +00:00
0b61628ce3
Fix for extra memory consumption.
...
Especially in the big List.sort() test.
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9310061
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3846 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-02 14:57:23 +00:00
ecbd1874bf
Recompile unit with potential conflict/dependency on some top-level symbol.
...
1. Change dependency tracking from API version on unit to just unit last modified time.
2. Track sets of top-level and all declared symbols in units, recompile in case of possible conflict.
3. Track units with TypeErrorCode.CANNOT_BE_RESOLVED, recompile if any unit changes top-level symbols.
4. Better tests with source code directly in test method.
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9148026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3799 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-01 17:47:04 +00:00
ffd2a08a22
Type Variables cannot be used in identifier expressions
...
dartc was allowing this code to get through to code generation.
http://code.google.com/p/dart/issues/detail?id=1387
Review URL: https://chromiumcodereview.appspot.com//9307010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3757 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-31 22:17:00 +00:00
6d9ee83915
Fix crash in dartc when given cyclic type variable bounds.
...
http://code.google.com/p/dart/issues/detail?id=211
Review URL: https://chromiumcodereview.appspot.com//9186017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3751 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-31 21:46:24 +00:00
3ddd2d6b03
Two different classes may have the same *name*.
...
Review URL: https://chromiumcodereview.appspot.com//9303033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3725 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-31 13:31:17 +00:00
2ae9b5fcaf
Issue 1251. Check for getter existence.
...
http://code.google.com/p/dart/issues/detail?id=1251
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9296016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3693 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-30 17:36:42 +00:00
8d897192ae
Call operator shared test and parser updates for operator call in dartc.
...
http://code.google.com/p/dart/issues/detail?id=1355
Review URL: https://chromiumcodereview.appspot.com//9288076
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3671 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-27 22:32:00 +00:00
afeaa7ed81
DartToSourceVisitor was omitting type annotations on list/map literals
...
Review URL: https://chromiumcodereview.appspot.com//9295019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3664 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-27 19:57:28 +00:00
3964729a31
Issue 801. Use actual super constructor with all named or synthetic.
...
http://code.google.com/p/dart/issues/detail?id=801
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9232050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3661 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-27 17:12:43 +00:00
49e1adff6f
Issue 962. Fix for crash in nested function parameters list code generation.
...
http://code.google.com/p/dart/issues/detail?id=962
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9225024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3655 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-27 14:58:22 +00:00
99cc34e500
Issue 1287. Allow to invoke function literal.
...
http://code.google.com/p/dart/issues/detail?id=1287
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9288021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3626 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-26 20:22:08 +00:00
226ed91138
Added runtime type checking to the elements of list and map literals in dartc
...
http://code.google.com/p/dart/issues/detail?id=220
http://code.google.com/p/dart/issues/detail?id=221
Review URL: https://chromiumcodereview.appspot.com//9289029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3619 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-26 17:33:04 +00:00
6f85c329e7
Issue 1330. Return actual Type from DartNewExpression.
...
http://code.google.com/p/dart/issues/detail?id=1330
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9113064
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3609 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-25 21:43:57 +00:00
7169189529
Update map literal syntax to expect only one type parameter
...
As of the spec v0.6, the correct syntax is now:
<V>{"key" : value };
Whereas you used to also specify the key. Added a deprecation warning
for the old syntax.
http://code.google.com/p/dart/issues/detail?id=1151
Review URL: https://chromiumcodereview.appspot.com//9235015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3606 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-25 20:21:24 +00:00
1431b3238e
Provide better debugging if a null type is encountered.
...
Patches up at least one case where the 'this' keyword could return null if used in a static context.
http://code.google.com/p/dart/issues/detail?id=761
Review URL: https://chromiumcodereview.appspot.com//9160004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3564 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-24 20:12:07 +00:00
f7182176bf
Issue 1229. Report error for using unary plus operator.
...
http://code.google.com/p/dart/issues/detail?id=1229
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9284029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3560 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-24 19:05:55 +00:00
64085a0adf
Remove RTT.derivedTypes and all generated initializations thereof.
...
This code is not currently used by the RTT system and was actually incomplete. If we need it for mirrors at some future point, then we can add it back.
Review URL: https://chromiumcodereview.appspot.com//9117008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3516 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-23 22:00:12 +00:00
c0a3f43ce6
Issue 932. Checks for various named arguments cases.
...
http://code.google.com/p/dart/issues/detail?id=932
1. Clean up List<? extends Type>;
2. Generate compile time warnings/errors.
3. Generate run time errors.
4. Fix corresponding tests according to spec.
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9270016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3511 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-23 20:01:31 +00:00
4e9e3f014f
More setting of symbols on identifiers
...
Konstantin was right in http://codereview.chromium.org/9150044/
I should have included a unit test. This change includes a
hand written unit test for identifiers being set properly on class/interface
definition variants, and fixes to the ResolverAuditVisitor (it was not
catching many problems in just those cases).
Review URL: https://chromiumcodereview.appspot.com//9138023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3459 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-20 18:19:49 +00:00
40edd9ce12
Issue 1233: Parser does not handle position stack correctly in string interpolation
...
https://code.google.com/p/dart/issues/detail?id=1233
Missing done()
R=messick@google.com
BUG=1233
TEST=
Review URL: https://chromiumcodereview.appspot.com//9254044
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3456 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-20 14:55:45 +00:00
c9e4011585
Record the elements on identifiers in the AST referring to types.
...
When dartc resolved a type, in the past it did not set the elements for the type
on the AST ( you had to go through the type). This is a bit tedious in the IDE,
so we are going to try to fill in more of the symbols in the AST.
Review URL: https://chromiumcodereview.appspot.com//9150044
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3449 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 21:50:14 +00:00
bbdbb3791e
Protect vs. NPE in TypeAnalyzer.checkInitializedDeclaration()
...
Stack trace came from user feedback on Dart Editor. See:
http://code.google.com/p/dart/issues/detail?id=759
I wish I could reproduce the original problem, but this guard would be sure to fix it.
Review URL: https://chromiumcodereview.appspot.com//9264022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3447 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 20:54:58 +00:00
d7b7edd2e0
Issue 1177: Non-existant documentation directory throws
...
https://code.google.com/p/dart/issues/detail?id=1177
-Just call mkdirs() before creating PrintStream() in DartDocumentationVisitor
R=zundel
BUG=1177
TEST=
Review URL: https://chromiumcodereview.appspot.com//9178038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3446 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 20:11:36 +00:00
2f96a3d8b1
Remove support for >>> and >>>= operators in dartc
...
http://code.google.com/p/dart/issues/detail?id=1166
Review URL: https://chromiumcodereview.appspot.com//9232041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3439 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 18:06:22 +00:00
fd3c2e8ab3
Issue 986: Static type warning when overriding static super members
...
http://code.google.com/p/dart/issues/detail?id=986
Truth table:
Super | static | instance
Local | |
---------+---------+---------
static | warning | error
instance | warning | warning
Ancillary adition: Warnings are now colored differently from errors to help
distinguish between the two.
R=zundel
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9186037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3435 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 15:38:29 +00:00
6b677ae576
Allow classes shadowed by type variables to be referenced in static context
...
We still print a shadowing warning, but if there is a valid reference outside
the variable is now resolved to it. Otherwise, we print the existing message
about not being able to reference type variables in a static context.
See bug: http://code.google.com/p/dart/issues/detail?id=643
Review URL: https://chromiumcodereview.appspot.com//9250017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3434 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 15:12:26 +00:00
2adbd94f14
Revert the revert of http://code.google.com/p/dart/source/detail?r=3360 .
...
Kasper found and fixed the underlying native class code generation bug as part of http://code.google.com/p/dart/source/detail?r=3390 .
TBR=kasperl,floitsch
Review URL: https://chromiumcodereview.appspot.com//9255025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3412 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 20:07:49 +00:00
6ad2499dbd
Issue 933: Fix for resolving type of Function in field.
...
http://code.google.com/p/dart/issues/detail?id=933
R=zundel@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9186015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3410 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 19:35:52 +00:00
ac0e22f2bc
Fix dartc in optimized mode (broken in r3358).
...
Add checks that ensure that keys used for array access are integers.
Fix bug in the optimization strategy that ended up generating the wrong
code for "native" classes.
R=floitsch@google.com ,mmendez@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9250005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3390 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 12:44:47 +00:00
6dfce3cc04
Revert "Remove TypeToken as means for assigning type arguments to arrays."
...
This reverts commit r3356. Apparently closure will optimize new Array(x) to Array(void 0).
Review URL: https://chromiumcodereview.appspot.com//9178020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3360 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 15:34:53 +00:00
513d5b44d5
Remove TypeToken as means for assigning type arguments to arrays.
...
For native, classes with a bodyless constructor, pass the constructor arguments to the native constructor in the generated factory method. The generated factory method will handle setting the runtime type information if necessary.
Review URL: https://chromiumcodereview.appspot.com//9183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3356 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 14:55:26 +00:00
353443aa53
Issue 1171: Failing to regenerate deleted output js file.
...
https://code.google.com/p/dart/issues/detail?id=1171
Basically: if no files have changed, check for out of dateness on the build
file to decide on continuing or not.
R=scheglov
BUG=
TEST=
Review URL: http://codereview.chromium.org//9211014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3308 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 20:46:49 +00:00
scheglov@google.com