901d01a45c
[ddc] Fix the use of the wrong null literal
...
This code should be using a `LiteralNull` from the JS AST but was
accidentally using the `NullLiteral` from the Kernel AST.
Add a test to trigger this code path in the expression compiler
because there must not be a source location for the code being
compiled.
Add a retry duration for getting a chrome tab in the test suite.
This fixes a failure I was seeing when I run the test locally.
Change-Id: I6900ace6280f1105c77ccafce4f47d0fc5771d6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252540
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-07-25 19:22:49 +00:00
3526954466
[ddc] Update content-length to not be negative
...
The null safety migration changed the 'content-length' from null to
-1 but a separate change at the same time disallowed negative
values.
Now returning what the 'content-length' would be if the request was
a GET.
Fixes: https://github.com/dart-lang/sdk/issues/49483
Change-Id: I2ba3ce1fb604c0fac50f354f56b3d29de6465caa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252005
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-07-21 00:45:35 +00:00
2f39f86198
[ddc] Migrate last tests to null safety
...
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I972864df3d5f036a19d3731052e4d5369c399ae7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250340
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
2022-07-18 23:04:44 +00:00
d795274248
[ddc] Migrate module symbol tests to null safety
...
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I168a02faeb2288430f4daa998a294ab6bd970031
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250321
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-07-18 21:59:43 +00:00
38dc4ed707
[ddc] Migrate expression_compiler_worker
...
Migrate library and tests to null safety.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I6657ebdeda7c9b4650cc6286229d2f4babdca5be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250260
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-07-18 21:14:53 +00:00
3fc0bf7e59
Retire the 2.17 language feature experiment flags.
...
Remove them from tests.
(They should have been removed from tests before launcing 2.17.)
Change-Id: I546f6cb90fdf9e6ed1bb560f3715f9db163b7c68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250384
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2022-07-11 13:02:22 +00:00
0f2e021da8
[ddc] Fix non-null assertion crash
...
`VariableDeclaration.name` could be null when the variable
was synthetically introduced by the compiler. In this case the
expression compiler can ignore the variable because it's value
doesn't reflect the value of a variable in the original dart
source code.
Add a regression test for the expression compiler that
ensures code that introduces a synthetic variable will not
cause a crash when you stop at a breakpoint.
Fixes: https://github.com/dart-lang/sdk/issues/49373
Change-Id: Ifc5f72ab4e5733ead17a20889c222bcc46921f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250343
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-07-01 16:15:53 +00:00
b4e2012f5b
[CFE] Remove support for .packages file
...
This CL:
* Removed the redirect from .packages to .dart_tool/package_config.json
(whenever such a file existed).
* Removes support for the old format entirely.
* Updates all tests etc that were found.
Fixes https://github.com/dart-lang/sdk/issues/48939
TEST=Existing tests updated.
Change-Id: Iccf711c455ac1885189aa773ca74dd8f55012964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248603
Reviewed-by: Michael Thomsen <mit@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2022-06-24 08:20:39 +00:00
f1d2813f12
[ddc] Migrate more tests to null safety
...
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I7f27810c0ca825ea777e6c6bfcade6a8ee2b06e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249065
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-06-22 22:05:25 +00:00
4c5a046f9d
[ddc] Migrate sourcemap and stacktrace tests
...
- Migrate suites and test files to null safety.
- Fix previous migration of sourcemap_testing to ensure list of
expected stops could include null values.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: Idd3b0937942cef18ae66d35137230437e1e971a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249063
Reviewed-by: Mark Zhou <markzipan@google.com >
2022-06-22 22:05:25 +00:00
9b9bfc34e9
[ddc] Migrate tests to null safety
...
Migrate the tests for expression_compiler.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I075787dff4ad33d13115b66170bf89260a52015f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248949
Reviewed-by: Mark Zhou <markzipan@google.com >
2022-06-22 22:05:25 +00:00
3f104a2ab4
[ddc] Migrate command to null safety
...
Revert small diffs introduced in earlier migrations to avoid an
import of command.dart before it was migrated.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: Ia728fd727417fd4fdf8c454a0044e096e9de5756
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248948
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-06-22 21:30:16 +00:00
6366fddf12
[ddc] Migrate expression_compiler to null safety
...
Migrate the test file that is unblocked.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I65598f5837115d7dce1c51389bb7c762c1ce451e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248884
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-06-22 21:30:16 +00:00
c52dd252f8
[ddc] Migrate nullable_inference to null safety
...
Also migrate the test file and temporarily inline some path
generation logic to break import of command.dart until it is
migrated.
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I50c158729346f3e31059241b90008ba861a65422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248341
Reviewed-by: Anna Gringauze <annagrin@google.com >
2022-06-22 21:30:16 +00:00
f80ad75e76
[ddc] emit full dill as part of modular tests.
...
This small change brings the modular test closer to the behavior we have
internally in our bazel rules.
Turns out that recently we discovered a bug in the static erasure
transformation when emitting the full dill generated by DDC. This change
will allow us to detect these kind of failures in our SDK repo as well.
Change-Id: I9032d2563f741692ae03035b9fc9be59ab4b3a38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247761
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2022-06-09 19:34:48 +00:00
d50097a4ec
[ddc] Break import cycle in shared_command.dart
...
Reduces the number of libraries that must be migrated to null safety
atomically.
Change-Id: I498f2956471be0435558c1b1a4badcba619f15de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247521
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-06-09 16:55:45 +00:00
ec1fa84691
[web] Enabled lints and cleanup violations
...
Change-Id: I1b559215cd8b55fca2b247d4279bef8b61f653b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243700
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-05-24 23:59:16 +00:00
5ecebdbddd
Update d8 to 10.4.31
...
The length limit for array.init has been bumped to 10,000 elements.
This gives dart2wasm more breathing room to create large constant lists,
maps and sets, until a more general mechanism for large constant arrays
in WasmGC has been decided and implemented.
Change-Id: I267ed7919bed4509481f37d453f2335dc51bb37c
Cq-Include-Trybots: luci.dart.try:dart2wasm-linux-x64-d8-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245373
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2022-05-20 16:49:42 +00:00
44f8583425
[ddc] Migrate modular test suite runners to null safety
...
- Migrate the test runner suites to null safety.
- Cleanup old "non-nullable" experiment flags
- Force null safety mode in the two suites:
- modular_suite.dart: weak null safety
- modular_suite_nnbd.dart: sound null safety
NOTE: in both cases the source code is treated as null safe code.
There are no tests written in a legacy dart version.
Change-Id: I19ec25f7b5abc712971771a193c02ebd5283b987
Fixes: https://github.com/dart-lang/sdk/issues/43096
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244500
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-05-13 19:10:56 +00:00
3c231e4f57
Read package_config.json in more tests
...
Towards #48275
R=mit@google.com
Change-Id: I38cc986937543c5e4d1f2a2cd4c7804d180a2741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244304
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Michael Thomsen <mit@google.com >
Auto-Submit: Nate Bosch <nbosch@google.com >
2022-05-11 18:58:44 +00:00
441a762352
[modular_test] no longer generate .packages within modular test suites
...
Since the null-safety test migration we've been generating both a .packages file
and a package_config.json file. This deletes the use of the old .packages file
and updates all references to use the new file.
Change-Id: Iecef64ac8ed8579338795ad5327765118d643236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240650
Reviewed-by: Joshua Litt <joshualitt@google.com >
2022-04-09 00:35:13 +00:00
b1fbe0c01d
[dart2js] Support running modular analysis alongside building a dill.
...
Change-Id: If10385445c5f6267e2de20b090b37e1741b7ace7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237925
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2022-03-30 23:59:00 +00:00
ba4e18b531
[ddc] Remove more diffs with pkg/js_ast
...
- Remove lint ignores and cleanup violations when they are either
in code that doesn't exist in or are already fixed in the pkg/js_ast
version.
- Migrate the builder_test.dart (the small test file).
Issue: https://github.com/dart-lang/sdk/issues/46617
Change-Id: I1083235de93f028e5f338180b97308f52a45f17f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239363
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-03-30 19:53:30 +00:00
d2882856ef
lints 2.0 fixes
...
In anticipation of lints v 2.0.
See: https://dart-review.googlesource.com/c/sdk/+/237746
Change-Id: If6ec7f0bae314af3aa84e4d8a7b9fc1b8219c128
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237763
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2022-03-18 01:42:47 +00:00
f83b5c251d
[ddc] Update the test that declared a custom 'index' in an enum
...
Landing of https://dart-review.googlesource.com/c/sdk/+/237365 made
the test fail due to a custom declaration of a member named
'index'. This CL adjusts the test, removing the declaration.
Change-Id: I8f967a6ec473cb1aac8690d740d90647e01bc55f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237584
Auto-Submit: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2022-03-16 21:28:44 +00:00
ea0ecbd78a
[ddc] Add expression evaluation tests
...
- Add tests for calling constructors that use super parameters.
- Reorganize tests for 2.17 language features into their own suite.
Going forward this will keep each test smaller and hopefully avoid
timeouts on the test bots.
Change-Id: Ia6056b497fe342c5ddaabb90d212b976dda3d5c5
Fixes: https://github.com/dart-lang/sdk/issues/48065
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235981
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-03-09 17:30:14 +00:00
e68c3e8bc8
[ddc] Adding expression eval tests for enums and enhanced enums.
...
Change-Id: I90881f00866ed8099142b0d1f9335aa49a8b7c26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233527
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2022-02-25 18:03:02 +00:00
2b3595ff97
[ddc] Add named-arguments-anywhere tests
...
- Plumb through language experiment flags.
- Add expression compiler tests for the
named-arguments-anywhere feature.
Change-Id: I3c28247343a858978e8d420b73f38b498bce66d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231361
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-02-22 23:29:32 +00:00
7f026d6e46
[dev_compiler] remove the dep on package:cli_util
...
Change-Id: I34c17dc76a0c608ac3536bfdf2c0e39bb8daa6c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232424
Auto-Submit: Devon Carew <devoncarew@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-02-11 00:50:31 +00:00
33e174084a
Replace Uri.scheme == with Uri.isScheme
...
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.
TEST=No behavior changes.
Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nate Bosch <nbosch@google.com >
2022-02-08 21:38:57 +00:00
b1b9378f6b
[ddc]: fix worker_test to run in windows
...
Change-Id: I882654acf1cdf67cec64efa9c4fdb3ecaba83b50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230826
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-01-29 00:45:22 +00:00
93e87899f4
[ddc] delete unused/unsupported internal scripts to run ddc.
...
All internal development uses pkg/dev_compiler/tool/ddb instead
Change-Id: I1a3cd9cef48063be16b2aa0c3bcb950e4c2b248d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229305
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2022-01-27 21:13:41 +00:00
8ac87895fe
[ddc] Migrate AssetFileSystem to null safety
...
Change-Id: Icf79bb882a863e333cc30620a1b0a5154763cdd0
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/223280
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2022-01-10 21:58:03 +00:00
427c83345a
[ddc] Enable null safety in module_symbols library
...
Also migrate the library test and the module_symbols_collector library.
Change-Id: Id00ac050e8f36ed7016b6d1d49b10fa4297aaeb6
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216760
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-12-10 18:51:30 +00:00
976cffc4c2
Use strict-casts in js and dev_complier
...
strict-casts is mostly a drop-in replacement for the deprecated
`implicit-casts: false` option. One big difference, seen in this CL, is that
strict-casts will report a non-Iterable (or non-Stream) in a for-each loop.
Change-Id: Ibc463ae9c870b6a795483c5dea0d2b856e7fd883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221546
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-11-29 23:22:44 +00:00
87c953bd0c
[cfe] Pass class hierarchy and core types through IncrementalCompilerResult
...
TEST=existing
Change-Id: I78a61147998a630d88997e0cebccb3e815592822
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221088
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2021-11-25 11:27:29 +00:00
e92e60da78
[cfe] Change computeDelta to return a result object
...
This prepares for returning more that just the component from an
incremental compilation.
TEST=existing
Change-Id: I3ee269083290097f1a92d77d105b607a6a02f1f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221086
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2021-11-25 10:15:07 +00:00
e4c63ce59f
[ddc] Use same options when emitting module and JS
...
In the test suite, the options passed to the two phases of the
compile drifted apart. Some were false when compiling the module
but true when printing that module as Javascript. This surfaced
when some unused portions were migrated to null safety.
Change-Id: I2d5c648bc53e5c9fe3f014446393d0f893bd5382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218181
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-11-10 23:12:56 +00:00
cc7fcb5f70
dev_compiler: migrate to pkg:lints
...
Change-Id: I0111e74d312f6d3aeebb80f017a4f48fc6186109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218220
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
2021-10-27 23:15:56 +00:00
e7faaaf85d
[ddc] Surface compile time errors in tests
...
- Module symbols tests now surface compile time errors from the
code under test.
- Fix errors in the code being tested.
Change-Id: Ica549c710f41ee22ac784fba99f9e12be664ac5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217024
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-10-19 22:18:33 +00:00
f9c68a5679
Replace a bunch of references to .packages
...
Most of these arguments are flowing through to a `--packages` argument
which allows passing the `package_config.json` file. In the long term we
should remove the `.packages` file entirely.
TEST=None, the change should have no visible impact.
Change-Id: I60a8b175d5e217a85588bbcb91cc5095514066b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211503
Auto-Submit: Nate Bosch <nbosch@google.com >
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-10-12 20:16:15 +00:00
198dc43075
[ddc] Migrate module_metadata to null safety
...
* Migrate the library and tests.
* Update comments per effective dart recommendations.
Change-Id: Ibc8da1fe68c977fb3c084208b96734354ad2705b
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215122
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-10-05 22:57:42 +00:00
ea4302d029
[ddc] Add constructor symbol information
...
- Adds tests for various types of constructors.
- Recognize when a constructor is const and mark the class symbol
accordingly.
Change-Id: I9ae7fc2837a6821b196f06a267603fd18c3e5075
Issue: https://github.com/dart-lang/sdk/issues/40273
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208362
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-10-01 22:57:09 +00:00
bb4e445b6e
[ddc] Add expression evaluation tests
...
* Tests constructor tear off values and calling torn off constructors.
* Covers default, named, redirecting, and factory constructors at break
point locations in a method, global function, and inside the default
constructor.
* Create new test suites for legacy code (Dart language version 2.11)
in amd and ddc module systems.
* Sound and Unsound suites now run code without a Dart language comment.
Change-Id: I9cf16c258ce6ece7c436f9deb044ed821f980d1b
Fixes: https://github.com/dart-lang/sdk/issues/47214
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214866
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-09-29 19:33:32 +00:00
6c4593929f
Reland "[ddc] Add web library environment variables"
...
This is a reland of fb36bba5f2https://github.com/dart-lang/sdk/issues/47207
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213802
> Commit-Queue: Nicholas Shahan <nshahan@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
Change-Id: Id88aeaf0ddc783936d413c06099df031bc7cb0a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214224
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-09-22 23:47:40 +00:00
d0e013b49a
Revert "[ddc] Add web library environment variables"
...
This reverts commit fb36bba5f2https://github.com/dart-lang/sdk/issues/47207
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213802
> Commit-Queue: Nicholas Shahan <nshahan@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
TBR=johnniwinther@google.com ,nshahan@google.com ,annagrin@google.com
Change-Id: Iedfc4c1a5b24b515646d4f1b486bcb2f19bb7783
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214222
Reviewed-by: Anna Gringauze <annagrin@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-09-22 21:33:26 +00:00
fb36bba5f2
[ddc] Add web library environment variables
...
Ensure frontend server builds for the `DevCompilerTarget` add the
environment variables needed for `bool.fromEnvironment()` calls for
conditional imports.
Change-Id: Ifd372c1cf385fc843534d85af1ac9ae75a6285b8
Fixes: https://github.com/dart-lang/sdk/issues/47207
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213802
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-09-22 20:39:44 +00:00
d6f0e39f30
Remove redundant import from dev_compiler
...
Bug: https://github.com/dart-lang/sdk/issues/44569
Change-Id: Iab83d15b0f6c5448b75881fcba8c8ea177feab71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213852
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2021-09-20 16:37:41 +00:00
df4671a77a
Split expression compiler worker tests
...
Expression compiler worker tests sometimes reach the timeout limit
on CI machines, split them into two batches.
Closes: https://github.com/dart-lang/sdk/issues/45484
Change-Id: I502de5d768f29be862e593379e3a906ec6c21eb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213734
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Anna Gringauze <annagrin@google.com >
2021-09-17 20:28:41 +00:00
211ad9acb1
[CFE] Don't mark procedures as async when not using await
...
This CL removes async markers where await wasn't used.
In a few cases this also meant the ability to make the procedure not
return a future at all.
Also - at least on the VM with my benchmark run on my PC - returning
new Future.value(whatever) in a non-async procedure is faster than
returning whatever in an async procedure.
TEST=CI and existing tests.
Change-Id: I4ba888313c87de76bb0ca02c19eb1ab45f168a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213480
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2021-09-17 11:56:29 +00:00
Nicholas Shahan