dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
87,312 Commits 2 Branches 0 Tags
e09493b7bc80098b5e71c9b2f34ee8da1fc7c160
Commit Graph

8251 Commits

Author SHA1 Message Date
Konstantin Shcheglov 126d79e27a Use named parameters for a few AST nodes. 
Change-Id: Iee8edcca9ae38e34e39a4156d5488f53fecbf0ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-21 15:45:56 +00:00
Konstantin Shcheglov 1aa398d4be Report EXPECTED_NAMED_TYPE_X when not a NamedType is parsed. 
Change-Id: Ibebc276777075da12e36642f08291fa9a9f9ac91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-21 02:24:45 +00:00
Konstantin Shcheglov 1ad52e061a Test for Expression.inConstantContext when the expression is RecordLiteral. 
Change-Id: I1330b966296e9521bdb0d5e576cd1a63f2c5fbdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-20 21:31:35 +00:00
Konstantin Shcheglov eb00d038c7 Update Expression.inConstantContext to support RecordLiteral(s). 
Change-Id: I02c3692c359e65822d30a4e931b14dec5963fef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-20 20:32:55 +00:00
Ahmed Ashour 6e03189e2b [analyzer] fix diagnostics for lints map 
Fixes #49651

Change-Id: I87b14e407e699da8b9247eed93d957e2ba12e22d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257520
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 17:11:35 +00:00
Ahmed Ashour f92aaae20c [analyzer] UNUSED_RESULT to handle PrefixExpression 
Fixes #49975

Change-Id: I30d08994b214b5bb453b45ca4ef98c45cebc22a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259589
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 16:30:25 +00:00
Konstantin Shcheglov 139344eb28 Support for RecordState in DartObjectPrinter. 
Change-Id: I44481daa436916841620491529178036fc46456a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-20 16:05:05 +00:00
Konstantin Shcheglov 81efd79749 Support for RecordState in DArtObject.getField() 
Change-Id: I095ee40e69617b0a45c1bcb493ef4891dbef4138
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-19 23:56:41 +00:00
Konstantin Shcheglov 9618bd7e6d Remove 'SimpleIdentifierImpl name' from AST impl, use Token directly. 
I removed factory methods that are already unused, and update other.

Ideally we should use Token(s) in AstBuilder as well, but it was too
complicated right now, so I will try doing this later.

Change-Id: I2dcfa0b419818ba551401cd08b7c496ebb90c840
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-17 17:33:51 +00:00
Konstantin Shcheglov 41fecd5394 Tweak for UP() for record types. 
Change-Id: Iefbbfdaee2a90c2987d54d7d10aa202cef8577f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259516
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-16 22:40:11 +00:00
Ahmed Ashour 5d0cdc12b0 [analysis_server] rename to handle private named parameters 
Fixes #49872
Change-Id: Ied484a817713a922133fed070e6703f57336ffb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257102
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-16 20:53:30 +00:00
Konstantin Shcheglov 8ebb7d70e5 Issue 49951. Fix SearchedFiles to avoid adding unrelated files to known. 
Bug: https://github.com/dart-lang/sdk/issues/49951
Change-Id: I66bd8c18c45ae8c0cde163ea094794a56599acc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259504
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-16 19:56:00 +00:00
Paul Berry a87935780e Tolerate improper operator declarations when analyzing compound assignment. 
We need some defensive coding here to avoid an analyzer crash.

Fixes #46569.

Bug: https://github.com/dart-lang/sdk/issues/46569
Change-Id: Ie51f7279af71ee36b94ad14e928b359288bc09e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259242
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-15 22:05:19 +00:00
Konstantin Shcheglov dc0dbb01f8 Make NodeListImpl not resizable, update AstBuilder. 
Change-Id: I1930b5fe863788198b5d88c0a08828980d935359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259103
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-14 20:12:12 +00:00
Konstantin Shcheglov 3945c9aa71 Use builders in AstBuilder to build ClassDeclarationImpl, etc. 
Relatved to https://dart-review.googlesource.com/c/sdk/+/259020

The goal is to avoid the need to update NodeListImpl.
I'm not 100% sure that we can fully achieve this, there is at least
one more place with switch / case.

Change-Id: Ic7468a7b9ded817b3315902cefdeaa7428ec6857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-13 18:30:27 +00:00
Konstantin Shcheglov f513115097 Use named parameters for a few AST implementations. 
Change-Id: Id6a5f4f547d9e7ef98925168cc8caa9ebc67cab4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258514
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-10 23:00:05 +00:00
Konstantin Shcheglov f58e9abf12 Use named parameters for a few AST implementations. 
Change-Id: I4dcc9dc48c7c4718dff16f01a582f2865a655307
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258502
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-09 16:59:44 +00:00
Brian Wilkerson 1e4d26b977 Add visitor support for pattern nodes 
Change-Id: Ifaef899d0b34e3d72796afbe09a1e49306dd1038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258506
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-09 16:58:05 +00:00
Konstantin Shcheglov 680a23c534 Use named parameters in 'for' related nodes. 
Change-Id: Id3ae04f383da65780157065278a692b2a654bddd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258500
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-09 00:36:57 +00:00
Brian Wilkerson f1d4d2be26 Fix exception for function type in unexpected places 
Closes https://github.com/dart-lang/sdk/issues/45565

Change-Id: I21089bd5194ab563a4cf205d3a7d0a58510345ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-08 14:08:53 +00:00
Danny Tuppeny b5c7af0417 [analysis_server] Don't search the same files multiple times when referenced by multiple drivers 
See https://github.com/Dart-Code/Dart-Code/issues/4106#issuecomment-1239564686.

Change-Id: I6fa86c9fe76e7410cbb00f31798ba3f1961e98ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 21:55:02 +00:00
Konstantin Shcheglov 6f0fe880c4 Breaking changes for analyzer version 5.0.0 
Reland of https://dart-review.googlesource.com/c/sdk/+/243164

Change-Id: I5167844ea1001f026cf8d9b82465a79f560d188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257267
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 16:27:18 +00:00
Konstantin Shcheglov 6546d85c50 Disallow subtyping class Record. 
Change-Id: I5f71e47cc0c60444cf0c7baebb4e9e9d3f105ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-06 21:04:56 +00:00
Konstantin Shcheglov 5c800a62cf Resolve assignments to RecordType fields. 
Change-Id: I961bbda7c0f1d9423624a58d02a81b53340256c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-06 18:53:26 +00:00
Ahmed Ashour 63f69b4756 [analysis_server] add a quick fix for some AnalysisOptionsHintCode 
Fixes #49513

Change-Id: Ib4a1b68c95c2f379e8cbdaf62b2b17bf0a25e7b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 18:26:46 +00:00
Konstantin Shcheglov 6484fa91ab Test that class references are indexed / searched / renamed in record type annotations. 
Change-Id: I29d9645c2509829e9dd8ba44ded7b38bbab217e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-06 17:24:06 +00:00
Ahmed Ashour 5cacf6636b [analyzer] ensure parameters are matching in messages.yaml 
Fixes #49857

Change-Id: Ifa0fe6e2ee4d51b55e13908f7a109173718dc1dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:24:17 +00:00
Sam Rawlins 1089fa528a Remove unused code in analyzer tests 
Change-Id: I791d3f53916f164b3ae061b894b35799146675ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-09-06 14:45:37 +00:00
Sam Rawlins b9a0205004 Move code from yaml_test to analysis_options_provider_test 
These 4 functions, declared in yaml_test, were unused in that file,
but were imported by analysis_options_provider_test. They are
otherwise unchanged.

This was discovered by the new unreachable_from_main lint rule.

Change-Id: I1b0e1548e641ca44222192530d58e2f743d36e17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257482
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 14:38:24 +00:00
Brian Wilkerson c191725dee Test that record types work correctly in outlines 
I don't believe there's any way for record literals to show up in the
outline, and I think this is a reasonable representative sample, but if
you think more tests would be better, let me know.

Change-Id: Ia62ad30d860d70a483249879f2ae8bea8e65b6a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257442
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-06 14:26:26 +00:00
Konstantin Shcheglov d07005b4a2 Issue 49106. Update the context type for index in read/write. 
Bug: https://github.com/dart-lang/sdk/issues/49106
Change-Id: I522269360c6664ac4a9129cb71bf378c9dfca812
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256647
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-01 16:24:52 +00:00
Konstantin Shcheglov ff8024fc78 Revert "Breaking changes for analyzer version 5.0.0" 
This reverts commit d8df88cbe4.

Reason for revert: breaks Flutter HHH, requires updates to linter

Original change's description:
> Breaking changes for analyzer version 5.0.0
>
> Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I6ca213427189c169ddacbd89f60d463efa2c38f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-31 21:05:19 +00:00
Konstantin Shcheglov d8df88cbe4 Breaking changes for analyzer version 5.0.0 
Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 05:08:50 +00:00
Konstantin Shcheglov 5a59b00da5 Comment out mismatch output in element_text.dart 
We have a few failing tests, so we would get output while running
tests.

Change-Id: I236f2a94ce4b893d9b5331020498fdaacd7ccb37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-31 00:20:28 +00:00
Brian Wilkerson a76d26545b Add const keyword in record literals to informative data 
I'm not sure how to test for this, but I'm guessing that we can't easily
test it until the parser is updated to parse the `const` token.

Change-Id: Iab1e2f7fd1965ebb2c29b1ef88869633a6a1b117
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256700
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 22:05:18 +00:00
Ahmed Ashour 17e0f87252 [analyser] add MISSING_DEFAULT_VALUE_FOR_PARAMETER_POSITIONAL 
Fixes #49816

Change-Id: I48f3c21fcf552e21da70cf12adf3671c3f490695
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256840
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 20:55:38 +00:00
Konstantin Shcheglov 9f7c26fe03 Issue 49842. Resolve 'call' simple identifier. 
Bug: https://github.com/dart-lang/sdk/issues/49842
Change-Id: Iccad2e6205915cc33fbc8a5d45e79d01c6ec8359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-30 19:07:54 +00:00
Brian Wilkerson 711ec5e387 Record the const keyword for record literals 
Change-Id: I0e85efa2634488a4c4f0529daf3a0e10a1ca06a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256922
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 19:00:02 +00:00
Konstantin Shcheglov 42ba276bbe Tests for one positional field in record type annotation and literal. 
Change-Id: I05cd1b31427e410682465dc06673fce93029c895
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-30 17:07:58 +00:00
Konstantin Shcheglov 8e4dc26b2a Issue 49842. Resolve call() invocation without a receiver. 
Bug: https://github.com/dart-lang/sdk/issues/49842
Change-Id: I44a274da4ca209b34710d6bfc3ae3d18ee62058c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256704
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 15:47:38 +00:00
Jens Johansen cec94a1446 [parser] Empty record types, record types with 1 element 
This should bring parsing of record types up-to-date with v1.6 of
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Also fixes https://github.com/dart-lang/sdk/issues/49826

Change-Id: I3737a72ddee49a957bd55f86cc200fb77f23e2a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256660
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-08-30 11:04:10 +00:00
Jens Johansen a4352d09e1 [parser] Record literals can be const and one-element only 
This should bring parsing of record literals up-to-date with v1.6 of
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Change-Id: If39bb1834137da55ef8bd1923106bbc614ea319b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256461
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-08-30 10:54:08 +00:00
Konstantin Shcheglov 999146d1eb Tests for 'contextType' in RecordLiteral fields. 
Change-Id: I1fd2f31c96658bf820097a19ec6a17e416af8908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-29 21:58:16 +00:00
Konstantin Shcheglov b99441e749 Issue 49844. Fix reporting DEPRECATED_EXPORT_USE when a library cycle. 
Bug: https://github.com/dart-lang/sdk/issues/49844
Change-Id: I67f4dda42d92932566162d4a70c1b5021ff2a683
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-29 21:27:36 +00:00
Konstantin Shcheglov a47a75d35c Resolve SimpleIdentifier(s) that reference RecordType fields. 
Change-Id: I735a32d1d4f83cca12dec3ac0c811d75644fd16d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256601
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-29 17:48:31 +00:00
Brian Wilkerson d40f06ee2a Partial constant evaluation for record literals 
Change-Id: I53db27f67ab1244b7e25a08002ae165840c7c012
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-26 21:53:21 +00:00
Konstantin Shcheglov dfc82df6f7 Store RecordLiteral(s) in summaries, for default value, initializers, etc. 
Change-Id: Ida4f9f4467cc951a167a6700ea0113c100107141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-26 20:50:42 +00:00
Konstantin Shcheglov 5a989a3161 Test that record types named fields like $0 still have different shape with positional fields. 
Change-Id: I991fc24a68025f1b01832e759d72c331fbf62d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256542
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-26 20:18:44 +00:00
Konstantin Shcheglov 5bb4ddd2f6 Resolve positional record field access in PropertyAccess. 
Change-Id: I1d2adf5188302a3c7548287e02973cbc2a288af8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256522
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-26 19:48:20 +00:00
Brian Wilkerson 088c346ed0 Add some tests of record type assignability 
Change-Id: Ic653447e3cb8fe8582131461d838c17e59f33fa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256428
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-26 19:11:01 +00:00