dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
87,312 Commits 2 Branches 0 Tags
e09493b7bc80098b5e71c9b2f34ee8da1fc7c160
Commit Graph

78 Commits

Author SHA1 Message Date
pq 3efd79b4b5 linter 1.26.0 
Change-Id: I0a20fd9f26933908f6c40cb1019fca45b9a88299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250949
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-07-11 20:00:21 +00:00
Brian Wilkerson 45d8c7ee4b Stop using main in test code in more places, part 3 
Change-Id: Ia35343f4d79037875fe154a38a3adcf8117d9369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-06 22:34:50 +00:00
Konstantin Shcheglov 994b2e2f47 Deprecate newAnalysisOptionsYamlFile2(), use newAnalysisOptionsYamlFile(). 
Change-Id: Ia86808f649459e6c4c9c7d4e488273c1e593a85b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241515
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 15:49:57 +00:00
Konstantin Shcheglov 20b560226e Rename newFile2() to newFile(). 
Change-Id: I1c2a4f15dee607a0a6241dfaf2d764a7d284389b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-19 02:59:57 +00:00
Konstantin Shcheglov 9ab676b6d0 Migrate analysis domain tests to PubPackageAnalysisServerTest. 
Change-Id: I684d027906b118d2c0fddd8f64930ae291ed8827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-30 17:01:00 +00:00
Konstantin Shcheglov 41b3e0abcc Make 'content' required in ResourceProviderMixin.newFile() 
Change-Id: Id697b0736b95a913c31247a66425027852f1ddc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-14 17:31:48 +00:00
Konstantin Shcheglov 6de7ea7432 Don't remove overlays immediately, wait for the next watch event. 
Change-Id: Ie3352bf70010de88874aea122d83a5533a00a1ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-14 17:21:28 +00:00
Konstantin Shcheglov 5fa65048c1 Use file_paths.pubspecYaml instead of 'pubspec.yaml' literal. 
WDYT ?

Change-Id: I6677b2237e0558c74bb11073dcfb44d7b672323f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-10 19:03:55 +00:00
Konstantin Shcheglov 1531030b42 Stop using newDotPackagesFile() in analysis_server/. 
Change-Id: Iaa4e8657ee1d5f115ab62177570aa662494b9d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-09 23:56:15 +00:00
Danny Tuppeny 650b9627b7 [analysis_server] Rebuild analysis contexts if changes occur between creation and watchers being ready 
See https://github.com/Dart-Code/Dart-Code/issues/3438.

Change-Id: I3ca038d8c878b118a465b6f230c62912d63990eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 00:18:41 +00:00
Konstantin Shcheglov fe35fdd2c5 Use newAnalysisOptionsYamlFile() where possible. 
Change-Id: I4b550cac941b6686738722cbcd3d04dfaabe5cdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-06-09 23:57:29 +00:00
Konstantin Shcheglov faa0528eef Use newDotPackagesFile() where possible. 
Change-Id: I74fc911e7da7ebfb9e1341791258d8c9a40d7324
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-06-09 18:07:12 +00:00
Brian Wilkerson 02d50e7ebf Migrate several test classes 
Change-Id: I7477d5c42a8c2f953c51aca7ab6fff8b6fc930f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-19 00:38:19 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Danny Tuppeny 77353dc380 [Analyzer] Allow files inside .dart_tool to be analyzed when modified 
These files were already analyzed at startup but not when modified. This meant code generated by flutter_gen would not update unless the analysis server was restarted/the project was reanalyzed.

Fixes https://github.com/Dart-Code/Dart-Code/issues/3074.

Change-Id: If0c88c1e5ab7e796046e7e776a42c3d904944405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179776
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-27 20:37:25 +00:00
pq 97ad2d69af re-land pubspec analysis 
Change-Id: I047687f2b64bfdc149bfde2fed6dc8f5d722e7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-10-12 14:43:52 +00:00
pq c21b906182 disable pubspec linting 
Disables the fix in https://dart-review.googlesource.com/c/sdk/+/164249 pending a fix to `sort_pub_dependencies` which is producing a false positive that is blocking the Flutter engine roll.

See: https://github.com/dart-lang/sdk/issues/43529
See: https://github.com/dart-lang/linter/issues/2271

Change-Id: Ica6262153b89259ba67b5a43eeeafe2bdd482b44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Field <dnfield@google.com>
 2020-10-08 19:39:55 +00:00
pq 71d2e6de69 lint diagnostic reporting for pubspecs 
See: https://github.com/dart-lang/sdk/issues/43529

Change-Id: Iaf05102b3f6473913d900286c31779cdb1d59926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164249
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-05 15:35:25 +00:00
Konstantin Shcheglov d219bde703 Enforce await_only_futures and fix violations (in more packages). 
Change-Id: I1812f7721915178e42956f988b9276bf8db0bfaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-24 16:58:50 +00:00
Brian Wilkerson 96d1b25486 Report errors in the data-driven fix data file 
Change-Id: Iaaa29d339d4c007f93bcc924f62e0f36471fe10c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162945
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-15 22:55:31 +00:00
Danny Tuppeny b613265c85 [Analyzer] Reanalyze analysis_options when .packages changes 
Fixes https://github.com/dart-lang/stagehand/issues/619.

Change-Id: I30022215b23de2b690b5cde95c9dd256a9ef83d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160068
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-25 15:03:29 +00:00
Konstantin Shcheglov ba92b78acd Move errors from StaticWarningCode to CompileTimeErrorCode. 
Bug: https://github.com/dart-lang/sdk/issues/42821
Change-Id: I153c48d7a2e4a02026928e6203aacf8f2dc029ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-26 04:19:25 +00:00
Danny Tuppeny 0aed132f4d Don't send analysis errors for ignored files 
Bug: https://github.com/dart-lang/sdk/issues/36064
Change-Id: Ic12aa70d7ca287c4a8db7915c10dde5da2e2137c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-21 15:44:28 +00:00
Konstantin Shcheglov 00fa48fbb1 MockSdk does need to create summary. 
Change-Id: Id62bc99394e9afd6306ba6a12118d7bcd045a598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-27 19:39:10 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Keerti Parthasarathy 8329bd7ca8 Do not check for '.analysis_options' for default options file in builder. 
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-09 19:31:24 +00:00
Brian Wilkerson 8efdee06d6 Begin adding return types in analysis_server 
Change-Id: Id0daa52236bdc90cba6bfd7cf81d1b4cf47603c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-28 21:18:30 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Danny Tuppeny 0450462503 Improve sending/flushing of errors for files in dot folders 
Ensure errors are only sent when there is an appropriate time to flush
them (plus ensure if of those places flushes them).

Fixes https://github.com/dart-lang/sdk/issues/33778.

Change-Id: Ieb4a2631c24649ba013eda93808b003b0e2ddb95
Bug: https://github.com/dart-lang/sdk/issues/33778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-05-09 14:44:23 +00:00
Devon Carew 14d09498b7 [analyzer] don't traverse into dot folders when analyzing android manifest files 
Change-Id: Ic0797064bc4209c597afb080adc050bf4a4c1f2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100569
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-04-26 15:14:39 +00:00
Keerti Parthasarathy 1f1592edce Add manifest checks for touchscreen feature 
Change-Id: Ib849eccdbad6f41e22dbffeca755099cb3926f8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100160
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-23 00:32:54 +00:00
Brian Wilkerson 32f5223119 Search all directories when attempting to analyze manifest files 
Change-Id: I3a900362d8d36d27e5c22f600db7bc54059c7717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-16 00:45:32 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov 79eb965d8f Replace FileContentOverlay with OverlayResourceProvider in AnalysisServer. 
R=brianwilkerson@google.com

Change-Id: Ic2fc13f4eacd94471fc8dccc1102e6fdbe59342d
Reviewed-on: https://dart-review.googlesource.com/c/86785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-12-10 21:00:57 +00:00
Konstantin Shcheglov 1f52372bfa Remove CFE integration from analyzer, analysis_server, and analyzer_cli. 
AnalysisDriverResolutionTest is partially updated, about 30 failing
tests added. I will get back to it in a following CL, it is not
directly CFE integration, but updated understanding how we want to
resolve. For example we don't need types for non-expression identifiers.

Change-Id: I3daddbb6c66ffad7a726f3313a1199fd7387aa04
Reviewed-on: https://dart-review.googlesource.com/71883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-08-29 13:46:45 +00:00
Konstantin Shcheglov 1b8f3026bf Remove most of isStrongModeError: false, update language_2 tests. 
https://github.com/dart-lang/sdk/issues/33022
https://github.com/dart-lang/sdk/issues/28823
https://github.com/dart-lang/sdk/issues/11124

Change-Id: I44427cdab25aae356ec89d677fa142d23d7b42c7
Reviewed-on: https://dart-review.googlesource.com/71428
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-08-29 02:06:45 +00:00
Brian Wilkerson f169ebf418 Fork several server tests to run under CFE 
Change-Id: I9ca4184dc5458304f3f1597681fc1c936972d8bd
Reviewed-on: https://dart-review.googlesource.com/67880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-01 20:18:40 +00:00
Brian Wilkerson ea94e65b43 Make preview-dart-2 imply strong-mode 
Change-Id: Ifa230f9e64a538e222557ea471dc728ad3dd01d7
Reviewed-on: https://dart-review.googlesource.com/46300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-03-13 17:15:39 +00:00
Danny Tuppeny 40e3f9addc Convert paths for mock SDK libraries to fix tests on Windows 
The other lines on this method are calling `provider.convertPath` around their paths but these ones do not, which is causing almost all analysis server tests to fail on Windows (for me - I can't explain them not
failing builds). This causes the hard-coded paths like `/lib/core/core.dart` to be fixed up to `C:\lib\core\core.dart` which is what the server is looking for (because at the other end the paths *have* been fixed up).

See #32226.

Closes #32230
https://github.com/dart-lang/sdk/pull/32230

GitOrigin-RevId: 1adeee23f8ac8efc8acf61caf5f769e4ec44c030
Change-Id: Id9bf195967db0912c6f4b67bd79d504e627b8aab
Reviewed-on: https://dart-review.googlesource.com/42300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-02-20 18:55:38 +00:00
Paul Berry 105b170ddb Roll package test to 0.12.29+1 and stack_trace to 1.9.0 
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue().  Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.

This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.

Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-07 14:22:23 +00:00
Brian Wilkerson 1d8a5d77c1 Convert more tests to use ResourceProviderMixin 
Change-Id: Ia4cce51e33c79c82a989bfda9b8303dfaa72e103
Reviewed-on: https://dart-review.googlesource.com/31880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-01-02 00:47:34 +00:00
Brian Wilkerson 4ecd8f7213 Enable the analysis of pubspec.yaml files in server 
Change-Id: I97c66b357d624cdcd6259c099b6421eb87c317c5
Reviewed-on: https://dart-review.googlesource.com/31404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-12-24 17:20:42 +00:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Brian Wilkerson 9ddb832e10 Generate constants in server as we do in plugin 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2960073002 .
 2017-06-28 08:21:33 -07:00
Brian Wilkerson 1e9ae646ff Clean up some hints 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939723002 .
 2017-06-13 09:24:50 -07:00
Brian Wilkerson 65d05524ce Remove some unnecessary tests for non-driver mode 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2935733003 .
 2017-06-12 11:31:09 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
 2017-05-15 09:35:46 -07:00
Brian Wilkerson 27f9e5e4ce Reverse the sense of the flag to make it easier to find test that need to be converted 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884593003 .
 2017-05-15 08:40:40 -07:00
Brian Wilkerson 863bd921e1 Remove the non-driver versions of several tests 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2863593004 .
 2017-05-05 13:46:03 -07:00