dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
87,312 Commits 2 Branches 0 Tags
e09493b7bc80098b5e71c9b2f34ee8da1fc7c160
Commit Graph

26 Commits

Author SHA1 Message Date
Brian Wilkerson e0820bb508 Enable the prefer_function_declarations_over_variables lint in the analysis server 
Change-Id: I53a6cd3c5d3be1c66173f52a7f01d8df63fd9350
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249727
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-06-27 18:27:23 +00:00
Danny Tuppeny 00ca3283c0 [analysis_server] Correct sorting of fixes, inverting priorities to maintain order 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3646.

Change-Id: I9784bbda8aa62d3506810fc7768d58a4cd2bf064
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-11-08 19:55:02 +00:00
Brian Wilkerson 34873853d8 Migrate some of the plugin support in server 
Change-Id: I1294a33725ff0d0c3d2eb981c23211a8576f60f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194023
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-04-04 00:23:39 +00:00
Konstantin Shcheglov e97f1bdbf0 Switch analysis_server to language 2.12, so null safety, but opt-out files. 
This should allow doing partial migration, specifically protocol files,
which are imported by other libraries, but are a small library cycle
that does not import much outside of it.

Change-Id: I904c05d6d5b444ee9a9dbd1f7ada12aabdcc5165
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-30 23:39:37 +00:00
Brian Wilkerson 87cb3ede9e Report conflicting edit exceptions 
Change-Id: I2b76b79a7b741c0d587fd24f8eaa30f1f0f8c657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171285
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 18:22:04 +00:00
Brian Wilkerson f60536c194 Enable slash_for_doc_comments in analysis_server 
Change-Id: Id2734d4c9ce591c5746bb9aa55810c78183db38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-14 17:17:17 +00:00
Brian Wilkerson 47e988b781 Clean up the remaining copyright notices in analysis_server 
Change-Id: Iee3110f92ab0f24312ddd1eff407d2229f895321
Reviewed-on: https://dart-review.googlesource.com/c/89101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-11 15:38:56 +00:00
Konstantin Shcheglov c91a245e30 Use ChangeWorkspace to limit where DartChangeBuilder(s) can edit. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/35402
Change-Id: If5f78b44b69f01d9ddc235401f70cc4aefd3ca37
Reviewed-on: https://dart-review.googlesource.com/c/87382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-14 22:32:35 +00:00
Brian Wilkerson 298d22f4ab remove async parse method 
Change-Id: I7a2e633b43283221790fb88a12065fed3dcdabb7
Reviewed-on: https://dart-review.googlesource.com/c/82120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-30 19:26:00 +00:00
Konstantin Shcheglov 5b1641432d Create CorrectionUtils only for ResolveResult. 
So, it is always self-consistent, never ask AnalysisContext for the
unit file content.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I93e71f7f8fa577b8e123c91252f3038a50cdccef
Reviewed-on: https://dart-review.googlesource.com/c/81580
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-10-26 14:04:12 +00:00
Brian Wilkerson 9a7168a2bf Clean up dead code in quick assist support 
Change-Id: I983c78a9ad131e5ae35a83abf2f455608b3ae835
Reviewed-on: https://dart-review.googlesource.com/52060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-20 14:23:29 +00:00
Konstantin Shcheglov 2cd992663e Sort assists and fixes by relevance and then by name. 
We used to get away with sorting just by relevance because the order
of assists and fixes was correct. I think it is time to switch to
sorting. I still would like to keep 'Surround with XXX' ordered in
a specific way, so I'm changing relevance for these assists.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I77f77ec732d70b31c32164759a3ac62dc790e469
Reviewed-on: https://dart-review.googlesource.com/40880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-13 18:18:59 +00:00
Brian Wilkerson b941f148a7 Remove uses of the old plugin model from the analysis server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3001413002 .
 2017-08-23 07:42:13 -07:00
Brian Wilkerson 7bd9e6c443 Add a mixin for assists similar to that for fixes 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2956353002 .
 2017-06-28 11:44:22 -07:00
Brian Wilkerson 0929b7736e Convert quick assist support to use AnalysisDriver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899843002 .
 2017-05-22 13:45:55 -07:00
Brian Wilkerson a6214b3129 Remove more libraries directives from server 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894883002 .
 2017-05-19 08:42:30 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
 2017-05-15 09:35:46 -07:00
Brian Wilkerson d2bbfb4f77 Make an AstProvider available to AssistProcessors 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2862143003 .
 2017-05-05 09:24:30 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
 2017-04-28 07:46:29 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
 2016-03-29 08:27:14 -07:00
Brian Wilkerson 7d72c6e1f5 Deprecate the generated AST library and clean up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1788223002 .
 2016-03-12 08:50:48 -08:00
Konstantin Shcheglov 1c5e2fd0fb Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix contributors. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1582613010 .
 2016-01-15 12:15:45 -08:00
Konstantin Shcheglov ae1bee3859 Make AssistContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461343002 .
 2015-11-20 12:18:26 -08:00
Brian Wilkerson 27eb09033f Clean up wording of client usage expectations 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1409353002 .
 2015-10-19 07:46:49 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server 
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
 2015-10-09 07:57:00 -07:00