dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
87,312 Commits 2 Branches 0 Tags
e09493b7bc80098b5e71c9b2f34ee8da1fc7c160
Commit Graph

5500 Commits

Author SHA1 Message Date
Konstantin Shcheglov 1aa398d4be Report EXPECTED_NAMED_TYPE_X when not a NamedType is parsed. 
Change-Id: Ibebc276777075da12e36642f08291fa9a9f9ac91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-21 02:24:45 +00:00
Ahmed Ashour de68893488 [analysis_server] FlutterRemoveWidget to handle Builder 
Fixes #49949

Change-Id: I6b6b0454661523f622256199f1ebd4051e37ec0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259590
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 17:04:35 +00:00
Sam Rawlins 065b7d6d62 Evaluate several diagnostics for fixes 
Change-Id: I223aa59b3e0833ce6d3a11a223efa706e30afbc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260063
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 16:24:35 +00:00
Brian Wilkerson a1e7743a0a Handle more top level declarations in the move to file refactoring 
I also added a few more TODO's because as I went through the code I
thought about what we'd need to do in order to make this production
ready.

Change-Id: I54e0d62790303c4b52269cb89cbf3601aa27af1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259882
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 22:02:31 +00:00
Ahmed Ashour c76c37c254 [analysis_server] AddExplicitCast to handle ARGUMENT_TYPE_NOT_ASSIGNABLE 
Bug #49896

Change-Id: I030b103f186d75bfcc8a434fc642e27ba55a7025
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 16:30:51 +00:00
Ahmed Ashour facfb4d9aa [analysis_server] AddExplicitCast to handle toSet 
Bug: #49896
Change-Id: I8fdbe33c3e0c5af9f39324b7c537a85a55a918d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 16:28:33 +00:00
Ahmed Ashour 5d0cdc12b0 [analysis_server] rename to handle private named parameters 
Fixes #49872
Change-Id: Ied484a817713a922133fed070e6703f57336ffb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257102
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-16 20:53:30 +00:00
Ahmed Ashour 5fe480b788 Fix typos 
Fix #49864

TEST=ci

Change-Id: I9a7e06d604cd0b4f56f2ac229ab3fc9f01cb9d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2022-09-16 19:35:00 +00:00
Danny Tuppeny b0ac65ab01 [analysis_server] Don't show return type Inlay Hints on setters 
Change-Id: I3f1d63cf0d71c1028ee3cbf3b780edcefb561aac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259588
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-16 18:53:20 +00:00
Danny Tuppeny c841c33482 [analysis_server] Fix location of inlay hints for functions/methods with docs/annotations and getter/setters 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4160.

Change-Id: I0b4925a12f462d5a54d8001dbbf893f25469d070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-16 15:25:40 +00:00
Danny Tuppeny 1857d5d7ec [analysis_server] Enable new refactors in LSP behind a flag + additional tests 
Change-Id: Iec717f9522efaa51e8b087a022c0bca1bbd2da14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-15 16:43:29 +00:00
Danny Tuppeny b3b2a1cebf [analysis_server] Change LSP types to use Uri types instead of Strings 
This requires some tweaks to to/from JSON code, and some handling for Maps that previously could be serialised directly but now may contain `Uri`s in keys and need to be converted to strings explicitly (since Uri has no toJson method).

Change-Id: I61358d8198ac1da322fae98d6c40747ad08754b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258927
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-14 18:58:44 +00:00
Danny Tuppeny 15dfda917a [analysis_server] Support inlay hints for parameter names 
Change-Id: I436d3e460759f58d6a87e8cc8742b0c7736f4f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-14 14:17:02 +00:00
Danny Tuppeny ba479310b3 [analysis_server] Include implicit parameter types in inlay hints 
Change-Id: If1b116cfc2a6fac00c20951e702a7d1a978e5421
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258808
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-13 16:06:27 +00:00
Brian Wilkerson 3744763f3a Add a framework for testing refactorings 
This currently isn't working, and I haven't yet figured out why. At this
point I thought it would be faster to ask than to keep guessing.

The problem is that the server is not getting initialized correctly.
There's probably something I don't understand about the way LSP clients
in general (and tests in particular) are expected to operate. I looked
at some of the other tests, but the ones that I looked at don't appear
to be following a common pattern.

Change-Id: I886a210f7b98a14de2f1bc53c2a499cc3462d6dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255100
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-12 21:19:07 +00:00
Konstantin Shcheglov 8f70d95df0 Use TypeAliasElement.aliasedType instead of aliasedElement in analysis_server/.. 
Change-Id: Ib7c144b12c59a09be98f3a461bd50b5e0a663fa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-12 19:38:19 +00:00
Danny Tuppeny 8e2dbc1cdc [analysis_server] Add support for showing inferred types via inlayHints 
Change-Id: I075871df3e6bec89f03f55e1387d479a48123713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258807
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-12 18:26:07 +00:00
Konstantin Shcheglov ace52d922b Semantic highlighting for record type annotations and literals. 
Change-Id: I16fb395a721f4fdd63cbf23b931551ea0f5c8682
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-08 21:55:53 +00:00
Ahmed Ashour 3584073fbc [analysis_server] AddReturnType to handle operator 
Fixes #49913

Change-Id: If7fb8b47d1211f11242f4c58365537ba3ead08b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258241
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-08 18:57:03 +00:00
Danny Tuppeny b5c7af0417 [analysis_server] Don't search the same files multiple times when referenced by multiple drivers 
See https://github.com/Dart-Code/Dart-Code/issues/4106#issuecomment-1239564686.

Change-Id: I6fa86c9fe76e7410cbb00f31798ba3f1961e98ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 21:55:02 +00:00
Konstantin Shcheglov 6f0fe880c4 Breaking changes for analyzer version 5.0.0 
Reland of https://dart-review.googlesource.com/c/sdk/+/243164

Change-Id: I5167844ea1001f026cf8d9b82465a79f560d188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257267
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-07 16:27:18 +00:00
Konstantin Shcheglov fe8b5f5e5a Support for RecordType in 'Extract Method' refactoring. 
Change-Id: Ie0808e0f2c529bc947e5a446aef9b3394d972465
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-06 18:51:26 +00:00
Ahmed Ashour 9d1e142ee9 [analysis_server] ConvertDocumentationIntoLine to handle not aligned start 
Fixes #49578

Change-Id: I19411576631361f003bdf5bb4a09e79bcf5b9a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 18:33:41 +00:00
Ahmed Ashour 63f69b4756 [analysis_server] add a quick fix for some AnalysisOptionsHintCode 
Fixes #49513

Change-Id: Ib4a1b68c95c2f379e8cbdaf62b2b17bf0a25e7b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 18:26:46 +00:00
Ahmed Ashour 6587bfbc6c [analysis_server] fix AddNullCheck with incompatible types 
Fixes #49333

Change-Id: I96311080f7dbcb1531baed311d8b4877609842ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:33:07 +00:00
Ahmed Ashour 50594939e9 [analysis_server] fix ConvertDocumentationIntoLine 
Fixes #49509

Change-Id: Ib59f60509b8fa17444f1bc8fe26e4a32586f359a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:26:02 +00:00
Danny Tuppeny daa733ef43 [analysis_server] Use LSP CompletionList.itemDefaults when supported to reduce payload size 
Change-Id: I9bdd493a843552fdddb947e06a62a6602398a363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:17:54 +00:00
Danny Tuppeny f8d3a6507a [analysis_server] Clean up LspClientCapabilities constructor 
No functional changes, just extracting some code from an initializer list to factory constructor so variables can be reused/code simplified (in preparation for adding some more).

Change-Id: I7df9bf75679363b76a08929a773e40068957b638
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:09:51 +00:00
Danny Tuppeny 8bf496e5a7 [analysis_server] Fix missing newlines after types in LSP hovers 
Consecutive lines in Markdown are rendered as a single paragraph. To prevent these being joined together, they need an additional newline.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4120.

Change-Id: I8c6270cae51c2b580a13bd799e1c4c99a1d18a8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257582
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:03:59 +00:00
Danny Tuppeny 1c8bb855c3 [analysis_server] Don't fail to resolve completions for unimported extension members 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4143.

Change-Id: I3c5a6d3bd60a6e1b5b4e432367c24deb41309f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-06 15:01:48 +00:00
Brian Wilkerson a186d80b0f Add semantic highlighting support for record literals 
I don't believe that we need any semantic highlighting for record types.

Change-Id: I33d8d3b91c30e4780e6909d4d201f211cefe9814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257425
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-02 22:32:14 +00:00
Brian Wilkerson 7d91a99f55 Add folding support for record literals 
At this point I'm not planning on adding folding for record types because we don't fold any other type annotations. Let me know if you think that's the wrong decision.

Change-Id: Ibcac086fabfaf841ac3450cdd549accfb10c6188
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-02 20:01:43 +00:00
Konstantin Shcheglov 3b3d061030 Completion in RecordTypeAnnotation. 
Change-Id: Ic3478551c39d5188e2de2a8245189e5e0674e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-02 19:05:53 +00:00
Konstantin Shcheglov a524f04c27 Completion in RecordLiteral(s). 
This also introduces CompletionResponsePrinter, which I'd like to use
instead of fluent APIs. At some point I decided that using easy to
produce, and easy to update expectations is better. Fluent API based
tests are too magical and require too many helper extensions. Also,
with textual dumps full actual results are visible, so it is easy to
compare them with expectations.

The missing key part for using textual dumps in completion tests, that
I realized only recently, was filtering. So, we don't need to dump
every available type, but we can focus on specifically named, or
specifically filtered, entities.

And configuration for `withX` flags lets us enable including features
that are interesting for a particular test suite.

Change-Id: I4a7f7ec99ed202333cf56cd3bb0dfec9ae5c39f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-01 18:57:02 +00:00
Ahmed Ashour ca010f7ffd [analysis_server] EncapsulateField to handle parameters 
Bug: #49872
Change-Id: I6a4a669abbaf129a6c24f38163b2bd44ea567970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-01 17:23:02 +00:00
Konstantin Shcheglov ff8024fc78 Revert "Breaking changes for analyzer version 5.0.0" 
This reverts commit d8df88cbe4.

Reason for revert: breaks Flutter HHH, requires updates to linter

Original change's description:
> Breaking changes for analyzer version 5.0.0
>
> Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I6ca213427189c169ddacbd89f60d463efa2c38f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-31 21:05:19 +00:00
Konstantin Shcheglov 69947a9b11 Compute context type for RecordLiteral fields. 
Change-Id: Id39e9c5ddb4f472d51d3a542b83c7ad055f24176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256971
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 18:37:19 +00:00
Danny Tuppeny 75b17a180b [analysis_server] Don't apply potential edits in LSP refactors 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4131.

Change-Id: I6555cadad7a21256b476c585729187e1cd68cfef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 15:49:09 +00:00
Konstantin Shcheglov d8df88cbe4 Breaking changes for analyzer version 5.0.0 
Change-Id: Id9f27b6c41829249f6b2e7b93ad396643193fc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243164
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-31 05:08:50 +00:00
Konstantin Shcheglov cfde826cc0 Code completion for record fields. 
Change-Id: I03134b2c0c7fac2595c23b00f9d13b5e344d15a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 23:11:08 +00:00
Ahmed Ashour 17e0f87252 [analyser] add MISSING_DEFAULT_VALUE_FOR_PARAMETER_POSITIONAL 
Fixes #49816

Change-Id: I48f3c21fcf552e21da70cf12adf3671c3f490695
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256840
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 20:55:38 +00:00
Ahmed Ashour 8a551b92c7 [analysis_server] Fix AddSuperConstructorInvocation with named parameters 
Fixes #49514

Change-Id: I8eb0095a7fbf770e5e2bda3ba3ec78af40b03afb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256842
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 18:59:52 +00:00
Ahmed Ashour 0f5d9b080c [analysis_server] don't write if_null for NullLiteral 
Fixes #49812

Change-Id: I507ceb3c722f0efdeb02c79a72d31ccf60314495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 18:51:48 +00:00
Ahmed Ashour 991615470f [analysis_server] Add quick fix for combinators_ordering 
Fixes #49450

Change-Id: I60f8d703002d94152d31fc4ad192fdab9271ffb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-08-30 18:38:58 +00:00
Ahmed Ashour c8f74cfb7d [analysis_server] fix UseCurlyBraces with comments 
Fixes #49539

Change-Id: Iebdfcca17e26389270ce7fc545a9a74b363345d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 18:27:18 +00:00
Sam Rawlins 34ef0cf762 Mark some enum diagnostics as needing fix 
Work towards: https://github.com/dart-lang/sdk/issues/49446

Change-Id: I5295a1b4bba83026672fa87d56a59e0818dd7e54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256800
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-30 14:05:29 +00:00
Jens Johansen cec94a1446 [parser] Empty record types, record types with 1 element 
This should bring parsing of record types up-to-date with v1.6 of
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Also fixes https://github.com/dart-lang/sdk/issues/49826

Change-Id: I3737a72ddee49a957bd55f86cc200fb77f23e2a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256660
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-08-30 11:04:10 +00:00
Jens Johansen a4352d09e1 [parser] Record literals can be const and one-element only 
This should bring parsing of record literals up-to-date with v1.6 of
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

Change-Id: If39bb1834137da55ef8bd1923106bbc614ea319b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256461
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2022-08-30 10:54:08 +00:00
Ahmed Ashour 23507bf6ab [analysis_server] add a quick fix for AMBIGUOUS_EXTENSION_MEMBER_ACCESS 
Fixes #49489

Change-Id: I49b34dd267a2b3b9e6639c3857de546d9f9995d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-29 18:19:00 +00:00
Brian Wilkerson 9d1a877082 Generate diagnostics for invalid field names in record literals 
Change-Id: I12ece78e257b1265d86114e8c17e6a8c641559e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256364
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-25 17:47:06 +00:00