1aa398d4be
Report EXPECTED_NAMED_TYPE_X when not a NamedType is parsed.
...
Change-Id: Ibebc276777075da12e36642f08291fa9a9f9ac91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-21 02:24:45 +00:00
de68893488
[analysis_server] FlutterRemoveWidget to handle Builder
...
Fixes #49949
Change-Id: I6b6b0454661523f622256199f1ebd4051e37ec0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259590
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-20 17:04:35 +00:00
065b7d6d62
Evaluate several diagnostics for fixes
...
Change-Id: I223aa59b3e0833ce6d3a11a223efa706e30afbc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260063
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-20 16:24:35 +00:00
a1e7743a0a
Handle more top level declarations in the move to file refactoring
...
I also added a few more TODO's because as I went through the code I
thought about what we'd need to do in order to make this production
ready.
Change-Id: I54e0d62790303c4b52269cb89cbf3601aa27af1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259882
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-19 22:02:31 +00:00
c76c37c254
[analysis_server] AddExplicitCast to handle ARGUMENT_TYPE_NOT_ASSIGNABLE
...
Bug #49896
Change-Id: I030b103f186d75bfcc8a434fc642e27ba55a7025
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-19 16:30:51 +00:00
facfb4d9aa
[analysis_server] AddExplicitCast to handle toSet
...
Bug: #49896
Change-Id: I8fdbe33c3e0c5af9f39324b7c537a85a55a918d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-19 16:28:33 +00:00
4c27d632ff
Add some initial documentation related to navigation
...
Change-Id: I62973a9c8adaa80f8171b1567c020915c2ef83a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259515
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-16 22:04:40 +00:00
5d0cdc12b0
[analysis_server] rename to handle private named parameters
...
Fixes #49872
Change-Id: Ied484a817713a922133fed070e6703f57336ffb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257102
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-16 20:53:30 +00:00
5fe480b788
Fix typos
...
Fix #49864
TEST=ci
Change-Id: I9a7e06d604cd0b4f56f2ac229ab3fc9f01cb9d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2022-09-16 19:35:00 +00:00
b0ac65ab01
[analysis_server] Don't show return type Inlay Hints on setters
...
Change-Id: I3f1d63cf0d71c1028ee3cbf3b780edcefb561aac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259588
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-16 18:53:20 +00:00
c841c33482
[analysis_server] Fix location of inlay hints for functions/methods with docs/annotations and getter/setters
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4160 .
Change-Id: I0b4925a12f462d5a54d8001dbbf893f25469d070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-16 15:25:40 +00:00
1857d5d7ec
[analysis_server] Enable new refactors in LSP behind a flag + additional tests
...
Change-Id: Iec717f9522efaa51e8b087a022c0bca1bbd2da14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-15 16:43:29 +00:00
b3b2a1cebf
[analysis_server] Change LSP types to use Uri types instead of Strings
...
This requires some tweaks to to/from JSON code, and some handling for Maps that previously could be serialised directly but now may contain `Uri`s in keys and need to be converted to strings explicitly (since Uri has no toJson method).
Change-Id: I61358d8198ac1da322fae98d6c40747ad08754b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258927
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-14 18:58:44 +00:00
15dfda917a
[analysis_server] Support inlay hints for parameter names
...
Change-Id: I436d3e460759f58d6a87e8cc8742b0c7736f4f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-14 14:17:02 +00:00
d1fbc73bf1
Add tests for selectionRange and signatureHelp with records
...
I don't believe that we need to implement anything new for these two
protocols to work correctly, and these tests are intended to demonstrate
that that's the case. The tests aren't intended to be exhaustive, but if
there are areas that you think should be tested, or aspects of the
protocols that you think might be impacted by records, please let me
know.
Change-Id: Id37fa4764b5d1d69cb7fb31f1a035e517043e96a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259060
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
2022-09-13 17:37:18 +00:00
ba479310b3
[analysis_server] Include implicit parameter types in inlay hints
...
Change-Id: If1b116cfc2a6fac00c20951e702a7d1a978e5421
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258808
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-13 16:06:27 +00:00
3744763f3a
Add a framework for testing refactorings
...
This currently isn't working, and I haven't yet figured out why. At this
point I thought it would be faster to ask than to keep guessing.
The problem is that the server is not getting initialized correctly.
There's probably something I don't understand about the way LSP clients
in general (and tests in particular) are expected to operate. I looked
at some of the other tests, but the ones that I looked at don't appear
to be following a common pattern.
Change-Id: I886a210f7b98a14de2f1bc53c2a499cc3462d6dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255100
Reviewed-by: Danny Tuppeny <danny@tuppeny.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-12 21:19:07 +00:00
8f70d95df0
Use TypeAliasElement.aliasedType instead of aliasedElement in analysis_server/..
...
Change-Id: Ib7c144b12c59a09be98f3a461bd50b5e0a663fa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2022-09-12 19:38:19 +00:00
8e2dbc1cdc
[analysis_server] Add support for showing inferred types via inlayHints
...
Change-Id: I075871df3e6bec89f03f55e1387d479a48123713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258807
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-12 18:26:07 +00:00
168e7444dc
Add pumpEventQueue() to getTestCodeSuggestions(), try to fix race.
...
Change-Id: I8d8c30b014a8bd2770fa4f62131d05944a5d186a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258511
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2022-09-09 21:32:54 +00:00
20095b844a
Use textual dumps for more completion tests.
...
Change-Id: If1160950c9f851cdb311ca1d35f02493ebc2d76c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258505
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-09 16:41:24 +00:00
f31547fecd
Use textual dumps in completion/dart/declaration tests.
...
Change-Id: I935031644543fbc9c8b8811669e41acff880018f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-09 00:30:23 +00:00
ee57ecbedb
Use textual dumps for a few tests in completion/dart/location
...
Change-Id: I5fdec2ab84a59a2af5b31583c8a6dbf3aad53a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-08 23:45:33 +00:00
ace52d922b
Semantic highlighting for record type annotations and literals.
...
Change-Id: I16fb395a721f4fdd63cbf23b931551ea0f5c8682
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-08 21:55:53 +00:00
3584073fbc
[analysis_server] AddReturnType to handle operator
...
Fixes #49913
Change-Id: If7fb8b47d1211f11242f4c58365537ba3ead08b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258241
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-08 18:57:03 +00:00
292ba46112
[analysis_server] Add some initial docs about running/debugging server from source in VS Code
...
Change-Id: I1218b3b583bc61d45a9568016ca825460717c12c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-08 18:55:53 +00:00
ac3695447d
[analysis_server] update FlutterTest
...
Fixes #49926
Change-Id: I3b2fe6962498cf40a332e0852702ed0b2e20a43a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-08 17:28:03 +00:00
b5c7af0417
[analysis_server] Don't search the same files multiple times when referenced by multiple drivers
...
See https://github.com/Dart-Code/Dart-Code/issues/4106#issuecomment-1239564686 .
Change-Id: I6fa86c9fe76e7410cbb00f31798ba3f1961e98ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-07 21:55:02 +00:00
6f0fe880c4
Breaking changes for analyzer version 5.0.0
...
Reland of https://dart-review.googlesource.com/c/sdk/+/243164
Change-Id: I5167844ea1001f026cf8d9b82465a79f560d188d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257267
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-07 16:27:18 +00:00
fe8b5f5e5a
Support for RecordType in 'Extract Method' refactoring.
...
Change-Id: Ie0808e0f2c529bc947e5a446aef9b3394d972465
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-06 18:51:26 +00:00
9d1e142ee9
[analysis_server] ConvertDocumentationIntoLine to handle not aligned start
...
Fixes #49578
Change-Id: I19411576631361f003bdf5bb4a09e79bcf5b9a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 18:33:41 +00:00
63f69b4756
[analysis_server] add a quick fix for some AnalysisOptionsHintCode
...
Fixes #49513
Change-Id: Ib4a1b68c95c2f379e8cbdaf62b2b17bf0a25e7b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 18:26:46 +00:00
6484fa91ab
Test that class references are indexed / searched / renamed in record type annotations.
...
Change-Id: I29d9645c2509829e9dd8ba44ded7b38bbab217e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-06 17:24:06 +00:00
35d19a460c
Fix the windows bot
...
Change-Id: Ic994e14d99def196dfb8457e5cceb33ba2e16971
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 16:18:28 +00:00
6587bfbc6c
[analysis_server] fix AddNullCheck with incompatible types
...
Fixes #49333
Change-Id: I96311080f7dbcb1531baed311d8b4877609842ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:33:07 +00:00
50594939e9
[analysis_server] fix ConvertDocumentationIntoLine
...
Fixes #49509
Change-Id: Ib59f60509b8fa17444f1bc8fe26e4a32586f359a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:26:02 +00:00
daa733ef43
[analysis_server] Use LSP CompletionList.itemDefaults when supported to reduce payload size
...
Change-Id: I9bdd493a843552fdddb947e06a62a6602398a363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:17:54 +00:00
f8d3a6507a
[analysis_server] Clean up LspClientCapabilities constructor
...
No functional changes, just extracting some code from an initializer list to factory constructor so variables can be reused/code simplified (in preparation for adding some more).
Change-Id: I7df9bf75679363b76a08929a773e40068957b638
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:09:51 +00:00
8bf496e5a7
[analysis_server] Fix missing newlines after types in LSP hovers
...
Consecutive lines in Markdown are rendered as a single paragraph. To prevent these being joined together, they need an additional newline.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4120 .
Change-Id: I8c6270cae51c2b580a13bd799e1c4c99a1d18a8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257582
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:03:59 +00:00
1c8bb855c3
[analysis_server] Don't fail to resolve completions for unimported extension members
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/4143 .
Change-Id: I3c5a6d3bd60a6e1b5b4e432367c24deb41309f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-06 15:01:48 +00:00
c191725dee
Test that record types work correctly in outlines
...
I don't believe there's any way for record literals to show up in the
outline, and I think this is a reasonable representative sample, but if
you think more tests would be better, let me know.
Change-Id: Ia62ad30d860d70a483249879f2ae8bea8e65b6a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257442
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-06 14:26:26 +00:00
cf2448e5d4
Fix the windows bot
...
Change-Id: If0525c4a0caaa9e229ea2c516d916e1e3a323a34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257426
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-03 04:38:23 +00:00
a186d80b0f
Add semantic highlighting support for record literals
...
I don't believe that we need any semantic highlighting for record types.
Change-Id: I33d8d3b91c30e4780e6909d4d201f211cefe9814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257425
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-02 22:32:14 +00:00
2f758c7389
Add tests for hovers related to record types and literals
...
As far as I can tell, there's no implementation work that needs to be
done. Let me know if there's an interesting case that I missed.
Change-Id: Ib6200d07fd2c6ef21749e522705810f537f053df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257423
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-09-02 20:12:43 +00:00
7d91a99f55
Add folding support for record literals
...
At this point I'm not planning on adding folding for record types because we don't fold any other type annotations. Let me know if you think that's the wrong decision.
Change-Id: Ibcac086fabfaf841ac3450cdd549accfb10c6188
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-02 20:01:43 +00:00
3b3d061030
Completion in RecordTypeAnnotation.
...
Change-Id: Ic3478551c39d5188e2de2a8245189e5e0674e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-02 19:05:53 +00:00
dd8146e17f
Use assertResponseText() for a few completion tests.
...
Change-Id: Idc331e401970b7e439626fcec336ec3f4acb932c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257266
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-02 00:53:42 +00:00
a524f04c27
Completion in RecordLiteral(s).
...
This also introduces CompletionResponsePrinter, which I'd like to use
instead of fluent APIs. At some point I decided that using easy to
produce, and easy to update expectations is better. Fluent API based
tests are too magical and require too many helper extensions. Also,
with textual dumps full actual results are visible, so it is easy to
compare them with expectations.
The missing key part for using textual dumps in completion tests, that
I realized only recently, was filtering. So, we don't need to dump
every available type, but we can focus on specifically named, or
specifically filtered, entities.
And configuration for `withX` flags lets us enable including features
that are interesting for a particular test suite.
Change-Id: I4a7f7ec99ed202333cf56cd3bb0dfec9ae5c39f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-09-01 18:57:02 +00:00
ca010f7ffd
[analysis_server] EncapsulateField to handle parameters
...
Bug: #49872
Change-Id: I6a4a669abbaf129a6c24f38163b2bd44ea567970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-09-01 17:23:02 +00:00
ff8024fc78
Revert "Breaking changes for analyzer version 5.0.0"
...
This reverts commit d8df88cbe4https://dart-review.googlesource.com/c/sdk/+/243164
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I6ca213427189c169ddacbd89f60d463efa2c38f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-08-31 21:05:19 +00:00
Konstantin Shcheglov