dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
87,312 Commits 2 Branches 0 Tags
e09493b7bc80098b5e71c9b2f34ee8da1fc7c160
Commit Graph

40368 Commits

Author SHA1 Message Date
Ahmed Ashour e09493b7bc [analyzer] use preferred quote-style when generating imports 
Bug #49559

Change-Id: Ib77ea67bb1ea15bfabb1c717cfb5abf13fd6d3cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-21 17:12:46 +00:00
Konstantin Shcheglov 126d79e27a Use named parameters for a few AST nodes. 
Change-Id: Iee8edcca9ae38e34e39a4156d5488f53fecbf0ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-21 15:45:56 +00:00
Johnni Winther 3e6050a158 [cfe] Handle structurally constant record literals 
Closes #50022

Change-Id: I608ce2cd66a5d88c0c69636350b779c32569b056
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260362
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
 2022-09-21 14:19:16 +00:00
Johnni Winther 24c8a19439 [cfe] Handle RecordType in isInstantiatedVisitor 
Closes #50021

Change-Id: Ifb608247d0ecef3de4388bec7891afc8be00f998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260112
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-09-21 12:07:36 +00:00
Aske Simon Christensen b85443e333 [dart2wasm] Skip selectors with no implementations in dispatch table 
This fixes a case of an empty selector in the dispatch table in
`lib/js/static_interop_test/mock/mockito_test`.

Change-Id: Ia4e409b4d45c71de8691f1290a853017bc56399f
Cq-Include-Trybots: luci.dart.try:dart2wasm-linux-x64-d8-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259741
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2022-09-21 09:56:36 +00:00
Johnni Winther 281a8a5d2b [cfe] Implement RecordLiteral.transformOrRemoveChildren 
Closes #50004

Change-Id: Iaea68b563bd59bb3280bd6ffb86f18d50f3d2a4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260105
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-09-21 08:49:16 +00:00
Oleh Prypin fba97eb77f Allow hooking into DeprecatedMemberUseVerifier for other use 
Split out a base class with an abstract `reportError` method that can be overriden to possibly filter errors or report them in a different way.

For the main class there is no change in behavior at all, it just implements `reportError` with the prior behavior.

Bug: b/247790768
Change-Id: I56e9afcd40b35db0063a25bfa4f6afb763267103
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260200
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-21 08:00:05 +00:00
Konstantin Shcheglov 1aa398d4be Report EXPECTED_NAMED_TYPE_X when not a NamedType is parsed. 
Change-Id: Ibebc276777075da12e36642f08291fa9a9f9ac91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-21 02:24:45 +00:00
Konstantin Shcheglov 1ad52e061a Test for Expression.inConstantContext when the expression is RecordLiteral. 
Change-Id: I1330b966296e9521bdb0d5e576cd1a63f2c5fbdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-20 21:31:35 +00:00
Paul Berry 4ab18dac68 Shared type analysis for patterns: rename finishStatementCase 
The new name, `handleMergedStatementCase`, is more consistent with the
rest of the type analyzer's `handle` methods, and more accurately
describes when the method is called (after a switch body that's
potentially shared by multiple case heads and possibly a `default`
clause).

Change-Id: I4f3166d5f58432f9f1cc0edffb3c0a317539ea23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260064
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-09-20 20:37:09 +00:00
Konstantin Shcheglov eb00d038c7 Update Expression.inConstantContext to support RecordLiteral(s). 
Change-Id: I02c3692c359e65822d30a4e931b14dec5963fef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-20 20:32:55 +00:00
Sigmund Cherem 3add88c955 [dart2js] cleanup element_map_impl 
Small follow up cleanup in element_map_impl addressing comments from the
previous code review.

Change-Id: I1eea8bba35575b953de4686351e60f0cbf353d84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260066
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2022-09-20 20:09:05 +00:00
Sigmund Cherem 755f124fcd [dart2js] prepare to migrate kernel/env.dart 
This makes kernel/env.dart fully ready for migration.

Change-Id: I1baa5bc7280236e5e2dfdfb060525752eb68c2d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260067
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-09-20 20:08:37 +00:00
Nate Biggs a263aeee33 [dart2js] Add methods to closed world for call graph generation. 
Change-Id: I22240a93e785eea0505d3594fbc41306890e24ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260241
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-09-20 19:54:35 +00:00
Nate Biggs e96a0f6c98 [dart2js] Use experimental type strategy from compiler based on flag. 
Change-Id: I3b79750691792f8f4cc7a8c09d2d4cc9b142f074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260240
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2022-09-20 19:54:35 +00:00
Ben Konyi 4eda3397f3 [ DDS ] Fix IsolateManager.initialize() not correctly handling Sentinel responses 
Fixes https://github.com/flutter/flutter/issues/111926

Change-Id: Iabde854f74410c0eb85f1e4d4ac24f6756395ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260220
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jason Simmons <jsimmons@google.com>
 2022-09-20 18:51:05 +00:00
Oleh Prypin c0b40136e5 Revert "[ddc] Add non-null assertions when setting fields" 
This reverts commit c590001ef0.

Reason for revert: Breaks google3 (b/247639927)

Original change's description:
> [ddc] Add non-null assertions when setting fields
>
> Re-land previously reverted change:
> https://dart-review.googlesource.com/c/sdk/+/258780
>
> Adds additional tests and more checks to ensure assertions are only
> added in libraries that have been migrated to null safety.
>
> Issue: https://github.com/dart-lang/sdk/issues/49918
> Change-Id: If0b9bca9fe0d7db5e15023fe03ccac891af568e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259120
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Commit-Queue: Nicholas Shahan <nshahan@google.com>

TBR=sigmund@google.com,nshahan@google.com,annagrin@google.com

Change-Id: Iee2d33005cbabfacab7fc5c45046c6eeb8e31b01
Issue: https://github.com/dart-lang/sdk/issues/49918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260106
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-09-20 17:19:38 +00:00
Paul Berry 380a505b0d Shared type analysis: add more pattern types. 
Support for the following pattern types is added to the (as yet
unused) shared type analysis prototype:

- Cast patterns
- List patterns
- Logical-and patterns
- Logical-or patterns
- Null-assert patterns
- Null-check patterns
- Wildcard patterns

Change-Id: I923df94b5deef925ca94e6ff0c8eac0493f69c1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257602
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-20 17:15:15 +00:00
Ahmed Ashour 6e03189e2b [analyzer] fix diagnostics for lints map 
Fixes #49651

Change-Id: I87b14e407e699da8b9247eed93d957e2ba12e22d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257520
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 17:11:35 +00:00
Ahmed Ashour de68893488 [analysis_server] FlutterRemoveWidget to handle Builder 
Fixes #49949

Change-Id: I6b6b0454661523f622256199f1ebd4051e37ec0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259590
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 17:04:35 +00:00
Sigmund Cherem 7d46dac715 [dart2js] improve nullsafe API for a few _find* methods 
A few private methods in common/elements.dart are used to lookup classes
and members. This is a step in normalizing these methods, so that we use
different APIs when the values are required and when they are not.

Ideally this is a change we'd do more generally in our APIs (e.g. the env APIs
should be split).


Change-Id: Iacc2f012f6f60ae960c61d8897630f6a7f1d60e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260080
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Mayank Patke <fishythefish@google.com>
 2022-09-20 16:34:45 +00:00
Ahmed Ashour f92aaae20c [analyzer] UNUSED_RESULT to handle PrefixExpression 
Fixes #49975

Change-Id: I30d08994b214b5bb453b45ca4ef98c45cebc22a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259589
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 16:30:25 +00:00
Sam Rawlins 065b7d6d62 Evaluate several diagnostics for fixes 
Change-Id: I223aa59b3e0833ce6d3a11a223efa706e30afbc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260063
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-20 16:24:35 +00:00
Kallen Tu 7578614639 Remove dynamic invocations from custom elements in html_dart2js. 
Registering custom elements are already broken -- see: https://github.com/dart-lang/sdk/issues/49536. There are plans on deleting this code at some point. This current change cleans up dynamic invocations in the deprecated code.

Removes cruft on already-deprecated code and doing it now because I assume dynamic clean up will finish before the issue resolves.

Change-Id: Ic6250c139c5d9b08d88650110f55442a7bf5dd42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259247
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2022-09-20 16:16:06 +00:00
Konstantin Shcheglov 139344eb28 Support for RecordState in DartObjectPrinter. 
Change-Id: I44481daa436916841620491529178036fc46456a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-20 16:05:05 +00:00
Paul Berry 84b71e55d4 Shared type analysis for patterns: clean up switch data structures. 
- `CaseHeadInfo` is renamed to `CaseHeadOrDefaultInfo`, to reflect the
  fact that it is used for both case heads and default clauses.

- `CaseHeadOrDefaultInfo.node` is no longer needed; this used to be
  used for error reporting, but after the refactor of
  https://dart-review.googlesource.com/c/sdk/+/259021 is was no longer
  used.

- `ExpressionCaseInfo` is renamed to `SwitchExpressionMemberInfo`,
  consistent with the AST structure `SwitchExpressionMember` in the
  analyzer.

- `SwitchExpressionMemberInfo.body` is renamed to
  `SwitchExpressionMemberInfo.expression`, consistent with the
  nomenclature used in the analyzer.

- `StatementCaseInfo` is renamed to `SwitchStatementMemberInfo` for
  consistency with `SwitchExpressionMemberInfo`.  Note that the
  analyzer calls its corresponding AST structure `SwitchMember` rather
  than `SwitchStatementMember` for legacy reasons.

- `SwitchExpressionMemberInfo` no longer extends
  `CaseHeadOrDefaultInfo`; it contains a pointer to the head or
  default info.  This is more consistent with
  `SwitchStatementMemberInfo`.

Change-Id: I727766a6f0601ec5cd8aff824364319a54446bd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-09-20 14:03:35 +00:00
Paul Berry 50ac31f286 Shared pattern logic: clean up nomenclature around guards. 
Change-Id: I596362dab53ac2efc68cb45dbb29feab80c6240a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259463
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-09-20 13:02:16 +00:00
Sigmund Cherem 026f253075 [dart2js] migreate js_model/element_map_impl 
Change-Id: Ie490c4b592a9caa155d22eefe24af1a2816414df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259640
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-09-20 04:14:52 +00:00
Konstantin Shcheglov 81efd79749 Support for RecordState in DArtObject.getField() 
Change-Id: I095ee40e69617b0a45c1bcb493ef4891dbef4138
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-19 23:56:41 +00:00
Nicholas Shahan c590001ef0 [ddc] Add non-null assertions when setting fields 
Re-land previously reverted change:
https://dart-review.googlesource.com/c/sdk/+/258780

Adds additional tests and more checks to ensure assertions are only
added in libraries that have been migrated to null safety.

Issue: https://github.com/dart-lang/sdk/issues/49918
Change-Id: If0b9bca9fe0d7db5e15023fe03ccac891af568e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259120
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2022-09-19 23:39:03 +00:00
Brian Wilkerson a1e7743a0a Handle more top level declarations in the move to file refactoring 
I also added a few more TODO's because as I went through the code I
thought about what we'd need to do in order to make this production
ready.

Change-Id: I54e0d62790303c4b52269cb89cbf3601aa27af1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259882
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 22:02:31 +00:00
Konstantin Shcheglov 9d0950716f Features control_flow_collections and spread_collections cannot be opted out. 
Change-Id: Iaaa0303cdefc168b3cd6da475b514f72bbe5db8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-19 21:55:21 +00:00
Sam Rawlins fb29df7fdc Add methods to Set and Map which are needed for Linter 
Bug: https://github.com/dart-lang/linter/issues/1307
Change-Id: Ia62aa7715509a45eb9fb0feb48c58ffee551db34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259506
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-19 18:26:31 +00:00
Nate Biggs 27f4d280b7 [dart2js] Rename inferrerExperimental to inferrer_experimental 
Change-Id: Ia951e055c4ecd30843a76aa7a84dde091c2fc73d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259940
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
 2022-09-19 18:19:11 +00:00
Paul Berry 7db67f3353 Migration: properly handle a field overriding a field in a mixin. 
Bug: https://b.corp.google.com/issues/246998513
Change-Id: Idcf496ee2957e80592fe22a016ca206b11274778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259659
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-19 17:11:51 +00:00
Paul Berry bace4c0b8a Shared type analysis for patterns: issue 2458 is now resolved. 
The spec has been updated so that the pattern type schema is only used
in irrefutable contexts, and consequently we don't need to come up
with a type schema for refutable patterns.

The prototype code already made these assumptions, so there is no
change, only comment updates.

Bug: https://github.com/dart-lang/language/issues/2458
Change-Id: I4179953fff24ad596d990ab0423fe35f8a010805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-09-19 17:09:31 +00:00
Devon Carew 8e0f4f4191 [pkg/vm_service] turn on a few more lints for this package 
Change-Id: I8eef00c606e713e252db8834f730f1655cdd57a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259509
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-09-19 17:02:14 +00:00
Ahmed Ashour c76c37c254 [analysis_server] AddExplicitCast to handle ARGUMENT_TYPE_NOT_ASSIGNABLE 
Bug #49896

Change-Id: I030b103f186d75bfcc8a434fc642e27ba55a7025
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 16:30:51 +00:00
Ahmed Ashour facfb4d9aa [analysis_server] AddExplicitCast to handle toSet 
Bug: #49896
Change-Id: I8fdbe33c3e0c5af9f39324b7c537a85a55a918d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-19 16:28:33 +00:00
Chloe Stefantsova f8ef60a868 Revert "Reland "[cfe,corelib] Add class 'Record' to the core library"" 
This reverts commit 4b6a8f35b9.

Reason for revert: Breakages in google3.

Original change's description:
> Reland "[cfe,corelib] Add class 'Record' to the core library"
>
> Part of https://github.com/dart-lang/sdk/issues/49713
>
> Change-Id: I56bfca49492d14bb561b32993fd9adfe775b7400
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259583
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I61c4db244329615d7d218484cd86601b1c737ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259800
Reviewed-by: Slava Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Auto-Submit: Chloe Stefantsova <cstefantsova@google.com>
 2022-09-19 13:52:01 +00:00
Jens Johansen f83c6d5e99 [CFE] Fix weekly bot #109 
Change-Id: I8133eab1a5b16530428aed7a8e499066ec2ede74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259760
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-09-19 10:10:12 +00:00
Konstantin Shcheglov e8b67ccf6f Inline methods to create ForElementImpl, IfElementImpl, VariableDeclarationImpl. 
They were simply passing arguments to constructors.

Change-Id: Ic986d357902ea540c1de0c8b9f8b6a4cf1c8cdc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259646
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-18 23:06:22 +00:00
Konstantin Shcheglov 836fc6dc3a Remove EphemeralIdentifier. 
Change-Id: I0ae49cfcd0d4592e8951b18437f0fa3fa5d3ac5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259645
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-18 07:31:52 +00:00
Konstantin Shcheglov 3f5a889378 Features spread_collections and control_flow_collections are enabled by default, update AstBuilder. 
Change-Id: Ib82a8841a2fceec12cc8506b3946a9cd50d4a7d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259643
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-17 17:43:01 +00:00
Konstantin Shcheglov 9618bd7e6d Remove 'SimpleIdentifierImpl name' from AST impl, use Token directly. 
I removed factory methods that are already unused, and update other.

Ideally we should use Token(s) in AstBuilder as well, but it was too
complicated right now, so I will try doing this later.

Change-Id: I2dcfa0b419818ba551401cd08b7c496ebb90c840
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259641
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-17 17:33:51 +00:00
Konstantin Shcheglov aeacd9be04 Follow up for IfElementImpl / IfStatementImpl. 
Change-Id: Iaed22f7e8cb97ad483d0ce7c13854ec33ea73673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259642
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-17 16:52:51 +00:00
Konstantin Shcheglov 41fecd5394 Tweak for UP() for record types. 
Change-Id: Iefbbfdaee2a90c2987d54d7d10aa202cef8577f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259516
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-09-16 22:40:11 +00:00
Brian Wilkerson 4c27d632ff Add some initial documentation related to navigation 
Change-Id: I62973a9c8adaa80f8171b1567c020915c2ef83a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259515
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-16 22:04:40 +00:00
Brian Wilkerson 66d74fa274 Use named parameters for if statement and element nodes 
Change-Id: Ifaf25f9be34fe93fcae24f571d480248e5a5366d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259514
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-09-16 21:39:10 +00:00
Kallen Tu c903b8a3f5 Expose the members of _ProcessImpl to avoid dynamic invocations. 
Change-Id: I676f3d5742bffb79bc0815ff55d09d09a5afe305
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258640
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2022-09-16 21:28:30 +00:00