0132d6114a
Fix for the missing new keyword on an external factory call.
...
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test
Fixes #27443
R=jacob314@gmail.com , vsm@google.com
Review URL: https://codereview.chromium.org/2394103002 .
2016-10-06 10:24:38 -07:00
20e402c43d
Fix type errors in math.min() and math.max().
...
Really, this works around them, but the workaround is all round better
code.
Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2386493003 .
2016-09-30 13:18:07 -07:00
2c313a43ac
Fix some errors around []= in core types.
...
- Get rid of JSMutableIndexable since it isn't useful.
- Make JSIndexable generic. (I think dart2js already did.)
- Add .length to NativeTypedArray since it no longer inherits it from
JavaScriptIndexingBehavior.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2378423003 .
2016-09-30 13:03:10 -07:00
6144c10409
Fix analyzer error
...
Analyzer was complaining that final field was not set. The other constructor
does set, so doing so here as well. We may be able to remove this flag soon,
but I see downstream uses.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2382463002 .
2016-09-28 10:21:15 -07:00
68d2121fd0
Use .packages instead of pubspec.yaml
...
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.
Travis may be unhappy with the lack of a pubspec.yaml. Here's the try:
https://travis-ci.org/dart-lang/sdk/builds/163270204
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2371113004 .
2016-09-28 09:49:31 -07:00
1129d3d121
fix #27421 , DDC did not generate implicit super calls in some cases
...
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers
R=vsm@google.com
Review URL: https://codereview.chromium.org/2365053003 .
2016-09-23 17:06:10 -07:00
361cd4c61c
fix #27408 , reverts "ignore dynamic in inference"
...
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb
R=vsm@google.com
Review URL: https://codereview.chromium.org/2360973004 .
2016-09-23 17:01:33 -07:00
ead14fbd74
Update global_compile tool
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2363053003 .
2016-09-23 13:30:18 -07:00
adc71ab396
re-land fix #27110 with proper DDC side of changes
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2362563004 .
2016-09-22 15:47:55 -07:00
aae63b7e21
Regenerate DDC SDK
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2358323002 .
2016-09-21 16:39:24 -07:00
8e943b8c59
Fix tests
...
This fixed the original 5 static errors from this morning.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2356413002 .
2016-09-21 13:59:55 -07:00
aa85651820
fix #27403 , use AST summaries in DDC
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
bad7f76374
Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2354603003 .
2016-09-19 14:52:12 -07:00
a4734d4b33
fix #27353 , support @checked covariant parameters in DDC
...
Seems pretty straightforward. Just added a simple test for now.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
7341e3d34c
Cleanup. Fix new analyzer errors due to recent strong mode changes.
...
BUG=
Review URL: https://codereview.chromium.org/2338323004 .
2016-09-15 10:45:05 -07:00
35e7c4c5f5
Always write the source map even if it is inlined. This simplifies bazel rules.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2342643003 .
2016-09-15 10:33:22 -07:00
ecc84b26a4
Break up another large file
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
bda62939a2
Support generating inlined source maps and wrapping module contents within a JavaScript eval block to improve the debugging experience.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2337213003 .
2016-09-14 10:54:47 -07:00
9732138317
Testing support for FF and Safari
...
Also travis support for testing FF. See:
https://travis-ci.org/dart-lang/sdk/builds/159331789
On FF 48, 1965 out of 1979 tests are passing. Run locally:
DDC_BROWSERS=Firefox npm test
On Safari 10 (tech preview), it fails immediately due to a static method named "caller". We disallow it as a field, but not a method right now. If I hack that out, 1972 out of 1979 tests appear to pass.
Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2334763002 .
2016-09-14 08:41:43 -07:00
1f10422fd5
Update uses of deprecated API in ddc
...
R=jmesserly@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
e52613f151
Fix error message
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2329493002 .
2016-09-09 09:02:50 -07:00
33ff9a3d4f
Fix type errors in sort().
...
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.
A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2311513002 .
2016-09-08 17:14:36 -07:00
8c7dd5cd04
Cast InternalMap to Map.
...
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2304323002 .
2016-09-08 16:23:45 -07:00
48817e61f7
fix strong mode messages in pkg/dev_compiler
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
38724f0626
Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2303163002 .
2016-09-06 09:57:05 -07:00
0c8cd45dea
Regen and fix expectations
...
Caught by travis :-)
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2300753006 .
2016-09-01 15:11:40 -07:00
9af2fb0115
More DDC mirrors support
...
(Note, this is a straight migration of the old DDC repo CL. :-))
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2301973002 .
2016-09-01 10:13:31 -07:00
2bc19eaa64
Remove deprecated code
...
Updating to the latest analyzer.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2289263004 .
2016-08-30 15:39:38 -07:00
feb77b40a4
Bind this in ng2 hack code
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2291873002 .
2016-08-29 16:41:29 -07:00
6a1a03add4
Make source map paths relative
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2288453002 .
2016-08-26 16:31:53 -07:00
4b321d0ecd
Import "NoInline" into core so StackTrace's use of it resolves.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2277753005 .
2016-08-25 17:08:52 -07:00
8081afc785
fix travis bots
...
- increase timeout so we load all tests
- mark a few more failures
- skip unittest tests until we re-triage them
Review URL: https://codereview.chromium.org/2279053002 .
2016-08-25 13:23:14 -07:00
bc50963a61
fix writing summaries
...
I also renamed "outPath" so this bug is less likely to happen in the future :)
R=vsm@google.com
Review URL: https://codereview.chromium.org/2279833002 .
2016-08-25 10:40:09 -07:00
c1139934a7
fix #626 , add AMD module format and make it default
...
R=nweiz@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2249233002 .
2016-08-25 09:39:36 -07:00
87577db2b2
Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2269963005 .
2016-08-24 09:13:06 -07:00
8442efa4d3
Support call methods on functions
...
Fixes #624
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2255993002 .
2016-08-18 07:51:17 -07:00
d90d172d8b
Remove deprecated DirectoryBasedDartSdk
...
We're getting bot failures due to analyzer deprecation messages.
R=brianwilkerson@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2258873002 .
2016-08-18 07:47:45 -07:00
a076edad94
roll analyzer
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2254883002 .
2016-08-17 21:10:21 -07:00
9b421ebb4f
fixes #627 , update DDC Future.then signature
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2259433002 .
2016-08-17 10:25:10 -07:00
36273565e3
fixes #610 , incorrect help output
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
0aa5cbd128
fix #620 , infer the input files from sources
...
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing
R=nweiz@google.com
Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
8fec051a8e
Mark recursive_inheritance_test as passing
...
This will get the dev and master bots green.
Will need to bump the pubspec on analyzer (once published) to make stable green after this.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2214263005 .
2016-08-05 09:35:01 -07:00
3ddb76b95c
Reify type params on map literals
...
Fixes #621
R=jmesserly@google.com , leafp@google.com
Review URL: https://codereview.chromium.org/2211293002 .
2016-08-05 07:16:02 -07:00
144cca4b62
Roll DDC to latest dart:html
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2207273002 .
2016-08-03 17:55:05 -07:00
b324b14105
Regen with latest analyzer
...
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2212663002 .
2016-08-03 17:32:17 -07:00
411de08847
Added list of imports to library modules (needed in order to discover filepaths of summaries, allowing the dev_compiler to run in the browser).
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2208883002 .
2016-08-03 15:47:57 -07:00
3b7e5eed8c
Updated sdk
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2206843002 .
2016-08-02 17:16:07 -07:00
8b0b57844b
Get rid of library proto information for debugger libraries
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2208533003 .
2016-08-02 17:08:27 -07:00
0fd3e8821c
Fix wrt analyzer tip
...
This sidesteps #618 for now.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2209473002 .
2016-08-02 14:42:06 -07:00
bd789e912b
Remove source file check
...
This is breaking downstream build rules.
TBR=leafp@google.com
Review URL: https://codereview.chromium.org/2199123003 .
2016-08-02 13:35:50 -07:00
nshahan