Commit Graph

36 Commits

Author SHA1 Message Date
pq 43f027fc05 Analysis request getReachableSources (#24893).
Implements a new request to get reachable sources.

This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").

More context here: https://github.com/dart-lang/sdk/issues/24893

R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1491013002 .
2015-12-02 13:26:35 -08:00
Brian Wilkerson 86216e5154 Consistently use implements when one interface inherits from another interface
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1481273002 .
2015-11-30 07:58:10 -08:00
Konstantin Shcheglov 0ae251793f Make index provisional API.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1471073002 .
2015-11-23 12:54:55 -08:00
Brian Wilkerson 0a64b0694c Make change builder provisional API
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1468133002 .
2015-11-23 10:18:58 -08:00
Konstantin Shcheglov bb1914e175 Make FixContributor asynchronous.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461313004 .
2015-11-20 14:57:00 -08:00
pq c0466f28f5 Rolling average work queue diagnostic (#24933).
Background: https://github.com/dart-lang/sdk/issues/24933

Salient bits:

* sampling will only start if a client registers interest in diagnostics.
* sampling will stop if clients stop requesting diagnostics.
* sample results are coming back as a string (but a double would be better).
* the mapping of context folders to averages in not garbage collected; since it's only potentially leaking `_Average` objects (and not contexts) when folders are deleted, I think that's fairly benign.

BUG=24933
R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1463923003 .
2015-11-20 14:24:47 -08:00
Konstantin Shcheglov ae1bee3859 Make AssistContributor asynchronous.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461343002 .
2015-11-20 12:18:26 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931).
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
2015-11-16 14:10:10 -08:00
pq 82e83bb34d Experimental getDiagnostics request (#24480).
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
2015-11-05 15:05:21 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
2015-11-03 10:19:41 -08:00
Brian Wilkerson 879cf82b6b Rework analyzed files support to use globs
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1413643006 .
2015-11-03 07:11:29 -08:00
Konstantin Shcheglov e0636b183c Make IndexableObjectKind parameterized.
LMK if this is a bad change.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1413563004 .
2015-10-19 10:13:43 -07:00
Brian Wilkerson 27eb09033f Clean up wording of client usage expectations
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition.
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
Konstantin Shcheglov 67576340b0 Declare IndexableObject.file instead of Source.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409203002 .
2015-10-16 14:43:49 -07:00
Konstantin Shcheglov 78da03cd97 Extract protocol_dart.dart APIs.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1398333002 .
2015-10-12 06:58:34 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
2015-10-09 07:57:00 -07:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
2015-10-05 11:57:35 -07:00
Brian Wilkerson ba318117d8 More documentation clean-up for server APIs
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1389713002 .
2015-10-05 11:04:09 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
Brian Wilkerson 6be842b53b Improve the documentation of extension points
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1335113004 .
2015-09-14 14:11:52 -07:00
Konstantin Shcheglov ef2fc0d778 Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
Konstantin Shcheglov b15a031276 Navigation extension point.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303033010 .
2015-09-01 13:06:25 -07:00
Konstantin Shcheglov 45862f401e Send 'execution.launchData' only after full resolution.
We don't need to send them after each and every notice.
This information becomes ready somewhere in between parsing and full resolution.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1157823002
2015-05-24 10:39:21 -07:00
Brian Wilkerson ad52c9eab9 Add support for specifying files needing analysis
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1152013002
2015-05-21 14:34:04 -07:00
brianwilkerson@google.com ac3613e2bb Re-apply change to move to plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1094083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45408 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 18:54:24 +00:00
brianwilkerson@google.com 3d536efcfe Revert breaking change
Review URL: https://codereview.chromium.org//1101213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45384 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 22:12:20 +00:00
brianwilkerson@google.com 24c853446a Convert analyzer and analysis_server to use the plugin package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1063153004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45382 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:32:35 +00:00
brianwilkerson@google.com b63a2e1d78 Add API for contributing to the index
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1060063008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45358 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:11:20 +00:00
brianwilkerson@google.com cb7e001db8 Add file missed in previous CL and comment clean-up
R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1084793006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45355 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 19:23:07 +00:00
brianwilkerson@google.com dbfb8bf97d Create a public API for contributing assists and make assists pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1073383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45109 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:03:50 +00:00
brianwilkerson@google.com 46064e8f2f Create a public API for contributing fixes and make fixes pluggable
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1080653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45079 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:01:10 +00:00
brianwilkerson@google.com b36c00f15f Temporarily move plugin support
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1027433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:06:22 +00:00
brianwilkerson@google.com b161853940 Minor clean-ups and rename
R=scheglov@google.com

Review URL: https://codereview.chromium.org//840473007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42776 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 16:36:14 +00:00
brianwilkerson@google.com b7de258068 Initial plugin API
R=danrubel@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//839833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42736 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:57:51 +00:00