dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
81,877 Commits 2 Branches 0 Tags
dfd7d7b37abd0332dced8ded5fac212d5e37e511
Commit Graph

4792 Commits

Author SHA1 Message Date
Konstantin Shcheglov 8ecbaa8393 Replace TypeName with NamedType in analysis_server/, where possible. 
Change-Id: Ice232aed2b705030861afa115350b1c77aa49d6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-22 01:26:39 +00:00
Brian Wilkerson b1d878fc8f Add a fix for avoid_print that makes the invocation conditional on kDebugMode 
Change-Id: I922f8f51d40127032573acadcdb76a37c005f48c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213801
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-18 15:42:43 +00:00
Sam Rawlins 1f66977de1 Use static strings from FunctionElement where possible 
This improves discovery, refactoring, etc.

I did not change any locations which would have required interpolation,
or tests which refer to a String immediately nearby (in tests).

Change-Id: I8479fd7822713e878e56fdf5ec35969492049333
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-09-16 19:05:55 +00:00
Konstantin Shcheglov a3f338e456 Fix MakeReturnTypeNullable for possible null type. 
Saw in crash log:

StateError: Bad state: No type: void
at ExpressionExtension.typeOrThrow	(extensions.dart:89)
at MakeReturnTypeNullable.compute	(make_return_type_nullable.dart:55)
Change-Id: Id985d7a2bb26fe9e494f3a36dc0b15196c6de463
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213412
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-15 20:59:58 +00:00
Danny Tuppeny f9512796e2 [analysis_server] Prevent duplicate LSP completion registrations for Dart 
... when using plugins that register for Dart files.

Fixes https://github.com/Dart-Code/Dart-Code/issues/3555.

Change-Id: Idadcda0b04f86eb40d11a69e8eadc7120c873ae7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213266
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-13 21:14:00 +00:00
Ahmed Ashour c1f63c05b8 Remove unnecessary raw string from protocol_generated 
Fixes #47146

Change-Id: I6710a8bb32e5ec770e570c93612f44a9ce63bc3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212744
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-13 21:10:40 +00:00
Danny Tuppeny d74199de8f [analysis_server] Add support for new TEAR_OFF highlight kinds to LSP 
Change-Id: I924037e639a8f37df085a7831f970ebc5334ba16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213263
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-13 15:15:00 +00:00
Brian Wilkerson 2a7237bd05 Include field in the element kinds associated with a property access 
Fixes: https://github.com/dart-lang/sdk/issues/47173
Change-Id: Ic96ddfe00f7bd9fe3883abe6b6f30a1d5211908c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213024
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-09 23:53:47 +00:00
pq dd35db6192 "master->main" migration 
Change-Id: I773e0a60a782f9e6678cea22e2a7d8fae48cffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-09 18:14:36 +00:00
Konstantin Shcheglov a900531934 Don't read files in _isPackageReference() during MoveFileRefactoringImpl. 
We regularly get FileSystemException(s) like:
at _PhysicalFile.readAsStringSync (physical_file_system.dart:184)
at _OverlayFile.readAsStringSync (overlay_file_system.dart:206)
at FileSource.contentsFromFile (source_resource.dart:68)
at FileSource.contents (source_resource.dart:55)
at MoveFileRefactoringImpl._isPackageReference (move_file.dart:183)

So, instead we could use already recorded source content from which
the element model was built.

Alternatively we could record different kinds of references into
the index, e.g. IS_REFERENCED_BY_PACKAGE_URI or IS_REFERENCED_BY.

Change-Id: Ic4aa839f706f37c9df2504f866dfca7c7581c347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-09 15:32:03 +00:00
Kevin Moore 9f3b7cf4c6 analysis_server: migrate to Object.hash functions 
Update min SDK to 2.14

Change-Id: I370875b550f5c103560e13697329c1443c036a2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212880
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-09-09 00:23:43 +00:00
Ahmed Ashour 928b6443c4 Add a quick fix for ABSTRACT_CLASS_MEMBER 
Fixes #46025

Change-Id: I716d620e7c77c09cf27f922069f57466f3df76ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212574
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-08 22:30:12 +00:00
pq 8cee82debb constructor tearoff fix support for unnecessary_lambdas 
Fixes: https://github.com/dart-lang/sdk/issues/47103

Change-Id: I521461a587b9272503772e9b13999d8e4e688352
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212803
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-08 21:56:02 +00:00
pq e5c659b55f quick fix for unnecessary_constructor_name 
Fixes: https://github.com/dart-lang/sdk/issues/47102

Change-Id: Idd8b44379d49f416eb4d671ed95ed5f9433af00c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212800
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-08 21:39:12 +00:00
Ahmed Ashour ff63fdcba8 Add fix for SWITCH_CASE_COMPLETES_NORMALLY 
Fixes #46999

Change-Id: I00b7d9fe6fdd2431d90cdee5248ce58473620807
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-08 16:22:39 +00:00
Sam Rawlins ef06bf2130 Remove unnecessary imports in analysis_server 
Bug: https://github.com/dart-lang/sdk/issues/44569
Change-Id: Ied7a1ed105ac82cf9e0f38454bce8cb4a69e17e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212605
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-07 22:32:04 +00:00
Konstantin Shcheglov 3e6ece2bd6 Support for constructor tear-offs in rename refactoring. 
Change-Id: Ia6b32e8ac24cfecbc915c008ce78f2a8b561c7a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-07 20:21:00 +00:00
Konstantin Shcheglov 06f0ecb8e8 Add more HighlightRegionType.xyz_TEAR_OFF 
Change-Id: I357d621439c68b77545bdd01719310c60684e1f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212602
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-07 18:31:03 +00:00
Ahmed Ashour 20a8d62cca Enable ADD_CONST for bulk 
Fixes #47001

Change-Id: Ia42affb8f26e69f94e12192458e68bc29e848ed9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211446
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-07 16:39:32 +00:00
Konstantin Shcheglov 1957af707c Use CONSTRUCTOR_TEAR_OFF for ConstructorReference highlighting. 
Change-Id: Iee9731ef6e273ae89bc5328d6941aa8ddd530562
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212488
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-07 16:08:02 +00:00
Ahmed Ashour f1ded6af56 Remove import dart:core 
Fixes #47092

TEST=existing

Change-Id: I3c5c0a1ec5e0426642a5dc70aa9a0391a143ed93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212298
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-09-06 11:57:40 +00:00
Ahmed Ashour b204782b12 Remove BulkFixProcessor.producableFixesForError 
Fixes #47083

Change-Id: I9f50beb10b95e052aff7a89dca763c8bd9710cf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212293
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-03 05:10:48 +00:00
Ahmed Ashour 55380c3ed4 Better message for extract_method 
Fixes #47084

Change-Id: I7d50f92af8e13d0ad0a2602af4ff8e055f5b04bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-02 18:35:15 +00:00
Danny Tuppeny 3aa464af26 [analysis_server] Support renaming files when classes are renamed via LSP 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3354.

Change-Id: I2a11a54e0a2c35d525ee08e0849e35c421f6e195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212291
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-02 18:09:38 +00:00
Konstantin Shcheglov ddc7523958 Issue 45267. Support for --packages in analysis server. 
Bug: https://github.com/dart-lang/sdk/issues/45267
Change-Id: Iac7dd7502b6936bab91279ac5db7cdafaa90c580
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212271
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-02 17:33:15 +00:00
Danny Tuppeny 7ccf06ad63 [analysis_server] Disable spawning pub commands during integration tests 
Change-Id: Ie23331a7e136d24dc7e982046b10a7c843ec7349
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212049
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-02 16:55:05 +00:00
Brian Wilkerson 26bb5a23c5 Fix assist to convert an expression function body to a block 
Converting an expression function body to a block should not include
return if the function has a return type of void.

Change-Id: I456e0b01ac83d6d42502eab18642ae66ca42111f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212038
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-01 22:19:07 +00:00
Konstantin Shcheglov 78fd1fb758 Format analysis_server/ and analyzer_plugin/. 
R=brianwilkerson@google.com

Change-Id: Ib3140b9a7e1dbefd7106cc471574d210b359e7bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-01 21:08:56 +00:00
Danny Tuppeny 681243f881 [analysis_server] Support HACK, FIXME, UNDONE types for TODO comments 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2364.

Change-Id: I0c66e6443e9a1b0bb3795b6db29de81e43e52b61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-01 15:47:19 +00:00
Danny Tuppeny 88a41363bc [analyzer] Support generic type aliases in available declarations 
Fixes https://github.com/dart-lang/sdk/issues/46409.

Change-Id: I16fe47f52254956e58cb5f034c49e1d8fa4c22c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204403
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-31 17:35:04 +00:00
Danny Tuppeny 03c525cc41 [analysis_server] Terminate in-process pub commands at shutdown 
May fix "The process cannot access the file because it is being used by another process" on Windows bots when tests are trying to clean up while the pub process was running.

Change-Id: I1f3ed0a404d27e2769887e6d33c94cf9b3614092
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-31 17:35:01 +00:00
Danny Tuppeny 7bc6c7ac39 [analysis_server] Map ENUM_CONSTANT to EnumMember in LSP if supported 
Change-Id: Iecbb5e61bb580091e9ada709aa38042f3dbc7a19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-31 17:12:13 +00:00
Danny Tuppeny f9db0dd6aa [analysis_server] Use "final" instead of "var" for assign_to_local_variable when prefer_final_locals is enabled 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3542.

Change-Id: I341d2de0620be726b756ec38b015632b64b202b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-31 16:51:11 +00:00
Brian Wilkerson 6e4678e150 Make the formatting of fix and assist constants consistent 
I added commas and formatted. No other changes were made.

Change-Id: I5aacab204d2a36474ed1689a912ea61362764726
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-30 18:46:37 +00:00
Ahmed Ashour 47b7fd4b75 Better loop for ADD_TYPE_ANNOTATION 
Fixes #47015

Change-Id: I3b3c6e88e601c5da9bc60936f08007bdea52375d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-27 00:42:16 +00:00
Ahmed Ashour 88cd302eb0 ADD_TYPE_ANNOTATION to handle multiple variables with the same type 
Fixes #46997

Change-Id: If64125dcd232472a49ffaa94b4bc8bdc5131d3cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-26 20:35:39 +00:00
Ahmed Ashour e30a55d74a CREATE_MISSING_OVERRIDES to create brackets if missing 
Fixes #37903

Change-Id: I13ed4e1bf34bf7d5cfd0bdc78d6191c6964cc28a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-26 20:15:30 +00:00
Brian Wilkerson dd5b4cb05c Fix a concurrent modification exception 
Fixes https://github.com/dart-lang/sdk/issues/47011

Change-Id: Ied724d32198831944a086de1bc045ef1e4b1909a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211462
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-26 20:14:49 +00:00
Ahmed Ashour 92026cec44 Add a fix for "EOL at end of file" lint. 
Change-Id: I5540fad40869ec85d6b8a75df3d919781998d512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-25 16:46:22 +00:00
Ahmed Ashour b9459ffdd7 Better message for CREATE_MISSING_OVERRIDES 
Fixes #46974

Change-Id: I9f628089803d880957d34c7d6063696d1aebdfcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-24 21:33:24 +00:00
Ahmed Ashour f4b6fa85ea Add a quick fix to return_of_invalid_type 
Bug: 46785
Change-Id: Ided0ebd07935289b9b7fdfaaf5a38a992646c9d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209962
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-23 23:56:07 +00:00
Ahmed Ashour 5502e51627 CHANGE_TYPE_ANNOTATION to handle unreferenceable type 
Fixes #46971

Change-Id: Id0f1a2ebd79b1459c4d518c0cd7f42545c584159
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-23 23:53:37 +00:00
Brian Wilkerson d6f4640c0d Make the set of fixes for lints extensible 
Change-Id: I70ba8737f91aa2d3728ae67d656de26d3619579e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210840
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-08-23 18:19:27 +00:00
Ahmed Ashour 86898c2ee6 DartEditBuilder to have canWriteType() 
Bug: 46911
Change-Id: Icf8cdb3af6f2c34fe2eff75f1aeb1dac4aa8aac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-21 18:51:36 +00:00
Konstantin Shcheglov 16e4709922 Support for navigation in macro with LSP. 
Change-Id: I6c1e35f944a7e551882745e74c9570086bc53b56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-18 15:31:34 +00:00
Konstantin Shcheglov fd2a3cdc3a Support navigation to macro-generated elements. 
We use previously added `CompilationUnitElementImpl.macroGeneratedContent`
to access the current combined content.

In order to make this work with current IntelliJ plugin, without
adding new protocols, we store the generated code into a new file,
and locations for macro-generated elements are in this file.

Locations for elements that are not macro-generated are still
in the source file.

We use `ElementLocationProvider` to separate writing to the file
system, and do this only in DAS.

Change-Id: Ib156c67b0bf1f3474eb06584e76aa532abd597d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-17 16:14:02 +00:00
Ahmed Ashour c9d954efe7 SPLIT_VARIABLE_DECLARATION assist to handle unreferenceable type 
Bug: 46910
Change-Id: I92c5e4afb25a75e1c1c28fb6b52c9bb02ca81eb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210127
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-17 04:40:52 +00:00
Konstantin Shcheglov 771cbb5328 Issue 46839. Remove UNCHECKED_USE_OF_NULLABLE_VALUE. 
Bug: https://github.com/dart-lang/sdk/issues/46839
Change-Id: If214aab6163cd0b88a37bc04952a0cddc2bc5319
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-08-16 16:29:14 +00:00
pq 11822117c0 fix for avoid_null_checks_in_equality_operators 
Fixes https://github.com/dart-lang/sdk/issues/45919

(The bulk fix test is not awesome but the lint doesn't fire multiply in one `==` so overlaps are infeasible.)

Change-Id: I6fec933f0ba62e794c1b71a6ccb255ed92c4887b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209661
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-09 23:21:29 +00:00
Brian Wilkerson 7d1f26ff09 Deprioritize the fix to add a null check 
I missed this as part of my previous CL.

Change-Id: I07f2d6a4e0b60433afb39ee1b0a4819147a494aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-06 20:05:48 +00:00