Commit Graph

1061 Commits

Author SHA1 Message Date
William Hesse 0bb497875a Update status for Chrome 44 on dart2js tests.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1240363003 .
2015-07-22 18:02:03 +02:00
Alan Knight de3ce04f0a Fix type problem with FilteredElementList._iterable
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1236793006 .
2015-07-17 10:53:19 -07:00
William Hesse d21bdcc27e Update status for failing dartium tests
BUG=https://github.com/dart-lang/sdk/issues/23849
TBR=terry@google.com

Review URL: https://codereview.chromium.org//1235283003 .
2015-07-15 17:34:14 +02:00
Karl Klose 71e2bec0a5 dart2js cps: Support JS_CURRENT_ISOLATE.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1222913003 .
2015-07-07 15:55:13 +02:00
Jacob Richman ae72b6a701 Enhance dart:js interop in a backwards compatible manner.
BUG=

Review URL: https://codereview.chromium.org//1213873004.
2015-06-29 11:20:11 -07:00
Asger Feldthaus 34302b1320 dart2js cps: Translate synthesized mixin constructors.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1216593002.
2015-06-29 15:28:40 +02:00
Jacob Richman 7e9e4d89d3 Revert "Enhance dart:js interop in a backwards compatible manner."
This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe.

BUG=

Review URL: https://codereview.chromium.org//1209093005.
2015-06-26 10:29:25 -07:00
Jacob Richman 3fdeb669ee Enhance dart:js interop in a backwards compatible manner. List objects can now be passed back and forth to Dartium without requiring jsify
BUG=
R=terry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1194643002.
2015-06-26 10:06:45 -07:00
Kevin Millikin b9192ab9e2 dart2js CPS: Support try/catch/finally.
Support try/catch/finally by pretending it is macro-expanded into
try/catch and try/finally:

    try S0 catch (ex, st) S1 finally S2
    ==>
    try { try S0 catch (ex, st) S1 } finally S2

The duplicated code for try/catch and try/finally is abstracted into a
function parameterized over translations for all the parts that
differed.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1207703002.
2015-06-24 17:13:15 +02:00
Kevin Millikin 089ed2965b Implement try/finally by inlining the finally code.
Try/finally is implemented by inlining.  There is a try/catch to catch
exceptions in the try block.  The catch body contains the finally code
followed by a rethrow.  The code for finally is translated again after the
normal exit of the try block.  Break, continue, and return exits in the try
block have the finally code inlined just before the exit is taken.

Try/catch/finally is not yet supported, it requires some changes to the
assigned variables analysis.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1201983002.
2015-06-24 10:12:42 +02:00
Asger Feldthaus 04c5c61a10 dart2js cps: Refactor and optimize string concatenations.
The ConcatenateStrings IR node has been removed. It was a leftover from
dart2dart.

Expressions inside string interpolations are now stringified explicitly
and we concatenate strings with a pure StringConcat operator.

ConstantExpressions have also been removed from the IR. They were also
an artifact from dart2dart and were complicating the optimizer.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac75893964144d5712d1da8417c27c232750ec37

Reverted: https://github.com/dart-lang/sdk/commit/988b65336b3194cd539781195a9b8be24b3bbdc3

Review URL: https://codereview.chromium.org//1195573003.
2015-06-23 13:17:59 +02:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
2015-06-22 09:41:01 -07:00
Kevin Millikin bf595224d5 Implement simple switch statements as nested if/else.
Simple switch statements that do not have continue to labeled cases
are compiled into a chain if/else comparisons.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1191193005.
2015-06-22 11:29:31 +02:00
Karl Klose 3f46181244 cps-ir: Support foreign code.
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/a120ee7c9071b60edccff066dcdade078f601377

Reverted: https://github.com/dart-lang/sdk/commit/40ed0daaaf71904d2da271e66ba8381ef857116d

Review URL: https://codereview.chromium.org//1185633003.
2015-06-19 13:44:58 +02:00
Karl Klose 40ed0daaaf Revert "cps-ir: Support foreign code."
This reverts commit a120ee7c90.

TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1196443002.
2015-06-18 13:37:52 +02:00
Karl Klose a120ee7c90 cps-ir: Support foreign code.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1185633003.
2015-06-18 13:09:50 +02:00
Karl Klose e4b56654ff Update dart2js-cps_ir test expectations with better annotations.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1181613003.
2015-06-11 10:56:56 +02:00
Karl Klose 6cffe227fe Update dart2js-cps_ir test expectations after bac7481d3d.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1171773004.
2015-06-09 15:12:18 +02:00
Karl Klose 993338408e cps_ir: Handle malformed type arguments and type checks.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1156373008
2015-05-29 09:53:35 +02:00
Alan Knight ee0a5db6a5 Make sanitizer tests handle IE11, where tagName can't be clobbered
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1148893004
2015-05-27 12:56:09 -07:00
Alan Knight 048079dc20 Narrow suppression of animation tests to MacOS
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1149923005
2015-05-27 10:35:21 -07:00
Stephen Adams 20a4c2b2a1 Fix safari status - html/js_test now working
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//1157163004
2015-05-26 17:56:11 -07:00
Karl Klose bfe00add63 Fix typo in test suppression.
R=sigurdm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1156043003
2015-05-26 09:07:48 +02:00
William Hesse 565bf6e0d3 Update status for Chrome 43 on Windows and Mac OS X.
BUG=dartbug.com/23506,23507,23508
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1142373004
2015-05-22 14:39:09 +02:00
Karl Klose 36d3e0d0e6 Update cps-ir test expectations.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1152133003
2015-05-22 09:58:58 +02:00
Alan Knight e7289bc080 Temporarily suppress IE11 sanitizer test failure around tagName
BUG=

Review URL: https://codereview.chromium.org//1152653003
2015-05-21 17:44:57 -07:00
Alan Knight 6452961033 Unsuppress animation tests on Chrome, they seem to have switched back to working
BUG=

Review URL: https://codereview.chromium.org//1157463003
2015-05-21 14:05:37 -07:00
Asger Feldthaus ccee558a5b dart2js cps: Access to lazily initialized fields.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1136843006
2015-05-19 10:05:09 +02:00
alanknight@google.com 34bf1903fa Update tests for Firefox 38, now on Windows bots
BUG=

Review URL: https://codereview.chromium.org//1132013007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45828 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 22:19:49 +00:00
alanknight@google.com 380e195ba1 Carefully suppress remaining IE and safari mobile sim failures
BUG=

Review URL: https://codereview.chromium.org//1137343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45769 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 17:36:34 +00:00
karlklose@google.com 9b32c9e673 Implement raw list checks.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1123343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45762 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 11:58:45 +00:00
alanknight@google.com ac3a2ea130 IE Event test suppressions
BUG=

Review URL: https://codereview.chromium.org//1125283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45750 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 22:56:28 +00:00
alanknight@google.com 92082307e9 Test suppressions and fixes for WheelEvent and related changes.
BUG=

Review URL: https://codereview.chromium.org//1130783003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45745 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 21:07:53 +00:00
alanknight@google.com f0136ff1eb Clean up WheelEvent
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1126463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45740 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:34:01 +00:00
alanknight@google.com 4a1b567136 Pass Redirect status higher than 307 through to the user
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1135893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45739 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:25:56 +00:00
asgerf@google.com f5f1eb643d dart2js cps: Introduce GetStatic/SetStatic.
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45735

Reverted: https://code.google.com/p/dart/source/detail?r=45737

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45738 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 14:19:40 +00:00
asgerf@google.com 961c805398 Revert "dart2js cps: Introduce GetStatic/SetStatic."
This reverts commit 28e4518df87c72cb8e23fe6d73b7750ad0f2183a.

TBR=karlklose@google.com

BUG=

Review URL: https://codereview.chromium.org//1136523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45737 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:53:15 +00:00
asgerf@google.com 2c90643171 dart2js cps: Introduce GetStatic/SetStatic.
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45735 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:35:49 +00:00
karlklose@google.com 0eaa4d4717 cps-ir: Support compilation of methods that use interceptor calling convention.
This is a modified version of sra@'s CL https://codereview.chromium.org/1020243002/ with kmillikin@'s comments addressed.

R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1109403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45680 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 12:38:14 +00:00
asiva@google.com 49d1dc7252 Address issue 13719, cleanup the status file to reflect reality.
R=regis@google.com

Review URL: https://codereview.chromium.org//1085363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45383 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:42:28 +00:00
alanknight@google.com b1bbf977b3 Remove 22327 suppression now that Chrome 41 is current
BUG=

Review URL: https://codereview.chromium.org//1097783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45252 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 19:47:30 +00:00
whesse@google.com 616a12b976 Update status for Chrome 42 dart2js
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45200 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 09:31:25 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend.
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 11:44:02 +00:00
alanknight@google.com 5d11064434 Emphasize that the XSS tests should not be casually suppressed
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1080583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45117 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 19:09:00 +00:00
alanknight@google.com 7c8351df36 Remove SVG constructor suppressions around foreignobject and altGlyph
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1078853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45112 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 16:53:35 +00:00
floitsch@google.com 80155170ce dart2js: Fix csp minified.
For the most part this only required status file or test updates.
There was, however, a bug in the code that extracted the class-name from its constructor.

R=sra@google.com

Review URL: https://codereview.chromium.org//1073273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45084 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 07:49:54 +00:00
alanknight@google.com ea26b521a3 Add another issue to the wheelevent_test suppression
BUG=

Review URL: https://codereview.chromium.org//1079523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45077 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 19:51:42 +00:00
alanknight@google.com b13d4f5742 Check for DOM clobbering attacks in sanitizing/node validation
BUG=

Review URL: https://codereview.chromium.org//1077813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45028 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 19:47:34 +00:00
alanknight@google.com e1e22c00f2 Fix node validation for SVG foreignobject tag
BUG=

Review URL: https://codereview.chromium.org//1072893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45019 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 17:24:03 +00:00
whesse@google.com 462fd69d5a Update IE status for co19 and html tests.
BUG=dartbug.com/23146
R=ricow@google.com

Review URL: https://codereview.chromium.org//1073753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44994 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 09:05:23 +00:00