dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
32,792 Commits 2 Branches 0 Tags
dfc35faaf940cc16c5d121e547d2c79c53cf1813
Commit Graph

1652 Commits

Author SHA1 Message Date
William Hesse 0bb497875a Update status for Chrome 44 on dart2js tests. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1240363003 .
 2015-07-22 18:02:03 +02:00
Alan Knight cd8c569632 Make sure NodeValidator uriAttributes aren't passed as attributes 
WIP

BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1236413002 .
 2015-07-17 14:12:44 -07:00
Alan Knight de3ce04f0a Fix type problem with FilteredElementList._iterable 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1236793006 .
 2015-07-17 10:53:19 -07:00
Alan Knight 4e790fef3d appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Committed: https://github.com/dart-lang/sdk/commit/930a40daa50a93adfce8786f4d7ef25e06324dda

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-16 10:30:51 -07:00
William Hesse d21bdcc27e Update status for failing dartium tests 
BUG=https://github.com/dart-lang/sdk/issues/23849
TBR=terry@google.com

Review URL: https://codereview.chromium.org//1235283003 .
 2015-07-15 17:34:14 +02:00
Cristian Almstrand 3b125d3bc9 Please refer to https://code.google.com/p/dart/issues/detail?id=23418 for the bug reportincluding a WebStorm project which demonstrates the problem. 
This proposal includes a fix to ensure that indices passed to the public functions defined in class FilteredElementList of the dart:html package consistently refer to element indices (not element indices sometimes, and node indices other times). Without this change, it is not possible to reliably insert elements relative to other elements. This can be problematic as the order of HTML elements must be guaranteed to ensure elements appear where expected in a normal page flow.

This proposal also address the TODO in file sdk/lib/html/html_common/filtered_element_list.dart to avoid excessively creating/allocating a filtered list of elements from nodes whenever calling [], every, any, length, etc. The implementation is less concise but should result in much reduced memory allocation and speed improvements.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1129333002 .

Patch from Cristian Almstrand <cristian.almstrand@gmail.com>.
 2015-07-14 14:50:42 -07:00
Alan Knight 610edadff2 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 930a40daa5.

BUG=

Review URL: https://codereview.chromium.org//1230203005 .
 2015-07-13 15:32:17 -07:00
Alan Knight 930a40daa5 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-13 12:50:49 -07:00
Alan Knight 1e8a275a20 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
 2015-07-08 12:19:30 -07:00
Alan Knight 560f12bb21 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-08 10:16:37 -07:00
Karl Klose 71e2bec0a5 dart2js cps: Support JS_CURRENT_ISOLATE. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1222913003 .
 2015-07-07 15:55:13 +02:00
Jacob Richman ae72b6a701 Enhance dart:js interop in a backwards compatible manner. 
BUG=

Review URL: https://codereview.chromium.org//1213873004.
 2015-06-29 11:20:11 -07:00
Asger Feldthaus 34302b1320 dart2js cps: Translate synthesized mixin constructors. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1216593002.
 2015-06-29 15:28:40 +02:00
Stephan Herhut 3b34c17909 Avoid multiline string literal in svgelement test. 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1219673002.
 2015-06-29 12:39:05 +02:00
Jacob Richman 7e9e4d89d3 Revert "Enhance dart:js interop in a backwards compatible manner." 
This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe.

BUG=

Review URL: https://codereview.chromium.org//1209093005.
 2015-06-26 10:29:25 -07:00
Jacob Richman 3fdeb669ee Enhance dart:js interop in a backwards compatible manner. List objects can now be passed back and forth to Dartium without requiring jsify 
BUG=
R=terry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1194643002.
 2015-06-26 10:06:45 -07:00
Stephan Herhut 225be75498 Fix some tests and exclude others from CRLF rewriting. 
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1212823002.
 2015-06-26 14:40:01 +02:00
Kevin Millikin b9192ab9e2 dart2js CPS: Support try/catch/finally. 
Support try/catch/finally by pretending it is macro-expanded into
try/catch and try/finally:

    try S0 catch (ex, st) S1 finally S2
    ==>
    try { try S0 catch (ex, st) S1 } finally S2

The duplicated code for try/catch and try/finally is abstracted into a
function parameterized over translations for all the parts that
differed.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1207703002.
 2015-06-24 17:13:15 +02:00
Kevin Millikin 089ed2965b Implement try/finally by inlining the finally code. 
Try/finally is implemented by inlining.  There is a try/catch to catch
exceptions in the try block.  The catch body contains the finally code
followed by a rethrow.  The code for finally is translated again after the
normal exit of the try block.  Break, continue, and return exits in the try
block have the finally code inlined just before the exit is taken.

Try/catch/finally is not yet supported, it requires some changes to the
assigned variables analysis.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1201983002.
 2015-06-24 10:12:42 +02:00
Asger Feldthaus 04c5c61a10 dart2js cps: Refactor and optimize string concatenations. 
The ConcatenateStrings IR node has been removed. It was a leftover from
dart2dart.

Expressions inside string interpolations are now stringified explicitly
and we concatenate strings with a pure StringConcat operator.

ConstantExpressions have also been removed from the IR. They were also
an artifact from dart2dart and were complicating the optimizer.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac75893964144d5712d1da8417c27c232750ec37

Reverted: https://github.com/dart-lang/sdk/commit/988b65336b3194cd539781195a9b8be24b3bbdc3

Review URL: https://codereview.chromium.org//1195573003.
 2015-06-23 13:17:59 +02:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
 2015-06-22 09:41:01 -07:00
Kevin Millikin bf595224d5 Implement simple switch statements as nested if/else. 
Simple switch statements that do not have continue to labeled cases
are compiled into a chain if/else comparisons.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1191193005.
 2015-06-22 11:29:31 +02:00
Karl Klose 3f46181244 cps-ir: Support foreign code. 
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/a120ee7c9071b60edccff066dcdade078f601377

Reverted: https://github.com/dart-lang/sdk/commit/40ed0daaaf71904d2da271e66ba8381ef857116d

Review URL: https://codereview.chromium.org//1185633003.
 2015-06-19 13:44:58 +02:00
Karl Klose 40ed0daaaf Revert "cps-ir: Support foreign code." 
This reverts commit a120ee7c90.

TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1196443002.
 2015-06-18 13:37:52 +02:00
Karl Klose a120ee7c90 cps-ir: Support foreign code. 
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1185633003.
 2015-06-18 13:09:50 +02:00
Karl Klose e4b56654ff Update dart2js-cps_ir test expectations with better annotations. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1181613003.
 2015-06-11 10:56:56 +02:00
Karl Klose 6cffe227fe Update dart2js-cps_ir test expectations after bac7481d3d. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1171773004.
 2015-06-09 15:12:18 +02:00
Karl Klose 993338408e cps_ir: Handle malformed type arguments and type checks. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1156373008
 2015-05-29 09:53:35 +02:00
Alan Knight ee0a5db6a5 Make sanitizer tests handle IE11, where tagName can't be clobbered 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1148893004
 2015-05-27 12:56:09 -07:00
Alan Knight 048079dc20 Narrow suppression of animation tests to MacOS 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1149923005
 2015-05-27 10:35:21 -07:00
Stephen Adams 20a4c2b2a1 Fix safari status - html/js_test now working 
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//1157163004
 2015-05-26 17:56:11 -07:00
Karl Klose bfe00add63 Fix typo in test suppression. 
R=sigurdm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1156043003
 2015-05-26 09:07:48 +02:00
William Hesse 565bf6e0d3 Update status for Chrome 43 on Windows and Mac OS X. 
BUG=dartbug.com/23506,23507,23508
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1142373004
 2015-05-22 14:39:09 +02:00
Karl Klose 36d3e0d0e6 Update cps-ir test expectations. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1152133003
 2015-05-22 09:58:58 +02:00
Alan Knight e7289bc080 Temporarily suppress IE11 sanitizer test failure around tagName 
BUG=

Review URL: https://codereview.chromium.org//1152653003
 2015-05-21 17:44:57 -07:00
Alan Knight 6452961033 Unsuppress animation tests on Chrome, they seem to have switched back to working 
BUG=

Review URL: https://codereview.chromium.org//1157463003
 2015-05-21 14:05:37 -07:00
Alan Knight efb738f633 Sanitization should reject elements that we can't examine (e.g. embed/object on FF) 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1146753004
 2015-05-21 13:54:50 -07:00
Asger Feldthaus ccee558a5b dart2js cps: Access to lazily initialized fields. 
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1136843006
 2015-05-19 10:05:09 +02:00
alanknight@google.com 34bf1903fa Update tests for Firefox 38, now on Windows bots 
BUG=

Review URL: https://codereview.chromium.org//1132013007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45828 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 22:19:49 +00:00
alanknight@google.com 1f20842389 Another try at appendHtml and insertAdjacentHtml should be consistently sanitized 
BUG=

Review URL: https://codereview.chromium.org//1123173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45818 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 17:59:23 +00:00
alanknight@google.com bfa61f62e0 "Reverting 45815" 
BUG=

Review URL: https://codereview.chromium.org//1127403006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45816 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 17:04:53 +00:00
alanknight@google.com 1c69173804 Test Dartium with appendHtml sanitizing. Will immediately revert. 
BUG=

Review URL: https://codereview.chromium.org//1133343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45815 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 16:30:17 +00:00
alanknight@google.com 90a31f8fea "Reverting 45807" 
BUG=

Review URL: https://codereview.chromium.org//1139193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45808 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 01:29:49 +00:00
alanknight@google.com 2faa58eb4c Testing for appendHtml and insertAdjacentHtml should be consistently sanitized 
BUG=

Review URL: https://codereview.chromium.org//1147473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45807 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 01:10:19 +00:00
alanknight@google.com e1c798b0fd "Reverting 45790" 
BUG=

Review URL: https://codereview.chromium.org//1138383006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45791 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-14 19:04:23 +00:00
alanknight@google.com 9453809937 appendHtml and insertAdjacentHtml should be consistently sanitized 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1081973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45790 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-14 18:04:17 +00:00
alanknight@google.com 380e195ba1 Carefully suppress remaining IE and safari mobile sim failures 
BUG=

Review URL: https://codereview.chromium.org//1137343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45769 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-13 17:36:34 +00:00
karlklose@google.com 9b32c9e673 Implement raw list checks. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1123343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45762 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-13 11:58:45 +00:00
alanknight@google.com ac3a2ea130 IE Event test suppressions 
BUG=

Review URL: https://codereview.chromium.org//1125283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45750 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-12 22:56:28 +00:00
alanknight@google.com 083429a6ef Workaround Dartium limitation in event_test 
BUG=

Review URL: https://codereview.chromium.org//1137803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45748 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-12 22:15:51 +00:00