John McCutchan
dfc35faaf9
Make exclude list also exclude contexts
...
- Only create a context if the directory/.packages/pubspec.yaml is not excluded.
- Add tests.
Fixes: https://github.com/dart-lang/sdk/issues/23941
R=brianwilkerson@google.com , devoncarew@google.com , paulberry@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//1263443005 .
2015-08-03 13:54:17 -07:00
Brian Wilkerson
24189ea4f9
Make PathFilter use the resource providers path context
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1260443006 .
2015-07-31 10:06:38 -07:00
pq
f013d3868c
Actual URI support for package URI resolution.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//1245263002 .
2015-07-21 15:53:56 -07:00
John McCutchan
977d213344
Refactor AnalysisOptionsProvider
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1245513002 .
2015-07-17 15:17:40 -07:00
John McCutchan
4bf66ce912
Add an AnalysisOptionsProvider to analyzer
...
BUG=
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1231633011 .
2015-07-17 13:34:03 -07:00
John McCutchan
c9dd867c1f
Add path filter
...
BUG=
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1232763004 .
2015-07-17 10:06:29 -07:00
pq
a81c308283
Analyzer code cleanup.
...
Removed some unused imports and fixed member sorting.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1230273002 .
2015-07-10 13:42:27 -07:00
John McCutchan
7abe54a857
Move from .sdkext to _sdkext
...
Reason: Pub does not publish dot files.
Review URL: https://codereview.chromium.org//1224103003 .
2015-07-08 16:33:09 -07:00
John McCutchan
13deb397a0
Second attempt at fixing SdkExtUriResolver.restoreAbsolute
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1229563006 .
2015-07-08 12:50:38 -07:00
John McCutchan
6ecf960c5e
Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1214823003 .
2015-07-08 10:28:19 -07:00
Paul Berry
db6c95502a
Work around naming conflict in analyzer's Resource class.
...
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name. (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).
As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class. In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1215753003 .
2015-06-26 13:00:44 -07:00
Konstantin Shcheglov
4936eb8d5d
Fix for 'Create part' Quick Fix.
...
1. NonExistingSource.modificationStamp should return -1.
2. NonExistingSource.fullName should be always an absolute path, not a URI.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1135073004
2015-05-18 11:55:23 -07:00
paulberry@google.com
279c20a625
Log details of calls to "pub list" to instrumentation.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1079673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45080 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:50:45 +00:00
scheglov@google.com
9534f300c2
ReApply: Issue 23133. Fix for restoring 'package:' uris on Windows.
...
There was a bug in the previous version https://codereview.chromium.org//1070203002
We used system path context instead of the one from the given ResourceProvider.
So, it worked, but was failing tests on Windows, because we always use posix style.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23133
Review URL: https://codereview.chromium.org//1051273007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45069 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 15:27:07 +00:00
ricow@google.com
88a0451f5a
Revert "Issue 23133. Fix for restoring 'package:' uris on Windows."
...
This reverts revision 45023
It is my strong suspicion that this is causing the redness here:
http://build.chromium.org/p/client.dart/builders/pub-win-russian-be/builds/3729/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio
R=scheglov@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1073993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45049 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 05:55:53 +00:00
scheglov@google.com
1be249945b
Issue 23133. Fix for restoring 'package:' uris on Windows.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23133
Review URL: https://codereview.chromium.org//1070203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45023 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 18:23:42 +00:00
brianwilkerson@google.com
98b7382071
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//975453004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44149 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 21:34:46 +00:00
paulberry@google.com
45b7294eff
Don't do folder existence checks when parsing pub list results.
...
It's just a waste of time since we already to folder existence checks
when resolving package URI's. Besides, all the folders output by pub
list should always exist except in pathological situations.
Improves total analysis time by about 2%.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//952333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44137 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 18:28:22 +00:00
danrubel@google.com
a2baa0f2ba
remove unused imports
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//962323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44104 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 21:09:29 +00:00
danrubel@google.com
10be2665af
(TBR) fix PubPackageMapProvider to use resourceProvider context for path
...
BUG=
Review URL: https://codereview.chromium.org//966453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44072 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 20:18:15 +00:00
danrubel@google.com
6a90488fc8
cache pub list results
...
BUG=
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//941883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44062 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 17:24:08 +00:00
paulberry@google.com
88e19fcb6e
When converting files to package URI's, favor longer directory matches.
...
Longer directory matches in mean that the relative path part of
the package URI will be shorter, making it more likely to match
user intent.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//953863004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44025 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 18:04:09 +00:00
paulberry@google.com
2b6e5b5f68
When translating from file to URI, make sure translation is reversible.
...
BUG=dartbug.com/22555
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//935453007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44003 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-24 22:15:39 +00:00
brianwilkerson@google.com
0e73ada9c2
Use package: URIs for files in lib
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//914373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:47:34 +00:00
brianwilkerson@google.com
c2d3ff3b95
Handle exception and clean-up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
scheglov@google.com
658d3e949e
Check PackageMapUriResolver constructor arguments.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//887943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
danrubel@google.com
3f91cbb15e
null check for pub result in PubPackageMapProvider
...
BUG=dartbug.com/21814
R=paulberry@google.com
Review URL: https://codereview.chromium.org//750113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42173 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:58:31 +00:00
brianwilkerson@google.com
ba033a38f9
Fix the code completion timing test
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//761533006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42007 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 20:09:17 +00:00
scheglov@google.com
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
scheglov@google.com
71a54f980b
Replace ${name} with $name where possible.
...
...i.e. when the next character is not a part of an identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//681003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41333 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 19:43:44 +00:00
paulberry@google.com
5b45f8e762
Move PubPackageMapProvider to its own file.
...
This will allow clients of the AnalysisServer package to provide their
own PackageMapProvider without bringing in a dependency on dart:io.
R=brianwilkerson@google.com , rpaquay@chromium.org
Review URL: https://codereview.chromium.org//599133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40638 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-24 18:09:08 +00:00
jwren@google.com
944174f36a
Move package_map_provider.dart from the server to the analyzer package to be used by the command line analyzer.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//560553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40051 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 20:36:35 +00:00
scheglov@google.com
c5263aae9f
Breaking changes in 'analyzer' package.
...
1. Source.uri added.
2. DartSdk.fromEncoding() replaced with fromFileUri().
This CL cannot be committed as is until pkg/code_transformers is fixed.
R=brianwilkerson@google.com , sigmund@google.com
BUG=
Review URL: https://codereview.chromium.org//428303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38949 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 20:41:42 +00:00
scheglov@google.com
57b5c62818
Test for the 'importing a package library' fix.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//426793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38653 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 22:18:14 +00:00
scheglov@google.com
4a47ef63f5
Move PackageMapUriResolver into analyzer.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//422973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38650 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 21:09:58 +00:00