Liam Appelbe
de0805283e
[nnbd] Re-add null checks in NNBD SDK file_impl.dart and directory_impl.dart
...
They were removed here: https://dart-review.googlesource.com/c/sdk/+/133060
Until everyone is migrated, we still need these null checks
This fixes standalone_2/io/file_constructor_test and
standalone_2/io/directory_fuzz_test
Change-Id: I5882ae924d1de0b88f4f0d2012e571fcef697868
Bug: https://github.com/dart-lang/sdk/issues/40614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135540
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-24 23:37:43 +00:00
Janice Collins
4c93115390
Upgrade steamroll_ecosystem to handle all hacks and run dartfix
...
end to end.
Change-Id: Idef5a99483abc79469c543435ea44289c000080a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135720
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-24 22:44:19 +00:00
Joshua Litt
2596c20486
[dart2js] Fix a bug with substitution of type variables and NNBD.
...
Change-Id: I5c5f6152b2f1c25a1ba0b3800023b550b8fabca0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136981
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-24 22:17:09 +00:00
Devon Carew
d2c9f906e8
[dartdev] show progress while the dart analyze command is running
...
Change-Id: If10a921bb25c0e87ae32ff35cfdcd21e124bbd0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137000
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2020-02-24 22:11:29 +00:00
Vijay Menon
b5a08c916c
[dartdevc/nnbd] fix null checks in primitive casts
...
These should go through the `cast` operation to fail in strong and pass with warning in weak.
Change-Id: I1863b507835c0c9993357318b9e7038154e47151
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136902
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2020-02-24 21:42:58 +00:00
Jaime Wren
fc6ace52c7
dartdev nits- test name and usage of ??
...
Change-Id: If789777f4e9022a5eafe6214624bc7c6c2726e36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136812
Auto-Submit: Jaime Wren <jwren@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-02-24 19:02:46 +00:00
Brian Wilkerson
0dca599153
Unify diagnostic names for uninitialized non-nullable fields
...
Change-Id: I1aa63cbb6f8aa8f3496df348dc1bc415ae8b1373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-24 17:59:56 +00:00
William Hesse
1ccad5fdf2
[analyzer] Fix line number in error test golden file
...
This failure was introduced by a stray change in
https://dart-review.googlesource.com/c/sdk/+/136903
Change-Id: Icd4d17539d72189e4f78940e0ee0fa4746873f86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-24 14:50:07 +00:00
Samir Jindel
9ab51b8012
[vm/tfa] Convert named and optional parameters to required parameters where possible.
...
Flutter Gallery code size (total):
ARM64: -2.31%
ARM32: -2.38%
Change-Id: Ide7764afb06bf6f8387015de612cd4798b301541
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135305
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-24 14:09:27 +00:00
Jens Johansen
372d306b36
[CFE] Update tool for investigation of the runtime via service protocol
...
Change-Id: I670f97f135c8cae37b6e07e95e6de69e88a1caf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136586
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-02-24 13:42:17 +00:00
Johnni Winther
1e7669885d
[cfe] Handle late lowering field type inference
...
Closes #40581
Change-Id: I50f5ad10e4b37ad58b5c9ad05e593572857d1351
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136636
Reviewed-by: Jens Johansen <jensj@google.com >
2020-02-24 13:29:25 +00:00
Johnni Winther
aa31a9162b
[cfe] Support constant evaluation in agnostic mode
...
Change-Id: Ia33ea19a091b1172eb9b4125f5f30a625886d34e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136632
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-02-24 13:29:05 +00:00
Johnni Winther
a9162bd599
[analyzer,cfe] Implement mixed inheritance id test for analyzer
...
Change-Id: Ie4ce09b83c2a96a5ad16c60d2924f18cd90a4089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136633
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-24 13:28:26 +00:00
Konstantin Shcheglov
ce5fb94014
Issue 40538. Revert YieldStatement changes after reverting language spec decision.
...
Bug: https://github.com/dart-lang/sdk/issues/40538
Change-Id: Idd563a15dc1e17e1271f823c33d015c73f720874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136814
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-23 21:32:44 +00:00
Brian Wilkerson
ed40a9d77e
Add a fix to remove dead null-aware operators
...
Change-Id: I4573eb87b1e454923655b2b7010ab84f4698ce79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136922
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-23 21:27:54 +00:00
Konstantin Shcheglov
f8f4b5ddd7
Transition DAS to analysis / idle when setAnalysisRoots with no Dart files.
...
Bug: https://github.com/dart-lang/sdk/issues/40096
Change-Id: I84b83d374e325f1c3c90be30c5c33ed6007b8849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-23 21:04:47 +00:00
Brian Wilkerson
cc45c9358b
Rename another diagnostic code
...
The diagnostic applies to both the if-null expression ('??') and the
compound assignment expression ('??='), so it seems like the name should
be more general.
Change-Id: I004cc2924ef97fcbd2168f070380ff17152cbb0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136903
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-02-23 17:11:24 +00:00
Nicholas Shahan
d41e419904
[dartdevc] Fix nullability of function types and typedefs
...
These fixes also prepare for an upcoming change to normalize FutureOr
types.
- Cache and emit the hoisted function type at the top level without
nullability wrappers.
- Always emit nullability wrappers at the use site.
- Fix issue where sometimes the return type would be double wrapped.
Change-Id: If4a0c94e62eca626f271cc3c259c813911075d9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136404
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-02-22 01:20:21 +00:00
Nicholas Shahan
9d1b5ced65
[dartdevc] Update instantiated type arguments in tear-offs
...
They now become a `Object*` or `Object?` if the library where the method
is defined is legacy or null safe.
Change-Id: Ia3de0d728187b9c5bf64cc8c08aa075e63aff942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136723
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-02-22 00:34:21 +00:00
Nicholas Shahan
cfc23cde53
[dartdevc] Removed deprecated 'library-root' command line option
...
It has always been ignored by kernel based DDC. No longer needed now
that analyzer based DDC has been deleted.
Change-Id: I50f010b79c22a41ee9a1b8c1e149f50f705a42fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130124
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-02-22 00:20:01 +00:00
Ben Konyi
1f0611919d
[ package:vm_service ] Non-reference types now implement their reference types. Fixed inconsistencies in protocol spec.
...
Change-Id: I6529c722d595ceeb80b7eabebef0e99c59db975b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136811
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2020-02-21 23:44:43 +00:00
Konstantin Shcheglov
732cd81f05
Move expectedErrorsByNullability / typeStringByNullability to ResolutionTest mixin.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I9ee6cf8ab8d06bc02ee4a52a6d7e5b63d277e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136810
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-21 21:59:35 +00:00
Konstantin Shcheglov
bc2c4181c1
Issue 40734. Allow multi-digit major / minor language version components.
...
Bug: https://github.com/dart-lang/sdk/issues/40734
Change-Id: Ic88082ba0ee86986e92c0944a93c0b299a1c825f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-21 21:38:40 +00:00
Joshua Litt
6b6d09a9ed
[dart2js] Update dart2js nnbd analyzer goldens.
...
Change-Id: Ic6329238802130f721348a606c3ebfdf89508d99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136805
Auto-Submit: Joshua Litt <joshualitt@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-02-21 21:04:26 +00:00
Konstantin Shcheglov
ce26dfda7d
Issue 37487. Add CompilationUnit.languageVersion override.
...
Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: I57fbcdd6771d9004ba1fc43902c19514dab2a23d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-21 20:19:43 +00:00
Jaime Wren
754972096f
Add a test to dartdev which asserts that all the command descriptions end with a period.
...
Change-Id: I3676e393b341afbdf78cde2af2133177de11b1a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136711
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2020-02-21 19:45:31 +00:00
Stephen Adams
eb29627e9e
[dart2js] Handle injected names from late fields
...
Change-Id: I5ca6535a282ce8fdf4fba6cd1fa5752bce2921c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136714
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Stephen Adams <sra@google.com >
2020-02-21 19:31:16 +00:00
Konstantin Shcheglov
c09e6c18b7
Issue 40538. Verify yield statements using new element type based rules.
...
Bug: https://github.com/dart-lang/sdk/issues/40538
Change-Id: I9feaca0484f7a5c779068e823bbd765f5c06fe59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136712
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-21 19:26:27 +00:00
Mark Zhou
8db8ebc2f3
[dartdevc] Removing nullability wrappers from deferred type parameter types.
...
This fixes the issue of nullability wrappers showing up around the settee of 'setBaseClass'.
Change-Id: I73207fafe33a039567052ae2c5c8c1a84d7505df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136724
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-02-21 19:23:10 +00:00
Joshua Litt
5aeb1a3f11
[dart2js] Update libraries.yaml with migrated dart2js.
...
Change-Id: Ibd70ce90d3b965d438a153654efb5e5bff94a201
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135798
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2020-02-21 18:37:40 +00:00
Brian Wilkerson
33e6f4af33
Rename a diagnostic code
...
Change-Id: I0b712af35d4a904bd0507b63ca52595cfcc7de2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136728
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-21 18:34:20 +00:00
Lasse R.H. Nielsen
98b4635aa9
Make TypeError no longer implement AssertionError.
...
This means that TypeError no longer inherits a spurious `message` member.
The message of a platform-thrown TypeError is still available as `toString()`.
Fixes #40317
Bug: http://dartbug.com/40317
Change-Id: I77312859ebae3f92c2e56aeea6283b075b71c8d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136129
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-02-21 14:02:57 +00:00
Johnni Winther
5829fc7829
[analyzer,cfe,dart2js] Add marker.options files to automate running id tests on all configurations
...
Change-Id: Ib5eb7f3967634721047f8dcc57b9e6c350b91a41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136226
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-21 08:34:26 +00:00
Jaime Wren
d986ab830e
Initial implementation in dartdev for the 'analyze' verb. This 'dart analyze .' carries over functionality from 'flutter analyze .', but with minimal flags (as a starting point).
...
Change-Id: I4a9e2210b2b9923ffd7b33073a7b0ea7946f1438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136520
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2020-02-21 07:44:46 +00:00
Clement Skau
ad118b1718
[Kernel] Fixes bug in async transform causing reuse of temps.
...
Certain nodes will delimit(..) an Expression to some Statements, which
was resetting the temp nameIndex.
This meant any sub-expressions that generated temps would not cause the
outer expressions to see those already used temps.
Bug: https://github.com/dart-lang/sdk/issues/40662
Change-Id: Ife07052ab756b9d05f34f69380614c7eb7309a4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136224
Commit-Queue: Clement Skau <cskau@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2020-02-21 07:35:16 +00:00
Devon Carew
9bedc9a7af
[dartdev] bring in the new stagehand project template
...
Change-Id: Ie6c0c83bec3db86f430faeb033b0de7ebaf183cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136660
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-21 00:26:30 +00:00
Robert Nystrom
b81f12a549
Migrate language_2/async_star to NNBD.
...
Change-Id: I0fa2ee2561dd0bc399d88868d790d56e6df3c94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134940
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-02-21 00:22:06 +00:00
Srujan Gaddam
a42c072017
Remove unnecessary null check in getPropertyValue
...
CSSStyleDeclaration.getPropertyValue returns a non-nullable string.
It will also return an empty string if the property is not found. Since
getPropertyValue returns the value of the native getPropertyValue, the
null check should be removed.
Change-Id: I9846553d3f9fcd68cbd15b9c39d2104cab594b7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136413
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-02-20 20:49:26 +00:00
Paul Berry
7911b6a989
Migration: fix handling of part files.
...
This CL fixes several minor bugs:
- In info_builder.dart, we were trying to apply SourceInformation from
the defining library to all its parts.
- In NnbdMigrationTestBase, we were trying to fully migrate each file
before processing any other files. We need to prepare each input,
then process each input, then finalize each input.
- In NodeBuilder, we were failing to send part file sources to
NullabilityGraph.migrating(). As a result, methods declared in part
files were being treated as already migrated, so they were getting
the wrong kinds of nullability nodes.
- In _ProvisionalApiTestBase, we were sometimes visiting parts before
discovering what libraries they were part of, causing inconsistent
resolution results.
I'm hoping this will be sufficient to address
https://github.com/dart-lang/sdk/issues/40670 .
Change-Id: I07d693b31b6cf64bc6f72126f5ef4792b29e5029
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136521
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-02-20 19:55:18 +00:00
Konstantin Shcheglov
a248f88e8e
Extract YieldStatementResolver.
...
Change-Id: I1e7c60dac6d97152fc8e3a463bc2f66274ed4f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-20 19:53:45 +00:00
Devon Carew
66353dc196
[dartdev] tweak the help text for the pub and format commands
...
Change-Id: Id7b24e5866acf04b93973fc08d76dc93722a3173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136321
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-20 19:16:52 +00:00
Konstantin Shcheglov
561039dd9e
Extract YIELD_OF_INVALID_TYPE tests.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I3f57f8d64e08312006ba3cdb81166453d91c867e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136704
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-20 19:02:10 +00:00
Brian Wilkerson
4ef4371891
Replace "generates" with "produces" in the diagnostic docs for consistency
...
Change-Id: I231467cb2186d81068e99215a6e94d6f76a31666
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136641
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2020-02-20 17:22:19 +00:00
Keerti Parthasarathy
67e42b611c
Add a resolver for resolution of a single file.
...
Change-Id: Ibe7062942db8d921c8305a5ab7fd5bd0f9667773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136409
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-02-20 16:06:39 +00:00
Jens Johansen
bc4893a3b3
Revert "[parser] New syntax for null aware index"
...
This reverts commit cf4e044e07 .
Reason for revert: Breaks internal customer.
Original change's description:
> [parser] New syntax for null aware index
>
> Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903
> Commit-Queue: Jens Johansen <jensj@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=brianwilkerson@google.com ,jensj@google.com ,johnniwinther@google.com
Change-Id: Ic0ff607c944e489f29bda7da37afd63c62d368eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136600
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-02-20 14:11:08 +00:00
Dmitry Stefantsov
b7aff59973
[cfe] Report errors on case expressions without primitive equality
...
Bug: http://dartbug.com/40425
Change-Id: Ied2da91cc32b84f6e64c0b76541e020d1a2447b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136227
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-02-20 13:39:09 +00:00
Johnni Winther
5c869545f2
[cfe] Add option for agnostic nnbd mode
...
Change-Id: Ie37b0fcd30985992ce5c4973bf1cce1ccba181a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136580
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-20 12:47:38 +00:00
Jens Johansen
cf4e044e07
[parser] New syntax for null aware index
...
Change-Id: Iea6b29eb897eb01863a92b223e270d225c3ca1ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135903
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-20 12:33:28 +00:00
Johnni Winther
e6d1762ff2
[cfe] Add test for issue 40512
...
Change-Id: I85eed2287a4df8c38035cf79847753f1ce8a032b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136189
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-02-20 10:27:58 +00:00
Konstantin Shcheglov
81d4cc6bc9
Issue 40701. Include 'late' into unlinked API signature.
...
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/sdk/issues/40701
Change-Id: Ia11ff4e65e779c4a370a6fec539564c0533bffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136529
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-20 04:16:35 +00:00