a4b3b8edec
Add an assist to convert a normal parameter to a super initializing parameter
...
Change-Id: Icf5d44a3a155e67f76165eca711094d368cdca64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-02-04 01:03:36 +00:00
ddff5ac88c
Tests for completion in NamedExpression.
...
Change-Id: I5a7ba57a1279797f7e625890a64c42091708f60e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-02-03 22:24:16 +00:00
d48a637bf5
[Analyzer] Add fix for use_raw_strings lint
...
Closes https://github.com/dart-lang/sdk/issues/47955
Bug: https://github.com/dart-lang/sdk/issues/47955
Change-Id: If321097598fcdcd79c246032f64332e91ee7f57c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-02-03 15:55:56 +00:00
4a5b0b3030
[analysis_server] Fix slash direction in auto-import details for LSP completions
...
Fixes some failing tests on the Windows bots that were getting backslashes but expecting forward.
Change-Id: Idd89a45d7be87385d497e221a1941e4c48d597af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-02-02 17:26:09 +00:00
eb4f5077ab
Check for private elements while rename
...
Change-Id: I3423cd746e675315a3abd1b728bc6cd978384beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2022-02-02 03:08:46 +00:00
7a6326e49c
Update fix statuses for 2.15, 2.16, 2.17 codes
...
* many super-parameter codes can have a fix of "remove 'super.'"
* many constructor-tearoff codes can have a fix of "remove type
arguments"
* did not evaluate the FfiCodes or PubspecWarningCodes
Change-Id: I3421f226ec88621d9927970cb607e13577c8f234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-01-28 17:19:22 +00:00
c49ccf09f1
Add a file to track all codes and fix status
...
Also sort a few files.
In general only "has fix(es)" and "needs evaluation" has been marked so far.
Evaluations will come later.
Change-Id: Ibc2207a17ac158db795920216af2a7e9f376658c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-01-28 06:13:21 +00:00
6dd2790b57
Use cached enclosingClassElement for extension completion.
...
This improves time to compute completion metrics from 61 to 48 seconds.
We used to spend 21% of all time in `[Stub] InstanceOf`.
Now 2%, unfortunately it does not show back pointers.
Change-Id: I3c6c62cabfa86bac138d95d4830b605693e086d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-01-27 23:34:42 +00:00
7a4c3c1c46
[analysis_server] Handle workspace folders with trailing slashes in LSP server
...
Fixes https://github.com/dart-lang/sdk/issues/48234 .
Change-Id: Ic10ab8054681779dd5ea6a1617e2f8a4057aee57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-27 17:09:30 +00:00
7ad1786e45
[analysis_server] Refactor completion handlers in preparation for using NotImportedContributor
...
Change-Id: I18608b110093e87887f8e9118340e323fe829248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-26 20:07:28 +00:00
540c053ca8
Add HighlightRegionType.EXTENSION
...
Change-Id: I375df19b8ee5f6570fcc7d440b9d71b148bcef73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-26 16:11:59 +00:00
afd8df4d54
Fix for suggesting enum constructors, tests for both protocols.
...
Change-Id: I71721cf0e2c3c772b1662f2abe065837c5405ad2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229950
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-26 00:44:59 +00:00
4e77df92de
Add a fix for the leading_newlines_in_multiline_strings lint.
...
Bug: https://github.com/dart-lang/sdk/issues/47960
Change-Id: Id775cfc3a2c5a8635ad26c8b4a611c94e770b6b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-25 17:24:01 +00:00
e3a2e59f18
Don't use 'whereType' in NotImportedContributor.
...
Bug: https://github.com/dart-lang/sdk/issues/47680
Change-Id: I7e90f52e7658eef4b9280f485b457d86ac0f4e9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-25 06:41:09 +00:00
1708703d15
Complete the refactoring of ElementMatcher
...
There are quite a few TODOs left in the code, and I'll address them in
future CLs, but this appears to be consistent with the behavior of the
previous implementation and finishes the majority of the refactoring
changes.
Change-Id: I68093f6ac115f8b8b9b10bf93239fe4e2b9c6390
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-25 05:36:36 +00:00
61de22db59
Test for enum constants with isNotImportedFeature, simplify it.
...
Change-Id: I1e00cd7291a4e018d1fc4820862c7e4c9d84be15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229325
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-22 00:11:00 +00:00
8781ab0151
Update CompletionWithSuggestionsTest for better alignment with the new protocol.
...
A few tests added, mostly removing CompletionSuggestionKind.INVOCATION
because it is set just for any available declaration by the completion
driver, but this is not what we use for local elements and the new
protocol.
Change-Id: I87da134fd94da75005a98e17e81f43ee56451baf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-20 22:44:08 +00:00
c736694ba2
Decrease relevance of not-yet-imported suggestions.
...
Change-Id: I00f309bee05f79ae400878a000a197ac1732b97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-20 22:03:57 +00:00
5bf643b24a
[analysis_server] Include static type in LSP hovers
...
Fixes https://github.com/dart-lang/sdk/issues/48147 .
Fixes https://github.com/Dart-Code/Dart-Code/issues/1160 .
Change-Id: Icc4bbb5b89a75a14579f72b2c74929e7a05ac688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-19 16:45:15 +00:00
df2e8fedbb
Start to refactor ElementMatcher
...
This is the first of multiple smaller CLs to refactor `ElementMatcher`.
I was starting to fix a bug and realized that the current implementation
allows the number of components to be out of sync with the element kind.
The primary goal is to prevent that by eventually merging the methods
`_componentsForNode` and `_kindsForNode` into a single method
(`buildMatchersForNode`).
In the process I realized that we can sometimes match either a top-level
declaraation or an instance member from a superclass, and that means
that we need multiple matchers (otherwise I think the number of
components will continue to be out-of-sync with the element kinds).
This CL also includes the failing test that started the whole
investigation into refactoring this class.
Change-Id: I0c3a56f29f0f6c6d0cad6ac80145b26201931518
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-18 23:39:27 +00:00
08c42b3178
[analysis_server] Fix some minor LSP codegen issues
...
Change-Id: Ie6171416cca75ec623d600ddea2e1efefd8156ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-18 17:35:05 +00:00
f0475f6015
[analysis_server] Add LSP semantic token modifier for instance fields/methods
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3778 .
Change-Id: I112ebf727925e2b576e91e719489ca7502e55058
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-18 16:58:25 +00:00
92da2376bc
[analysis_server] Handle override completion before getters
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3784 .
Change-Id: I422f7758f0ae713a37c4b15672828ada67ce9d65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-18 16:16:16 +00:00
a8c63a8773
Semantic highlighting for super-formal parameters.
...
Change-Id: Ib3a663c9bec7909451c082bcc8943df08339a35f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228380
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-17 00:11:24 +00:00
e8098caeab
Field formal parameter identifier is a declaration.
...
Change-Id: I70bdf7af8f2663a056b8b9be65f5ea23a105d2f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-15 20:37:53 +00:00
650b9627b7
[analysis_server] Rebuild analysis contexts if changes occur between creation and watchers being ready
...
See https://github.com/Dart-Code/Dart-Code/issues/3438 .
Change-Id: I3ca038d8c878b118a465b6f230c62912d63990eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-15 00:18:41 +00:00
9abb0d17c8
[analysis_server] Use existing line/col information in preference to LineInfos for LSP diagnostic mapping
...
See https://github.com/dart-lang/sdk/issues/48092 .
Change-Id: Ifdacf33b30c19859aa33be83300329454637ba5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-14 19:26:31 +00:00
6e30e5a7f6
Add 'Extract local variable' fix for UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE.
...
Bug: https://github.com/dart-lang/sdk/issues/47588
Change-Id: Ice823f239b3b152d9583cecb143ea78a62361539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227900
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-13 01:03:22 +00:00
2170c061b0
Add Element.libraryUri and CompletionSuggestion.isNotImported
...
Remove libraryUrisToImport and libraryUriToImportIndex.
Change-Id: Iafe27d6fb0c5ce0c623567a0384a4579274b151f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227580
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-11 19:53:14 +00:00
6041987d33
Index, search, rename for super-formal parameters.
...
Change-Id: Ic220a9011914a54a9b35e667edbe90af4257b860
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226803
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-07 18:18:56 +00:00
794a42074d
Code completion for super-formal parameters.
...
Change-Id: I52b0786f7db8e8ec0181b5e4d7eb352b157856b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226606
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-06 19:46:15 +00:00
3adbfcf6a5
Suggest SUPER if Feature.super_parameters is enabled.
...
Change-Id: I9d6393a412e5f5016359c89cf85fd910b0ac9357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226608
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-06 19:07:55 +00:00
c548470d26
Dart Analysis Server change to the code completion getSuggestions2 protocol, adding completionMode and invocationCount.
...
Change-Id: I6095cda72943a52de211cf758fbf45fe98d6f0d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2022-01-05 21:15:50 +00:00
aeb50d4e6f
Make CompletionSuggestionKind a required parameter.
...
Change-Id: Icd69f9d2853b5acfe8dbf9a5f75ba5437a881bc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-05 20:19:04 +00:00
f795340952
Add required keyword when fields are non-nullable
...
Fixes https://github.com/dart-lang/sdk/issues/48021
Change-Id: I75062fba435d56beaea26b93178d24030a98fb32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226482
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-01-05 18:08:46 +00:00
cd13938e5e
Use CompletionSuggestionKind.IDENTIFIER for properties and accessors.
...
Change-Id: Ib40bc5a73b551aee98b3a783513909727cd1e9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-05 17:21:54 +00:00
ccc1656eb0
Improve the message when the required keyword needs to replace the required annotation
...
Fixes https://github.com/dart-lang/sdk/issues/46841
Change-Id: If318064a901f3cf1cbcf117ad392d72a9cf004fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-05 16:38:25 +00:00
7dd8732825
Use CompletionSuggestionKind.IDENTIFIER for local variables and typedefs.
...
Change-Id: I1638d15a81a6a43ee1319e1d7227323f19efda53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-04 20:57:42 +00:00
57fdc16b7b
Enable prefer_final_parameters quick fix for default parameters.
...
Fixes #47912
Bug: 47912
Change-Id: Ic2e2802ee89d6f78750efef862dcaa74083a9d33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225840
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2022-01-04 19:23:51 +00:00
ad773d003b
Suggest classes with CompletionSuggestionKind.IDENTIFIER
...
Change-Id: I99a4eb7d4ca6d58c779390243a0d2caa6b509183
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-04 18:10:11 +00:00
0870e9f38c
When run out of budget during not-yet-imported, mark incomplete.
...
Change-Id: Ic03bf7f20301f6790c3041b51cd4ef01208d840f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225860
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-12-29 22:27:37 +00:00
6e27367656
Refactor ElementDescriptor to make enhancements easier
...
Just moved some code into separate methods so that the one method doesn't
become unreadable.
Change-Id: I48ffa0f53ae12b0cbf0d379db6ee03ad4d458704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-12-23 23:15:52 +00:00
3bcae89fcc
Use the unique names of lint codes in FixProcessor
...
Some lint rules produce more than one lint code and sometimes the fixes
that should be associated with those codes is different. This change
will allow us to use the unique names of those codes to produce the
right fix.
Change-Id: Ib6fc69decb664c1224e33e2a78b28ce91594d826
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225582
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-12-23 20:40:33 +00:00
eaef692c3f
Add quick fixes for invalid return types for generator functions
...
Change-Id: I23a3befd37946c02aadc8c0ebdf75e60cf6767c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225426
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-12-23 17:36:42 +00:00
7b7079f519
Allow authors to specify that a member is static
...
This information isn't currently being used, but the intention is to not
apply a transform for a static element if the reference to the element
isn't qualified by the name of the container (because outside the
container all references to a static member must be qualifed).
Change-Id: I9e316c32287e6cf3dcdfd911296bc3948f1749e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-12-23 00:11:32 +00:00
b16b0322b9
Reland "analyzer: Report missing return for nullable return types"
...
This is a reland of 93bcdf0329https://github.com/dart-lang/sdk/issues/46656
>
> Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
Change-Id: I369b2dc38db0dc278f50b55aab67da53a5a63a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-12-22 18:46:14 +00:00
3b5d06e449
Revert "analyzer: Report missing return for nullable return types"
...
This reverts commit 93bcdf0329https://github.com/dart-lang/sdk/issues/46656
>
> Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com ,srawlins@google.com
Change-Id: I122be4cb1d07f7f95334d2d5cbac1de4bd597d15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224950
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2021-12-22 08:38:52 +00:00
8d8da75060
Stop using package:intl, but keep in DEPS.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/224660
Reverted: https://dart-review.googlesource.com/c/sdk/+/225260
Change-Id: I66ef3126997c4f564e4181bbe185a1f64abf43e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225324
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-12-22 01:17:04 +00:00
73cfe523e0
Revert "Stop using package:intl, remove it from DEPS."
...
This reverts commit b0d7c56e84https://dart-review.googlesource.com/c/sdk/+/224660
> Reviewed-by: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com ,srawlins@google.com
Change-Id: I39d4a2c773063da4dfa75404b64987f85dbcf764
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-12-21 19:08:24 +00:00
93bcdf0329
analyzer: Report missing return for nullable return types
...
This is implemented as a new HintCode, but it could be a new Warning, if
we'd like to stop adding new Hints.
There is also a dartfix available in this change.
Fixes https://github.com/dart-lang/sdk/issues/46656
Change-Id: I8e93e576d2bd09a8ff02d52c12bbb9ec6adff9c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-12-21 18:22:03 +00:00
Brian Wilkerson