dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
89,608 Commits 2 Branches 0 Tags
ddc19f7f92ff0aaa5ba17ff5e5fab9c82e8339fb
Commit Graph

291 Commits

Author SHA1 Message Date
Nicholas Shahan bdc1ddd5a9 [dartdev] Enable create_integration_test 
Bump build_web_compilers dependency in the web template
pubspec.yaml.

New webdev and build families of packages have been published
that work with the Dart 3 SDK so this test should work again.

Fixes: https://github.com/dart-lang/sdk/issues/51106
Issue: https://github.com/dart-lang/sdk/issues/51037
Change-Id: I854fafb683bff20786b1b31b0368d08b49029e83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280053
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2023-02-01 16:47:38 +00:00
Josh Soref 77978889eb Spelling 
Closes https://github.com/dart-lang/sdk/pull/51143

GitOrigin-RevId: 9e21c99a222d588e4fc95980725a2f8c9784965c
Change-Id: If0870e8936c7649935dce7e23cd783d62aa5610c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279916
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-30 18:29:59 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Paul Berry 5d7b701d12 Remove dart migrate command. 
Bug: https://github.com/dart-lang/sdk/issues/50319
Change-Id: I216a20afe8382eab5872672b2e01ed1daf7ac78d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278367
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2023-01-06 17:21:35 +00:00
Josh Soref 50b94ef9fc Spelling runtime bin 
TEST=build VM

Closes: https://github.com/dart-lang/sdk/pull/50862

GitOrigin-RevId: ae54b37666f70f670ee3af11c984c7e9a7e9da26
Change-Id: I459fda0439a1cd368f488a70d84ee6bb915e60bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277761
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2023-01-06 07:48:22 +00:00
Ben Konyi 778e8d13b2 [ CLI ] Remove --enable-asserts from dart compile exe options 
`dart compile exe` creates a product mode binary, which does not support
asserts.

Fixes https://github.com/dart-lang/sdk/issues/50426

TEST=N/A

Change-Id: I46bfabebc1dd08f0a09ba40105cbfe9721ca34fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278141
Reviewed-by: Derek Xu <derekx@google.com>
 2023-01-03 17:21:41 +00:00
Jens Johansen fa88e0c91f [analyzer] Add benchmarks of running dart analyze 
This CL:
  * Adds a benchmark of running `dart analyze` on a single small file.
  * Adds a benchmark of running `dart analyze` on a single project.
  * Adds a benchmark of running `dart analyze` on several projects.
  * Adds a hidden flag to `dart analyze` so it reports ram usage:
    run via `dart analyze --format=json --memory` and the memory
    usage will be reported in the json output.

All the bencmarks run without and with cache for speed testing, and
without and with cache when measuring memory usage.

The idea of running this via `dart analyze` instead of running either
the script or the snapshot is to measure the "real world" speed which
could be different (although in practise it _does_ just run the
snapshot).

Future CL(s) should also add benchmarks for queries using the
language server.

Change-Id: Iad6d6d72c1a2ed18ab51d056b4914f8b6eb963e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2022-12-19 08:22:32 +00:00
Ben Konyi e3ab2fc4bd [ CLI ] Update dart create templates to support SDK version >=3.0.0-dev < 4.0.0 
Fixes https://github.com/dart-lang/sdk/issues/50635

Change-Id: I7a0fcc95220a7402ff9462d9837e93a2e21f4688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275040
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-12-12 19:56:16 +00:00
asiva 606a64a743 [3.0 alpha][VM/Runtime] - Flip flag to make strong null safety the default. 
- Flip flag to make strong null safety the default
- Remove code that auto detects null safety mode from source files,
  it is necessary to specify --no-strong-null-safety to opt out.
- Retains sniffing of AOT/JIT snapshots and kernel files to determine
  null safety mode, the opt out has to be done when generating these
  file.

TEST=ci

Change-Id: If2c9608eedb7c46d9c3cd85e261ee9640e0d28eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261140
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2022-12-06 04:04:23 +00:00
Devon Carew 4b4b3645b8 [dartdev] uncomment the dependencies: section in the create templates 
Change-Id: I7ad57d3a2fd357b368e8d2210a6dfef0fe2ed4a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273543
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-12-05 17:34:03 +00:00
Devon Carew 793367c498 [pkg/dartdev] add windows support for 'dart bug' 
Change-Id: Id94a4d9e4a485350cbe37f78d5395e093ccf5892
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272741
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-11-30 20:13:05 +00:00
Devon Carew ccb092a5f4 [dartdev] remove the package:intl dep 
Change-Id: Ia884172c15a61d788b175fd7b08239e72b271665
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272860
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2022-11-30 18:00:18 +00:00
Daco Harkes eba9ada49e [pkg/dartdev] Fix bug_linux_test 
Makes test pass when there's snapshots in the current processes.

Makes test pass when there's more digits in the Memory column, the
header is aligned right.

Closes: https://github.com/dart-lang/sdk/issues/50583
Change-Id: Ia0445c38795b60a403b8cba26c0444e829955973
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272820
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2022-11-30 11:06:51 +00:00
Devon Carew 1dd71b412f [dartdev] contribute a 'dart bug' command 
Change-Id: Ib5557711df23d3a3e0485378c04ff6264194717f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269750
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-11-29 16:58:58 +00:00
Ben Konyi 3602351df0 [ VM Service ] Add support for '--[no-]serve-observatory' 
To prepare for the eventual removal of Observatory, we plan on disabling
Observatory by default while providing an escape hatch to manually serve
the tool for some period of time before completely removing Observatory
from the SDK. This change adds flags that can be used to configure
whether or not Observatory is served.

Currently, '--serve-observatory' is the default behavior, but will be
changed to '--no-serve-observatory' once tooling is ready to support the
escape hatch behavior.

Part of https://github.com/dart-lang/sdk/issues/50233

TEST=run_test.dart

Change-Id: Ib6d1e1587d9fbd3c61d4a4c75d90635052835844
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267720
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-11-21 17:47:31 +00:00
Devon Carew 8e70a02f05 [dartdev] updates to the 'dart compiler-server-shutdown' command 
Change-Id: I38c268dace6610083051f9ec62fc9c0846d202d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270023
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-11-16 21:14:41 +00:00
Kevin Moore 0210b58d68 dartdev: update generated .gitignore files 
No standard Dart package creates build directory
.packages is gone

Change-Id: Ib9859a7147f251c0e6422fa75e0d24c7ab3c6070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270025
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2022-11-16 09:14:13 +00:00
Tamir Duberstein 154843a376 Remove analysis server shutdown timeout 
See https://fxbug.dev/98703; this shutdown is sometimes taking longer
than the arbitrary 1 second timeout used here. Make the timeout argument
optional and avoid setting it in the analyze command.

This timeout was previously raised in response to issues in fuchsia in
https://dart-review.googlesource.com/c/sdk/+/237780.

Change-Id: Ic896c36a37735bb49d13cde07a95a6fe7837b580
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269061
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Jacob Richman <jacobr@google.com>
Auto-Submit: Tamir Duberstein <tamird@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-11 00:30:10 +00:00
Devon Carew b31ce2833d [dartdev] update the 'create' template dependencies 
Change-Id: I48a1daf1fc347b88a604767c3b5866909c912847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268368
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-11-09 17:09:13 +00:00
Ben Konyi 72506b826a [ CLI ] Add support for --[no-]sound-null-safety to dart compile {jit-snapshot,kernel} 
Fixes https://github.com/dart-lang/sdk/issues/50079

Change-Id: I4a71dab1c9003f13ff74741bc64f3ee239c03195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262620
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-10-04 17:03:29 +00:00
Ben Konyi c8651ac551 [ CLI ] Force isolate running dart2js to use --no-sound-null-safety 
Fixes https://github.com/dart-lang/sdk/issues/50090

TEST=N/A

Change-Id: I5e26a88a8daa107fa684009562c4eb2207f41a9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262621
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-10-04 16:59:57 +00:00
Devon Carew ad34feec87 [dart create] suggest using the pubspec repository field 
Change-Id: I51e83853d947bc545aced1ae2ae3d048dd7c6b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-09-29 19:13:27 +00:00
Tess Strickland be4d469e38 [pkg/dart2native] Refactor MachO parsing. 
* Move parsing functions to static methods of the classes that
  represent the data being parsed.

* Move calculations for adjusting offsets in load commands into the
  corresponding classes.

* Make function to insert a new payload segment an instance method
  of MachOFile.

* Remove unnecessary abstractions and definitions for MachO load
  commands that we don't need to parse.

These refactorings are being done to make later changes easier to
review, by first lifting the initial refactorings out into a
separate CL.

Issue: https://github.com/dart-lang/sdk/issues/49783
Change-Id: I133eb368cbb9ee0d8e4f3998ba1a0bbe8555b8aa
Cq-Include-Trybots: luci.dart.try:analyzer-mac-release-try,dart-sdk-mac-arm64-try,dart-sdk-mac-try,pkg-mac-release-arm64-try,pkg-mac-release-try,vm-kernel-precomp-mac-product-x64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256821
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-09-07 11:32:37 +00:00
pq 1519292b7a [dart fix] dry-run individual code run details 
Adds details to make applying individual fixes easier.

Example output:

```
3 proposed fixes in 1 file.

foo/baz/main.dart
  annotate_overrides • 1 fix
  prefer_single_quotes • 2 fixes

To fix an individual diagnostic, run one of the following commands:
  dart fix --apply --code=no_duplicate_case_values .
  dart fix --apply --code=unused_imports .

To fix all diagnostics, run:
  dart fix --apply .
```

See: https://github.com/dart-lang/sdk/issues/47219


Change-Id: Ibc89388acabe868fe3253d802e03481d853646ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256367
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-25 18:11:40 +00:00
pq c0e74c4433 [dart fix] report undefined diagnostics 
Fixes: https://github.com/dart-lang/sdk/issues/49699

Change-Id: Ia412e4dce51b0887c3cd0d9b6d91f0ace926bea3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-08-24 20:35:59 +00:00
Michael Richards 8d262e2944 [dartdev] This adds the ability for the Dart CLI to use the Resident Frontend Compiler for faster start times. 
Dartdev will use the user's home directory to store the server information and will keep a directory for cached kernel files in each dart package's .dart_tool directory and in the .dart directory for stand alone dart programs.

This functionality is accessed by providing the --resident flag to the Dart CLI, and the server can be manually shutdown with the new shutdown command.

Change-Id: I5231a00b7535266ab0704ca3ae35c039738bd38b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254341
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Richards <msrichards@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2022-08-18 17:01:34 +00:00
pq f4ea96ff2c [dartdev] fix --code support 
See: https://github.com/dart-lang/sdk/issues/47219

I'll follow up with tests for error conditions once diagnostic codes are validated by the protocol (see: https://dart-review.googlesource.com/c/sdk/+/255541).

Change-Id: I3318364e952522522608e86bdfdd231839685689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255544
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-18 16:51:54 +00:00
Michael Thomsen c626cb8346 Make package arg to analyzer absolute 
Bug: https://github.com/dart-lang/sdk/issues/49646

Change-Id: Ie653b2372ba12992457c25972294c261cb8ea40e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254901
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-08-16 20:54:32 +00:00
Ben Konyi eff8c305d9 [ Service / Timeline ] Enable Compiler, Dart, and GC timeline streams when --observe is provided 
TEST=pkg/vm_service/test_timeline_default_streams_test.dart

Fixes https://github.com/flutter/devtools/issues/3444

Change-Id: I3f772a54a512eb836e3e7279ee8d4d3437473393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255181
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-08-15 21:02:36 +00:00
Danny Tuppeny 09bcc1f4ae [dartdev] [dds] Share DevTools arg parsing with serve_local script 
Change-Id: Ia8f95b205fda1201a7ec50805a84d374a6201f39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-04 20:32:14 +00:00
Anis Alibegić 40e18905f2 Fixed various typos in a lot of files 
Closes https://github.com/dart-lang/sdk/pull/49478

TEST=Manual

GitOrigin-RevId: f4c9c6869dfe73639295e86574a021523b3d374d
Change-Id: I134a97caed4eec59d70e9cbca16b7e9a472cf2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251902
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2022-07-25 12:21:59 +00:00
Ben Konyi cc92eb0a7f [ CLI ] Fix LateInitializationError in DartDev when passed an invalid flag 
`log` was previously initialized after argument parsing had already
taken place, which caused an exception when an invalid flag was passed
to DartDev as `log` was referenced in the `dart fix` command
description, which is accessed when building the usage message.

Also fixes a minor test failure related to usage line lengths not being
set correctly for `dart devtools`.

Fixes https://github.com/dart-lang/sdk/issues/49437

Fixed: 49437
Change-Id: Ib367677db5f34d7b6da31e51dbe717c954298ecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251241
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-12 18:22:42 +00:00
Ben Konyi c50236ff9c [ CLI ] Ensure training arguments aren't parsed by the CLI for JIT snapshots 
TEST=test/commands/compile_test.dart

Fixes https://github.com/dart-lang/sdk/issues/49302

Change-Id: I15462eb617de2dca042ee445b85084b8b8602f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249340
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-06-24 14:26:39 +00:00
Sam Rawlins 567b45fb1d Add the enable-experiment flag back to DAS 
Bug: https://github.com/dart-lang/sdk/issues/48960
Change-Id: I6576f45e63e28902986db844df49a06a71385704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245202
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-06-16 16:26:39 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
pq 8d9009d610 fix path normalization for windows 
See: https://github.com/flutter/flutter/issues/105641#issuecomment-1150497628

Change-Id: I176467d5885feab1c44892ea9140f619e30df223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247608
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2022-06-09 03:00:02 +00:00
Jaime Wren 128a7e1641 Modify dartdev language-server to call the server snapshot 
This change also modifies the Dart Analysis Server to default to use the LSP protocol

Change-Id: I73a1ceae9a05bc8e5af219e4f28df959c054d4c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247461
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-07 21:31:02 +00:00
pq 467a1b05c0 dart fix for single files 
Fixes: https://github.com/dart-lang/sdk/issues/43892

Change-Id: If1dca6bdef59e9de6dfd74e9774f61072651166d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246160
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 17:42:14 +00:00
Jaime Wren 6c210bbc57 Revert "Modify dartdev language-server to call the server snapshot" 
This reverts commit 1598182907.

Reason for revert: The snapshot for the DAS needs to have the default set before this change can land.  Will work with Analyzer folks in the morning to put together a new PR.

Original change's description:
> Modify dartdev language-server to call the server snapshot
>
> Change-Id: I6fc7b2c1e55089fa0bf88633733c51ff768e699b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246059
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Jaime Wren <jwren@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I848f4ad08405fee5aeb0d2eb166f95390e81bb3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246840
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-02 05:13:26 +00:00
Jaime Wren 1598182907 Modify dartdev language-server to call the server snapshot 
Change-Id: I6fc7b2c1e55089fa0bf88633733c51ff768e699b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246059
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2022-05-31 21:40:44 +00:00
Danny Tuppeny e00fe8a259 [dartdev] Don't filter out TODO errors from dart analyze if configured as warning/error 
Fixes https://github.com/dart-lang/sdk/issues/49061.

Change-Id: I251d6a6c918023f4f8b4597dbb79dc02064898ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-21 17:25:33 +00:00
Sam Rawlins bbd7e5a4d9 Fix bad sdk-path error message 
Fixes #48959

Change-Id: I2ebbb06583886a8e54dbda0a4222bc02d380f7fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244742
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 20:03:35 +00:00
Sam Rawlins f3c2d2ee81 Support an sdk-path option in dart analyze 
Bug: https://github.com/dart-lang/sdk/issues/48959
Change-Id: I4c386f1f7c474c1ff809d15d597d3f8f2de0418a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-05-06 03:08:28 +00:00
Danny Tuppeny 5dafbb8889 [dds] Provide better error output for DAP protocol violations 
See https://github.com/flutter/flutter/issues/99734.

Change-Id: Idf23f745d0736db41a195fd5294b5f545c2a39a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-27 14:12:54 +00:00
pq 5470e07025 rename local functions with _s 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.

Change-Id: If6e6497418e7044ce906d87981e3b3afa1f26da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242423
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-04-26 17:48:43 +00:00
Parker Lougheed 731ef4f5c9 [dartdev] Adjust dart compile packages flag description for .packages discontinuation 
Change-Id: Ie461aa6124308637585f37c26d0f0525236680b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240903
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-25 14:10:54 +00:00
pq dfa6c5f402 update package:lints dep to 2.0.0 
See: https://github.com/dart-lang/lints/issues/73.

Change-Id: I553ef8d9226c1c7d43c9594160a115a1abf043c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236841
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-03-18 19:55:51 +00:00
Darren Chan 019b6f110b Increase analysis server shutdown timeout. 
Fixes https://github.com/dart-lang/sdk/issues/48584.

Tested on infra CQ (see http://tqr/509011 vs http://fxr/659793).

Also logs an error if the server shutdown times out.

Change-Id: Idd126f915c2b00f7331a51f0f3d527452b540a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237780
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Darren Chan <chandarren@google.com>
Commit-Queue: Darren Chan <chandarren@google.com>
 2022-03-18 00:35:07 +00:00
pq 47a52fc5de lint 2.0 fixes 
In anticipation of lints v 2.0.

See: https://dart-review.googlesource.com/c/sdk/+/237746

Change-Id: I42bcdfa43d4707324622b498c57dde6e2fe1f13b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-03-17 23:11:28 +00:00
Ben Konyi 8c484d12fe Reland "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit d4f71515c7.

TEST=CQ

Change-Id: I180f9d045870a1ff5f7f3f82b6f4782e18c18cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237440
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-15 18:14:42 +00:00