dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
89,608 Commits 2 Branches 0 Tags
ddc19f7f92ff0aaa5ba17ff5e5fab9c82e8339fb
Commit Graph

7579 Commits

Author SHA1 Message Date
Ahmed Ashour 2bc3d0ef6e [analysis_server] fix benchmark tests 
Fixes #51207

Change-Id: I3bd20fa283ed60cfd3610edfc517a3872206f654
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-02-01 21:56:27 +00:00
Danny Tuppeny dac58febd0 [analysis_server] Don't use window/showMessageRequest unless client has explicitly expressed support 
LSP currently has no capability for showMessageRequest and assumed all clients support it. They do not.

Until there's a capability (and clients have been updated to pass it), we should assume there is _not_ support for this. So that it can be used in VS Code, we accept a custom flag in experimental that indicates support for this (which the current VS Code extension is passing).

When there is an official capability we should treat either as an indication of this being supported, and then further into the future we can drop the custom flag.

See https://github.com/microsoft/language-server-protocol/issues/1635.

Change-Id: I7ca36555a5a10231f754faf6ae0ba199f791be35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280173
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-02-01 19:11:06 +00:00
Keerti Parthasarathy 83539664d9 Wire up remove var and replace if else with conditional for patterns 
BUG=https://github.com/dart-lang/sdk/issues/49960

Change-Id: I1a2d6e69127d4d82ed2cd4a121572d0ff6c3af82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-02-01 17:33:07 +00:00
Danny Tuppeny 692adf85ef [analysis_server] Show more LSP client info in diagnostic pages 
+ split LSP pages up because capabilities/registrations can be very long.

Change-Id: Ia352f2d1fcb2f7ed7e76108b14f9b23c82f61073
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-02-01 15:25:02 +00:00
Brian Wilkerson d05ee1898a Completion support for object patterns 
I wasn't comfortable with the previous approach of fixing one
contributor at a time, so I tried handling a single location all at
once. I think it worked better, and might be easier to review.

So what that means is that I think the tests and changes cover
everything that needs to be done for object patterns. If you see
anything I missed, please let me know.

Change-Id: Ia4a5e8ed1cb7c1f68a96d5856165b239126ddfd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280124
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 22:35:55 +00:00
Kallen Tu 95c1899b43 [analyzer] Report an error when extending an interface class or mixing in an interface mixin. 
Change-Id: I868b8c89fa52edbcd05d7f06e3246196bbf3d952
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279910
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2023-01-31 19:18:40 +00:00
Danny Tuppeny 6897faa67a [analysis_server] Add semantic highlights for assigned/declared variables and field names 
Change-Id: I7d11497c9ca1646ab913aedbed0fe84b40215215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 19:16:03 +00:00
Ahmed Ashour d0131191bd [analysis_server] RangeFactory enhancements 
Fixes #50959

Change-Id: I582706c0aea2597fd04dacb496e2ef16f055102a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278741
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-31 18:32:45 +00:00
Ahmed Ashour 1631284945 [analysis_server] update header of Flutter mock files. 
Bug #51184

Change-Id: Ic8eda3e07858b3533f65bef4e2133d0da74e5209
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280117
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 18:20:56 +00:00
Danny Tuppeny 96559e8804 [analysis_server] Mark "when" keyword as a control keyword for Semantic Tokens 
Change-Id: I07bf8b4c72fa60a9bf6062a875702d4605b6f113
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280114
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 18:07:41 +00:00
Danny Tuppeny f1fe38b6a8 [analysis_server] Add SelectionRange tests with patterns 
+ convert tests to use TestFormat instead of parsing offsets themselves.

Change-Id: Ice62489d77ed94e7e6cbe5177236394283ac53a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280112
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-31 15:30:51 +00:00
Sam Rawlins 88d56dc0b9 Move 9 more Hints to be Warnings, INVALID_LANGUAGE_OVERRIDE_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ia9612f618e2b8e7695ad98bb6b347320d4944efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280077
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-31 14:57:58 +00:00
Kallen Tu de9849c9ef [analysis_server] Base, interface, and final class and mixin semantic highlighting. 
Change-Id: I7262dd6d12787b1cf3f2a0ee6873273f3455423d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280076
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2023-01-31 01:32:43 +00:00
Keerti Parthasarathy 4abe6806ac Wire up unnecessary swtich case, add test for use curly braces. 
Change-Id: I30f2f65824b549a48076a6b03b6d7db4c4a85d85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-31 00:25:12 +00:00
Brian Wilkerson b83a4463fe Make the default print configuration in completion tests appropriate for more tests 
Change-Id: I14c98611f84769a8a36e79d4725a5105f6d18f12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-30 18:50:28 +00:00
Josh Soref 77978889eb Spelling 
Closes https://github.com/dart-lang/sdk/pull/51143

GitOrigin-RevId: 9e21c99a222d588e4fc95980725a2f8c9784965c
Change-Id: If0870e8936c7649935dce7e23cd783d62aa5610c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279916
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-30 18:29:59 +00:00
Sam Rawlins 02149377d7 [analyzer] Move 6 more Hints to be Warnings, INVALID_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ic46261738fbbd5d0e78a60b520283ea38a28b22b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-30 17:35:18 +00:00
Ahmed Ashour 5687262570 [analysis_server] don't offer an assist for 
`ConvertIntoAsyncBody` for a closure.

Fixes #50686

Change-Id: I1cabf2c381392aafee5ac88ebdb4c2c9ee3a1248
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279519
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-30 17:09:45 +00:00
Lasse R.H. Nielsen bee7ab2b32 Make record positional field getters start at $1. 
An update for co19 is available at https://github.com/dart-lang/co19/pull/1759

TEST=Existing tests run after change, two new tests for edge cases.

Change-Id: I408e398d532ba2c2e8e60777bb4f7bd0057e27fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278912
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2023-01-30 08:14:28 +00:00
Keerti Parthasarathy 15e57bc1ed Wire up add_const fix 
Change-Id: I5253bea646ad0d10104e01541689f200a4ad52e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279755
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-27 21:31:13 +00:00
Jens Johansen e4f0882709 [analyzer] Speedup some completion queries 
When getting completions, some of the "contributers" basically do a
walk of the AST and almost add everything they see, and the list
is then later pruned based on the user query.

This CL introduces a "first pruning" (a copy of the first part of what
is done in the subsequent pruning) so only the things has could match
the user query is added.

Benchmarks for this:

Notes:
 - All of these numbers are with the timeout increased a lot (to a
   point where there effectivley isn't any timeout).
 - I have an external project too, but only in Android Studio as it's
   a Flutter project and my VSCode then uses the dart included in
   flutter. I don't know how to make it not do that.

Summary:

Android Studio, bin/server.dart --- `print(CallHierarchyK^);`
Difference at 95.0% confidence
        -46.45 +/- 10.0349
        -45.7861% +/- 9.8915%
        (Student's t, pooled s = 15.6785)

Android Studio, bin/server.dart --- `starter.^;`
No difference proven at 95.0% confidence

Android Studio, Other project --- `print(Cryptm^);`
Difference at 95.0% confidence
        -90.3 +/- 10.9506
        -58.0894% +/- 7.04448%
        (Student's t, pooled s = 17.1092)

VSCode, bin/server.dart --- `print(CallHierarchyK^);`
Difference at 95.0% confidence
        -61.45 +/- 5.41501
        -51.4226% +/- 4.53139%
        (Student's t, pooled s = 8.46036)

VSCode, bin/server.dart --- `starter.^;`
Difference at 95.0% confidence
        6.4 +/- 5.08317
        15.4217% +/- 12.2486%
        (Student's t, pooled s = 7.94189)

So for several queries it's ~50% faster. For a single one it slightly slower.

Raw numbers:

BEFORE:

Android Studio, bin/server.dart --- `print(CallHierarchyK^);`
90 ms
88 ms
89 ms
85 ms
139 ms
92 ms
86 ms
101 ms
87 ms
84 ms
112 ms
110 ms
128 ms
99 ms
99 ms
104 ms
98 ms
88 ms
106 ms
144 ms

Android Studio, bin/server.dart --- `starter.^;`
38 ms
38 ms
34 ms
30 ms
35 ms
34 ms
29 ms
31 ms
35 ms
60 ms
53 ms
37 ms
54 ms
31 ms
51 ms
33 ms
39 ms
68 ms
75 ms
91 ms

Android Studio, Other project --- `print(Cryptm^);`
150 ms
146 ms
142 ms
138 ms
150 ms
213 ms
147 ms
143 ms
149 ms
147 ms
153 ms
147 ms
136 ms
151 ms
151 ms
186 ms
160 ms
153 ms
150 ms
197 ms

VSCode, bin/server.dart --- `print(CallHierarchyK^);`
122 ms
113 ms
115 ms
118 ms
124 ms
116 ms
116 ms
114 ms
118 ms
125 ms
130 ms
117 ms
104 ms
119 ms
121 ms
120 ms
127 ms
123 ms
117 ms
131 ms

VSCode, bin/server.dart --- `starter.^;`
38 ms
45 ms
35 ms
37 ms
37 ms
59 ms
39 ms
38 ms
37 ms
44 ms
41 ms
41 ms
43 ms
41 ms
39 ms
40 ms
42 ms
43 ms
49 ms
42 ms


WITH CL:

Android Studio, bin/server.dart --- `print(CallHierarchyK^);`
65 ms
59 ms
41 ms
41 ms
70 ms
38 ms
56 ms
66 ms
64 ms
44 ms
47 ms
56 ms
46 ms
38 ms
46 ms
64 ms
57 ms
44 ms
69 ms
89 ms

Android Studio, bin/server.dart --- `starter.^;`
36 ms
36 ms
38 ms
35 ms
37 ms
43 ms
32 ms
30 ms
34 ms
39 ms
32 ms
40 ms
35 ms
34 ms
35 ms
39 ms
46 ms
54 ms
56 ms
78 ms


Android Studio, Other project --- `print(Cryptm^);`
59 ms
63 ms
61 ms
80 ms
98 ms
56 ms
60 ms
61 ms
57 ms
61 ms
57 ms
61 ms
59 ms
59 ms
57 ms
64 ms
60 ms
65 ms
58 ms
107 ms


VSCode, bin/server.dart --- `print(CallHierarchyK^);`
55 ms
54 ms
50 ms
47 ms
59 ms
55 ms
53 ms
53 ms
67 ms
67 ms
54 ms
54 ms
50 ms
62 ms
54 ms
54 ms
56 ms
59 ms
63 ms
95 ms


VSCode, bin/server.dart --- `starter.^;`
57 ms
41 ms
57 ms
40 ms
45 ms
47 ms
40 ms
44 ms
43 ms
43 ms
41 ms
40 ms
42 ms
49 ms
40 ms
46 ms
57 ms
49 ms
81 ms
56 ms

https://github.com/flutter/flutter-intellij/issues/6470

Change-Id: I1e34ce04774cafcb47f4e8590b990400a7b0f0ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279389
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-27 08:27:48 +00:00
Kallen Tu f48a1fb3da [analyzer] Report error when implementing a base class. 
Change-Id: Ia55354350451849a112a32bb048a4fcbe5afe1b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279655
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2023-01-26 22:15:57 +00:00
Danny Tuppeny 010749c995 [analysis_server] Don't hold references to Elements in _ElementCompletionData 
Instances of `_ElementCompletionData` can be cached so this would keep a lot of objects alive unnecessarily.

Change-Id: I51e07d3e081e2e376572d03ecb98283cecccf057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279716
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-26 18:50:38 +00:00
Ahmed Ashour b7f929e85f [analyzer] improve error message of 
`MIXIN_APPLICATION_NO_CONCRETE_SUPER_INVOKED_MEMBER` for setters

Bug: #49355
Change-Id: Ic2ae5cbb8f9e795cee672accacfbaeb5ea1b16fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279717
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-26 16:29:27 +00:00
Josh Soref 01b28894e7 Spelling pkg dev compiler 
Closes https://github.com/dart-lang/sdk/pull/50861

GitOrigin-RevId: 71005e6f5bf5a151cb5c1aefb6a2a300fc40f592
Change-Id: Iadfafb5787a62e9a379437f6a3763d31f99ba7c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277743
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-26 09:12:41 +00:00
Brian Wilkerson f4ee87329b Add more completion tests for case clause 
Change-Id: Icb4affd42bee3c671066ee9462045aa5f690485f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279652
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-25 21:42:24 +00:00
Sam Rawlins f6d41b95fb [analyzer] Move 2 more Hints to be Warnings, UNUSED_CATCH_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Id8b53ebef2b44d6fe1a436edf796056f60913024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279443
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-25 16:04:09 +00:00
Brian Wilkerson 6b1dca4471 Move two tests to make it easier to see the coverage 
Change-Id: I43d77b9d0458efa0ac87aa9e57fad135837e1750
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279467
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-25 00:13:26 +00:00
Ahmed Ashour 5c045992bc [analysis_server] associate UNNECESSARY_TYPE_CHECK_* with RemoveComparison 
Fixes #47793
Fixes #51013

Change-Id: I50c080d51284cf669918d41c2aa7310b2c4a90f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279351
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 22:54:36 +00:00
Brian Wilkerson 45b01a6fe7 Add a deprecation message to the remaining contributor classes 
Change-Id: I100c4fdbfdfd650dac0b40eb8f93c273bfad7d1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 21:33:18 +00:00
Brian Wilkerson 178d465521 Fix some previously added tests for completion in patterns 
Change-Id: I64fc6bbda11cd1feacd541a5c3a0571f274eb277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279647
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 21:32:37 +00:00
Ahmed Ashour 457aa53834 [analysis_server] enable AddExplicitCast for FixInFile. 
Bug #49896

Change-Id: Ife8f60d1ce13683e9ec1b12af5d27221f3f04aea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 18:44:11 +00:00
Ahmed Ashour 0b5cd20ff2 [analysis_server] associate RemoveComparison 
with `UNNECESSARY_NAN_COMPARISON`

Fixes #50481

Change-Id: I29f2a924a62cbfd5c90c9578338d111a40d9207c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 18:39:24 +00:00
Johnni Winther 3184f2224b [_fe_analyzer_shared][cfe][analyzer] Initial implementation of exhaustiveness checking 
This adds the initial implementation of exhaustiveness checking in
the analyzer and CFE. The checking is currently only performed in
switch statements and only handle a subset of the patterns.

Change-Id: Ia0050c2c80fbefe3e22615599136f9d919ebe4ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279173
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2023-01-24 13:34:46 +00:00
Samuel Rawlins c5177be45e Revert "[analyzer] Move 4 more Hints to Warnings, OVERRIDE_ON_*" 
This reverts commit b2c26d0aae.

Reason for revert: linter references this HintCode.

Original change's description:
> [analyzer] Move 4 more Hints to Warnings, OVERRIDE_ON_*
>
> Bug: https://github.com/dart-lang/sdk/issues/50796
> Change-Id: I74625c25f947178b24d3374b0e87d7c89c3b20ba
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279332
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

TBR=scheglov@google.com,srawlins@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I6f786ae0ebb3727a3eac0c3fdb39523a96d3525a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/50796
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279660
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-24 01:53:46 +00:00
Brian Wilkerson 2ca588fce8 Support code completion in cast patterns 
Change-Id: I429957a44bdc09a0936c10123b58b3514b23e016
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279563
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-24 00:22:32 +00:00
Sam Rawlins b2c26d0aae [analyzer] Move 4 more Hints to Warnings, OVERRIDE_ON_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: I74625c25f947178b24d3374b0e87d7c89c3b20ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279332
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-23 23:19:19 +00:00
Ahmed Ashour 16453a9f74 [analyzer] Add AnalysisOptionsWarningCode.RECURSIVE_INCLUDE_FILE 
Fixes #50979

Change-Id: I872f0629253d0fabb993c108c11e7d2af04cb4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278908
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2023-01-23 18:34:39 +00:00
Josh Soref ba15a61271 Spelling build 
Closes https://github.com/dart-lang/sdk/pull/50859

GitOrigin-RevId: 7b056018c2925745701bdecdd7da325d9458204d
Change-Id: Iff037d773713bf73efde6951599becfd7297b921
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277740
Reviewed-by: Alexander Thomas <athom@google.com>
 2023-01-23 08:56:14 +00:00
Brian Wilkerson 9c11d59a34 Clean up some code completion tests 
Change-Id: I250fdee2e05684dffc2432b2b615f26e6860172e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279445
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-22 21:09:22 +00:00
Ahmed Ashour d5d7cc967f [analyzer] fix typo in class name 
Fixes #51080

Change-Id: Id8bb271110d0753eb2fd3c794ca1b03cf64d3765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279385
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2023-01-20 17:02:17 +00:00
Sam Rawlins 00a797b69e [analyzer] Move two more Hints to be Warnings, UNDEFINED_* 
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ifa01985beba01298addacf58b576b049ce0918f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-20 16:05:59 +00:00
Brian Wilkerson 0a0413aac8 Add completions for keywords in patterns 
I'm reasonably confident that there are missing test cases, so please
let me know if you see any that you think should be added.

Change-Id: I7d6780158a6fb1aa2fe64e8efcb24982a39d7f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278992
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-20 15:23:34 +00:00
Alexander Thomas b9b6511ca6 Spelling sdk 
Closes https://github.com/dart-lang/sdk/pull/50918

Co-authored-by: Josh Soref <jsoref@gmail.com>
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
 2023-01-20 12:37:49 +00:00
Jens Johansen af0e2dd01e [analyzer] Create report from web interface 
This CL adds a page "Collect Report" on the
"Analysis Server Diagnostics" website, available from the top right,
between "Diagnostics" and "Feedback".

The created json report includes most data from the subpages of the
"Diagnostics" page as well as data fetched from the observatory
protocol which, if not already enabled, will be enabled while the report
is created.

Change-Id: Iec545fb8caf642088c47ccfc98f005598a462ada
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2023-01-20 11:42:29 +00:00
Keerti Parthasarathy ae5dc9e2a9 Wire up remove question mark and remove non null assert fixes for patterns 
Bug:49960
Change-Id: I6b0a94454e0f51c5fd15d4abef16d075dce54a90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279334
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2023-01-20 00:30:48 +00:00
Sam Rawlins a4ca3ded5f [analyzer] Move two more Hints to be Warnings, EQUAL_* 
Bug: https://github.com/dart-lang/sdk/issues/50796

Change-Id: Id07ac5940eafed58b1473804248381dd933cb311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279229
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2023-01-19 20:04:17 +00:00
Josh Soref 84e3c8b50f Spelling tests 
Closes https://github.com/dart-lang/sdk/pull/50920

GitOrigin-RevId: fa87531bd0f52b69485c9d02ff9e44a4a29c6a91
Change-Id: I0ae8574a5b77087895e004079f221201bb550cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278535
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 16:24:29 +00:00
Josh Soref 9e4dc755cb Spelling pkg 
Closes https://github.com/dart-lang/sdk/pull/50921

GitOrigin-RevId: 6b1ca502b6722b0a987f33ace66f65cbd2c24e23
Change-Id: I74e4ff3c8e759c576036d6b791bd7734ebd215d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278536
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2023-01-19 10:06:29 +00:00
Sam Rawlins 305358e8ce [analyzer] Introduce WarningCode for non-spec warnings. 
Rename StaticWarningCode to WarningCode, leaving the spec ones as StaticWarningCode.

In this CL I do not introduce a new "type" for WarningCode, it is still "STATIC_WARNING". Later, we can make a new type, "WARNING", taking care for pkg/test_runner and DAS clients like IntelliJ.

Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: Ife856b2beb7e9b6bf8203f365634f49846d03bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278997
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2023-01-18 20:28:38 +00:00