Commit Graph

132 Commits

Author SHA1 Message Date
podivilov@google.com ab071c11a4 DartCallback is now a DartIsolateDestructionObserver.
R=antonm@google.com

Review URL: https://codereview.chromium.org//11274018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14130 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 12:16:55 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
antonm@google.com 5233dfaf73 Make endianness named argument for DataView accessors.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11234062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13994 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 07:25:37 +00:00
antonm@google.com e524049060 Switch to new library syntax.
R=podivilov@chromium.org,kasperl@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11235059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13962 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:52:27 +00:00
antonm@google.com c0b6dd849e Get rid of Dynamic.
R=podivilov@chromium.org,kasperl@google.com
BUG=6187

Review URL: https://codereview.chromium.org//11235060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13958 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 12:56:44 +00:00
antonm@google.com 24f777a084 Get rid of abstract modifier for members.
Actually it was only put on getters.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//11225055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13954 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 12:10:28 +00:00
kasperl@google.com 7da3f29f41 Remove more () from getters.
Anton, there seems to be some unrelated changes put in the
html_dartium.dart file as a result of me re-running the
lib/html/scripts/go.sh script. Could you take a look at
those too?

R=antonm@google.com
BUG=

Review URL: https://codereview.chromium.org//11225054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13943 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 10:28:53 +00:00
antonm@google.com bd7784b08b Get rid of ===/!===.
R=podivilov@chromium.org
BUG=6133

Review URL: https://codereview.chromium.org//11235029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13941 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 10:18:26 +00:00
antonm@google.com b4c773d3ff Fixes to unbreak the build.
TBR=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11227049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13931 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 08:53:13 +00:00
antonm@google.com 00ffc1ba5a Start a whitelist of methods those optionals should be treated as named formals in dart:html.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11236008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13925 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 08:08:15 +00:00
podivilov@google.com c3cec5113c Cleanup list-like interfaces generation.
R=antonm@google.com

Review URL: https://codereview.chromium.org//11227024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13876 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 14:09:30 +00:00
podivilov@google.com a5d055806e Merge ListLikeIDLTypeInfo into InterfaceIDLType and add other list-like types to the registry.
The merge is needed to get html renames and svg tear-off support for list-like types.

R=antonm@google.com

Review URL: https://codereview.chromium.org//11236024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13872 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 13:31:34 +00:00
antonm@google.com 036bf35aa2 Remove now unnecessary renames.
TBR=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11226027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13869 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:59:25 +00:00
vsm@google.com b9234ecc28 Use CheckSecurityForNode to filter out insecure calls
Testing note, I took out the special-cased lines under
_removed_html_members, verified that crossframetest and innerframetest
started breaking, and fixed with the more general code in this CL.

Review URL: https://codereview.chromium.org//11175014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13846 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 23:13:45 +00:00
antonm@google.com 137370942a Force named arguments in constructors.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org,sra@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11196020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13833 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 18:45:00 +00:00
antonm@google.com a5202b9ce3 WebKit IDL are getting closer to the standard, but...
ExtAttrs for most of interfaces and attributes were moved
into 1st position, but, alas, there are exceptions.
So for now I support both positions in somewhat hacky way.

TBR=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11230009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13830 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 18:19:36 +00:00
sra@google.com 7ee39fa99b Generate contains() method for list mixin only if not already defined.
Review URL: https://codereview.chromium.org//11187063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13828 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 17:36:03 +00:00
antonm@google.com e2f288ea26 Discard modules information.
WebKit IDLs decided to drop it.  So to keep rolling Chrome forward I need that.

R=podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//11238007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13825 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 16:58:12 +00:00
efortuna@google.com 23236055d6 Change return types of Callbacks to w3c standard of void
Review URL: https://codereview.chromium.org//11138028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13795 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 18:43:58 +00:00
lrn@google.com ae9664a9cc Revert "Add "contains" method to Collection."
Review URL: https://codereview.chromium.org//11186045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13769 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 10:55:02 +00:00
lrn@google.com c3c2ae61c6 Add "contains" method to Collection.
Also added a Sequence interface to capture things with a length and
integer indexing. List and String implement that interface, and
there is a base skeleton class for collections that are Sequences.

BUG=1030

Review URL: https://codereview.chromium.org//11169004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13766 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 08:48:11 +00:00
antonm@google.com dbe15ba638 Minor simplification.
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11190023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13745 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 15:01:30 +00:00
antonm@google.com 8889337203 Unify formatting of parameters in interfaces and implementing classes.
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11191026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13744 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:49:11 +00:00
podivilov@google.com 2d7f516b9f Extract common logic from Backend.BaseClassName().
R=antonm@google.com

Review URL: https://codereview.chromium.org//11118025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13742 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:24:50 +00:00
podivilov@google.com dc0c8157bc Rename Dartium dart:html implementation classes.
Currently, Dartium implementation classes are named as "_<IDL_Name>Impl" while
dart2js implementation classes are named as "_<Dart_Name>Impl". The goal of
this patch is to unify the naming across the backends.

R=antonm@google.com

Review URL: https://codereview.chromium.org//11108017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13740 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 14:02:25 +00:00
podivilov@google.com e846c4789b Switch to using IDLTypeInfo.interface_name().
R=antonm@google.com

Review URL: https://codereview.chromium.org//11114019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13736 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:53:20 +00:00
antonm@google.com a8c94bc8f5 Provide a correct value for is_optional argument of ParamInfo constructor.
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11194029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13735 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:52:46 +00:00
antonm@google.com de3b284e8f Refactor common functionality.
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11191024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13733 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:43:48 +00:00
podivilov@google.com f20ca10855 Remove ParamInfo.dart_type field.
R=antonm@google.com

Review URL: https://codereview.chromium.org//11117025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13732 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:37:10 +00:00
antonm@google.com a6913b069c Remove unnecessary support for default values.
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11196017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13730 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 12:10:11 +00:00
efortuna@google.com b9e2d45d8a Replace DOMStringList with List<String>.
Review URL: https://codereview.chromium.org//11140043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13699 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 20:02:33 +00:00
sra@google.com 1eeb83bbdf Convert legacy 'native code' to JS-forms in dart:html
This should enable minification to rename function arguments. Issue 5821 and Issue 5822 need to be fixed first.

BUG=dart:5808

Review URL: https://codereview.chromium.org//11094082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13690 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 17:50:15 +00:00
antonm@google.com 02d9df218e Make WheelEvent.delta{X,Y} return num, not int.
That requires hiding native implementation with private prefix.

R=blois@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//11098052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13608 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-12 10:57:04 +00:00
podivilov@google.com f6c129ce61 Move interface merging info to type registry.
R=antonm@google.com

Review URL: https://codereview.chromium.org//11091046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13533 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 11:45:40 +00:00
antonm@google.com 2a77601516 Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}.
Also remove WheelEvent.wheelDelta.

We originally have done that for dart2js, but that broke Dartium support.  Instead of
removal, just rename to generate binding code still.

R=blois@google.com,podivilov@chromium.org
BUG=5756

Review URL: https://codereview.chromium.org//11099033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13476 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 14:53:29 +00:00
podivilov@google.com 5464ab01d3 Get rid of webkit_renames in dartdomgenerator.py.
Now that we don't rename interfaces in fremontcutbuilder, there is
no need to rename them back in dartdomgenerator.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11062005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13473 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 13:31:16 +00:00
podivilov@google.com f8762b2568 Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table.
IDLTypeInfo hierarchy is a convenient way to deal with idl type polymorfism.

R=antonm@google.com,efortuna@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11065042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13472 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 13:22:45 +00:00
podivilov@google.com 9d19336573 Add interface_name and implementation_name to IDLTypeInfo class and use them instead of dart_type.
R=antonm@google.com

Review URL: https://codereview.chromium.org//11040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13470 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 12:38:41 +00:00
vsm@google.com 30b34c8457 Better return types for window.location and window.history
Review URL: https://codereview.chromium.org//11086029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13432 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:37:41 +00:00
vsm@google.com 166d2b2d86 Fix some type narrowing
I think I 'broke' this is an earlier CL.

Review URL: https://codereview.chromium.org//11086017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13430 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:29:55 +00:00
blois@google.com 845c13e426 Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants.
This is the same as the earlier CL for this, which failed because of dartium build issues which have since been fixed by Anton.

BUG=4592

Review URL: https://codereview.chromium.org//11028068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13361 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 16:15:23 +00:00
vsm@google.com c40edf6954 Wrap Window in case it's a window from a different page / frame.
I also refactored inner_frame_test to explicitly notify if the subframe tests pass or fail.  This should make them more robust and (if they break) fail quickly instead of timing out.

BUG=1913

Review URL: https://codereview.chromium.org//11074005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13331 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:07:08 +00:00
blois@google.com 06f1665623 Adding synchronous measurement methods to Element. Refactoring unit tests some so element_test passes on all browsers.
Original CL was failing in checked mode because the refactored html/element_test fires multiple mouseWheel event typess to try to validate that the event functions. This causes an assertion elsewhere, which is probably a valid assertion.

I'm not sure how much we get out of this test for mouseWheel, so I don't think it's a big issue to remove it.

BUG=838

Review URL: https://codereview.chromium.org//11065017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13328 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 22:27:43 +00:00
sra@google.com 5c1a93e251 Convert between Dart and JavaScript SerializedScriptValues on postMessage.
Review URL: https://codereview.chromium.org//11065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13311 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 19:19:16 +00:00
blois@google.com caa43082d6 Fixes to get SelectElement working properly on IE.
BUG=

Review URL: https://codereview.chromium.org//11031076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13307 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 18:13:13 +00:00
vsm@google.com c4c8c62e3b Remove window.length and window.frames
BUG=2312

Review URL: https://codereview.chromium.org//11065039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13305 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 17:26:03 +00:00
blois@google.com bc5a9328bb Fixing SelectElement.selectedOptions to work on all platforms.
This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium.

Fix was to move impl_SelectElement.darttemplate to dart2js.

BUG=4503

Review URL: https://codereview.chromium.org//11035032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13304 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 17:03:28 +00:00