Commit Graph

49 Commits

Author SHA1 Message Date
floitsch@google.com 7041a6bbf1 Make methods in Stopwatch getters and rename to be more consistent.
Includes:
- Stopwatch.frequency.
- Stopwatch.elapsedInMs() -> Stopwatch.elapsedMilliseconds
- Stopwatch.elapsedInUs() -> Stopwatch.elapsedMicroseconds
- Stopwatch.elapsed() -> Stopwatch.elapsedTicks

Review URL: https://codereview.chromium.org//11265024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14140 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 14:25:23 +00:00
lrn@google.com b8b5632148 Convert NoMoreElementsException and EmptyQueueException to StateError.
Review URL: https://codereview.chromium.org//11269045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14122 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 08:28:33 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com 0e47b363ae Make hasNext a getter instead of a method.
Review URL: https://codereview.chromium.org//11230011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
ajohnsen@google.com 86e5c73ce6 Move StringBufferImpl from coreimpl to core as _StringBufferImpl.
BUG=

Review URL: https://codereview.chromium.org//11274007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14005 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 10:35:40 +00:00
ajohnsen@google.com 590413765a Moved RuntimeOptions from coreimpl to core, renamed to _OptionsImpl.
BUG=

Review URL: https://codereview.chromium.org//11260010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14004 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 10:34:42 +00:00
ajohnsen@google.com 7983141903 Move DualPivotQuicksort from coreimpl to core as _Sort.
I've added a tempoary coreSort method in core, to coreimpl and other
uses, until the move is done.

BUG=

Review URL: https://codereview.chromium.org//11239004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13993 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 07:17:18 +00:00
ajohnsen@google.com 8b6565ceea Move DateImplementation from coreimpl to core, making it private.
BUG=

Review URL: https://codereview.chromium.org//11227055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13980 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 17:34:36 +00:00
ajohnsen@google.com 7e608a2521 Move FutureImpl and CompleterImpl from coreimpl to core, while also making them private.
BUG=

Review URL: https://codereview.chromium.org//11231043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13968 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 15:17:19 +00:00
danrubel@google.com e88232c83f Revert 13878
Review URL: https://codereview.chromium.org//11227027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13886 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 15:43:17 +00:00
danrubel@google.com af05ebb307 [core] cleanup === and !==
Review URL: https://codereview.chromium.org//11233032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13878 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 14:27:20 +00:00
floitsch@google.com 9074fd0178 Make hashCode a getter and not a method.
Review URL: https://codereview.chromium.org//11191078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
sigmund@google.com c5e87ddd9e Improvement on future: add stack trace to unhandled failures.
Re-apply change https://codereview.chromium.org/11225017/, now with updates to
co19 tests.

Review URL: https://codereview.chromium.org//11226013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13851 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-20 01:12:59 +00:00
sigmund@google.com af32282ec6 Revert "Improvement on future: add stack trace to future failures."
Some co19 tests need to be updated. Will reapply after fixing their status
files.

Review URL: https://codereview.chromium.org//11231024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13850 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-20 00:34:28 +00:00
sigmund@google.com 8e2c51cc4d Improvement on future: add stack trace to future failures.
Review URL: https://codereview.chromium.org//11225017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13849 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-20 00:23:26 +00:00
lrn@google.com 89f5daea9e Rename OutOfMemoryException to OutOfMemoryError.
This is a reapply with missing status file changes.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//11233004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13822 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 14:01:24 +00:00
kasperl@google.com f7a56d3f70 Revert "Rename OutOfMemoryException to OutOfMemoryError."
This reverts r13818.

TBR'ed.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//11229003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13820 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 13:11:15 +00:00
lrn@google.com 58f3453267 Rename OutOfMemoryException to OutOfMemoryError.
Also move ExceptionImplementation to core.

Review URL: https://codereview.chromium.org//11228002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13818 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 12:20:52 +00:00
lrn@google.com 9f32f0674a Add "contains" method to Collection.
This versions does not implement "contains" on DOM lists.

Review URL: https://codereview.chromium.org//11195039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13806 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 06:58:19 +00:00
lrn@google.com ae9664a9cc Revert "Add "contains" method to Collection."
Review URL: https://codereview.chromium.org//11186045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13769 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 10:55:02 +00:00
lrn@google.com c3c2ae61c6 Add "contains" method to Collection.
Also added a Sequence interface to capture things with a length and
integer indexing. List and String implement that interface, and
there is a base skeleton class for collections that are Sequences.

BUG=1030

Review URL: https://codereview.chromium.org//11169004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13766 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 08:48:11 +00:00
regis@google.com adb534674c Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
Review URL: https://codereview.chromium.org//11090016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
lrn@google.com 37197c2553 Stop using the Hashable interface.
All objects have a hashCode method, so there is no need for a Hashable
interface.
The interface itself is retained for at least two weeks, to give time for
code to remove uses of it.

Review URL: https://codereview.chromium.org//10993059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12955 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 13:07:54 +00:00
lrn@google.com ae0d6fca62 Ensure that hashCode and runtimeType work on null.
BUG=5510

Review URL: https://codereview.chromium.org//10979050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12948 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 11:38:16 +00:00
lrn@google.com a1faa6f135 Change IllegalArgumentException to ArgumentError.
Review URL: https://codereview.chromium.org//10989013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12841 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 12:27:52 +00:00
danrubel@google.com e3ad38a535 migrate raw string to new syntax in core
Review URL: https://codereview.chromium.org//10964046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12747 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-22 14:53:11 +00:00
rnystrom@google.com b81b2cd656 If transformException() returns a future, act like chain().
Review URL: https://codereview.chromium.org//10958021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12661 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 22:35:04 +00:00
lrn@google.com ee569ce10a Reapply conversion of most core interfaces to abstract classes.
Previous commit was reverted due to hitting an unrelated error.

TBR=ahe@google.com

Review URL: https://codereview.chromium.org//10939030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12551 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 10:48:14 +00:00
johnniwinther@google.com 4bb37a7a90 Normalization of patch signatures.
This is the second part of the patch refactoring which will require identical signatures on patches and their origins.

Review URL: https://codereview.chromium.org//10911325

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12542 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 09:00:47 +00:00
ricow@google.com 055ca720df Revert 12494.
This is causing failures in checked mode

TBR
Review URL: https://codereview.chromium.org//10948009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12501 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:52:10 +00:00
lrn@google.com 60bfeadcf6 Convert most interfaces in dart:core to abstract classes.
Review URL: https://codereview.chromium.org//10950006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12494 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:43:10 +00:00
lrn@google.com 26fab5183a Move parseInt parseDouble to int/double classes as a static method.
Remove math dependency from core/coreimpl in dart2js.
The existing Math.parseInt and Math.parseDouble are kept *for now*, but
simply redirect to the static methods.
They will be removed in time (when library code is ready for it).

Review URL: https://codereview.chromium.org//10913271

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12417 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 07:25:38 +00:00
ager@google.com 665aaf939f Patch print directly in corelib instead of going through coreimpl.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10928145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12316 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:50:19 +00:00
kasperl@google.com 997e534c28 Change Duration to take proper named optional parameters.
R=bak@google.com,lrn@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10905255

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12314 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:17:31 +00:00
ager@google.com 2e49065159 Reapply changes to Expando patching.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10911201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12181 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:03:50 +00:00
ager@google.com 1adc0b35a2 Revert Expando changes. There are checked-mode errors that I need
to sort out.

Revert "Patch expando directly in corelib instead of going through coreimpl."

Revert "Fix merge error."

R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918163

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12158 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:39:05 +00:00
ager@google.com e3f4f6696e Patch expando directly in corelib instead of going through coreimpl.
R=ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10908173

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12156 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:27:31 +00:00
lrn@google.com 9ae63b5684 Revert "Remove dart2js specific core.dart and coreimpl.dart files."
TBR=johnniwinter@google.com

Review URL: https://chromiumcodereview.appspot.com//10911179

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12101 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 08:50:40 +00:00
lrn@google.com d47489ba3c Remove dart2js specific core.dart and coreimpl.dart files.
Review URL: https://chromiumcodereview.appspot.com//10908167

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12100 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 08:05:49 +00:00
srdjan@google.com 362f2b538b Fixed exception text.
Review URL: https://chromiumcodereview.appspot.com//10905149

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12044 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 16:27:50 +00:00
kasperl@google.com 9beb871852 Get rid of a lot of () for getters.
R=bak@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12017 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 11:50:07 +00:00
rnystrom@google.com 2f2df82784 Support transforming the exception in Future.transform().
Review URL: https://chromiumcodereview.appspot.com//10908040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11844 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 21:52:31 +00:00
bak@google.com 5782b0beba - Removed named constructor Stopwatch.start() due to conflict with instance methods start().
This change reduces errors reported by dart_analyser when cheking corelib.
- Change comment format in newissues.dart.
Review URL: https://chromiumcodereview.appspot.com//10908066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11801 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 10:56:29 +00:00
ager@google.com 5e0098f34e Fix lib/core/core.dart and lib/coreimpl/coreimpl.dart files.
Where did these files come from?

R=lrn@google.com,ajohnsen@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11788 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:42:53 +00:00
ager@google.com 156e6a71b5 First corelib cleanup patch after unification.
Do not go through coreimpl for object implementation. Instead, use patching
in core directly.

This leads to error message issues in dart2js which I have patched up
the best way I could find.

R=ajohnsen@google.com,johnniwinther@google.com,lrn@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11784 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:26:02 +00:00
iposva@google.com 387a2fbcae - Change "static final" to "static const" in the lib/coreimpl/ directory.
Review URL: https://chromiumcodereview.appspot.com//10910037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11705 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 17:58:26 +00:00
ajohnsen@google.com 3cf5d6531d Move core and coreimpl from corelib/ to lib/core and lib/coreimpl.
BUG=

Review URL: https://chromiumcodereview.appspot.com//10890030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11606 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 11:45:40 +00:00