dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
76,699 Commits 2 Branches 0 Tags
dc5f88a24c4d7eebfa11efbc61ca190071e7908c
Commit Graph

5669 Commits

Author SHA1 Message Date
Danny Tuppeny 732305f11e [Analyzer] Don't show duplicate LSP code actions on same line 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2960.

Change-Id: I63361728e80c7db843db9e2b31e76eae78f85400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172562
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-19 10:55:33 +00:00
Danny Tuppeny 3bf25c6c40 [Analyzer] Support fix-all-for-file in LSP code fixes 
Change-Id: Ic3628ee80c409feab178e237bccc5054501549e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172400
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-19 10:44:13 +00:00
Sam Rawlins f230313871 analysis_server: remove unused imports with shared prefixes 
Bug: https://github.com/dart-lang/sdk/issues/38784
Change-Id: Ifd4df564247c08606841a0e22896d767da438a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-11-18 17:30:21 +00:00
Devon Carew 289bc8ce38 [analysis_server] rename and re-word analysis server CLI flags 
Change-Id: If8084297b82596794500ee95f4683747152b7bb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172660
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-18 02:16:29 +00:00
pq 8b47021578 prefer convertPath 
Follow-up from: https://dart-review.googlesource.com/c/sdk/+/172683/1

Change-Id: I5cb2371fcb6719e4b08ec512bad31031f1d28143
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172687
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-18 01:49:49 +00:00
pq df64dbc0ed windows path fix 
Change-Id: I676a1e3b71e89880d7a3d9be8c6c9211eabc87c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-18 00:43:08 +00:00
pq 29a9fe27d2 bulk fix details server protocol 
Change-Id: Id96fd8508018159959448c383baa53ad69b5828f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172621
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-17 21:45:28 +00:00
pq f0c9321b14 bulk fix change mapping 
Striving to do the "simplest thing that could possibly work" this may just be a conversation starter.


Change-Id: Id3deab6fd1541febbc090c696352563e6b5ce932
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172460
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-17 00:45:30 +00:00
pq 5e9454cbbf infer set type from invocation expressions 
Fixes: https://github.com/dart-lang/sdk/issues/44199

Change-Id: I61b76fdcd65fae180d3a1cc1926fe26d2e90ae49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-16 19:23:06 +00:00
Devon Carew 8bf0f4ed8c [analysis_server] remove the custom args parser 
Change-Id: I2c7bfd290bd12d3b608f4b3628ec31a0ea522157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-16 18:32:08 +00:00
Brian Wilkerson 25ff121c41 Offer to add async when a function should returns Future<void> but does not include a return statement 
Bug: https://github.com/dart-lang/sdk/issues/43726
Change-Id: I8d44c8aa10cdd9af4391126b61a691a6a544a441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172028
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-16 16:28:15 +00:00
Brian Wilkerson c88f99b0b7 Initial support for code completion in yaml files 
Change-Id: I21276fe32d1c0d8525980edf3b1a5e93de5ae572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172024
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-11-16 16:26:36 +00:00
Devon Carew f5e26456bf Remove the --completion-model flag from the analysis server. 
Change-Id: I6bedbb0b5c4b8bedba18d2e3b788db0a9686f6df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172026
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-16 03:31:18 +00:00
Brian Wilkerson c3f96e863f Remove uses of useNewRelevance and clean up associated code 
Change-Id: I04dd3b33d229348042609c5a656d1ad68a95913d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172120
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-15 00:18:07 +00:00
Devon Carew 94fa3c89c7 [analysis_server] remove the analysis server's --use-new-relevance flag 
Change-Id: Ia7a182e11fbe62ba2814e56c59804b14b70f88cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-14 03:00:16 +00:00
Devon Carew 5a649b22e9 [analysis_server] re-order the server's command line flags 
Change-Id: I9a8295f302683c77cdbecd587ae9c546111838a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-14 00:25:34 +00:00
Brian Wilkerson 9c334a8f3c Support conditional change lists for data-driven fixes 
Change-Id: I2e2c383fc2e8c1b101dec90f81486c4e63038911
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 21:50:05 +00:00
Konstantin Shcheglov 861879fad4 Issue 44196. Change ExtensionElement.displayString to the empty string for unnamed extensions. 
Bug: https://github.com/dart-lang/sdk/issues/44196
Change-Id: Idcd6b2caa6efa37350a518d229768e9ab3e24599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-13 21:44:24 +00:00
Paul Berry 7d3bc4862d Rename pkg/analysis_tool to pkg/analyzer_utilities. 
It's no longer just for the tools in the `tool` directory; it also
contains test utilities for use by the analyzer and related packages.

Change-Id: I0f8cf57f24ea7aad8e2177e43ee2bcb2ab3030da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171704
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-13 17:46:30 +00:00
Devon Carew 4a7aad370f rename DartUnitHighlightsComputer2 to DartUnitHighlightsComputer 
Change-Id: I08f15cfbba260dddc1e87f0a91d823df04214e49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-12 23:12:15 +00:00
Konstantin Shcheglov 6685f4a9e8 Use ResourceProviderMixin where possible in AbstractContextManagerTest. 
Change-Id: Id279e01189a1523c2158b0e1315e1ee4c119f301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-12 22:24:40 +00:00
Brian Wilkerson 797cd72e3e Fix the bot by forcing a test to fail 
Change-Id: Iea61438c8d0f1ef90136a977a183063ae516e005
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 22:01:11 +00:00
Konstantin Shcheglov a30ba008f7 Fix AbstractContextManagerTest for Windows. 
Change-Id: I21899663fe779b88c6f493c4c526ca57ff865d9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-12 21:44:40 +00:00
Devon Carew 2ba123b86e [analysis server] remove the --file-read-mode cli option for the analysis server 
Change-Id: I279233cd0b7ec09a7d2fdcd50837552f56f2584d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-12 21:42:50 +00:00
Brian Wilkerson 601a8883d2 Allow variables to be declared in templates 
While this would allow some variabless to be deduplicated, the real
purpose is to support conditional change lists, which will be added in
the next CL.

Change-Id: I8692b8620e04533d3db0c385964567d629317d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171741
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 19:10:09 +00:00
Devon Carew 2f9cb8e81b Remove support for v1 of analysis highlighting. 
Change-Id: I65bc645de9565628d82d1ff969616f3e38582275
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171682
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 18:36:19 +00:00
Brian Wilkerson 08312459f3 Fix a bug in the convert_to_null_aware assist/fix 
Bug: https://github.com/dart-lang/sdk/issues/44173
Change-Id: I3b09732fe79577fc394b41a18d58fa8627be5eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 17:48:17 +00:00
Danny Tuppeny 44e680ac53 [Analyzer] Add LSP support for Format Selection/Range 
Fixes https://github.com/Dart-Code/Dart-Code/issues/812.

Change-Id: I099654483f3799344d68640b4d00df88e6bbca01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171722
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 16:20:36 +00:00
Danny Tuppeny a36f85b5e6 [Analyzer] Generate minimal edits when formatting files using LSP 
Fixes https://github.com/Dart-Code/Dart-Code/issues/1626

Change-Id: Id36a86df736ed7d31320abfd2acf1118be3f600b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171590
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-12 16:20:36 +00:00
Brian Wilkerson 813b0d029a Rename a parse method and make it consistent with newer methods 
Change-Id: I3cde98229649557eb32a291afeab7558943cf140
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171631
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-12 06:20:56 +00:00
pq c84ada0fd4 be aware of cascades when scraping type params for var replacement 
Fixes: https://github.com/dart-lang/sdk/issues/44156

Change-Id: I5ceb69d4a3fa4bbc68cdb7af2f9eb065ac8ae0f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171627
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-11 21:08:29 +00:00
Devon Carew e7647f2cf2 Revert "[analysis server] remove the --file-read-mode cli option for the analysis server" 
This reverts commit 1caee4d1fd.

Reason for revert: This breaks google3 - we need to update the linter's use of the analyzer API.

Original change's description:
> [analysis server] remove the --file-read-mode cli option for the analysis server
>
> Change-Id: Id07e3655cb4bcfc462ada0db8257e7cf584272f5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171101
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I68294ad8b565a94aa098e65276b78e9745eec5a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171640
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-11 20:10:41 +00:00
Danny Tuppeny 8687aa6145 [Analyzer] Add an LSP setting for including parameters in completions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2823.

Change-Id: I477aba5f3563c01a85bb867a1e01f294eed3636e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171585
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-11 19:44:12 +00:00
Devon Carew 1caee4d1fd [analysis server] remove the --file-read-mode cli option for the analysis server 
Change-Id: Id07e3655cb4bcfc462ada0db8257e7cf584272f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-11-11 19:30:23 +00:00
Paul Berry cd05ad0009 Share and improve implementation logic of verify_tests_test.dart 
This CL unifies the implementations of `verify_tests_test.dart` found
in packages `analysis_server`, `analyzer`, and `analyzer_plugin`.  It
also enhances the functionality of the tests by having them detect
both missing and extra imports in `test_all.dart` files.

This should make it easier to re-use this logic in other packages,
such as `nnbd_migration`.

Change-Id: Id344eeb4ad514461cda622495651b1339f379022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-11 18:09:18 +00:00
Paul Berry 596198fb74 Share logic of package_root.dart 
This CL unifies the implementations of `package_root.dart` found in
packages `analysis_server`, `analysis_server_client`, `analyzer`, and
`analyzer_plugin`.

This should make it easier to re-use this logic in other packages,
such as `nnbd_migration`.

Change-Id: I0da44edb379b8e929dd0b1c16a6989c1e9418acb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-11 18:09:18 +00:00
Brian Wilkerson 23478cb386 Implement a simple transactional model for change builders for use by bulk fixes 
Change-Id: I4e7a3e13345a865a2302dfddbc9aa4eb7b531d15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171340
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-11-11 16:46:42 +00:00
pq d6a8505ba4 remove redundant @required annotations when adding required 
Fixes: https://github.com/dart-lang/sdk/issues/43603

Change-Id: I21ccee4787695b72d5ac25195ade638e918d9550
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-10 23:06:07 +00:00
Konstantin Shcheglov b16c6a8292 Issue 44131. Handle .dart_tool/package_config.json file change, re-configure with new Packages. 
Bug: https://github.com/dart-lang/sdk/issues/44131
Change-Id: I4c843da4c6cecea5e334ba6b73cffa42be6d80ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 21:59:06 +00:00
Brian Wilkerson d7b3812f51 Remove a duplication of analysis from some tests 
Change-Id: Ib358b943519172afaf32ba9185ebec96c57beeda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 19:15:26 +00:00
Brian Wilkerson 87cb3ede9e Report conflicting edit exceptions 
Change-Id: I2b76b79a7b741c0d587fd24f8eaa30f1f0f8c657
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171285
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 18:22:04 +00:00
Brian Wilkerson f3f053e328 Add preliminary support for simple conditions in data-driven fixes files 
Change-Id: Id65d4cf8daebfa01bf6d59c90f755b9a8827c458
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171043
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 18:07:34 +00:00
Danny Tuppeny d4e5a14627 [Analyzer] Use SymbolKind.EnumMember when client supports it 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2945.

Change-Id: Ifdfade387c97c9bf1162e048b2d18930a726806a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-10 17:58:54 +00:00
Brian Wilkerson 0d222cc712 Throw an exception when an attempt is made to produce conflicting edits. 
Change-Id: I826cd1771a61685f76314b3ec0125cfc0364b700
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170800
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-10 15:56:06 +00:00
Danny Tuppeny 4c85f1950b Send LSP unhandled exceptions to instrumentation service 
Change-Id: Id8e876b7144aa98dc7c219b9eec2c140824f9675
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170427
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-11-09 20:06:14 +00:00
Konstantin Shcheglov a0227f5902 Issue 44063. Report IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE hint. 
Bug: https://github.com/dart-lang/sdk/issues/44063
Change-Id: I69c6f84da9a9c928e177507cedb30e06a561f3f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-09 19:42:08 +00:00
Devon Carew 5871cfb23c [analysis server] remove older analysis server flags 
Change-Id: I4384c98a067467def91e2b769d711069ad057a27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-11-09 03:54:58 +00:00
Sam Rawlins d8903669be Quick fix: make a parameter nullable 
Closes https://github.com/dart-lang/sdk/issues/44098

Change-Id: Ib3bb0b352f33a027c79746418033497aee1d8a7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170763
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-09 01:19:07 +00:00
pq a15b252c28 overlapping fix test 
Change-Id: I4621e8e24b8d296875d2033ac21ba8da68fb0387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-05 21:14:31 +00:00
Konstantin Shcheglov 2513d37525 Fix reported void_checks diagnostics. 
Change-Id: I49b27cf3aab3606fb5b024cba3ed4b95e9ebe0f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170420
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-04 23:50:37 +00:00