f4186fb463
Issue 27244. Add 'isDeprecated' to HoverInformation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244
Review URL: https://codereview.chromium.org/2310153002 .
2016-09-06 11:31:11 -07:00
7a9b2a3133
Use null aware operators to clean up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1941793002 .
2016-05-02 08:38:46 -07:00
338c95be8c
Sort the files in analysis_server
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1834423002 .
2016-03-28 18:25:29 -07:00
c0d40223bf
Issue 25945. Include static/propagateInvokeType for MethodInvocation names into hover.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25945
Review URL: https://codereview.chromium.org/1814893002 .
2016-03-17 10:29:10 -07:00
93aa6f1ecf
Deprecate the generated element library and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1789233002 .
2016-03-12 09:13:44 -08:00
7d72c6e1f5
Deprecate the generated AST library and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1788223002 .
2016-03-12 08:50:48 -08:00
ec08de7df8
Get more data to track down issue 25884
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1775913005 .
2016-03-10 08:21:40 -08:00
71e7ed86c0
Move scanner out of generated and clean up imports
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1693083004 .
2016-02-14 07:48:44 -08:00
e7e52ae2c0
Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
Review URL: https://codereview.chromium.org/1632033002 .
2016-01-25 17:09:48 -08:00
5dc34340a1
Issue 25538. Fix for notification and private methods.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25538
Review URL: https://codereview.chromium.org/1610773003 .
2016-01-21 08:01:51 -08:00
1f8eddcc21
Cache element docs (and add to completions) [ #23694 ].
...
This does away with the expensive call to `computeDocumentationComment` in favor of cached comments. Notably this makes adding doc content to code completion proposals performant (and so is done here). It should also make `dartdoc` *much* faster for doc generation since there are no more trips to disk to fetch comments for elements (still needed for source though).
For more on the desire for docs in completions see here: https://github.com/dart-lang/sdk/issues/23694
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1534043002 .
2015-12-17 21:07:42 -08:00
56fe38f0ab
Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
38a4193b5f
Issue 25244. Disable invalid overrides.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244
Review URL: https://codereview.chromium.org/1519413002 .
2015-12-13 15:50:12 -08:00
2f0f398c73
Fix lints: unnecessary_brace_in_string_interp
...
Also fixes two cases of empty_constructor_bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
168556a3e4
Tweaks for hover.
...
1. Include full signature of classes - extends, with and implements clauses.
2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1513943005 .
2015-12-11 14:25:46 -08:00
9ad256cf18
Move the wire protocol support into the public API
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
0e7f4b5717
Fix hover documentation for parameters.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1384583007 .
2015-10-05 07:04:20 -07:00
e6053aa135
Rollback https://codereview.chromium.org/1380223003
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1390463002 .
2015-10-04 17:07:10 -07:00
1af7b154af
Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694
Review URL: https://codereview.chromium.org/1380223003 .
2015-10-04 16:16:45 -07:00
3924b15d85
Remove ElementLocator.locateWithOffset altogether.
...
It was needed only for the old Angular implementation support, which
overlayed its own Element subclasses into normal Dart AST, for example
for string literals - names of components.
As we don't support this anymore, there is no need for the method.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1370833002 .
2015-09-25 14:57:15 -07:00
75600fc162
Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1345943006 .
2015-09-17 10:37:04 -07:00
a01281370b
Fix for dynamic instance field reference highlighting.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1349223002 .
2015-09-17 09:25:22 -07:00
d71bda7c05
Highlight library identifiers as LIBRARY_NAME.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1352843002 .
2015-09-17 09:24:14 -07:00
ef2fc0d778
Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
e090ff872e
Issue 24277. Use node's offset as the source range start for the first unit node in Outline.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277
Review URL: https://codereview.chromium.org//1325143003 .
2015-09-02 17:55:15 -07:00
b15a031276
Navigation extension point.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1303033010 .
2015-09-01 13:06:25 -07:00
089f84f6cd
Keep only unique overridden elements.
...
If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass.
In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1273003005 .
2015-08-10 16:13:43 -07:00
d5d0017e21
Tweak for navigation for URIs.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1246833002 .
2015-07-20 15:07:00 -07:00
55cb93b422
Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1241193002 .
2015-07-20 10:37:46 -07:00
10b7db100f
Revert "Update Analysis Server highlight API and implementation."
...
This reverts commit 739847402bR=paulberry@google.com
Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
d7c2f4550b
Issue 23640. Implement 'analysis.getNavigation' request.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640
Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
739847402b
Update Analysis Server highlight API and implementation.
...
I think this is a good enough compromise between the existing and IDEA granilarity.
Eclipse plugin CL will follow.
(IN)VALID_STRING_ESCAPE are not implemented yet.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
7e194d8fb5
Change navigation regions generation for constructors.
...
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1218183007 .
2015-07-06 11:27:19 -07:00
f3c28ef449
Don't create navigation regions for not existing sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1180883003 .
2015-06-11 13:21:12 -07:00
f118546d06
Issue 23332. Don't compute overrides for static members.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23332
Review URL: https://codereview.chromium.org//1151573011
2015-06-01 10:42:22 -07:00
81e474c43e
Clean up many generated constructors
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1131423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45676 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-09 19:06:12 +00:00
e154d7ac6a
Tweaks for hover - local variables and methods.
...
1. We don't need enclosing class and library for local elements.
2. None of the elements other than methods append class name in toString(), so remove it there too.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1050983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44838 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-01 18:24:16 +00:00
2a7227b15d
Fix for computing overridden/implemented members from interfaces.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1037193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44737 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 15:16:21 +00:00
0c21dc284c
Add 'containingClassDescription' to HoverInformation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1003193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
4dac0013c0
Fix hints
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1008583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44447 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:58:22 +00:00
2e77fcdd11
Add an optional 'typeParameters' to Element.
...
Also use it in Editor, e.g. in Outline.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//990343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:02:44 +00:00
cd58e290c4
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//969113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
268cd8bab2
API clean-up
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//970913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44134 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 17:28:37 +00:00
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
865b217511
Issue 22381. Fix for navigating to constructor from redirecting factory constructor.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381
Review URL: https://codereview.chromium.org//921833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 17:58:29 +00:00
94dd9d28f8
Fix a null pointer exception
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43617 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:55:48 +00:00
b280b861f9
Issue 22143. Navigation from super initializers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22143
Review URL: https://codereview.chromium.org//882823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43209 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:50:00 +00:00
96462aab53
Send notifications using separate server operations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//847663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42970 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 20:11:47 +00:00
409fcc9d44
Fix for 'await' highlighting in for-each.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//835953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42610 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 20:01:05 +00:00
e73e5faaad
Getters should not have parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//787603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:04:44 +00:00
Konstantin Shcheglov