dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
72,663 Commits 2 Branches 0 Tags
dc0fcc7472002dcfcb4944cd73b9ad1df64bd56e
Commit Graph

3873 Commits

Author SHA1 Message Date
Simon Binder 10bd820169 analysis_server: Show plugins page in LSP diagnostics 
Since the LSP server has basic support for server plugins, it seems
appropriate to enable the plugin page in its diagnostics.

Change-Id: If5fb601023e94a418250bca101240a69da1f0e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 22:36:00 +00:00
Konstantin Shcheglov 2ebd8e22a0 Add DartType.isDartCoreIterable 
R=brianwilkerson@google.com

Change-Id: Ia21b8f66bc19467b1b4e84c0cd9d59d6553a58a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 22:06:20 +00:00
Danny Tuppeny 994c0e8dad Fix handling of static members in LSP completion 
Bug: https://github.com/dart-lang/sdk/issues/41843
Change-Id: Ifb653f9c11a5130e46dce354f7e38490e8e923db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147546
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 17:09:07 +00:00
Danny Tuppeny 9678d604c7 Don't included instance fields in completion lists 
The LSP completion handler was missing a filter on child declarations that the DAS implementation has. This caused instance fields for classes to show up in the completion list when they should not.

Bug: https://github.com/dart-lang/sdk/issues/41841
Change-Id: Ic4dbf9ba297e665c8b88ba90bb95412b5f51d3a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 17:09:07 +00:00
Simon Binder c7619172b4 Include plugin results in LSP autocomplete 
The completion handler will merge plugin results with results from the
Dart contributor.
For non-Dart files, or files that can't be resolved, it will still
request completions for plugins.

I've added a test case for both scenarios and adapted the capabilities
computer to include plugin file endings for completion.

Change-Id: Id55c6fe33c84d6255de3e723f2628510baace0e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 17:00:37 +00:00
Simon Binder 10172cd1c4 LSP Server: Forward overlay changes to plugins 
Send appropriate plugin notifications in response to a document open,
change or close notification from the client.

Change-Id: Iafda3387b493c3b84cda2186390db124cfe86045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147366
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 15:25:27 +00:00
Brian Wilkerson 8ac2e1db44 Extract two more fixes as examples that use the diagnostic 
Change-Id: If1e1a310ca60a63599a493c94b0964cd99906301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147337
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-09 15:32:29 +00:00
Brian Wilkerson 043dd0dd4a Update the ArgListContributor to use SuggestionBuilder 
Change-Id: I99d11d71ff314fe080e24c12a0f643cc01f25bcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147333
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-08 21:50:47 +00:00
Konstantin Shcheglov 83ce658c6d Remove old compute, rename compute2(). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I0ceddd83ae7ca6eac7bd4ddd0034aabb14e703a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-08 19:02:46 +00:00
Brian Wilkerson f4b401a755 Make createSuggestion an instance method and clean up some code in SuggestionBuilder 
Change-Id: Ia7751c0d87b50fcbdf546aa14e5c2c3dc3f3f0a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147331
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-08 18:18:36 +00:00
Brian Wilkerson 8c1d13ce89 Move another batch of fixes to be producers 
Change-Id: If0c66b04a54b2ce8329b03e192fdc4fec1326cad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147346
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-08 18:12:46 +00:00
Keerti Parthasarathy 485ad3ba4c Add prefix start information for completions 
Change-Id: Ia03503937c50695067e088114e2ed9aa3599eb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-08 15:16:19 +00:00
Brian Wilkerson b89e2b99b2 Convert LocalConstructorContributor to use SuggestionBuilder 
Change-Id: I208b170dda295d3cc5524a8f76b14314290f5b23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147049
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-08 15:08:59 +00:00
Brian Wilkerson 39e0e75fcf Remove ElementSuggestionBuilder 
Change-Id: I60d32ff61953ff6b87420c4fd2b38dbd327c24ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147241
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-07 19:44:38 +00:00
Danny Tuppeny 30da9d580b Ensure new analysis drivers are seeded with existing priority files 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2438
Change-Id: Ia1ca9a024b9d864d94ad7a9ee186fd9de0c536b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-05-07 18:00:48 +00:00
Brian Wilkerson f16663a678 Convert LocalReferenceContributor to use SuggestionBuilder 
Change-Id: I1065b6294b315abcf60b9e743a9c6961a3080978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147047
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-07 17:40:48 +00:00
Konstantin Shcheglov c5a5884b7f Fix for crash when completing a setter without parameters. 
Change-Id: I7e749c96a72569869189283e9affd350ba09f5a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-06 19:38:22 +00:00
Brian Wilkerson 7449aa8c6b Make hasOverride and extension on AstNode 
Change-Id: I71339d78b4d28006d2212184bbaa5255116b3d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146688
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 17:01:27 +00:00
Konstantin Shcheglov 9b3f9db65a Switch InheritanceManager3 to computing ClassElement interfaces. 
Change-Id: Id9148d1bf3fc369eeabe2b1acc7507c20986a3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-06 03:09:03 +00:00
Brian Wilkerson c1e7641d5b Convert six more contributors to use SuggestionBuilder 
Change-Id: I06033fb50e546601292200f22e713750dde87465
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-05 18:52:27 +00:00
Paul Berry 8061d2d6cc Migration: add support for a machine-readable summary of migration results. 
Change-Id: Id41bc9869448dd4ed63286cab814bf7687baaaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146620
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 17:35:22 +00:00
Brian Wilkerson ed3d0e7483 Convert StaticMemberContributor to use SuggestionBuilder 
This also removes the use of an ElementVisitor.

Change-Id: I9589a4f8fb66ce365ed911a86d3a6f832c189dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146380
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-04 19:17:54 +00:00
Mike Fairhurst 2b80aa0f7f [analysis_server] Report angular plugin exceptions to new staging crash product 
Change-Id: I72826fc66ff87acc5003e913483a63081fa2931b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145960
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-04 18:11:54 +00:00
Mike Fairhurst f1c1dfacb7 [analysis_server] Report to both prod & staging crash reporting 
This CL enables us to have different crash reporters that report to
different backends, this will be useful if we report plugin errors to
staging and server errors to prod.

Currently doing this with server errors so that we can make the switch
over to prod incrementally. For the time being, the staging backend will
have our whole crash history, and continue to get new crashes. Reports
and dashboards can switch over to the prod backend as we get enough
history for those reports to be useful, and when we have switched
everything over we can stop reporting to staging entirely.

Change-Id: Ie29b4e05c89fd57faf1487a2c2eba3701fc319d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145922
Reviewed-by: Devon Carew <devoncarew@google.com>
 2020-05-04 18:11:54 +00:00
Brian Wilkerson c562a628bd Remove containingMemberName parameters from SuggestionBuilder 
Change-Id: I5dc85773deffe98fd5d8308b0d4c8fe350a385f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146063
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-05-04 16:23:30 +00:00
Brian Wilkerson 0d9c03b6a3 Convert the FixProducer to be table driven 
At this point I'm mostly interested in getting your feedback on the
general approach of making the fix processor be table driven. If you
agree that it's a good direction, then I would actually propose adding a
static method to each of the producer classes that looks something like

static AddRequiredKeyword generator() => AddRequiredKeyword();

and updating the map to contain references to those static methods
(rather than local closures), such as:

CompileTimeErrorCode.MISSING_DEFAULT_VALUE_FOR_PARAMETER: const [
  AddRequiredKeyword.generator,
],

Doing so would make the code in FixProcessor slightly cleaner, and would
allow the tables to be constants.

Change-Id: Ifdd8a4d82c6ab83aea0929dc9c8a4dcbce271e6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146064
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-03 17:34:07 +00:00
Brian Wilkerson d5af40b640 Convert NamedConstructorContributor to use SuggestionBuilder 
Change-Id: I3a174c1d65d98433d837502ad3ccedad0c535bde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-03 16:57:56 +00:00
Brian Wilkerson 72a36e41ce Finish converting LocalReferenceProvider 
There's still some clean-up work that I'll do in a separate CL.

Change-Id: I010973365720dcfa9ecd5b8c4690b8b489446e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-02 20:19:36 +00:00
Brian Wilkerson be1f85847f More conversion of the LocalReferenceContributor 
Still not done, but it's getting closer.

Change-Id: Ic577ed5ae77ecefa2349f81f832fa79b41fb3cc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-02 04:14:55 +00:00
Paul Berry f0e428eb73 Migration: encode and decode paths properly on Windows. 
Fixes #41678.

Bug: https://github.com/dart-lang/sdk/issues/41678
Change-Id: I532f65eb99a9ad7ce2542bffa0aa2d5a680d28c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145880
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-01 17:53:13 +00:00
Brian Wilkerson f6621463b2 More progress on converting LocalReferenceContributor 
Change-Id: Idf4b0051504ad020d17e4f1733ca7036aadddf18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145665
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-05-01 14:44:13 +00:00
Brian Wilkerson cea45271b3 Convert about half of LocalReferenceContributor to use the SuggestionBuilder 
I'm planning on converting the rest of the class in the next CL, but
thought that a combined CL would be too large.

Change-Id: Ic18ead8285019791053f696daee0b5182c4740de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145600
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-30 16:58:57 +00:00
Paul Berry c6f94c3224 Migrtaion: add a hook to allow the preview server to be shut down in unit tests. 
Without this, it's possible for a unit test failure to result in a
preview server remaining open, which can prevent test execution from
terminating.

Change-Id: I8a11056da5bea003dfa46e3871a241e8f5ce8cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145440
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-29 19:11:54 +00:00
Jaime Wren cb77214f19 Revert 2 of the override_contributor.dart changes from last week. 
This reverts commit f7d14e49 and 45588642

Change-Id: Iab211d2879f2bd6a420ea6fb5b0de058c02ac4ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-29 18:22:49 +00:00
Jaime Wren 53601ecc18 Implement available suggestions in completion_metrics.dart, a flag is added to enable the new feature. 
Change-Id: Ib7477b1a517d4aa1dc09d85df3df553ca61baa2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145241
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-29 17:59:24 +00:00
Sam Rawlins 82e4a4465b Migrator: change sdk constraints to >=2.9.0 <2.10.0 
Bug: #38347
Change-Id: Iedb9acfe313a14d4c35f3637f3ef0104e836dd4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145260
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-29 17:47:44 +00:00
Brian Wilkerson 51a66bcfa2 Use SuggestionBuilder to build suggestions for field formal parameters 
Change-Id: I157cc755f4bad5086c8e44d7e89504e31283e6bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145442
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-29 15:30:14 +00:00
Brian Wilkerson 2270add4ae Use the element kind feature for instance members 
Change-Id: I8fb449e485c77f7c13b9dd8b01f056d970ba551b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-28 23:40:43 +00:00
Brian Wilkerson 5528d8daac Add a fix to add the required keyword 
Change-Id: I2602ab5b4d3b47d3d8e302aa60847b791768481a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-28 20:04:22 +00:00
Brian Wilkerson 1c7a69e015 Support suggesting an accessor in SuggestionBuilder 
This also introduces a first step toward de-duplicating suggestions as
part of the responsibilities of the SuggestionBuilder.

Change-Id: I1bcda241b0caee528c5740deae5662c6d43102aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145143
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-28 18:38:52 +00:00
Konstantin Shcheglov 14f41846ab Add CiderFixesComputer. 
Change-Id: Ie0a69ccbba5a6b9afec322caeb3d8edfe8293abd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-28 15:34:31 +00:00
Brian Wilkerson 20ac7e08ee Remove _coverageMarker and uses 
Change-Id: I52158e1bfc75773136dbbdc3191cb31d2813a3f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144989
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-28 04:32:17 +00:00
Brian Wilkerson 7598d4b3d5 Support suggesting methods in SuggestionBuilder 
Change-Id: I2d6845690513eaa408b69d7028b7bc25376cbda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144987
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-27 22:41:46 +00:00
Paul Berry 123222090f Migration: add the ability for the preview server to be turned off. 
This is necessary for unit testing, and probably good practice for
normal usage; we don't want to fire up a server even briefly if the
user specifies `--no-web-preview` when running the migration tool.

Not yet wired up to dartfix--probably I won't bother to do this since
migration is being decoupled from dartfix and a new CLI is being
implemented for it.

Change-Id: I79862d9baf328d0f428f63955fb5918c94186ccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144860
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-27 16:33:23 +00:00
Jaime Wren 7dd9945622 Bug fix in combinator_contributor.dart, don't suggest names already shown or hidden by the existing combinators (in the same directive). 
Change-Id: I8de3670d4026ed2b6eda4c24223580e22015864b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144806
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-27 16:18:09 +00:00
Konstantin Shcheglov 03429b20cd Use FuzzyMatcher for Cider completion filtering and sorting. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I1b8360e95327dfd4eaefaa8990105bd4750c2acc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144864
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-27 04:10:09 +00:00
Brian Wilkerson c1edd26d97 Remove the remaining unnecessary awaits from analysis_server 
Change-Id: I3d10c244ca711a0978cb2d4a99dbe1f3bedc159c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144863
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-27 04:05:59 +00:00
Konstantin Shcheglov f43437cf80 Fix for avoid_types_as_parameter_names in try/catch. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I5d7e89567ac947274de073b166840753a79814bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144786
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-04-27 03:29:09 +00:00
Brian Wilkerson 12dcfe63bb Start removing extraneous awaits from server 
Change-Id: I484227773e98d87c915f6dfe6e320dda1a7b8eaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144862
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-26 23:45:29 +00:00
Brian Wilkerson a53d336b9f Convert the remaining methods in BaseProcessor to use subclasses of CorrectionProducer 
Change-Id: Ide2c426939f6a0965caaa37a87ebe825b74d9d17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144787
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-26 20:12:49 +00:00