Commit Graph

42 Commits

Author SHA1 Message Date
Sigmund Cherem b7b24e9bbe Update dart2js-strong status across several suites
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-03 00:27:31 +00:00
Alexander Thomas 2a3d1dc9ed [vm] Prepare status for app_jitk builders (#33126)
Change-Id: Iec5347b5f091b9fd6ff3c24047b011527f8b08ee
Reviewed-on: https://dart-review.googlesource.com/56802
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-05-29 11:43:25 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Sigmund Cherem 5f51db3efb More status preparations to make the CQ clean
TBR=sra@google.com

Change-Id: I8275ada3611cfd4099342f963d76d94d7a267aac
Reviewed-on: https://dart-review.googlesource.com/45751
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-09 06:47:28 +00:00
Sigmund Cherem 16e8194147 Prepare additional lib, html, samples statuses: this embeds of d8-hostcheck results
TBR=sra@google.com

Change-Id: I4a86f3d51629bbd7dd36825f8c2d993b386ea8e0
Reviewed-on: https://dart-review.googlesource.com/45745
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-08 21:10:37 +00:00
Peter von der Ahé 94aa20dd07 Update status for $compiler == fasta
Change-Id: I5d073d1c678dc313e79193074c6491085c093596
Reviewed-on: https://dart-review.googlesource.com/45381
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-03-07 10:32:33 +00:00
Siva Chandra d45d5a72d2 Pass --preview-dart-2 to dart_bootstrap and dart_precompiled in dartkp config.
Change-Id: I728d085b6433d7ad35fb389ce61b4959311a9b4a
Reviewed-on: https://dart-review.googlesource.com/44383
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
2018-02-28 23:49:05 +00:00
Paul Berry 063a244a7f Fix analyzer bot failures in non-strong mode.
Change-Id: I614f2b5869e8b2ac022cc401df08d4dda4efd513
Reviewed-on: https://dart-review.googlesource.com/44101
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-02-28 09:22:13 +00:00
Siva Chandra efc8ec1560 Update status of kernel/unsorted/types_test for dartkp non-strong.
Change-Id: Ibd22612ccbf4fa855f3a6bc068da64f4bb911fe6
Reviewed-on: https://dart-review.googlesource.com/44123
Reviewed-by: Siva Chandra <sivachandra@google.com>
2018-02-28 05:49:00 +00:00
Siva Chandra 579911393d More status file updates.
Update status files after 4f5ad1918c

Change-Id: Ied65144686db3d57b3af7375ddd810337867d016
Reviewed-on: https://dart-review.googlesource.com/44121
Reviewed-by: Siva Chandra <sivachandra@google.com>
2018-02-28 04:43:18 +00:00
Siva Chandra 27d28702a6 Update status files after 4f5ad1918c
Change-Id: I96c56728521a507fe9870fa3f53060d594fa8a78
Reviewed-on: https://dart-review.googlesource.com/44023
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Chandra <sivachandra@google.com>
2018-02-28 02:06:36 +00:00
Siva Chandra 4f5ad1918c Make strong mode the default under --preview-dart-2.
Change-Id: Ic1637d65a34f6b0310439293f7d83cb351f2c89c
Reviewed-on: https://dart-review.googlesource.com/43200
Commit-Queue: Siva Chandra <sivachandra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-27 22:16:07 +00:00
Aske Simon Christensen 9d3e18e14d Do not treat context messages as errors in tests.
Re-enable co19 tests in legacy mode, reverting
f9be43d0f6

Closes https://github.com/dart-lang/sdk/issues/32337

Change-Id: I87922f6d8d727737f51fa6506dd775decd68915e
Reviewed-on: https://dart-review.googlesource.com/43966
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2018-02-27 15:20:19 +00:00
William Hesse 28b318abd4 Update status for non-strong dartk on args mismatch compile-time warning/error
The test kernel/unsorted/invocation_errors_test is mistakenly reported as
an error in non-strong mode

R: askesc@google.com
Bug: https://github.com/dart-lang/sdk/issues/32337
Change-Id: Ic0bcf74a87570d72b386c3a4e04d3a13f2a10394
Reviewed-on: https://dart-review.googlesource.com/43963
Reviewed-by: William Hesse <whesse@google.com>
2018-02-27 11:57:33 +00:00
asiva b656c6cb1e Fix bot
Change-Id: I226ed09a482aace743e04c637b2c5a9dcc215090
Reviewed-on: https://dart-review.googlesource.com/43942
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-27 06:56:30 +00:00
asiva 29b0a84220 Fix status file.
Change-Id: I44e4ae7cc9095a097d4d10f9f6a4b9ea74e8b6bf
Reviewed-on: https://dart-review.googlesource.com/43941
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-27 06:05:36 +00:00
asiva fb2d58945d Adjust a non strong run status file (maybe this directory should also be skipped for non strong runs of dartk and dartkp)
TBR=rmacnak

Change-Id: I4bb17256bf77637d5da7dbcd63e79dc9427e7e73
Reviewed-on: https://dart-review.googlesource.com/43940
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-27 05:47:23 +00:00
Alexander Markov 882daf8972 [Tests] Update tests/kernel for Dart 2 fixed-size integers
Closes https://github.com/dart-lang/sdk/issues/32072

Change-Id: Ic9bb34d2dbee6852e024f1b79d895e4d8150f03f
Reviewed-on: https://dart-review.googlesource.com/39821
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-13 00:09:28 +00:00
William Hesse be2e6c4f82 Update status for new dartk and dartkp builders
Change-Id: Ie5ed3cade049d1d7831440adece520dd09ad13d7
Reviewed-on: https://dart-review.googlesource.com/39985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-08 16:52:56 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-02-07 11:50:10 +00:00
Brian Wilkerson 4cad8c202d Attempt to fix bot status
Change-Id: Ib934765771306d57b218d3691c3bba249f1d90ef
Reviewed-on: https://dart-review.googlesource.com/37863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-31 19:51:55 +00:00
Sigmund Cherem 0c04eb53c7 Disable int64 when running dart2js
The goal is to renable it as soon as we migrate our constant-evaluator and
constant folding to use Bigint.

Change-Id: I3bba1bbe07517e9cb496896b3417f58173878d62
Reviewed-on: https://dart-review.googlesource.com/34302
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-01-16 19:52:22 +00:00
Alexander Thomas 89bd41d19a [infra] Simplify vm-kernel configurations in test matrix
This also adds the missing vm-kernel opt-counter builder.

Bug: https://github.com/dart-lang/sdk/issues/31753
Change-Id: I0199218f83d227cfc52505c213d7b689acd9c43e
Reviewed-on: https://dart-review.googlesource.com/31984
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-01-09 20:59:49 +00:00
Alexander Markov c051a0b905 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default, v2
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

This CL includes ff9fc413a7 with fixes.

Change-Id: I632d8177e9d07cd82ecea75ab6c325681b3a25c9
Reviewed-on: https://dart-review.googlesource.com/32443
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-05 01:44:56 +00:00
Alexander Markov 90551f6aa5 Revert "[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default"
This reverts commit ff9fc413a7.

Reason: buildbot failures.
Change-Id: I68ffde271c8ba3b212e3bf015e2e550c8c891441
Reviewed-on: https://dart-review.googlesource.com/32442
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-01-04 19:04:44 +00:00
Alexander Markov ff9fc413a7 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

Change-Id: I967a413c0b81eb92cf6be78ad3ee324798288bd2
Reviewed-on: https://dart-review.googlesource.com/31406
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-01-04 18:02:57 +00:00
Vyacheslav Egorov efca9c69ab [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration.
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Reland of https://dart-review.googlesource.com/27820

Change-Id: I49400fae716f75425e70bf1e561b3375ba39157e
Reviewed-on: https://dart-review.googlesource.com/28565
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-12-12 12:19:10 +00:00
Vyacheslav Egorov e84fa65696 Revert "[vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration."
This reverts commit 50865e9387.

CQ on Mac is broken.

TBR=kustermann@google.com

Bug:
Change-Id: I41a7cab59c076dba4f25f5904725cca5bb4619c9
Reviewed-on: https://dart-review.googlesource.com/28420
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2017-12-11 21:07:43 +00:00
Vyacheslav Egorov 50865e9387 [vm/testing] Make --strong -c dartk configuration a Dart 2.0 configuration.
Switch it to use pkg/vm/tool/dart2 which is the source of truth for what
Dart 2 VM configuration means. Don't pass any additional flags from
tools/test.py itself.

Align pkg/vm/tool/dart2 with what tools/test.py was passing to VM on _2 suites.

Make default invocation `tools/test.py -c dartk --strong -m release,debug`
green by updating status files and skipping suites that are not Dart 2.0
compliant. I have filed issues #31588 for isolate suite and #31587 for
service suite.

Change-Id: I882b28f6a011eabf69c349ff0792b275434e39ff
Reviewed-on: https://dart-review.googlesource.com/27820
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2017-12-11 12:49:22 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook.
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-07 08:38:30 +00:00
Vyacheslav Egorov 7d5231796e [VM, Precompiler] Support obfuscation of the symbolic information in precompiler
Obfuscation is controlled by obfuscate flag in Dart_IsolateFlags.

Obfuscation of identifiers is performed during script tokenization - when TokenStream is generated from the source. All kIDENT and kINTERPOL_VAR tokens are renamed consistently using a persistent obfuscation map stored in ObjectStore::obfuscation_map.

Some identifiers (pseudo-keywords, arithmetic operators, builtin recognized methods and entry-points) are not renamed to keep name based lookups from breaking. All other identifiers are renamed.

Constant instances of Symbol-s (both created via literal syntax #ident and using constant constructor const Symbol("ident")) are renamed consistently with corresponding identifiers.

Script urls and Library urls and names are also obfuscated.

Obfuscation map can be dumped as a JSON array at the end of precompilation using Dart_GetObfuscationMap API.

BUG=https://github.com/dart-lang/sdk/issues/30524
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/3003583002 .
2017-08-25 09:48:23 +02:00
Peter von der Ahé ba84f801f4 Change how unresolved super sends are handled.
The mixin transformer is now responsible for adding no-such-method calls.

Fixes https://github.com/dart-lang/sdk/issues/30000

R=paulberry@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2963763002 .
2017-06-29 12:21:49 +02:00
Vyacheslav Egorov de56824429 Switch -c dartk/dartkp configuration to use fasta.
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721443002 .
2017-02-26 20:39:02 +01:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
2017-02-06 13:26:39 -08:00
Johnni Winther dd89b3fe27 Skip kernel test on dart2js
Review URL: https://codereview.chromium.org/2475573003 .
2016-11-03 14:36:34 +01:00
Vyacheslav Egorov dc80ad0ab4 Update kernel.status to accomodate for dart2js semantics
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2457703005 .
2016-10-28 12:08:08 +02:00
Vyacheslav Egorov eb8c24e133 Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2451623006 .
2016-10-27 10:09:22 +02:00
Vyacheslav Egorov 12968edb9c Revert "Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork.""
This reverts commit 4e7a31262e.

Windows bots are broken now.

R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2451893004 .
2016-10-26 17:07:18 +02:00
Vyacheslav Egorov 4e7a31262e Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
This relands commit 2fed1c3905 with fixes to ensure that analyzer summaries are correctly created and XARM build does not try to use target binaries on the host.

R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2453773002 .
2016-10-26 16:48:28 +02:00
Vyacheslav Egorov cf7ff42e60 Revert "Merge more Kernel infrastructure from kernel_sdk SDK fork."
This reverts commit 2fed1c3905.

SDK builds are failing

TBR=zra@google.com

Review URL: https://codereview.chromium.org/2455593002 .
2016-10-26 13:06:27 +02:00
Vyacheslav Egorov 2fed1c3905 Merge more Kernel infrastructure from kernel_sdk SDK fork.
- bring patched SDK generation scripts and VM patch tweaks that allow VM patch files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
R=asiva@google.com, kmillikin@google.com, whesse@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2434123003 .
2016-10-26 13:02:54 +02:00