dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
68,705 Commits 2 Branches 0 Tags
dbb56e5e10adb22805edf25cfd9a0ee5086c19cf
Commit Graph

3312 Commits

Author SHA1 Message Date
Brian Wilkerson afde51a608 Start sending urls for preview mode from server to dartfix 
Change-Id: Ice8463ec9a5d3d21b47e6250f24d093a48b11b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127988
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-11 14:26:29 +00:00
Sam Rawlins 9ce43015f4 NNBD preview: improve details of where a nullable value is 'assigned' 
Change-Id: Ifcb37460ef5255e9de58a51860ee47228735abf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127200
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-12-11 14:07:09 +00:00
Sam Rawlins 108a80bd0d NNBD: Mark some good tests as passing; add FailingTests for some GitHub issues 
Change-Id: Ia5a55b5c6f1e7d7c7bef32c0afecf689952e17eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127761
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-09 22:17:44 +00:00
Brian Wilkerson 9605cca5a6 Make a method public that is overridden in a subclass 
Having the method be private causes the interactive tool to be broken.

Change-Id: I9390de3b9510c38c69039f2df38a116802acdf89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127701
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-09 19:31:13 +00:00
Mike Fairhurst 22fef10a59 [nnbd_migration] suppress fewer upstream exact nullable nodes 
Change-Id: I1acd6b44c098868127e903d96baafa03bcd34b04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127421
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-12-09 18:56:29 +00:00
Sam Rawlins acac2d8d63 NNBD preview: Extract Dart page styles into their own file 
Change-Id: Iaea12e058c703a198a2ff388a85683cf5cbff8b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127493
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-07 02:06:54 +00:00
Brian Wilkerson 310c2eb5c4 Display target file name as link text 
Change-Id: I1a919db827709210e89ca6e7ecf5a9ed2c5e7d0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127300
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 23:22:04 +00:00
Konstantin Shcheglov b92cd2cb95 Deprecate DartType.displayName, use getDisplayString() instead. 
We call it with `withNullability: false` almost everywhere.
My attempt to update all places turned out to be a long chain of
changes. So, instead I will make decisions and updates in separate
CLs, starting with ErrorReporter.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9d72475577ba2934bed1c06a4808ab620e92a20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127441
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 22:43:59 +00:00
Mike Fairhurst 70750329af [nnbd_migration] use animation/delay to make tooltips easier to use 
Change-Id: I7c32a091952b221037abcdb27b803834678219aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127487
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2019-12-06 22:35:54 +00:00
Sam Rawlins 84cc410c7e NNBD preview: move navigation; clean up styles 
View output for logging here:
https://srawlins.users.x20web.corp.google.com/nnbd-i13n/logging-sample/lib/logging.html

* black background
* navigation on the right, colored links, styled
* flex display allows links to be up top if they don't fit horizontally next to source code
* nice font
* removed "suggestions" from text, which I think confused participants into thinking
  they were expected to manually enter changes being "suggested."
* nice positioning; consistent margins and padding.
* hyphenated-case CSS classes

Change-Id: I67f373e7c549d9c56cceb082439a77be78e45827
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-06 22:02:04 +00:00
Brian Wilkerson 652926bbaf Deprecate Element.getAncestor, replacing it with methods matching those in AstNode 
Change-Id: Iebb046791c1fce57a228f997e9c5936809fbc872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 18:29:02 +00:00
Devon Carew 723baf767f [analyzer] fix an npe in fix_internal.dart:2171 
Bug: https://github.com/dart-lang/sdk/issues/39673
Change-Id: Iad903410ba5fecfa61992c2dfba9289c07234269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-06 00:56:10 +00:00
Brian Wilkerson 2bb60763c3 Fix remove_type_annotation fix/assist to work with for loops (issue 39628) 
Change-Id: Ie212ea369cb2c0d4d8b37b50928d3935fad6a445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-04 16:15:08 +00:00
Sam Rawlins 28fc03709d NNBD preview: Improve details for overridden nullable parameter types 
Change-Id: Id7f85d2030f818f690f904050f0ec54c15b0d819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127066
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-04 14:20:48 +00:00
Devon Carew ec28bf1fd1 [analyzer] refactor the vm status section in the analyzer diagnostics page 
Change-Id: I67213237d8b867ef5ac3655b51f58ee2ea5a6485
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-02 19:20:18 +00:00
Brian Wilkerson 4ba61bbbbc Fix exception in ML ranking (issue 39537) 
Change-Id: I5667060acb3392da60956176e1edd35dd8098b2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-11-28 00:03:51 +00:00
Devon Carew 3204295ce1 [analyzer] send the plugin name with crash reports 
Change-Id: I674fe2a80a628bd3c509686f205101be8e081f19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126605
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 22:07:21 +00:00
Brian Wilkerson 6f8fa3cbb3 Fix an NPE when using ml without available suggestions (issue 39535) 
Change-Id: Iea21873e7878cb3db289e5a7418e991deb8f7b16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126602
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-11-27 19:34:31 +00:00
Mike Fairhurst 58dde43b5e [analysis_server] don't create futures for stalled plugins. 
Also looks like "cannot stop a plugin that's already running" occurred
from this case, which was also an easy fix.

Change-Id: I113170e65ced26d1113cdb4e0cf206c8b1b68d31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-27 18:18:21 +00:00
Devon Carew f6a76586de [analyzer] send additional data to crash reporting 
Change-Id: I9f2da85e1c283ed4942ba076c98003aef80b7051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126203
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 00:16:50 +00:00
Mike Fairhurst bb76f935c1 [nnbd_migration] Better descriptions for the most common bangs 
Change-Id: I6a0dbc67a5c696385e76b1cb340755a573903366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-26 17:37:29 +00:00
Konstantin Shcheglov 58e9aeafdb Deprecate AnalysisSession.typeProvider and typeSystem. 
Change-Id: I33132bed9fd950030746adbd8951506a81912c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-26 01:30:33 +00:00
Mike Fairhurst 4987416f69 [nnbd_migration] Only restyle code links (which I also bolded) 
This leaves default link styling for links that aren't click-thru nav,
so inside the pop-ups as well as the links to other files at the top of
the page. Default styling as in blue and underlined.

I also made the code links bold when hovered, because the participant
didn't try clicking on them. Hopefully this grabs more attention.

Change-Id: Ib35c2353e54faa19ba2fa8e0a613ecabd3298463
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126206
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-25 22:28:47 +00:00
Konstantin Shcheglov 273ca5858b Deprecate AnalysisContext.typeProvider/typeSystem 
Change-Id: I5235aa38bcde93618a10b88da9ad6a8c3e5dc29c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-25 22:00:47 +00:00
Mike Fairhurst d89252d369 [nnbd_migration] make tooltips stickier 
Change-Id: I266701e447e2f7ea0cd432ebb9ab55bddfb5375c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126202
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-25 21:28:50 +00:00
Brian Wilkerson 53d3b5d780 Generate the auxiliary files in a subdirectory 
Rather than being in the top-level of the output directory, these files
are now in a directory named `aux`.

Change-Id: I40df67f76d22fcf1bfe0821e65854ff375c127b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-25 20:27:45 +00:00
Devon Carew 18b7580944 [analyzer] for 'Failed to handle request' errors, send the exception to crash reporting as well 
Change-Id: Id50543fe6cac0e60ec32bfc6860064b210514dca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125988
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-25 20:20:46 +00:00
Danny Tuppeny d45438e793 Add support for selecting text in completion snippets 
When a client advertises that it supports snippets in completions we should wrap a tabstop around the part indicated by selectionOffset/selectionLength.

Change-Id: I7a0ee4b71dd5f46c206f57b81080aa8f2d79225b
Bug: https://github.com/dart-lang/sdk/issues/39500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126165
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-11-25 15:14:15 +00:00
Konstantin Shcheglov 6294c73f3e Deprecate 'typeSystem' parameter for InheritanceManager3. 
Change-Id: If14eb8900b0fb5cac5e49cf865f2e6e3a0a0263d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-22 23:08:41 +00:00
Brian Wilkerson f196196779 Add modification counts and instructions to all pages; add an index page 
Change-Id: If78e4c8cc0a4e638ca778240d8060c545b14fcba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126082
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-22 23:03:37 +00:00
Mike Fairhurst c58d263729 [analysis_server] Handle directory watcher closed on windows. 
Change-Id: I11d1d9a324ebb27a920837ee4382b89e7cbb0253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125765
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-22 21:22:28 +00:00
Konstantin Shcheglov c9165dc3cd Add 'sdkVersion' field to 'server.log' messages. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ib0777ba24139e095540b4dc2aa2e7d19aabaf002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125990
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-22 18:00:45 +00:00
Ivan Inozemtsev 82c9950e9c Reland "Fix completion in Analysis Server LSP mode" 
This is a reland of ec8fc01d3b

Original change's description:
> Fix completion in Analysis Server LSP mode
>
> Looks like it was initially broken in
> https://dart-review.googlesource.com/c/sdk/+/122962
>
> Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I06e1dea28e4510334e3fc4f887455a81ccdec916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125975
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2019-11-22 14:28:54 +00:00
Ivan Inozemtsev a2bf8153af Revert "Fix completion in Analysis Server LSP mode" 
This reverts commit ec8fc01d3b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix completion in Analysis Server LSP mode
> 
> Looks like it was initially broken in
> https://dart-review.googlesource.com/c/sdk/+/122962
> 
> Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,dantup@google.com,ariaye@google.com,iinozemtsev@google.com

Change-Id: If4a86634335c3e962b37c1e97532f05ee8b9d28d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125974
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2019-11-22 10:35:45 +00:00
Ivan Inozemtsev ec8fc01d3b Fix completion in Analysis Server LSP mode 
Looks like it was initially broken in
https://dart-review.googlesource.com/c/sdk/+/122962

Change-Id: I83b565223208fc1404c61c6971fdcc41b10fb406
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125964
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-22 10:25:31 +00:00
Sam Rawlins 535cbf5db9 NNBD preview: Text for return type with nullable return type in subclass 
Change-Id: Ia829b3f8cb7f09b10180478394608a05cdcdbb6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125984
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-21 21:07:25 +00:00
Brian Wilkerson 655ddc90b4 Print a URL that can be used to open the preview tool when a port is specified 
Change-Id: Ia22ce6fa6f42bbcc13c9688d35f7bc72028ae39f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125928
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-21 18:20:15 +00:00
Konstantin Shcheglov 615928c514 Stop referencing non-API TypeSystem in analyzer. 
Replace it with TypeSystem from lib/dart/element/type_system.dart,
or (internally) with TypeSystemImpl.

We keep the old TypeSystem where its is exposed from API:
- ResolveResult.typeSystem
- AnalysisSession.typeSystem
- AnalysisContext.typeSystem

  We will make changes to these as a breaking change later.

Change-Id: I40ca53ea77e440457c6d0f3832ec3b6286bacdf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 01:09:24 +00:00
Brian Wilkerson f31fb0386b Catch exceptions during ranking and disable smart ranking 
Change-Id: Ib24a5a16da0fdfaf6d8504adab5c087ecec3abf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-19 20:06:29 +00:00
Paul Berry 0d40d3736b Change mocks.dart to triple-slash comment style 
Change-Id: I157e67f3d893058fc00732dc8eda6fe2729fa805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125548
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-18 23:04:10 +00:00
Paul Berry c0144141ce Move TestPluginManager, MockServerChannel, and ServerError into utilities 
There's no reason these classes need to be in test, and I want to
re-use them in a tool for testing NNBD migrations.

Change-Id: I43686a44d5f8d83f0d1cc23315746250eb766681
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125485
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 22:26:00 +00:00
Paul Berry 28d9eaf230 Migration: Go ahead and generate migration output files even when a port is given 
Change-Id: I5912834d4cdf53ea3baab0dd15acd2df982ca5a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 22:26:00 +00:00
Jaime Wren bc449f160b Fix for dartbug.com/39401 -- quick fix improvement around angular generated files 
Change-Id: I363b8f14363a53f01fd170e36752a3f0a9ec8e48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125412
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 20:58:35 +00:00
Sam Rawlins ed971fd0c7 NNBD migrator: Add Locations for each edit made in an NN fix 
Change-Id: I53342cb43910deea2f59f37d5795ddbb70cb6b0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125480
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 20:40:25 +00:00
Mike Fairhurst e34e734b56 [nnbd_migration] track causations for substitution nodes 
Change-Id: I7da4f2923d9b99b0bd6c16644a7adeaeda437340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125463
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-18 18:49:39 +00:00
Sam Rawlins 7905e78db2 NNBD preview: Better messaging for non-late uninitialized variable 
Change-Id: Ica0433154f0f72d6f79159a77e0b784bdb1d6f40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-18 18:28:23 +00:00
Brian Wilkerson 1ae6f1b031 Support for creating and displaying edits in the preview tool 
Change-Id: I2284ceeb0229d7111022eb3759e39752264f1bc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125492
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 16:14:43 +00:00
Konstantin Shcheglov 8fbb053092 Issue 39021. Guard against invalid generic type alias, without function type. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39021
Change-Id: I0259ef04f95e1935ca273b5540aafb069c7ad455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125526
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 16:06:53 +00:00
Konstantin Shcheglov 3a17bebf9c Issue 39028. Guard against mixin constructor in FieldFormalParameter completion. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39028
Change-Id: I78e4df6baa8424231aeb2c8044d9cb5c685dcdbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:36:48 +00:00
Sam Rawlins 15e5c23167 nnbd preview tool: Better text when inserting 'required' 
Helps with #39247

Change-Id: I3bb7b25c73d58fc49260d6e3019b58b2f3f6b80a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125440
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-15 22:20:16 +00:00