Commit Graph

43 Commits

Author SHA1 Message Date
kevmoo@j832.com d28d86f8dc pkg/serialization types cleanup
Hide a few things, fix return types, make a few things final, etc.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//14793016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22524 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 18:59:40 +00:00
alanknight@google.com 66fbf314d5 adding missing interfaces to _LazyList
R=alanknight@google.com

Review URL: https://codereview.chromium.org//13985040

Patch from Adam Singer <financecoding@gmail.com>.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22143 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 19:11:31 +00:00
alanknight@google.com 2abd6c9b51 Fix for mirror API breaking change to index libraries by URI, and clean up references in doc comments
Review URL: https://codereview.chromium.org//14447008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22040 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-25 16:49:38 +00:00
alanknight@google.com 1e92447b78 Update pkg/serialization to use Symbols and synchronous mirrors
Review URL: https://codereview.chromium.org//13982012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21818 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 17:00:58 +00:00
floitsch@google.com 759a366cea Remove insertRange.
Review URL: https://codereview.chromium.org//13956006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21464 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:20:16 +00:00
lrn@google.com 485c8a5999 Move Iterable implementation to collection.
Add IterableMixin and IterableBase to dart:collection.
For now, the implementation is duplicated, because mixins and const
constructors don't mix. We hope that mixins will be improved in the
future to allow using the mixin to define the base class.

Review URL: https://codereview.chromium.org//14022007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21457 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 14:32:16 +00:00
gbracha@google.com e08647bfd3 BREAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, setFieldAsync. Likewise ClosureMirror.apply and ClassMIrror.newInstance. This is in preparation of new synchronous versions of the originals.
Review URL: https://codereview.chromium.org//13967003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21242 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 23:58:22 +00:00
lrn@google.com 24e3c0bbb0 Reapply "Reduce usage of IterableMixinWorkaround"
Fix bug and recommit

Review URL: https://codereview.chromium.org//13496014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21049 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 08:07:39 +00:00
erikcorry@google.com 4e0db7cede Revert 20969: Reduce usage of IterableMixinWorkaround
R=ahe@google.com
BUG=

Review URL: https://codereview.chromium.org//13598015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20972 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 15:18:13 +00:00
lrn@google.com f3608405a3 Reduce usage of IterableMixinWorkaround.
Review URL: https://codereview.chromium.org//13685004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20969 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 15:01:19 +00:00
lrn@google.com 3b13f62170 Remove addLast from List.
The List.addLast method has been deprecated for quite a while.
A recent change removed it from the interface, but left the
implementation in place (which caused some errors from the analyzer).
This removes it completely.

Review URL: https://codereview.chromium.org//13528004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20857 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 12:52:19 +00:00
alanknight@google.com 6ed8fcc992 Add test and fix for 9203, fix sdk dep, delete unused file.
Review URL: https://codereview.chromium.org//12604023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20346 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-21 20:40:17 +00:00
floitsch@google.com 76d507cb6f Add List.insert.
BUG= http://dartbug.com/5375

Review URL: https://codereview.chromium.org//12383073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20037 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 17:38:14 +00:00
floitsch@google.com 65718c56df Rename XMatching to XWhere.
For example firstMatching -> firstWhere.

BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337

Review URL: https://codereview.chromium.org//12537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
floitsch@google.com d91bca2813 Add List.asMap().
Review URL: https://codereview.chromium.org//12391046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19399 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 16:57:52 +00:00
lrn@google.com f4300b84a2 Make List.from and Iterable.toList default to not growable.
Review URL: https://codereview.chromium.org//12401002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19391 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 14:55:40 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list.
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
lrn@google.com bbfe7b02dc Reapply "Make Comparable generic."
Avoid concurrent modification in dart2js.
Avoid crash in VM by not using self-referential type bound.

Review URL: https://codereview.chromium.org//12288040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18667 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 10:29:44 +00:00
kasperl@google.com d4feeb4910 Revert "Make Comparable generic."
This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//12298027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18657 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 08:06:03 +00:00
lrn@google.com a0f22b77be Make Comparable generic.
It's now allowed to write "class X implements Comparable<X>" to make
X comparable only to X's. The argument type of Comparable<T>.compareTo
is now T.

Review URL: https://codereview.chromium.org//12255055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18655 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 07:52:24 +00:00
lrn@google.com 03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com 0e0473d33a Unbreak pub:
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Review URL: https://codereview.chromium.org//12286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
floitsch@google.com 0672317bec Remove deprecated mappedBy.
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy."
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy.
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
alanknight@google.com 84b4fc6a80 Fix modification of map while iterating in SimpleJsonFormat
Review URL: https://codereview.chromium.org//12210151

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18527 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 18:30:21 +00:00
alanknight@google.com 9fef95b7cc Some fixes to work better with the services framework
Review URL: https://codereview.chromium.org//12136002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18357 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 23:38:22 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
floitsch@google.com 1b65d1175b Remove import of collection-dev.
Review URL: https://codereview.chromium.org//12096042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17802 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 19:29:54 +00:00
alanknight@google.com d455506421 Serialization shouldn't modify the keys of a map it's iterating over
Review URL: https://codereview.chromium.org//12091026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17727 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 18:55:35 +00:00
alanknight@google.com 205d67aa3f Add a MapRule
Review URL: https://codereview.chromium.org//11931030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17724 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 17:57:11 +00:00
lrn@google.com 16795f22d1 Add List.reversed to give a reverse fixed-length view of a list.
Review URL: https://codereview.chromium.org//11896013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17402 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 14:56:45 +00:00
lrn@google.com 0e934a631e Add methods to Collection.
Methods are:
- void add(E)
- void addAll(Iterable<E>)
- void remove(Object)
- void removeAll(Iterable)
- void retainAll(Iterable)
- void removeMatching(bool test(E))
- void retainMatching(bool test(E))

They have been implemented for List and Set only.

Default implementations of removeX methods in Collections assume an efficient
remove method, which Lists won't have.

Review URL: https://codereview.chromium.org//11931034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17257 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 10:13:51 +00:00
alanknight@google.com b3b4c02a96 Make output formats pluggable, adapt to new libraries
Review URL: https://codereview.chromium.org//11820032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16989 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 22:17:14 +00:00
ajohnsen@google.com 32eeecd930 Fix tests for VM in checked mode.
BUG=

Review URL: https://codereview.chromium.org//11801008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16689 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:59:49 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
alanknight@google.com 7602684d20 Fix documentation bugs 7517 and 7518 in serialization.
Review URL: https://codereview.chromium.org//11624031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16581 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-02 18:01:20 +00:00
alanknight@google.com db782503f0 Rename specialTreatmentFor, improve handling of constants as constructor parameters.
Review URL: https://codereview.chromium.org//11644030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16448 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 18:27:57 +00:00
alanknight@google.com 87601ebd4a Duplicate of https://chromiumcodereview.appspot.com/11567018/
BUG=

Review URL: https://codereview.chromium.org//11613005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16229 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 21:14:30 +00:00
alanknight@google.com b909ef7dd9 Replicating CL https://chromiumcodereview.appspot.com/11553012/
BUG=

Review URL: https://codereview.chromium.org//11578037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16182 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 22:14:53 +00:00
alanknight@google.com 5df2b86dff Initial version of a serialization framework
Review URL: https://codereview.chromium.org//11293283

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15796 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 18:13:36 +00:00