8a86fc897f
Remove uses of Options from utils directory.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//46673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29560 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 15:58:52 +00:00
95e272386c
Use userAgent instead of webkitStartDart
...
This modifies our browser package and test scripts to use the
userAgent instead of webkitStartDart (which is gone) to determine if
we have native dart support.
I'm TBR-ing to get rid of a ton of warnings on the Dartium bots (they
are trying to run both native tests (successfully) and compiled-to-js
tests (warning no js file)).
E.g., see HttpServer warnings on this otherwise green run:
http://chromegw.corp.google.com/i/client.dart/builders/dartium-mac-inc-be/builds/634/steps/drt_core_checked_tests/logs/stdio
Siggi: you have comments elsewhere around removing/refactoring when
webkitStartDart is gone. They are still there.
TBR=sigmund@google.com ,ricow@google.com
Review URL: https://codereview.chromium.org//52023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29515 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 04:08:39 +00:00
c42ec6584d
pkg/unittest: remove testState
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//26443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29307 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 01:33:23 +00:00
6a72655d1b
Very simple version of Isolates.
...
R=ajohnsen@google.com , iposva@google.com , kasperl@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//27215002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
35d7140e66
Remove Encoding-enum from dart:io and add interface in dart:convert.
...
BUG= http://dartbug.com/6284
BUG= http://dartbug.com/7966
R=nweiz@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//22872012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26632 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 10:37:25 +00:00
179c810f8a
starting to work on unit test config interface
...
R=gram@google.com
Review URL: https://codereview.chromium.org//22883008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26215 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 20:48:32 +00:00
1b541506ff
Roll forward "Use package:stack_trace in unittest."
...
This reverts r25135, and rolls forward r25131, r25132, and r25133.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19540015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25169 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-18 19:30:33 +00:00
e93476aa9d
Roll back "Use package:stack_trace in unittest."
...
This reverts r25131, r25132, and r25133.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19684006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25135 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 23:55:46 +00:00
c7b527f8bc
Roll forward "Use package:stack_trace in unittest."
...
This reverts r24669 and rolls forward r24652, r24659, and r24661.
BUG=11649
R=asiva@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//18892003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25131 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 22:39:44 +00:00
d3af1780d2
Roll back "Use package:stack_trace in unittest."
...
This reverts r24652, r24659, and r24661. r24652 triggered a crashing bug in all
the Dartium tests, so it's being reverted until that bug is fixed.
BUG=11649
R=asiva@google.com
Review URL: https://codereview.chromium.org//18400002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24669 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 23:12:23 +00:00
7b0ae79768
Use package:stack_trace in unittest.
...
R=gram@google.com
Review URL: https://codereview.chromium.org//18052029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24652 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:10:54 +00:00
4638137480
Switch from DRT to content shell.
...
R=kustermann@google.com , ricow@google.com
Review URL: https://codereview.chromium.org//15755017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23328 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 08:34:52 +00:00
9d6a64e81b
Merge the dart:uri library into dart:core and update the Uri class
...
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.
* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization
R=floitsch@google.com , lrn@google.com , nweiz@google.com , scheglov@google.com
BUG=
Review URL: https://codereview.chromium.org//16019002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
2ef54d314a
Add the ability to change the working directory
...
Directory.current have been changed from a factory constructor to a
getter and setter. The getter returns a Direcotry object holding the
current working directory. The setter changes the current working
directory of the Dart process.
R=whesse@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=6316 , https://code.google.com/p/dart/issues/detail?id=8893
Review URL: https://codereview.chromium.org//13896034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22116 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 12:43:53 +00:00
eccaec8f3b
Updated testrunner:
...
- works with latest SDK
- understand and works with pub and pubspecs
- tested on Linux, Mac and Windows
- has its own tests
There is still as issue on Windows, where using Process.start to run a .bat file is not terminating until the timeout kills the cmd.exe process. My suspicion is that this is am issue with Process, not testrunner. I have contacted whesse et al about this.
Review URL: https://codereview.chromium.org//14247033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21969 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 18:39:50 +00:00
dd48256fe5
Remove deprecated StringBuffer.add, addAll and addCharCode.
...
Review URL: https://codereview.chromium.org//12473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
3c0ac360e7
Remove deprecated string features.
...
Make String.codeUnits return a List.
Review URL: https://codereview.chromium.org//12282038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
488b016a2f
Merge IO v2 branch to bleeding edge
...
R=ager@google.com , ajohnsen@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//12316036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
ecce8a6293
Remove deprecated Strings class.
...
Review URL: https://codereview.chromium.org//12295014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 13:57:03 +00:00
3f7146707d
Rework Timer interface.
...
Review URL: https://codereview.chromium.org//12213092
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18326 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 19:22:16 +00:00
fb7b9e3c5c
Rename Date to DateTime.
...
BUG=http://dartbug.com/1424
Review URL: https://codereview.chromium.org//11770004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17549 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 12:16:37 +00:00
7259a9df79
This change does a couple fixes to configurations:
...
- it renames '_postMessage' so that it can be overriden by configurations that don't need it.
- it splits the onDone callback in two: onSummary - a callback with all the results, and onDone - a callback with just the end result. The idea is that onSummary is mostly dedicated to reporting results, while onDone is about notifying that unittest is done. This split is very useful for subclasses that only want to override onSummary or onDone.
Review URL: https://codereview.chromium.org//11829045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 03:42:08 +00:00
4a7dfd2da3
Big merge from experimental to bleeding edge.
...
Review URL: https://codereview.chromium.org//11783009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
ab69873a42
Make RegExp constructor non-const.
...
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.
BUG=
Review URL: https://codereview.chromium.org//11369210
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ec9fee9858
"Reverting 14829-14832"
...
BUG=
Review URL: https://codereview.chromium.org//11312203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
8dc3edd7ce
Make RegExp's constructor non-const.
...
BUG=
Review URL: https://codereview.chromium.org//11410033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
83f2cfa4c1
Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your streams.
...
When using an interactive process started with Process.start you have
to drain the stdout and stderr streams to make sure that all resources
are freed. If you do that the dart:io library will make sure to free
all system resources for you.
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//11343009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14187 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 11:59:09 +00:00
2e778387b3
Make getKeys, getValues getters (keys, values).
...
Review URL: https://codereview.chromium.org//11267018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
5fb2069f5c
Get rid of more () in getter definitions.
...
R=antonm@google.com
BUG=
Review URL: https://codereview.chromium.org//11228053
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13952 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 11:59:22 +00:00
ff9e0f75fb
Change Process.start to return a future that completes with a
...
Process object only when the process has been successfully started.
This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.
BUG=dartbug.com/5305
Review URL: https://codereview.chromium.org//11091070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
403bbf44b0
Added the ability for testrunner to start the HTTP server with a random port and communicate that port to the tests via a 'testState' map in unittest.
...
Review URL: https://codereview.chromium.org//11103015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13507 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 23:47:56 +00:00
29611d7d98
Added ability to have custom test HTTP server handlers in the test directories.
...
Review URL: https://codereview.chromium.org//11093033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13490 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 19:48:18 +00:00
2602f8c28e
Change imports etc to new syntax.
...
Fix issues wutrh handling console messages from DRT when using --list-tests and --list-groups.
Review URL: https://codereview.chromium.org//11033042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13327 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 22:13:12 +00:00
2eff2baa75
New testrunner that runs the test pipleine in an isolate.
...
Review URL: https://codereview.chromium.org//10977069
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13155 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 00:02:04 +00:00
d4c7f79ef7
Added support for running an HTTP server during the test and being able to serve up static files. Later this will be extended to being able to write tests on both ends of the connection, but this is a first step.
...
Review URL: https://codereview.chromium.org//10966020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12674 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 00:46:01 +00:00
eeef25322f
Support for pixel layout tests.
...
Review URL: https://codereview.chromium.org//10909240
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12655 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 20:08:35 +00:00
e11b3b82fe
Make args package follow new layout.
...
Review URL: https://codereview.chromium.org//10919249
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12284 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 21:31:42 +00:00
a1eecbbc65
Added support for layout render tests. These use expected values for the text render output from DumpRenderTree. When running a test in DRT the testrunner will see if there is a file with a .render extension in the same directory as the test file and with the same base file name. If so it will do additional checks of the rendered layout.
...
Here is a simple example test:
#library('sample');
#import('dart:html');
#import('pkg:unittest/unittest.dart');
main() {
group('foo', () {
test('test 1', () {
document.body.nodes.add(new Element.html("<p>Test 1</p>"));
});
test('test 2', () {
document.body.nodes.add(new Element.html("<p>Test 2</p>"));
});
});
}
And a sample matching .render file:
[foo test 1]
RenderBlock {P} at (0,0) size 284x20
RenderText {#text} at (0,0) size 38x19
text run at (0,0) width 38: "Test 1"
[foo test 2]
RenderBlock {P} at (0,0) size 284x20
RenderText {#text} at (0,0) size 38x19
text run at (0,0) width 38: "Test 2"
Note that the render content is only the content inside the <body> element, not including the body element itself.
testrunner can generate render files itself if you use the --generate-renders flag.
Also in this change - rename Configuration.log to trace, to avoid clash with the math log() function.
Review URL: https://chromiumcodereview.appspot.com//10914049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11994 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 21:51:24 +00:00
ba92707967
Testrunner for 3rd parties.
...
Review URL: https://chromiumcodereview.appspot.com//10897016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11648 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 20:12:24 +00:00
whesse@google.com