dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
67,857 Commits 2 Branches 0 Tags
d76ffbc1497568dedba37671ffd5a4792a6c1b2a
Commit Graph

344 Commits

Author SHA1 Message Date
Paul Berry 5d4cd6d589 Breaking changes for analyzer version 0.39. 
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-21 18:23:10 +00:00
Konstantin Shcheglov ad47b1ca64 Remove summary1, part 2. 
Change-Id: I050b62bbbd77db6bd6a2d815e70cfe92cc9432a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-07 17:35:55 +00:00
Konstantin Shcheglov 595022bdea Remove summary1, part 1. 
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-28 14:30:05 +00:00
Konstantin Shcheglov 59008b8692 Skip parts with invalid URIs. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/140849287
Change-Id: I97da019f5aa6ec4db3b796842aaaa91834fc00b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116894
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 15:51:20 +00:00
Konstantin Shcheglov 76e6325ae0 Remove unused methods of AnalysisContext. 
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 17:09:47 +00:00
Konstantin Shcheglov 6f38a73618 Remove most of the task model. 
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a

R=brianwilkerson@google.com

Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 18:26:50 +00:00
Brian Wilkerson 19533094eb Stop deleting the terminating period on diagnostic messages 
We have messages that contain more than one sentence, and sometimes
include end-of-line markers. We really need to do more to improve the
output in these cases, but this is a start.

Change-Id: I4750feae0a8e6665a8243c6d15726350b26a558b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-08-21 15:21:49 +00:00
Konstantin Shcheglov ccdddd2eee Parallel build-mode and DDC changes for summary2. 
It does not enable summary2 yet, but makes it possible to flip
one flag AnalysisDriver.useSummary2 to switch between summary1
and summary2.

I run presubmit scripts, and it seems that it works for both.
https://test.corp.google.com/ui#id=OCL:255717824:BASE:259228828:1563746330268:5481d33a
https://test.corp.google.com/ui#id=OCL:255717824:BASE:258892260:1563515248201:2d5ce329

One thing that is not implemented yet is tracking used dependencies
for summary2. So, //dart/bazel_codegen_tests:dependencies_test_run fails.


Change-Id: Iec9f3852e9b91236ce98e87041031daa0cc71a88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107689
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-07-23 15:07:11 +00:00
David Morgan 79a5257155 Revert "Increase analyzer cache size to 512MB." 
This reverts commit 0256155b7a.

Reason for revert: this change is obsolete; we now do caching outside the analyzer to make sure analyzer disk access is fast. So more likely we want to reduce the cache size to zero. Certainly, we don't want to increase it.

Original change's description:
> Increase analyzer cache size to 512MB.
> 
> I noticed earlier today that the cache looks to be to small for large internal apps, causing us to constantly reload summaries. This change fixes that, reducing build times significantly for large apps.
> 
> There is a larger issue here of the actual cache implementation though that should likely get resolved. We end up with several versions of each summary file in the cache until it fills up, so we will fill up the cache even on small apps today.
> 
> It is possible we should change how that works, instead of increasing this.
> 
> Fwiw, I see total ram consumption of almost exactly 1GB per worker after this change.
> 
> Change-Id: I0d8a06da72b86d44562819bc04f5ae5543610f0d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107360
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: David Morgan <davidmorgan@google.com>
> Commit-Queue: Jake Macdonald <jakemac@google.com>

TBR=scheglov@google.com,jakemac@google.com,davidmorgan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If00c0f9b8ee3fc177433df7c8d92731c2e5f0f9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108140
Reviewed-by: David Morgan <davidmorgan@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2019-07-08 08:39:50 +00:00
Jacob MacDonald 0256155b7a Increase analyzer cache size to 512MB. 
I noticed earlier today that the cache looks to be to small for large internal apps, causing us to constantly reload summaries. This change fixes that, reducing build times significantly for large apps.

There is a larger issue here of the actual cache implementation though that should likely get resolved. We end up with several versions of each summary file in the cache until it fills up, so we will fill up the cache even on small apps today.

It is possible we should change how that works, instead of increasing this.

Fwiw, I see total ram consumption of almost exactly 1GB per worker after this change.

Change-Id: I0d8a06da72b86d44562819bc04f5ae5543610f0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2019-06-27 15:44:03 +00:00
Brian Wilkerson dd862e7933 Display context messages in command-line analyzer output 
Change-Id: I2b2f668ef738cf7801dbfdc77d070a8d8a473fe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107303
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-06-25 17:36:52 +00:00
Konstantin Shcheglov a468780d96 Disable buildSummary2 in build_mode. 
It is expensive internally.

R=paulberry@google.com

Change-Id: Ic39245af9b8adc26e8441a14900ba46b7b68ec12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-19 21:54:40 +00:00
Brian Wilkerson 97bf0a6834 Print the URLs associated with the diagnostics 
Change-Id: I1078cbda2b11e5591c96864a57538d6c94004136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106430
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2019-06-18 01:22:18 +00:00
Konstantin Shcheglov 149ebf683b Support for 'uri' property of Import/Export/CompilationUnitElement. 
_Builder in source_gen uses code like this to check that the generated
file is expected in the library. While it is a questionable approach,
I don't feel that I have time to fix it, and remove the `uri` property
completely. So, we fix in in Analyzer with summary2.

`if (!library.parts.map((c) => c.uri).contains(part)) { ...fail... }`

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I983f29589cbb2613d5f896b87f6218c31a47afa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-11 16:53:03 +00:00
Konstantin Shcheglov 0629ce94cc Change location where we set AnalysisDriver.useSummary2 in build mode. 
We need to make sure that it is set when we create FileState(s).

Change-Id: I68103902d0f4df659291e02dd7809b2140b9af72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-10 14:47:03 +00:00
Konstantin Shcheglov ef62349c6d Turn on useSummary2 in build mode only temporary when computing errors. 
We don't want to keep it on while building summary1, because there
are changes in type manipulations that depend on it.

R=brianwilkerson@google.com

Change-Id: I4f84860ec197eb8f40dba80ecb51868f3d48e5e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-03 16:13:44 +00:00
Konstantin Shcheglov 7c956f4387 Make it possible to consume summary2 in build mode, but don't turn it on yet. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iad4d625217e3eeb6d8e5142825224dc0b2dcf8bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-30 16:49:04 +00:00
Konstantin Shcheglov b1d3a212a7 Fill references to dynamic/Naver in LinkedElementFactory. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I85f61c6322a6332ac6b095aaf8cf4203460babc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-29 01:20:42 +00:00
Konstantin Shcheglov 03781b9402 Build also summary2 in build mode. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I172612fd50c1cb50dfad8b5dc2807f744cf973b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-28 17:44:48 +00:00
Konstantin Shcheglov 959e7df20e Remove 'await null' in build mode. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I903a389ab15d45cc18d3678bc44ff8d78ffba683
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103083
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-05-20 16:58:35 +00:00
Keerti Parthasarathy b997b59c09 Include manifest in the list of files to analyze 
Change-Id: I9b1c52ce085303e84b8882b0ccdc51c9555ce55c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2019-04-15 14:15:15 +00:00
Keerti Parthasarathy 04ee9b9336 Add support for the manifest checks in analyzer_cli 
Change-Id: I8d2670cca509cf2229f5475e355e3b85b1ca2f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99220
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 20:41:51 +00:00
Paul Berry 54caf5c950 Dart deps_pruning: track summary dependencies during analysis phase. 
(Originally written by Emmanuel Pellereau (emmanuelp@google.com))

Change-Id: I61983558cbb88b76be2a292080e96c0bf3f780de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98680
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-11 14:48:44 +00:00
Konstantin Shcheglov 85e5684863 Remove OptionsWorkManager and GenerateOptionsErrorsTask is not a task. 
R=brianwilkerson@google.com

Change-Id: Ic257c13a553835f78bd7bc0778dd33c327097af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-19 19:03:03 +00:00
Paul Berry 7c3ab264e5 Change link methods to take a DeclaredVariables object. 
Change-Id: I6cc36f9152fb90642ec3261418e60ac3bdbe5acf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96922
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 19:52:24 +00:00
Konstantin Shcheglov eeb19b0416 Remove usages of ExtensionManager and package:plugin in general. 
R=brianwilkerson@google.com

Change-Id: I489e72464474b3d40d7678f44562f65934f93288
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-14 15:31:08 +00:00
Paul Berry 31c47567dc Remove AnalysisOptionsForLink and plumb analysis options through linker. 
This is a non-breaking change; the only way linking is exposed to
clients is through `SummaryBuilder`, which can get the analysis
options from the context.

Fixes #35747.

Change-Id: I273408f33a881ac32ab248cbc8f3e0644630563b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96829
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-13 22:39:53 +00:00
Paul Berry 22c2c7ffd8 Sort declarations in build_mode.dart 
Change-Id: I0fa24b9733c2423ea253d75fd533b4ba2fef415e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96700
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-12 19:27:06 +00:00
pq aacd8c7711 de-dup machine format errors 
Fixes: https://github.com/dart-lang/sdk/issues/36062.

Change-Id: I489a5fe991e715c5067479a29c1cddbd4de57c49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-03-05 17:33:51 +00:00
Paul Berry 7a95930bee Add a "summary-deps-output" option to build mode. 
Change-Id: Ia63d260ba3dc9f15df2c6e49a95e5c20952557cd
Reviewed-on: https://dart-review.googlesource.com/c/91764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-01-31 18:33:08 +00:00
Brian Wilkerson a10f6aac38 Finish cleaning up the copyright notices in the analyzer_cli package 
Change-Id: I4de3c9e17b4e569c32470ffd1c2061749d3184ed
Reviewed-on: https://dart-review.googlesource.com/c/88439
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-06 19:16:31 +00:00
Brian Wilkerson 18844b85ec Remove occurrences of Future<Null> from analyzer_cli 
Change-Id: I008589455681dd5da80df4e466803f8cf48cd910
Reviewed-on: https://dart-review.googlesource.com/c/88435
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-05 19:25:47 +00:00
Brian Wilkerson 4b04ff2270 Remove dead code from analyzer_cli 
Change-Id: I032a004497c0add825b24d4f989d8f5851d157d0
Reviewed-on: https://dart-review.googlesource.com/c/88164
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-02 14:22:39 +00:00
Brian Wilkerson 8bff3a9e20 Fix batch mode to re-create the analysis driver when the set of experiments has changed 
Change-Id: I44bf0d520aa3f4b16c21d6984925ed5050b8ae8a
Reviewed-on: https://dart-review.googlesource.com/c/87160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-12 21:11:11 +00:00
Paul Berry 5768e513f8 Rework analyzer representation of experimental flags to prepare for codegen. 
This CL introduces
pkg/analyzer/lib/src/dart/analysis/experiments_generated.dart, which
will eventually be code generated from a YAML description of the
currently-allowed set of experimental flags.

Change-Id: Iabbefa8e5037573d4b4e7b7b4eb661c1698bd673
Reviewed-on: https://dart-review.googlesource.com/c/86220
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-12-10 22:32:24 +00:00
Brian Wilkerson 01e0df71a8 Stop unnecessarily extending Object 
Change-Id: Ib557755916b09be4e1ad1b1c2e4bed052a280513
Reviewed-on: https://dart-review.googlesource.com/c/84640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-16 16:43:24 +00:00
Konstantin Shcheglov 2079620a53 Issue 34733. Expand 'implicit-casts' controlled casts, and deprecate more of 'declaration-casts'. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34733
Change-Id: Ifda5cbd8cc8d81a7e3ad8133d68c056b869bb588
Reviewed-on: https://dart-review.googlesource.com/c/84122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 21:04:59 +00:00
Brian Wilkerson 4534e3ea6d Use the constants defined in Experiments rather than hard coding them in multiple places 
Change-Id: I56a6d93a41c5ebb8ad90ebe5c0fbce4bdb4a3ef7
Reviewed-on: https://dart-review.googlesource.com/c/84123
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 18:33:47 +00:00
Brian Wilkerson c6148ecba7 Add support for reading experimental options from the command-line 
Change-Id: I903bfce32ed1f01a3a7601d724bc5b9e865b9c1d
Reviewed-on: https://dart-review.googlesource.com/c/83882
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-09 00:13:16 +00:00
Brian Wilkerson 22408c6dee Remove references to previewDart2 
Change-Id: Id382dd95d3ae90d483467741b5b6d3dbc6c31ea1
Reviewed-on: https://dart-review.googlesource.com/c/83300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-07 14:52:37 +00:00
Konstantin Shcheglov 5711a1d539 Move implementations of analysis results into src/results. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7527dfb597ff54802517093b4aa526b14e7b705c
Reviewed-on: https://dart-review.googlesource.com/c/82461
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-01 16:11:23 +00:00
danrubel a82e025739 Move dartfix to its own package 
Fix https://github.com/dart-lang/sdk/issues/34765

Change-Id: I44b3ccc4861b383601fea1b006f1fd4726b11062
Reviewed-on: https://dart-review.googlesource.com/c/81080
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-10-22 17:50:25 +00:00
danrubel 2d14d9a313 Improve how dartfix finds the analysis server pkg root 
Change-Id: Iead97b14a2eede8628ea286fedcccbafb4f3c2b7
Reviewed-on: https://dart-review.googlesource.com/c/80943
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-22 16:28:10 +00:00
Brian Wilkerson a342cecffd Disable support for the old super mixins 
Change-Id: I8f8074b67ea43249fcc10deddd2325938996d529
Reviewed-on: https://dart-review.googlesource.com/c/79469
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-22 16:02:01 +00:00
Dan Rubel a29c04953e Automatically run analysis server from source if launched with the SDK source tree 
Change-Id: I13ff79f90b3a7e0f0ea55b5c839a20c0d790de0d
Reviewed-on: https://dart-review.googlesource.com/c/80510
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-10-18 11:37:49 +00:00
David Morgan a3db8a904e Support running analyzer_cli in worker mode in an isolate. 
Change-Id: I2ce54bd775e0f7f9e9205c6d24f019d9a395c455
Reviewed-on: https://dart-review.googlesource.com/c/80160
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-10-17 13:56:39 +00:00
danrubel 6066ac83e3 Improve dartfix console output 
Change-Id: Ifa55c6d03487a987cf6b0a4a6ae58d6068e54d8b
Reviewed-on: https://dart-review.googlesource.com/c/80180
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-10-16 21:25:45 +00:00
Devon Carew 93b1955ed0 Dartfix ui tweaks. 
Change-Id: Ice0901d2412eefb06099b0328bb97cc328dc7d49
Reviewed-on: https://dart-review.googlesource.com/c/80083
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-10-16 20:12:00 +00:00
Devon Carew c6b43d9cb6 Use ansi color in the dartfix cli output. 
Change-Id: I7b0c369e232e01b9227a04b466a89dcab00cd64e
Reviewed-on: https://dart-review.googlesource.com/c/79980
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-10-15 22:04:27 +00:00
Devon Carew f3c51a4be0 Organize imports. 
Change-Id: I52347442fbde47e365a9ad861788df49bc9bb9bd
Reviewed-on: https://dart-review.googlesource.com/c/79821
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-10-15 17:06:57 +00:00