dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
8,725 Commits 2 Branches 0 Tags
d41409e427bfa47b2e97fc718dec1f0660ab66bc
Commit Graph

108 Commits

Author SHA1 Message Date
antonm@google.com dbe15ba638 Minor simplification. 
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11190023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13745 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 15:01:30 +00:00
antonm@google.com 8889337203 Unify formatting of parameters in interfaces and implementing classes. 
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11191026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13744 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 14:49:11 +00:00
podivilov@google.com 2d7f516b9f Extract common logic from Backend.BaseClassName(). 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11118025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13742 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 14:24:50 +00:00
podivilov@google.com dc0c8157bc Rename Dartium dart:html implementation classes. 
Currently, Dartium implementation classes are named as "_<IDL_Name>Impl" while
dart2js implementation classes are named as "_<Dart_Name>Impl". The goal of
this patch is to unify the naming across the backends.

R=antonm@google.com

Review URL: https://codereview.chromium.org//11108017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13740 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 14:02:25 +00:00
podivilov@google.com e846c4789b Switch to using IDLTypeInfo.interface_name(). 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11114019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13736 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 12:53:20 +00:00
antonm@google.com a8c94bc8f5 Provide a correct value for is_optional argument of ParamInfo constructor. 
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11194029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13735 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 12:52:46 +00:00
antonm@google.com de3b284e8f Refactor common functionality. 
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11191024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13733 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 12:43:48 +00:00
podivilov@google.com f20ca10855 Remove ParamInfo.dart_type field. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11117025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13732 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 12:37:10 +00:00
antonm@google.com a6913b069c Remove unnecessary support for default values. 
R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11196017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13730 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-17 12:10:11 +00:00
efortuna@google.com b9e2d45d8a Replace DOMStringList with List<String>. 
Review URL: https://codereview.chromium.org//11140043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13699 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-16 20:02:33 +00:00
sra@google.com 1eeb83bbdf Convert legacy 'native code' to JS-forms in dart:html 
This should enable minification to rename function arguments. Issue 5821 and Issue 5822 need to be fixed first.

BUG=dart:5808

Review URL: https://codereview.chromium.org//11094082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13690 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-16 17:50:15 +00:00
antonm@google.com 02d9df218e Make WheelEvent.delta{X,Y} return num, not int. 
That requires hiding native implementation with private prefix.

R=blois@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//11098052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13608 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-12 10:57:04 +00:00
podivilov@google.com f6c129ce61 Move interface merging info to type registry. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11091046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13533 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-11 11:45:40 +00:00
antonm@google.com 2a77601516 Rename WebKit's WheelEvent.wheelDelta{X,Y} to W3C WheelEvent.delta{X,Y}. 
Also remove WheelEvent.wheelDelta.

We originally have done that for dart2js, but that broke Dartium support.  Instead of
removal, just rename to generate binding code still.

R=blois@google.com,podivilov@chromium.org
BUG=5756

Review URL: https://codereview.chromium.org//11099033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13476 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-10 14:53:29 +00:00
podivilov@google.com 5464ab01d3 Get rid of webkit_renames in dartdomgenerator.py. 
Now that we don't rename interfaces in fremontcutbuilder, there is
no need to rename them back in dartdomgenerator.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11062005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13473 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-10 13:31:16 +00:00
podivilov@google.com f8762b2568 Introduce ListLikeIDLTypeInfo as a replacement for nativified_classes table. 
IDLTypeInfo hierarchy is a convenient way to deal with idl type polymorfism.

R=antonm@google.com,efortuna@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11065042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13472 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-10 13:22:45 +00:00
podivilov@google.com 9d19336573 Add interface_name and implementation_name to IDLTypeInfo class and use them instead of dart_type. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13470 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-10 12:38:41 +00:00
vsm@google.com 30b34c8457 Better return types for window.location and window.history 
Review URL: https://codereview.chromium.org//11086029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13432 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-09 19:37:41 +00:00
vsm@google.com 166d2b2d86 Fix some type narrowing 
I think I 'broke' this is an earlier CL.

Review URL: https://codereview.chromium.org//11086017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13430 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-09 19:29:55 +00:00
blois@google.com 845c13e426 Replacing non-portable CanvasRenderingContext.setFillColor with more portable variants. 
This is the same as the earlier CL for this, which failed because of dartium build issues which have since been fixed by Anton.

BUG=4592

Review URL: https://codereview.chromium.org//11028068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13361 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-08 16:15:23 +00:00
vsm@google.com c40edf6954 Wrap Window in case it's a window from a different page / frame. 
I also refactored inner_frame_test to explicitly notify if the subframe tests pass or fail.  This should make them more robust and (if they break) fail quickly instead of timing out.

BUG=1913

Review URL: https://codereview.chromium.org//11074005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13331 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 23:07:08 +00:00
blois@google.com 06f1665623 Adding synchronous measurement methods to Element. Refactoring unit tests some so element_test passes on all browsers. 
Original CL was failing in checked mode because the refactored html/element_test fires multiple mouseWheel event typess to try to validate that the event functions. This causes an assertion elsewhere, which is probably a valid assertion.

I'm not sure how much we get out of this test for mouseWheel, so I don't think it's a big issue to remove it.

BUG=838

Review URL: https://codereview.chromium.org//11065017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13328 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 22:27:43 +00:00
sra@google.com 5c1a93e251 Convert between Dart and JavaScript SerializedScriptValues on postMessage. 
Review URL: https://codereview.chromium.org//11065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13311 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 19:19:16 +00:00
blois@google.com caa43082d6 Fixes to get SelectElement working properly on IE. 
BUG=

Review URL: https://codereview.chromium.org//11031076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13307 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 18:13:13 +00:00
vsm@google.com c4c8c62e3b Remove window.length and window.frames 
BUG=2312

Review URL: https://codereview.chromium.org//11065039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13305 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 17:26:03 +00:00
blois@google.com bc5a9328bb Fixing SelectElement.selectedOptions to work on all platforms. 
This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium.

Fix was to move impl_SelectElement.darttemplate to dart2js.

BUG=4503

Review URL: https://codereview.chromium.org//11035032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13304 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 17:03:28 +00:00
vsm@google.com e5285fb6f1 Make fremontcut serial by default 
We suspect there are some race conditions in the Dartium build under
heavy load.  Making this serial by default until we have time to investigate.

go.sh is still parallel by default as it's run by hand.

Review URL: https://codereview.chromium.org//11033049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13301 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 15:58:31 +00:00
podivilov@google.com c71b6b20a1 Fix JS native binding and documentation for interfaces with overridden name. 
R=vsm@google.com,sra@google.com,antonm@google.com
BUG=5657

Review URL: https://codereview.chromium.org//11036035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13296 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 15:15:48 +00:00
efortuna@google.com d20462a58b Finish Listifying html classes. 
Review URL: https://codereview.chromium.org//11044023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13270 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 00:30:38 +00:00
antonm@google.com fa3dba72b2 Override CSSStyleDeclaration.getPropertyValue in general way. 
Hide actual implementation and check returned value.

R=efortuna@google.com
BUG=5617

Review URL: https://codereview.chromium.org//11065014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13253 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 18:38:43 +00:00
vsm@google.com a1d9180d98 New cross frame base types. 
Local types (LocalWindow, LocalLocation, LocalHistory) now subtype the corresponding "safe" base type.  The _CrossFrameImpl classes implement the safe types.

This also fills out Location and History for dart2js.

Note for dart2js, I still need to trap returned windows.  That's a separate bug.

BUG=3836

Review URL: https://codereview.chromium.org//11047021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13252 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 18:16:03 +00:00
blois@google.com 14db66f26c Revert "Adding synchronous measurement methods to Element." 
This reverts commit 13246 as html/element_test is breaking on dartium.

BUG=

Review URL: https://codereview.chromium.org//11036037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13251 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 18:09:50 +00:00
podivilov@google.com 87cda6aa97 Move Dart type narrowing to TypeRegistry. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11027033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13248 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:55:30 +00:00
podivilov@google.com f892f55ecb Refactor idl to dart renaming logic for interfaces. 
Make sure all types that comes to TypeRegistry.TypeInfo are either registered
or present in database. That is to fix the mess with idl vs. dart types.
Also, InterfaceIDLTypeInfo.dart_type now returns an already renamed type.

R=antonm@google.com

Review URL: https://codereview.chromium.org//11026039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13247 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:54:04 +00:00
blois@google.com 6ec1dff0db Adding synchronous measurement methods to Element. 
I also did some refactoring unit tests some so element_test passes on all browsers- it seems quite bad that element_test was expected to fail on so many configurations. Ideally this gets refactored further when our browser support gets flushed out further.

BUG=838

Review URL: https://codereview.chromium.org//11046025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13246 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:42:06 +00:00
podivilov@google.com 97255190cd Get rid of webkit renames. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11033024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13244 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:33:06 +00:00
blois@google.com 4198b9d3a8 Revert "Fixing SelectElement.selectedOptions to work across all platforms." 
This reverts commit #13239 because it breaks the dartium build.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//11032033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13242 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:16:51 +00:00
podivilov@google.com 4f396585c4 Remove global DartType function. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11030027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13241 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:13:57 +00:00
blois@google.com 25f67482f2 Fixing SelectElement.selectedOptions to work across all platforms. 
BUG=4503

Review URL: https://codereview.chromium.org//11049012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13239 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:10:12 +00:00
efortuna@google.com bffc05a1b1 CSSStyleDeclaration.getPropertyValue returns empty string instead of null. 
Review URL: https://codereview.chromium.org//11047008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13189 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 18:05:41 +00:00
blois@google.com f36360ec8b Converting NodeList to List<Node>. 
This keeps the NodeList class because other classes depend on it (notably RadioNodeList), but converts all APIs over to List<Node>.

BUG=2712

Review URL: https://codereview.chromium.org//11055009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13188 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 17:47:48 +00:00
podivilov@google.com 5169ef12d7 Extract common logic for emitting implementation classes. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11051014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13181 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 16:04:30 +00:00
podivilov@google.com b9e0a92118 Merge BaseGenerator into HtmlDartInterfaceGenerator. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11045020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13180 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 15:58:03 +00:00
podivilov@google.com f37795b15d Remove constants declaration from dart2js implementation classes. 
They aren't used anymore.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11053016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13173 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 14:41:59 +00:00
antonm@google.com e44ef72329 Make event renames optional, not mandatory. 
That should lead to less frequent build breaks.

R=podivilov@chromium.org

Review URL: https://codereview.chromium.org//11034022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13160 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 07:44:22 +00:00
efortuna@google.com a6efb0872e Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to 
noteOff.
Review URL: https://codereview.chromium.org//11043013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13156 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 00:49:37 +00:00
efortuna@google.com 2e1220541b Missed a change in the rename from initCustomEvent -> $dom_initCustomEvent. 
Review URL: https://codereview.chromium.org//11028018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13134 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 20:17:49 +00:00
efortuna@google.com d44e51fb59 Revert r13127. 
TBR.
Review URL: https://codereview.chromium.org//11036024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13129 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 17:48:08 +00:00
efortuna@google.com 047bf6ac9a Add constructor for CustomEvent. 
Review URL: https://codereview.chromium.org//11030012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13127 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 17:16:13 +00:00
podivilov@google.com a800e16aeb Cleanup html events generation. 
Get rid of HtmlSystemShared and move event interfaces and implementations
generation to HtmlEventGenerator class.

R=antonm@google.com,sra@google.com

Review URL: https://codereview.chromium.org//11020008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13107 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 10:22:37 +00:00